- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl] Pushed new branch issue-101-clang-trapping-math
by Raymond Toy 05 Feb '21

05 Feb '21

Raymond Toy pushed new branch issue-101-clang-trapping-math at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-101-clang-trapping-… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][native-image] 8 commits: ldb prints out Unicode characters
by Raymond Toy 04 Feb '21

04 Feb '21

Raymond Toy pushed to branch native-image at cmucl / cmucl Commits: 19f274f0 by Raymond Toy at 2021-01-29T17:30:03-08:00 ldb prints out Unicode characters When printing out a base-char, only the low 8 bits of the code were used. But with Unicode support, we need to take all the bits and print them out. For control codes we use the form "#\^x". (Was #\C-x, which isn't a valid supported character form.) Ascii is printed as normal "#\a", and everything else use uses "#\u+<hex>". While we're at it, we also added special cases like #\Vt that are listed in https://cmucl.org/docs/cmu-user/html/Characters.html#Characters. With this, we can print out all unicode characters in a form that can be pasted back into lisp. - - - - - 832e116a by Raymond Toy at 2021-01-30T01:54:08+00:00 Merge branch 'issue-100-ldb-base-char-printing' into 'master' ldb prints out Unicode characters See merge request cmucl/cmucl!67 - - - - - e349bf1d by Raymond Toy at 2021-01-30T09:51:59-08:00 Update notes in preparation for snapshot. Just updated based on the issues that were closed. - - - - - 74b0de87 by Raymond Toy at 2021-02-03T17:04:16-08:00 Add test for overflow in expt that shouldn't happen We shouldn't get an overflow, but we do because clang 10 miscompiles e_pow.c and causes an overflow. Addresses #101 - - - - - 23d1a1d1 by Raymond Toy at 2021-02-04T01:28:29+00:00 Merge branch 'issue-101-add-test' into 'master' Add test for overflow in expt that shouldn't happen See merge request cmucl/cmucl!68 - - - - - bfbd0527 by Raymond Toy at 2021-02-03T20:19:53-08:00 Merge branch 'master' into native-image - - - - - 6887f2de by Raymond Toy at 2021-02-03T20:27:35-08:00 Support type_Ratio Ratios contain only boxed objects so asm_boxed works. Also fixed a gcc warning about init_asmtab; make the arg `void`. - - - - - 02da0955 by Raymond Toy at 2021-02-03T20:49:05-08:00 Support type_Complex and type_SimpleArray With these changes, static space has no unimplemented objects. - - - - - 4 changed files: - src/general-info/release-21e.md - src/lisp/print.c - src/lisp/save.c - tests/issues.lisp Changes: ===================================== src/general-info/release-21e.md ===================================== @@ -19,8 +19,6 @@ public domain. ## New in this release: * Known issues: - * Building with gcc8 or later doesn't work with the default -O option. Use -O1 instead. This shouldn't really impact overall speed much. - * Added simple support to compile with clang instead, which works. (Use x86_linux_clang). * Feature enhancements * Changes * Update to ASDF 3.3.4 @@ -35,6 +33,12 @@ public domain. * ~~#80~~ Use ASDF to load contribs. cmu-contribs still exists but does nothing. The contrib names are the same, except it's best to use a keyword instead of a string. So, `:contrib-demos` instead of `"contrib-demos"`. * ~~#81~~ Added contribs from Eric Marsden * ~~#82~~ Replace bc with expr in GNUMakefile + * ~~#86~~ Building with gcc 8 and later works when using -O2 optimization + * ~~#90~~ Some static symbols have been removed. This probably makes the fasl files incompatible with older versions. + * ~~#91~~ Loop destructuring no longer incorrectly signals an error + * ~~#95~~ Disassembler syntax of x86 je and movzx is incorrect + * ~~#98~~ fstpd is not an Intel instruction; disassemble as `fstp dword ptr [addr]` + * ~~#100~~ ldb prints out unicode base-chars correctly instead of just the low 8 bits. * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: ===================================== src/lisp/print.c ===================================== @@ -212,12 +212,15 @@ static void brief_otherimm(lispobj obj) { int type, c, idx; - char buffer[10]; type = TypeOf(obj); switch (type) { case type_BaseChar: - c = (obj >> 8) & 0xff; + /* + * A base-char should only be 16 bits long now. But + * sometimes it uses all 24. So just grab all the bits. + */ + c = (obj >> 8) & 0xfffff; switch (c) { case '\0': printf("#\\Null"); @@ -228,20 +231,35 @@ brief_otherimm(lispobj obj) case '\b': printf("#\\Backspace"); break; + case '\11': + printf("#\\Tab"); + break; + case '\13': + printf("#\\Vt"); + break; + case '\15': + printf("#\\Return"); + break; + case '\33': + printf("#\\Escape"); + break; + case '\40': + printf("#\\Space"); + break; case '\177': printf("#\\Delete"); break; default: - strcpy(buffer, "#\\"); if (c >= 128) { - strcat(buffer, "m-"); - c -= 128; - } - if (c < 32) { - strcat(buffer, "c-"); - c += '@'; - } - printf("%s%c", buffer, c); + /* Just print out the code value */ + printf("#\\u+%04X", c); + } else if (c < 32) { + /* Print it out as a control character */ + printf("#\\^%c", c + '@'); + } else { + /* Plain ASCII character */ + printf("#\\%c", c); + } break; } break; ===================================== src/lisp/save.c ===================================== @@ -655,7 +655,7 @@ asm_complex_double_float(lispobj* ptr, lispobj object, FILE* f) #endif void -init_asmtab() +init_asmtab(void) { int k = 0; @@ -674,6 +674,9 @@ init_asmtab() asmtab[type_OtherPointer | (k << 3)] = asm_other_pointer; } + asmtab[type_Ratio] = asm_boxed; + asmtab[type_Complex] = asm_boxed; + asmtab[type_SimpleArray] = asm_boxed; asmtab[type_SymbolHeader] = asm_boxed; asmtab[type_Fdefn] = asm_fdefn; asmtab[type_InstanceHeader] = asm_boxed; @@ -683,6 +686,7 @@ init_asmtab() asmtab[type_BaseChar] = asm_immediate; /* Just use asm_boxed or have a special version for a value cell? */ asmtab[type_ValueCellHeader] = asm_boxed; + } void ===================================== tests/issues.lisp ===================================== @@ -544,3 +544,15 @@ ;; the correct value. (assert-false (funcall (compile nil '(lambda () (array-displacement "aaaaaaaa")))))) + +(define-test issue.101 + (:tag :issues) + ;; Verifies that we don't get unexpected overflow. The actual value + ;; is not really important. The important part is no overflow is + ;; signaled. + ;; + ;; See https://gitlab.common-lisp.net/cmucl/cmucl/-/issues/101 for + ;; more details. + (assert-equalp + 3.0380154777955097d205 + (expt 1.7976931348623157d308 0.6666))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/9f71e8eb109c45a709c03c… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/9f71e8eb109c45a709c03c… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 3 commits: Update CI to use 2021-01 snapshot
by Raymond Toy 04 Feb '21

04 Feb '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: a3e42a4c by Raymond Toy at 2021-02-03T19:57:26-08:00 Update CI to use 2021-01 snapshot Binaries for the 2021-01 snapshot are available so use those instead of doing a cross-compile from 2020-04. - - - - - 84fa2568 by Raymond Toy at 2021-02-03T20:11:21-08:00 Set version correctly Updated the directory path but forgot the version part. - - - - - 408711a9 by Raymond Toy at 2021-02-04T04:31:04+00:00 Merge branch 'update-ci-snapshot-2021-01' into 'master' Update CI to use 2021-01 snapshot See merge request cmucl/cmucl!69 - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -1,6 +1,6 @@ variables: - download_url: "https://common-lisp.net/project/cmucl/downloads/snapshots/2020/04" - version: "2020-04-x86" + download_url: "https://common-lisp.net/project/cmucl/downloads/snapshots/2021/01" + version: "2021-01-x86" bootstrap: "" stages: @@ -37,11 +37,11 @@ linux:build: artifacts: true script: # Do cross compile first - - bin/create-target.sh xtarget x86_linux_clang - - bin/create-target.sh xcross x86_linux_clang - - bin/cross-build-world.sh -crl -B boot-2020-04-1 xtarget xcross src/tools/cross-scripts/cross-x86-x86.lisp snapshot/bin/lisp - # Regular build using the cross-compiled result - - bin/build.sh $bootstrap -R -C "" -o xtarget/lisp/lisp + #- bin/create-target.sh xtarget x86_linux_clang + #- bin/create-target.sh xcross x86_linux_clang + #- bin/cross-build-world.sh -crl -B boot-2020-04-1 xtarget xcross src/tools/cross-scripts/cross-x86-x86.lisp snapshot/bin/lisp + # Regular build using the cross-compiled result or snapshot + - bin/build.sh $bootstrap -R -C "" -o snapshot/bin/lisp - bin/make-dist.sh -I dist linux-4 linux:test: @@ -108,11 +108,11 @@ osx:build: artifacts: true script: # Do cross compile first - - bin/create-target.sh xtarget x86_darwin - - bin/create-target.sh xcross x86_darwin - - bin/cross-build-world.sh -crl -B boot-2020-04-1 xtarget xcross src/tools/cross-scripts/cross-x86-x86.lisp snapshot/bin/lisp - # Regular build using the cross-compiled result - - bin/build.sh $bootstrap -R -C "" -o xtarget/lisp/lisp + #- bin/create-target.sh xtarget x86_darwin + #- bin/create-target.sh xcross x86_darwin + #- bin/cross-build-world.sh -crl -B boot-2020-04-1 xtarget xcross src/tools/cross-scripts/cross-x86-x86.lisp snapshot/bin/lisp + # Regular build using the cross-compiled result or snapshot + - bin/build.sh $bootstrap -R -C "" -o snapshot/bin/lisp - bin/make-dist.sh -I dist darwin-4 osx:test: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/23d1a1d1c92aef17210b0b… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/23d1a1d1c92aef17210b0b… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][update-ci-snapshot-2021-01] Set version correctly
by Raymond Toy 04 Feb '21

04 Feb '21

Raymond Toy pushed to branch update-ci-snapshot-2021-01 at cmucl / cmucl Commits: 84fa2568 by Raymond Toy at 2021-02-03T20:11:21-08:00 Set version correctly Updated the directory path but forgot the version part. - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -1,6 +1,6 @@ variables: download_url: "https://common-lisp.net/project/cmucl/downloads/snapshots/2021/01" - version: "2020-04-x86" + version: "2021-01-x86" bootstrap: "" stages: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/84fa2568b65deedf5ff402f… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/84fa2568b65deedf5ff402f… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch update-ci-snapshot-2021-01
by Raymond Toy 04 Feb '21

04 Feb '21

Raymond Toy pushed new branch update-ci-snapshot-2021-01 at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/update-ci-snapshot-2021-01 You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Add test for overflow in expt that shouldn't happen
by Raymond Toy 04 Feb '21

04 Feb '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 74b0de87 by Raymond Toy at 2021-02-03T17:04:16-08:00 Add test for overflow in expt that shouldn't happen We shouldn't get an overflow, but we do because clang 10 miscompiles e_pow.c and causes an overflow. Addresses #101 - - - - - 23d1a1d1 by Raymond Toy at 2021-02-04T01:28:29+00:00 Merge branch 'issue-101-add-test' into 'master' Add test for overflow in expt that shouldn't happen See merge request cmucl/cmucl!68 - - - - - 1 changed file: - tests/issues.lisp Changes: ===================================== tests/issues.lisp ===================================== @@ -544,3 +544,15 @@ ;; the correct value. (assert-false (funcall (compile nil '(lambda () (array-displacement "aaaaaaaa")))))) + +(define-test issue.101 + (:tag :issues) + ;; Verifies that we don't get unexpected overflow. The actual value + ;; is not really important. The important part is no overflow is + ;; signaled. + ;; + ;; See https://gitlab.common-lisp.net/cmucl/cmucl/-/issues/101 for + ;; more details. + (assert-equalp + 3.0380154777955097d205 + (expt 1.7976931348623157d308 0.6666))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/e349bf1da7a83e19650aff… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/e349bf1da7a83e19650aff… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-101-add-test
by Raymond Toy 04 Feb '21

04 Feb '21

Raymond Toy pushed new branch issue-101-add-test at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-101-add-test You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new tag snapshot-2021-01
by Raymond Toy 30 Jan '21

30 Jan '21

Raymond Toy pushed new tag snapshot-2021-01 at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/snapshot-2021-01 You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Update notes in preparation for snapshot.
by Raymond Toy 30 Jan '21

30 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: e349bf1d by Raymond Toy at 2021-01-30T09:51:59-08:00 Update notes in preparation for snapshot. Just updated based on the issues that were closed. - - - - - 1 changed file: - src/general-info/release-21e.md Changes: ===================================== src/general-info/release-21e.md ===================================== @@ -19,8 +19,6 @@ public domain. ## New in this release: * Known issues: - * Building with gcc8 or later doesn't work with the default -O option. Use -O1 instead. This shouldn't really impact overall speed much. - * Added simple support to compile with clang instead, which works. (Use x86_linux_clang). * Feature enhancements * Changes * Update to ASDF 3.3.4 @@ -35,6 +33,12 @@ public domain. * ~~#80~~ Use ASDF to load contribs. cmu-contribs still exists but does nothing. The contrib names are the same, except it's best to use a keyword instead of a string. So, `:contrib-demos` instead of `"contrib-demos"`. * ~~#81~~ Added contribs from Eric Marsden * ~~#82~~ Replace bc with expr in GNUMakefile + * ~~#86~~ Building with gcc 8 and later works when using -O2 optimization + * ~~#90~~ Some static symbols have been removed. This probably makes the fasl files incompatible with older versions. + * ~~#91~~ Loop destructuring no longer incorrectly signals an error + * ~~#95~~ Disassembler syntax of x86 je and movzx is incorrect + * ~~#98~~ fstpd is not an Intel instruction; disassemble as `fstp dword ptr [addr]` + * ~~#100~~ ldb prints out unicode base-chars correctly instead of just the low 8 bits. * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/e349bf1da7a83e19650aff2… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/e349bf1da7a83e19650aff2… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: ldb prints out Unicode characters
by Raymond Toy 30 Jan '21

30 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 19f274f0 by Raymond Toy at 2021-01-29T17:30:03-08:00 ldb prints out Unicode characters When printing out a base-char, only the low 8 bits of the code were used. But with Unicode support, we need to take all the bits and print them out. For control codes we use the form "#\^x". (Was #\C-x, which isn't a valid supported character form.) Ascii is printed as normal "#\a", and everything else use uses "#\u+<hex>". While we're at it, we also added special cases like #\Vt that are listed in https://cmucl.org/docs/cmu-user/html/Characters.html#Characters. With this, we can print out all unicode characters in a form that can be pasted back into lisp. - - - - - 832e116a by Raymond Toy at 2021-01-30T01:54:08+00:00 Merge branch 'issue-100-ldb-base-char-printing' into 'master' ldb prints out Unicode characters See merge request cmucl/cmucl!67 - - - - - 1 changed file: - src/lisp/print.c Changes: ===================================== src/lisp/print.c ===================================== @@ -212,12 +212,15 @@ static void brief_otherimm(lispobj obj) { int type, c, idx; - char buffer[10]; type = TypeOf(obj); switch (type) { case type_BaseChar: - c = (obj >> 8) & 0xff; + /* + * A base-char should only be 16 bits long now. But + * sometimes it uses all 24. So just grab all the bits. + */ + c = (obj >> 8) & 0xfffff; switch (c) { case '\0': printf("#\\Null"); @@ -228,20 +231,35 @@ brief_otherimm(lispobj obj) case '\b': printf("#\\Backspace"); break; + case '\11': + printf("#\\Tab"); + break; + case '\13': + printf("#\\Vt"); + break; + case '\15': + printf("#\\Return"); + break; + case '\33': + printf("#\\Escape"); + break; + case '\40': + printf("#\\Space"); + break; case '\177': printf("#\\Delete"); break; default: - strcpy(buffer, "#\\"); if (c >= 128) { - strcat(buffer, "m-"); - c -= 128; - } - if (c < 32) { - strcat(buffer, "c-"); - c += '@'; - } - printf("%s%c", buffer, c); + /* Just print out the code value */ + printf("#\\u+%04X", c); + } else if (c < 32) { + /* Print it out as a control character */ + printf("#\\^%c", c + '@'); + } else { + /* Plain ASCII character */ + printf("#\\%c", c); + } break; } break; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/ef9fc1bced6dbad3b63213… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/ef9fc1bced6dbad3b63213… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0