- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][issue-69-compile-in-gc-assert] Add function to get and set GC check options
by Raymond Toy 04 Sep '18

04 Sep '18

Raymond Toy pushed to branch issue-69-compile-in-gc-assert at cmucl / cmucl Commits: 62d02997 by Raymond Toy at 2018-09-04T05:05:32Z Add function to get and set GC check options Define GET-GC-ASSERTIONS to get the current GC assertions and SET-GC-ASSERTIONS to set them. These control the whether gc_assert is called; whether a a pre-scan of generation 0 is done before GC; whether we verify the heap after gc_free_heap is called from purify; and the verify pointers to old-space when GCing generations greater than or equal the given generation. Update C code to change boolean variables to int's to make it simple to to access from Lisp. (Don't have c-call:boolean.) - - - - - 2 changed files: - src/code/gc.lisp - src/lisp/gencgc.c Changes: ===================================== src/code/gc.lisp ===================================== @@ -72,14 +72,39 @@ (progn (alien:def-alien-routine get_bytes_allocated_lower c-call:int) (alien:def-alien-routine get_bytes_allocated_upper c-call:int) - ;; Controls GC assertions that are enabled in the runtime. A value - ;; of 0 disables all assertions (the normal default). - (alien:def-alien-variable gc_assert_level c-call:int) - (setf (documentation 'gc-assert-level 'variable) - "Current GC assertion level. Higher values enable more GC assertions") (defun dynamic-usage () (dfixnum:dfixnum-pair-integer - (get_bytes_allocated_upper) (get_bytes_allocated_lower)))) + (get_bytes_allocated_upper) (get_bytes_allocated_lower))) + + ;; Controls GC assertions that are enabled in the runtime. A value + ;; of 0 disables all assertions (the normal default). + (alien:def-alien-variable ("gc_assert_level" gc-assert-level) c-call:int) + (alien:def-alien-variable ("verify_after_free_heap" gc-verify-after-free-heap) c-call:int) + (alien:def-alien-variable ("pre_verify_gen_0" gc-verify-new-objects) c-call:int) + (alien:def-alien-variable ("verify_gens" gc-verify-generations) c-call:int) + (defun get-gc-assertions () + (list :assert-level gc-assert-level + :verify-after-free-heap (not (zerop gc-verify-after-free-heap)) + :verify-generations gc-verify-generations + :verify-new-objects (not (zerop gc-verify-new-objects)))) + (defun set-gc-assertions (&key (assert-level 0 assert-level-p) + (verify-after-free-heap nil verify-after-free-heap-p) + (verify-generations 6 verify-generations-p) + (verify-new-objects nil verify-new-objects-p)) + (declare (type (and fixnum unsigned-byte) assert-level) + (type boolean verify-after-free-heap) + (type (integer 0 6) verify-generation) + (type boolean verify-new-objects)) + (when assert-level-p + (setf gc-assert-level assert-level)) + (when verify-after-free-heap-p + (setf gc-verify-after-free-heap (if verify-after-free-heap 1 0))) + (when verify-generations-p + (setf gc-verify-generations verify-generations)) + (when verify-new-objects-p + (setf gc-verify-new-objects (if verify-new-objects 1 0))) + (values)) + ) #+cgc (c-var-frob dynamic-usage "bytes_allocated") ===================================== src/lisp/gencgc.c ===================================== @@ -260,15 +260,15 @@ int verify_gens = NUM_GENERATIONS; * makes GC very, very slow, so don't enable this unless you really * need it!) */ -boolean pre_verify_gen_0 = FALSE; +int pre_verify_gen_0 = FALSE; /* * Enable checking for bad pointers after gc_free_heap called from purify. */ #if 0 && defined(DARWIN) -boolean verify_after_free_heap = TRUE; +int verify_after_free_heap = TRUE; #else -boolean verify_after_free_heap = FALSE; +int verify_after_free_heap = FALSE; #endif /* @@ -8031,7 +8031,9 @@ collect_garbage(unsigned last_gen) /* Verify the new objects created by lisp code. */ if (pre_verify_gen_0) { - fprintf(stderr, "Pre-Checking generation 0\n"); + if (gencgc_verbose > 0) { + fprintf(stderr, "Pre-Checking generation 0\n"); + } verify_generation(0); } View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/62d029977c6e367cfbef2ec68… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/62d029977c6e367cfbef2ec68… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-69-compile-in-gc-assert] 2 commits: Correct an assertion on rehash-threshold.
by Raymond Toy 02 Sep '18

02 Sep '18

Raymond Toy pushed to branch issue-69-compile-in-gc-assert at cmucl / cmucl Commits: d895efeb by Raymond Toy at 2018-09-02T22:39:02Z Correct an assertion on rehash-threshold. The limit for rehash-threshold is 0.1 to 1. not 0 to 1. Also fix a compiler warning about bad casts. And use an appropriate structure type for the single-float object instead of hacking as float array. - - - - - cfaac541 by Raymond Toy at 2018-09-02T22:39:56Z Add gc-assert-level in lisp This allows users to change the runtime GC assertion level. Zero means no assertions and greater than 0 means assertions are enabled. - - - - - 2 changed files: - src/code/gc.lisp - src/lisp/gencgc.c Changes: ===================================== src/code/gc.lisp ===================================== @@ -72,7 +72,11 @@ (progn (alien:def-alien-routine get_bytes_allocated_lower c-call:int) (alien:def-alien-routine get_bytes_allocated_upper c-call:int) - + ;; Controls GC assertions that are enabled in the runtime. A value + ;; of 0 disables all assertions (the normal default). + (alien:def-alien-variable gc_assert_level c-call:int) + (setf (documentation 'gc-assert-level 'variable) + "Current GC assertion level. Higher values enable more GC assertions") (defun dynamic-usage () (dfixnum:dfixnum-pair-integer (get_bytes_allocated_upper) (get_bytes_allocated_lower)))) ===================================== src/lisp/gencgc.c ===================================== @@ -4813,12 +4813,12 @@ scav_hash_vector(lispobj * where, lispobj object) if (gc_assert_level > 0) { /* * Check to see that hash-table-rehash-threshold is a single - * float in the range (0, 1] + * float in the range [0.1, 1] */ lispobj threshold_obj = (lispobj) hash_table->rehash_threshold; - float* raw_slots = PTR(threshold_obj); - float threshold = raw_slots[2]; - gc_assert(threshold > 0 && threshold <= 1); + struct single_float* float_slot = (struct single_float*) PTR(threshold_obj); + float threshold = float_slot->value; + gc_assert(threshold >= 0.1 && threshold <= 1); } scavenge((lispobj *) hash_table, HASH_TABLE_SIZE); View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/ab9c63efd703fd07305b0491… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/ab9c63efd703fd07305b0491… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-69-compile-in-gc-assert
by Raymond Toy 02 Sep '18

02 Sep '18

Raymond Toy pushed new branch issue-69-compile-in-gc-assert at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/tree/issue-69-compile-in-gc-asse… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Oops. Forgot to remove one more FPU_MODE
by Raymond Toy 01 Sep '18

01 Sep '18

Raymond Toy pushed to branch master at cmucl / cmucl Commits: d7f49e51 by Raymond Toy at 2018-09-01T16:53:24Z Oops. Forgot to remove one more FPU_MODE - - - - - 1 changed file: - bin/build.sh Changes: ===================================== bin/build.sh ===================================== @@ -144,7 +144,7 @@ buildit () fi $TOOLDIR/load-world.sh $TARGET "$VERSION" || { echo "Failed: $TOOLDIR/load-world.sh"; exit 1; } - $TARGET/lisp/lisp -batch -noinit -nositeinit < /dev/null || { echo "Failed: $TARGET/lisp/lisp -batch -noinit $FPU_MODE"; exit 1; } + $TARGET/lisp/lisp -batch -noinit -nositeinit < /dev/null || { echo "Failed: $TARGET/lisp/lisp -batch -noinit"; exit 1; } return 0; fi } View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/d7f49e5153e53ddb7fa1ccc10… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/d7f49e5153e53ddb7fa1ccc10… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Get rid of FPU_MODE
by Raymond Toy 30 Aug '18

30 Aug '18

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 9d2590c0 by Raymond Toy at 2018-08-28T22:00:19Z Get rid of FPU_MODE This was used to selecte whether we were building for x87 or sse2, but we dropped support for x87 a long while ago. Remove this var. - - - - - 1 changed file: - bin/build.sh Changes: ===================================== bin/build.sh ===================================== @@ -144,12 +144,11 @@ buildit () fi $TOOLDIR/load-world.sh $TARGET "$VERSION" || { echo "Failed: $TOOLDIR/load-world.sh"; exit 1; } - $TARGET/lisp/lisp -batch -noinit -nositeinit $FPU_MODE < /dev/null || { echo "Failed: $TARGET/lisp/lisp -batch -noinit $FPU_MODE"; exit 1; } + $TARGET/lisp/lisp -batch -noinit -nositeinit < /dev/null || { echo "Failed: $TARGET/lisp/lisp -batch -noinit $FPU_MODE"; exit 1; } return 0; fi } -FPU_MODE= BUILDWORLD="$TOOLDIR/build-world.sh" BUILD_POT="yes" UPDATE_TRANS= View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/9d2590c07eb51011a23884c27… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/9d2590c07eb51011a23884c27… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Add support for compiling with clang on x86/linux
by Raymond Toy 25 Aug '18

25 Aug '18

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 82bf2c72 by Raymond Toy at 2018-08-25T23:51:54Z Add support for compiling with clang on x86/linux Add `Config.x86_linux_clang` to use clang instead of gcc to build cmucl. update `create-target.sh` so that it sets the motif variant correctly when using `Config.x86_linux_clang` See issue #68. With this config, Fedora 28 successfully builds cmucl and passes all the tests. - - - - - 2 changed files: - bin/create-target.sh - + src/lisp/Config.x86_linux_clang Changes: ===================================== bin/create-target.sh ===================================== @@ -83,7 +83,7 @@ case $uname_s in hp700*) motif_variant=hpux_cc ;; pmax_mach) motif_variant=pmax_mach ;; sgi*) motif_variant=irix ;; - x86_linux|linux*) motif_variant=x86 ;; + x86_linux*|linux*) motif_variant=x86 ;; esac } [ -f src/motif/server/Config.$motif_variant ] || quit "No such motif-variant could be found: Config.$motif_variant" ===================================== src/lisp/Config.x86_linux_clang ===================================== @@ -0,0 +1,15 @@ +# -*- Mode: makefile -*- +include Config.x86_common + +CC = clang +CPPFLAGS += -m32 -D__NO_CTYPE -D_GNU_SOURCE +CFLAGS += -march=pentium4 -mfpmath=sse -mtune=generic + +UNDEFSYMPATTERN = -Xlinker -u -Xlinker & +ASSEM_SRC += linux-stubs.S +OS_SRC += Linux-os.c elf.c +OS_LIBS = -ldl +OS_LINK_FLAGS = -m32 -rdynamic -Xlinker --export-dynamic -Xlinker -Map -Xlinker foo +OS_LINK_FLAGS += -Wl,-z,noexecstack + +EXEC_FINAL_OBJ = exec-final.o View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/82bf2c727ba1d3c461fa360aa… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/82bf2c727ba1d3c461fa360aa… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Set label correctly.
by Raymond Toy 23 Aug '18

23 Aug '18

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 14f72f54 by Raymond Toy at 2018-08-23T00:26:05Z Set label correctly. It's a tilde, not dash. - - - - - 1d6d12de by Raymond Toy at 2018-08-23T00:27:01Z Set label to feature - - - - - 2 changed files: - .gitlab/issue_templates/Bug.md - .gitlab/issue_templates/Feature.md Changes: ===================================== .gitlab/issue_templates/Bug.md ===================================== @@ -21,4 +21,4 @@ If applicable, add screenshots to help explain your problem. **Additional context** Add any other context about the problem here. -/label -bug \ No newline at end of file +/label ~bug ===================================== .gitlab/issue_templates/Feature.md ===================================== @@ -6,3 +6,5 @@ If you have a prototype, provide links to illustrate this addition. This is the **Describe the feature in more detail** Provide more information to describe the feature. + +/label ~feature View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/1894fbfe99d979fe79eb439b… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/1894fbfe99d979fe79eb439b… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Add template for Bugs
by Raymond Toy 23 Aug '18

23 Aug '18

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 7a6a0e19 by Raymond Toy at 2018-08-23T00:16:10Z Add template for Bugs - - - - - 1894fbfe by Raymond Toy at 2018-08-23T00:19:24Z Add template for Feature requests - - - - - 2 changed files: - + .gitlab/issue_templates/Bug.md - + .gitlab/issue_templates/Feature.md Changes: ===================================== .gitlab/issue_templates/Bug.md ===================================== @@ -0,0 +1,24 @@ +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Desktop (please complete the following information):** + - OS: [e.g. Linux] + - Version [e.g. 21c] + +**Additional context** +Add any other context about the problem here. + +/label -bug \ No newline at end of file ===================================== .gitlab/issue_templates/Feature.md ===================================== @@ -0,0 +1,8 @@ +**Describe the feature** +Briefly describe the feature you would like see. + +**Is there a prototype?** +If you have a prototype, provide links to illustrate this addition. This is the best way to propose a new feature. + +**Describe the feature in more detail** +Provide more information to describe the feature. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/2de12cd70652794979529cdf… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/2de12cd70652794979529cdf… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Fix compiler warning
by Raymond Toy 05 Aug '18

05 Aug '18

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 2de12cd7 by Raymond Toy at 2018-08-05T23:46:44Z Fix compiler warning clang complains: warning: incompatible pointer to integer conversion passing 'lispobj *' (aka 'unsigned long *') to parameter of type 'lispobj' (aka 'unsigned long'); dereference with * [-Wint-conversion] || in_range_p(addr, control_stack, control_stack_size) So cast control_stack to lispobj. Same complaint for binding_stack too. - - - - - 1 changed file: - src/lisp/Linux-os.c Changes: ===================================== src/lisp/Linux-os.c ===================================== --- a/src/lisp/Linux-os.c +++ b/src/lisp/Linux-os.c @@ -385,8 +385,8 @@ valid_addr(os_vm_address_t addr) || in_range_p(addr, STATIC_SPACE_START, static_space_size) || in_range_p(addr, DYNAMIC_0_SPACE_START, dynamic_space_size) || in_range_p(addr, DYNAMIC_1_SPACE_START, dynamic_space_size) - || in_range_p(addr, control_stack, control_stack_size) - || in_range_p(addr, binding_stack, binding_stack_size)) + || in_range_p(addr, (lispobj) control_stack, control_stack_size) + || in_range_p(addr, (lispobj) binding_stack, binding_stack_size)) return TRUE; return FALSE; } View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/2de12cd70652794979529cdfc… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/2de12cd70652794979529cdfc… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Export more symbols in defpackage for xlib.
by Raymond Toy 05 Aug '18

05 Aug '18

Raymond Toy pushed to branch master at cmucl / cmucl Commits: cb251bbe by Raymond Toy at 2018-08-05T01:46:45Z Export more symbols in defpackage for xlib. The compiler complained that these symbols were also being exported from the XLIB package. Just add them to the defpackage to silence the warnings. - - - - - 7c79326d by Raymond Toy at 2018-08-05T01:50:55Z Add %UNARY-FROUND to exports of defpackage for KERNEL. - - - - - 2 changed files: - src/clx/package.lisp - src/code/exports.lisp Changes: ===================================== src/clx/package.lisp ===================================== --- a/src/clx/package.lisp +++ b/src/clx/package.lisp @@ -177,4 +177,93 @@ wm-size-hints-user-specified-position-p wm-size-hints-user-specified-size-p wm-size-hints-width wm-size-hints-width-inc wm-size-hints-win-gravity wm-size-hints-x wm-size-hints-y wm-zoom-hints write-bitmap-file - write-resources xatom)) + write-resources xatom + picture-subwindow-mode picture-format-id + mode-info-hsyncstart + mode-info + xfree86-vidmode-get-mode-line + picture-drawable + picture-alpha-y-origin + make-mode-info + shape-mask + xfree86-vidmode-get-viewport + render-query-version + shape-rectangles + xfree86-vidmode-select-next-mode + xfree86-vidmode-set-gamma + render-composite-glyphs + xfree86-vidmode-get-dotclocks + render-trapezoids + xfree86-vidmode-get-all-mode-lines + mode-info-hskew + picture-format-type + xfree86-vidmode-get-gamma-ramp + render-create-picture + picture-format-blue-byte + shape-query-extents + xfree86-vidmode-validate-mode-line + shape-offset + shape-input-selected-p + mode-info-vsyncend + shape-select-input + screen-saver-get-idle + mode-info-vtotal + picture-format-depth + picture-clip-x-origin + picture-format-alpha-byte + screen-saver-query-info + xfree86-vidmode-set-gamma-ramp + xfree86-vidmode-switch-to-mode + mode-info-vdisplay + xfree86-vidmode-delete-mode-line + xfree86-vidmode-set-viewport + picture-dither + picture-format-colormap + xfree86-vidmode-lock-mode-switch + render-triangles + xfree86-vidmode-add-mode-line + picture-component-alpha + xfree86-vidmode-get-permissions + shape-get-rectangles + shape-query-version + mode-info-hsyncend + mode-info-hdisplay + picture-repeat + picture-graphics-exposures + xfree86-vidmode-query-version + screen-saver-query-version + find-window-picture-format + render-add-glyph-from-picture + mode-info-private + xfree86-vidmode-get-gamma + picture-alpha-map + xfree86-vidmode-mod-mode-line + mode-info-htotal + render-free-picture + picture-poly-mode + picture-format-green-byte + render-free-glyph-set + render-free-glyphs + shape-combine + render-free-glyph + mode-info-flags + render-fill-rectangle + picture-clip-y-origin + mode-info-vsyncstart + mode-info-privsize + picture-poly-edge + render-composite + picture-format-red-byte + render-add-glyph + picture-format-display + render-reference-glyph-set + xfree86-vidmode-get-gamma-ramp-size + find-matching-picture-formats + mode-info-dotclock + xfree86-vidmode-set-client-version + picture-clip-mask + picture-alpha-x-origin + xfree86-vidmode-get-monitor + render-create-glyph-set + xfree86-vidmode-switch-mode + xfree86-vidmode-select-prev-mode)) ===================================== src/code/exports.lisp ===================================== --- a/src/code/exports.lisp +++ b/src/code/exports.lisp @@ -2530,7 +2530,8 @@ "SET-SYMBOL-VALUE-CONDITIONAL" "ATOMIC-POP-SYMBOL-VALUE" "ATOMIC-PUSHA" - "ATOMIC-PUSHD") + "ATOMIC-PUSHD" + "%UNARY-FROUND") #+x87 (:export "%COS-QUICK" "%SIN-QUICK" "%TAN-QUICK") ;;#+double-double View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/0c427fc137491327a31e997b… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/0c427fc137491327a31e997b… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0