- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl] Pushed new branch rtoy-fix-60-unary-fround-undefined
by Raymond Toy 18 Feb '18

18 Feb '18

Raymond Toy pushed new branch rtoy-fix-60-unary-fround-undefined at cmucl / cmucl --- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/tree/rtoy-fix-60-unary-fround-un… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new tag snapshot-2018-02
by Raymond Toy 10 Feb '18

10 Feb '18

Raymond Toy pushed new tag snapshot-2018-02 at cmucl / cmucl --- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/tree/snapshot-2018-02 You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Update from logs
by Raymond Toy 10 Feb '18

10 Feb '18

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 894e18e0 by Raymond Toy at 2018-02-10T08:52:20-08:00 Update from logs - - - - - 1 changed file: - src/general-info/release-21d.md Changes: ===================================== src/general-info/release-21d.md ===================================== --- a/src/general-info/release-21d.md +++ b/src/general-info/release-21d.md @@ -25,10 +25,14 @@ public domain. * The required state for this generator is just 4 32-bit words instead of the 600+ for MT19937. * The generator is also faster than MT19937 (approximately 28% faster on x86 and 18% on sparc). * The new function `KERNEL:RANDOM-STATE-JUMP` modifies the given state to jump 2^64 samples ahead, allowing 2^64 non-overlapping sequences. - + * Updated CLX to telent clx version 06e39a0d. * ANSI compliance fixes: * Bug fixes: * Gitlab tickets: + * ~~~#50~~~ CLX (Hemlock) fails to run. + * ~~~#49~~~ CLM crashes + * ~~~#47~~~ Backquate and multiple splices + * ~~~#59~~~ Incorrect type-derivation for `decode-float` * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/894e18e020e6a16024bc63f2f… --- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/894e18e020e6a16024bc63f2f… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 6 commits: Fix #59: type derivation for decode-float exponent
by Raymond Toy 04 Feb '18

04 Feb '18

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 3acdd1b7 by Raymond Toy at 2018-02-03T08:57:28-08:00 Fix #59: type derivation for decode-float exponent Type derivation for exponent part of decode-float was incorrect. We need to take the absolute value of the argument before deriving the type since the exponent is, of course, independent of the sign of the number. In the test case, the negative interval caused the lower and upper bounds to be reversed, resulting in an invalid interval. - - - - - 62c5f3e9 by Raymond Toy at 2018-02-03T09:03:04-08:00 Add test for issue #59. - - - - - 2292400e by Raymond Toy at 2018-02-04T08:16:35-08:00 Fix typo. double-double-float is in the kernel package - - - - - 4e58e53c by Raymond Toy at 2018-02-04T08:19:13-08:00 Be more careful in computing the decode-float bounds If 0 is the lower bound then the smallest exponent is not for 0, but for the least positive float because of denormals. Also handle exclusive bounds. - - - - - 7b336362 by Raymond Toy at 2018-02-04T08:19:37-08:00 Add more tests decode-float. - - - - - 90df7817 by Raymond Toy at 2018-02-04T18:46:50+00:00 Merge branch 'rtoy-fix-59-derive-decode-float' into 'master' Fix #59: derive decode float Closes #59 See merge request cmucl/cmucl!34 - - - - - 3 changed files: - src/compiler/float-tran.lisp - tests/float-tran.lisp - tests/issues.lisp Changes: ===================================== src/compiler/float-tran.lisp ===================================== --- a/src/compiler/float-tran.lisp +++ b/src/compiler/float-tran.lisp @@ -2028,31 +2028,36 @@ (defun decode-float-exp-derive-type-aux (arg) ;; Derive the exponent part of the float. It's always an integer ;; type. - (flet ((calc-exp (x) - (when x - (nth-value 1 (decode-float x)))) - (min-exp () - ;; Use decode-float on the least positive float of the - ;; appropriate type to find the min exponent. If we don't - ;; know the actual number format, use double, which has the - ;; widest range (including double-double-float). - (nth-value 1 (decode-float (if (eq 'single-float (numeric-type-format arg)) - least-positive-single-float - least-positive-double-float)))) - (max-exp () - ;; Use decode-float on the most postive number of the - ;; appropriate type to find the max exponent. If we don't - ;; know the actual number format, use double, which has the - ;; widest range (including double-double-float). - (if (eq (numeric-type-format arg) 'single-float) - (nth-value 1 (decode-float most-positive-single-float)) - (nth-value 1 (decode-float most-positive-double-float))))) - (let* ((lo (or (bound-func #'calc-exp - (numeric-type-low arg)) - (min-exp))) - (hi (or (bound-func #'calc-exp - (numeric-type-high arg)) - (max-exp)))) + (labels + ((calc-exp (x) + (when x + (bound-func #'(lambda (arg) + (nth-value 1 (decode-float arg))) + x))) + (min-exp (interval) + ;; (decode-float 0d0) returns an exponent of -1022. But + ;; (decode-float least-positive-double-float returns -1073. + ;; Hence, if the low value is less than this, we need to + ;; return the exponent of the least positive number. + (let ((least (if (eq 'single-float (numeric-type-format arg)) + least-positive-single-float + least-positive-double-float))) + (if (or (interval-contains-p 0 interval) + (interval-contains-p least interval)) + (calc-exp least) + (calc-exp (bound-value (interval-low interval)))))) + (max-exp (interval) + ;; Use decode-float on the most postive number of the + ;; appropriate type to find the max exponent. If we don't + ;; know the actual number format, use double, which has the + ;; widest range (including double-double-float). + (or (calc-exp (bound-value (interval-high interval))) + (calc-exp (if (eq 'single-float (numeric-type-format arg)) + most-positive-single-float + most-positive-double-float))))) + (let* ((interval (interval-abs (numeric-type->interval arg))) + (lo (min-exp interval)) + (hi (max-exp interval))) (specifier-type `(integer ,(or lo '*) ,(or hi '*)))))) (defun decode-float-sign-derive-type-aux (arg) ===================================== tests/float-tran.lisp ===================================== --- a/tests/float-tran.lisp +++ b/tests/float-tran.lisp @@ -28,7 +28,7 @@ #+double-double (assert-equalp (c::specifier-type '(integer -1073 1024)) (c::decode-float-exp-derive-type-aux - (c::specifier-type 'double-double-float))) + (c::specifier-type 'kernel:double-double-float))) (assert-equalp (c::specifier-type '(integer 2 8)) (c::decode-float-exp-derive-type-aux (c::specifier-type '(double-float 2d0 128d0))))) ===================================== tests/issues.lisp ===================================== --- a/tests/issues.lisp +++ b/tests/issues.lisp @@ -443,3 +443,64 @@ (write (read-from-string "`(,@vars ,@vars)") :pretty t :stream s))))) + +(define-test issue.59 + (:tag :issues) + (let ((f (compile nil #'(lambda (z) + (declare (type (double-float -2d0 0d0) z)) + (nth-value 2 (decode-float z)))))) + (assert-equal -1d0 (funcall f -1d0)))) + +(define-test issue.59.1-double + (:tag :issues) + (dolist (entry '(((-2d0 2d0) (-1073 2)) + ((-2d0 0d0) (-1073 2)) + ((0d0 2d0) (-1073 2)) + ((1d0 4d0) (1 3)) + ((-4d0 -1d0) (1 3)) + (((0d0) (10d0)) (-1073 4)) + ((-2f0 2f0) (-148 2)) + ((-2f0 0f0) (-148 2)) + ((0f0 2f0) (-148 2)) + ((1f0 4f0) (1 3)) + ((-4f0 -1f0) (1 3)) + ((0f0) (10f0)) (-148 4))) + (destructuring-bind ((arg-lo arg-hi) (result-lo result-hi)) + entry + (assert-equalp (c::specifier-type `(integer ,result-lo ,result-hi)) + (c::decode-float-exp-derive-type-aux + (c::specifier-type `(double-float ,arg-lo ,arg-hi))))))) + +(define-test issue.59.1-double + (:tag :issues) + (dolist (entry '(((-2d0 2d0) (-1073 2)) + ((-2d0 0d0) (-1073 2)) + ((0d0 2d0) (-1073 2)) + ((1d0 4d0) (1 3)) + ((-4d0 -1d0) (1 3)) + (((0d0) (10d0)) (-1073 4)) + (((0.5d0) (4d0)) (0 3)))) + (destructuring-bind ((arg-lo arg-hi) (result-lo result-hi)) + entry + (assert-equalp (c::specifier-type `(integer ,result-lo ,result-hi)) + (c::decode-float-exp-derive-type-aux + (c::specifier-type `(double-float ,arg-lo ,arg-hi))) + arg-lo + arg-hi)))) + +(define-test issue.59.1-float + (:tag :issues) + (dolist (entry '(((-2f0 2f0) (-148 2)) + ((-2f0 0f0) (-148 2)) + ((0f0 2f0) (-148 2)) + ((1f0 4f0) (1 3)) + ((-4f0 -1f0) (1 3)) + (((0f0) (10f0)) (-148 4)) + (((0.5f0) (4f0)) (0 3)))) + (destructuring-bind ((arg-lo arg-hi) (result-lo result-hi)) + entry + (assert-equalp (c::specifier-type `(integer ,result-lo ,result-hi)) + (c::decode-float-exp-derive-type-aux + (c::specifier-type `(single-float ,arg-lo ,arg-hi))) + arg-lo + arg-hi)))) \ No newline at end of file View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/e7f97a5d5e72b65650ecfc28… --- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/e7f97a5d5e72b65650ecfc28… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][rtoy-fix-59-derive-decode-float] 3 commits: Fix typo. double-double-float is in the kernel package
by Raymond Toy 04 Feb '18

04 Feb '18

Raymond Toy pushed to branch rtoy-fix-59-derive-decode-float at cmucl / cmucl Commits: 2292400e by Raymond Toy at 2018-02-04T08:16:35-08:00 Fix typo. double-double-float is in the kernel package - - - - - 4e58e53c by Raymond Toy at 2018-02-04T08:19:13-08:00 Be more careful in computing the decode-float bounds If 0 is the lower bound then the smallest exponent is not for 0, but for the least positive float because of denormals. Also handle exclusive bounds. - - - - - 7b336362 by Raymond Toy at 2018-02-04T08:19:37-08:00 Add more tests decode-float. - - - - - 3 changed files: - src/compiler/float-tran.lisp - tests/float-tran.lisp - tests/issues.lisp Changes: ===================================== src/compiler/float-tran.lisp ===================================== --- a/src/compiler/float-tran.lisp +++ b/src/compiler/float-tran.lisp @@ -2031,29 +2031,33 @@ (labels ((calc-exp (x) (when x - (nth-value 1 (decode-float x)))) - (min-exp () - ;; Use decode-float on the least positive float of the - ;; appropriate type to find the min exponent. If we don't - ;; know the actual number format, use double, which has the - ;; widest range (including double-double-float). - (calc-exp (if (eq 'single-float (numeric-type-format arg)) - least-positive-single-float - least-positive-double-float))) - (max-exp () + (bound-func #'(lambda (arg) + (nth-value 1 (decode-float arg))) + x))) + (min-exp (interval) + ;; (decode-float 0d0) returns an exponent of -1022. But + ;; (decode-float least-positive-double-float returns -1073. + ;; Hence, if the low value is less than this, we need to + ;; return the exponent of the least positive number. + (let ((least (if (eq 'single-float (numeric-type-format arg)) + least-positive-single-float + least-positive-double-float))) + (if (or (interval-contains-p 0 interval) + (interval-contains-p least interval)) + (calc-exp least) + (calc-exp (bound-value (interval-low interval)))))) + (max-exp (interval) ;; Use decode-float on the most postive number of the ;; appropriate type to find the max exponent. If we don't ;; know the actual number format, use double, which has the ;; widest range (including double-double-float). - (calc-exp (if (eq 'single-float (numeric-type-format arg)) - most-positive-single-float - most-positive-double-float)))) - (let* ((interval (interval-func #'calc-exp - (interval-abs (numeric-type->interval arg)))) - (lo (or (interval-low interval) - (min-exp))) - (hi (or (interval-high interval) - (max-exp)))) + (or (calc-exp (bound-value (interval-high interval))) + (calc-exp (if (eq 'single-float (numeric-type-format arg)) + most-positive-single-float + most-positive-double-float))))) + (let* ((interval (interval-abs (numeric-type->interval arg))) + (lo (min-exp interval)) + (hi (max-exp interval))) (specifier-type `(integer ,(or lo '*) ,(or hi '*)))))) (defun decode-float-sign-derive-type-aux (arg) ===================================== tests/float-tran.lisp ===================================== --- a/tests/float-tran.lisp +++ b/tests/float-tran.lisp @@ -28,7 +28,7 @@ #+double-double (assert-equalp (c::specifier-type '(integer -1073 1024)) (c::decode-float-exp-derive-type-aux - (c::specifier-type 'double-double-float))) + (c::specifier-type 'kernel:double-double-float))) (assert-equalp (c::specifier-type '(integer 2 8)) (c::decode-float-exp-derive-type-aux (c::specifier-type '(double-float 2d0 128d0))))) ===================================== tests/issues.lisp ===================================== --- a/tests/issues.lisp +++ b/tests/issues.lisp @@ -450,3 +450,57 @@ (declare (type (double-float -2d0 0d0) z)) (nth-value 2 (decode-float z)))))) (assert-equal -1d0 (funcall f -1d0)))) + +(define-test issue.59.1-double + (:tag :issues) + (dolist (entry '(((-2d0 2d0) (-1073 2)) + ((-2d0 0d0) (-1073 2)) + ((0d0 2d0) (-1073 2)) + ((1d0 4d0) (1 3)) + ((-4d0 -1d0) (1 3)) + (((0d0) (10d0)) (-1073 4)) + ((-2f0 2f0) (-148 2)) + ((-2f0 0f0) (-148 2)) + ((0f0 2f0) (-148 2)) + ((1f0 4f0) (1 3)) + ((-4f0 -1f0) (1 3)) + ((0f0) (10f0)) (-148 4))) + (destructuring-bind ((arg-lo arg-hi) (result-lo result-hi)) + entry + (assert-equalp (c::specifier-type `(integer ,result-lo ,result-hi)) + (c::decode-float-exp-derive-type-aux + (c::specifier-type `(double-float ,arg-lo ,arg-hi))))))) + +(define-test issue.59.1-double + (:tag :issues) + (dolist (entry '(((-2d0 2d0) (-1073 2)) + ((-2d0 0d0) (-1073 2)) + ((0d0 2d0) (-1073 2)) + ((1d0 4d0) (1 3)) + ((-4d0 -1d0) (1 3)) + (((0d0) (10d0)) (-1073 4)) + (((0.5d0) (4d0)) (0 3)))) + (destructuring-bind ((arg-lo arg-hi) (result-lo result-hi)) + entry + (assert-equalp (c::specifier-type `(integer ,result-lo ,result-hi)) + (c::decode-float-exp-derive-type-aux + (c::specifier-type `(double-float ,arg-lo ,arg-hi))) + arg-lo + arg-hi)))) + +(define-test issue.59.1-float + (:tag :issues) + (dolist (entry '(((-2f0 2f0) (-148 2)) + ((-2f0 0f0) (-148 2)) + ((0f0 2f0) (-148 2)) + ((1f0 4f0) (1 3)) + ((-4f0 -1f0) (1 3)) + (((0f0) (10f0)) (-148 4)) + (((0.5f0) (4f0)) (0 3)))) + (destructuring-bind ((arg-lo arg-hi) (result-lo result-hi)) + entry + (assert-equalp (c::specifier-type `(integer ,result-lo ,result-hi)) + (c::decode-float-exp-derive-type-aux + (c::specifier-type `(single-float ,arg-lo ,arg-hi))) + arg-lo + arg-hi)))) \ No newline at end of file View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/62c5f3e9a170e5f8799f37b3… --- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/62c5f3e9a170e5f8799f37b3… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch rtoy-fix-59-derive-decode-float
by Raymond Toy 03 Feb '18

03 Feb '18

Raymond Toy pushed new branch rtoy-fix-59-derive-decode-float at cmucl / cmucl --- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/tree/rtoy-fix-59-derive-decode-f… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new tag snapshot-2017-10
by Raymond Toy 30 Jan '18

30 Jan '18

Raymond Toy pushed new tag snapshot-2017-10 at cmucl / cmucl --- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/tree/snapshot-2017-10 You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Move defsystem for pcl-tests to its own file.
by Raymond Toy 30 Jan '18

30 Jan '18

Raymond Toy pushed to branch master at cmucl / cmucl Commits: a368558e by Raymond Toy at 2017-10-08T15:17:59-07:00 Move defsystem for pcl-tests to its own file. The upgrade to ASDF 3.3.0 broke the pcl-tests; this version doesn't like having the defsystem in the same file. Thus, move the defsystem to its own file and load it up in pcl.lisp (via require). - - - - - 2 changed files: - + tests/pcl-tests.asd - tests/pcl.lisp Changes: ===================================== tests/pcl-tests.asd ===================================== --- /dev/null +++ b/tests/pcl-tests.asd @@ -0,0 +1,39 @@ +;;; -*- Mode: lisp -*- + +(asdf:defsystem :pcl-tests + :pathname "pcl/" + :components + ((:file "pkg") + #+gerds-pcl + (:file "ctor" + :depends-on ("pkg")) + (:file "defclass" + :depends-on ("pkg")) + (:file "make-instance" + :depends-on ("pkg" #+gerds-pcl "ctor")) + (:file "reinitialize-instance" + :depends-on ("pkg" "make-instance")) + (:file "slot-value" + :depends-on ("pkg" "make-instance")) + (:file "slot-boundp" + :depends-on ("pkg" "make-instance")) + (:file "slot-missing" + :depends-on ("pkg" "make-instance")) + (:file "slot-accessors" + :depends-on ("pkg" "make-instance")) + (:file "slot-type" + :depends-on ("pkg" "slot-value")) + (:file "inline-access" + :depends-on ("pkg" "slot-type")) + (:file "method-combination" + :depends-on ("pkg")) + (:file "pv" + :depends-on ("pkg")) + (:file "defgeneric" + :depends-on ("pkg")) + (:file "defmethod" + :depends-on ("pkg")) + (:file "find-method" + :depends-on ("pkg")) + (:file "methods" + :depends-on ("pkg")))) ===================================== tests/pcl.lisp ===================================== --- a/tests/pcl.lisp +++ b/tests/pcl.lisp @@ -26,42 +26,11 @@ (merge-pathnames #p"pcl/*.*" *load-truename*)))) -(asdf:defsystem :pcl-test - :pathname "pcl/" - :components - ((:file "pkg") - #+gerds-pcl - (:file "ctor" - :depends-on ("pkg")) - (:file "defclass" - :depends-on ("pkg")) - (:file "make-instance" - :depends-on ("pkg" #+gerds-pcl "ctor")) - (:file "reinitialize-instance" - :depends-on ("pkg" "make-instance")) - (:file "slot-value" - :depends-on ("pkg" "make-instance")) - (:file "slot-boundp" - :depends-on ("pkg" "make-instance")) - (:file "slot-missing" - :depends-on ("pkg" "make-instance")) - (:file "slot-accessors" - :depends-on ("pkg" "make-instance")) - (:file "slot-type" - :depends-on ("pkg" "slot-value")) - (:file "inline-access" - :depends-on ("pkg" "slot-type")) - (:file "method-combination" - :depends-on ("pkg")) - (:file "pv" - :depends-on ("pkg")) - (:file "defgeneric" - :depends-on ("pkg")) - (:file "defmethod" - :depends-on ("pkg")) - (:file "find-method" - :depends-on ("pkg")) - (:file "methods" - :depends-on ("pkg")))) +;; Just smash it with our path so we don't accidentally look up +;; pcl-files somewhere else. +(setf asdf:*central-registry* + (list (make-pathname :directory (pathname-directory *load-pathname*)))) -(asdf:oos 'asdf:load-op :pcl-test) +(require :pcl-tests) + +(asdf:oos 'asdf:load-op :pcl-tests) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/a368558eacabee5d8b099dc07… --- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/a368558eacabee5d8b099dc07… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #47: Print backquote multiple splices correctly
by Raymond Toy 30 Jan '18

30 Jan '18

Raymond Toy pushed to branch master at cmucl / cmucl Commits: dc4a7e00 by Raymond Toy at 2018-01-28T18:20:20-08:00 Fix #47: Print backquote multiple splices correctly * Print multiple splices correclty without the extra set of parenthesis around each splice. * Add test for this. - - - - - e7f97a5d by Raymond Toy at 2018-01-30T03:04:30+00:00 Merge branch 'rtoy-fix-47-backq-splice-printer' into 'master' Fix #47: Print backquote multiple splices correctly Closes #47 See merge request cmucl/cmucl!33 - - - - - 2 changed files: - src/code/backq.lisp - tests/issues.lisp Changes: ===================================== src/code/backq.lisp ===================================== --- a/src/code/backq.lisp +++ b/src/code/backq.lisp @@ -263,7 +263,8 @@ (backq-unparse (car tail) t))) (push (backq-unparse (car tail)) accum))) (backq-append - (mapcar #'(lambda (el) (backq-unparse el t)) + (mapcar #'(lambda (el) + (car (backq-unparse el t))) (cdr form))) (backq-nconc (mapcar #'(lambda (el) (backq-unparse el :nconc)) ===================================== tests/issues.lisp ===================================== --- a/tests/issues.lisp +++ b/tests/issues.lisp @@ -434,4 +434,12 @@ "./" test-dir-name "ls-link"))))) - + +(define-test issue.47 + (:tag :issues) + (with-standard-io-syntax + (assert-equal "`(,@VARS ,@VARS)" + (with-output-to-string (s) + (write (read-from-string "`(,@vars ,@vars)") + :pretty t + :stream s))))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/380759e3d91a1d6517a20254… --- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/380759e3d91a1d6517a20254… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch rtoy-fix-47-backq-splice-printer
by Raymond Toy 30 Jan '18

30 Jan '18

Raymond Toy pushed new branch rtoy-fix-47-backq-splice-printer at cmucl / cmucl --- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/tree/rtoy-fix-47-backq-splice-pr… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0