- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl] Pushed new branch issue-367-count-octets-for-encoding
by Raymond Toy (＠rtoy) 12 Jan '25

12 Jan '25

Raymond Toy pushed new branch issue-367-count-octets-for-encoding at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-367-count-octets-fo… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-363-add-version-number] 3 commits: Clean up changes
by Raymond Toy (＠rtoy) 10 Jan '25

10 Jan '25

Raymond Toy pushed to branch issue-363-add-version-number at cmucl / cmucl Commits: 2dcd20b0 by Raymond Toy at 2025-01-09T20:11:18-08:00 Clean up changes Comment out `set -x` things that we don't need but could be useful in the future for debugging. For the make file, remove some unneeded echoes in the rule. - - - - - a8014384 by Raymond Toy at 2025-01-09T20:17:29-08:00 Always rebuild lisp.o to keep version number in sync We need to recompile lisp.o whenever make is run so that we get an updated cmucl version to match what build.sh and friends are using. To do this add lisp.o to the .PHONY target. - - - - - c60a9a25 by Raymond Toy at 2025-01-09T20:18:41-08:00 Don't need to `cd src` before calling git describe As long as we call this somewhere in the git repo, we'll be able to get something. - - - - - 5 changed files: - bin/build.sh - bin/cmucl-version.sh - bin/make-dist.sh - bin/run-unit-tests.sh - src/lisp/GNUmakefile Changes: ===================================== bin/build.sh ===================================== @@ -131,9 +131,9 @@ buildit () if [ "$ENABLE" = "yes" ]; then $TOOLDIR/clean-target.sh $CLEAN_FLAGS $TARGET || { echo "Failed: $TOOLDIR/clean-target.sh"; exit 1; } - set -x + #set -x time $BUILDWORLD $TARGET $OLDLISP $BOOT || { echo "Failed: $BUILDWORLD"; exit 1; } - set +x + #set +x if [ "$REBUILD_LISP" = "yes" ]; then $TOOLDIR/rebuild-lisp.sh $TARGET fi @@ -144,15 +144,15 @@ buildit () if [ "$BUILD_WORLD2" = "yes" ]; then - set -x + #set -x $BUILDWORLD $TARGET $OLDLISP $BOOT || { echo "Failed: $BUILDWORLD"; exit 1; } - set +x + #set +x fi $TOOLDIR/load-world.sh $TARGET "$VERSION" || { echo "Failed: $TOOLDIR/load-world.sh"; exit 1; } - set -x + #set -x $TARGET/lisp/lisp -lib $TARGET/lisp -batch -noinit -nositeinit < /dev/null || { echo "Failed: $TARGET/lisp/lisp -batch -noinit"; exit 1; } - set +x + #set +x return 0; fi } ===================================== bin/cmucl-version.sh ===================================== @@ -1,7 +1,7 @@ #!/bin/sh # Script to determine the cmucl version based on git describe -GIT_HASH="`(cd src; git describe --dirty 2>/dev/null || git describe 2>/dev/null)`" +GIT_HASH="`(git describe --dirty 2>/dev/null || git describe 2>/dev/null)`" # echo GIT_HASH = ${GIT_HASH} if expr "X${GIT_HASH}" : 'Xsnapshot-[0-9][0-9][0-9][0-9]-[01][0-9]' > /dev/null; then ===================================== bin/make-dist.sh ===================================== @@ -149,7 +149,7 @@ if [ -n "$COMPRESS_ARG" ]; then esac fi -set -x +#set -x if [ -z "$VERSION" ]; then # If a default version exists, use it. Otherwise this is an # error---at least one of these must not be empty. ===================================== bin/run-unit-tests.sh ===================================== @@ -49,7 +49,7 @@ function cleanup { trap cleanup EXIT -set -x +#set -x if [ -n "${TESTDIR}" ]; then TESTDIRARG=" :test-directory \"${TESTDIR}/\"" else ===================================== src/lisp/GNUmakefile ===================================== @@ -54,8 +54,6 @@ version.o : version.c version $(CC) ${CFLAGS} $(CPPFLAGS) -DVERSION=`cat version` -c $< lisp.o : lisp.c - echo GIT_HASH = ${GIT_HASH} - echo DEFAULT_VERSION = ${DEFAULT_VERSION} $(CC) ${CFLAGS} $(CPPFLAGS) -DCMUCL_VERSION="\"${DEFAULT_VERSION}\"" -c $< lisp: ${OBJS} version.o @@ -127,7 +125,8 @@ translations: rm -f /tmp/$$$$-updated-$$f.po /tmp/$$$$-orig-$$f.po; \ done; done -.PHONY : translations +# Always build lisp.o so that the embedded version is updated. +.PHONY : translations lisp.o # Like translations, but we don't compute the diff. We just overwrite # the po files in the repository so that we can tell if the View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/c16456c663e3fe6ac02831… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/c16456c663e3fe6ac02831… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-369-unix-setlocale-docstring] Update docstring some more and the pot file
by Raymond Toy (＠rtoy) 09 Jan '25

09 Jan '25

Raymond Toy pushed to branch issue-369-unix-setlocale-docstring at cmucl / cmucl Commits: 4191faa0 by Raymond Toy at 2025-01-08T19:59:09-08:00 Update docstring some more and the pot file Forgot to mention the return values which were in the original docstring. Update the pot file for the changed docstring. - - - - - 2 changed files: - src/code/unix.lisp - src/i18n/locale/cmucl-unix.pot Changes: ===================================== src/code/unix.lisp ===================================== @@ -2874,7 +2874,9 @@ (defun unix-setlocale () _N"Set all the categories of the locale from the values of the - environment variables using setlocale(LC_ALL, \"\")" + environment variables using setlocale(LC_ALL, \"\"). + + Returns 0 on success and -1 if setlocale failed." (alien:alien-funcall (alien:extern-alien "os_setlocale" (function c-call:int)))) ===================================== src/i18n/locale/cmucl-unix.pot ===================================== @@ -1418,7 +1418,11 @@ msgid "" msgstr "" #: src/code/unix.lisp -msgid "Call setlocale(3c) with fixed args. Returns 0 on success." +msgid "" +"Set all the categories of the locale from the values of the\n" +" environment variables using setlocale(LC_ALL, \"\").\n" +"\n" +" Returns 0 on success and -1 if setlocale failed." msgstr "" #: src/code/unix.lisp View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/4191faa08c887322f8fe0b1… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/4191faa08c887322f8fe0b1… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-369-unix-setlocale-docstring
by Raymond Toy (＠rtoy) 09 Jan '25

09 Jan '25

Raymond Toy pushed new branch issue-369-unix-setlocale-docstring at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-369-unix-setlocale-… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-364-add-mkstemp-mkdtemp] Use NULL-ALIEN to check if result is NULL in unix-mkdtemp
by Raymond Toy (＠rtoy) 09 Jan '25

09 Jan '25

Raymond Toy pushed to branch issue-364-add-mkstemp-mkdtemp at cmucl / cmucl Commits: f230bce9 by Raymond Toy at 2025-01-08T19:35:42-08:00 Use NULL-ALIEN to check if result is NULL in unix-mkdtemp - - - - - 1 changed file: - src/code/unix.lisp Changes: ===================================== src/code/unix.lisp ===================================== @@ -2926,6 +2926,6 @@ (function (* char) c-call:c-string)) octets))) - (if (zerop (sap-int (alien-sap result))) + (if (null-alien result) (values nil (unix-errno)) (%file->name octets)))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f230bce9c3d1f315ac8c3c9… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f230bce9c3d1f315ac8c3c9… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-363-add-version-number] Set TESTDIRARG earlier
by Raymond Toy (＠rtoy) 09 Jan '25

09 Jan '25

Raymond Toy pushed to branch issue-363-add-version-number at cmucl / cmucl Commits: c16456c6 by Raymond Toy at 2025-01-08T19:31:41-08:00 Set TESTDIRARG earlier We need to set up `TESTDIR` and `TESTDIRARG` earlier because we need `TESTDIR` to be defined to build the necessary files and to load the scripts from the right place. - - - - - 1 changed file: - bin/run-unit-tests.sh Changes: ===================================== bin/run-unit-tests.sh ===================================== @@ -49,6 +49,13 @@ function cleanup { trap cleanup EXIT +set -x +if [ -n "${TESTDIR}" ]; then + TESTDIRARG=" :test-directory \"${TESTDIR}/\"" +else + TESTDIR="tests/" + TESTDIRARG="" +fi # Compile up the C file that is used for testing alien funcalls to # functions that return integer types of different lengths. We use # gcc since clang isn't always available. @@ -56,12 +63,6 @@ trap cleanup EXIT if [ $# -eq 0 ]; then # Test directory arg for run-all-tests if a non-default - if [ -n ${TESTDIR} ]; then - TESTDIRARG=" :test-directory \"${TESTDIR}/\"" - else - TESTDIR="tests/" - TESTDIRARG="" - fi # No args so run all the tests $LISP -nositeinit -noinit -load $TESTDIR/run-tests.lisp -eval "(cmucl-test-runner:run-all-tests ${TESTDIRARG})" else View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c16456c663e3fe6ac028312… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c16456c663e3fe6ac028312… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-363-add-version-number] Install unit tests and run-unit-tests.sh
by Raymond Toy (＠rtoy) 08 Jan '25

08 Jan '25

Raymond Toy pushed to branch issue-363-add-version-number at cmucl / cmucl Commits: f9383d9c by Raymond Toy at 2025-01-08T15:15:56-08:00 Install unit tests and run-unit-tests.sh Install all of the unit-test files to share/cmucl/version/tests. Install run-unit-tests.sh to bin/run-unit-tests.sh To make this work, modify run-unit-tests to add a `-d` commandline arg that specifies the directory where the test files are located. If no `-d` flag is given, it defaults to how run-unit-tests.sh used to work, which expected the tests to in "./tests/". - - - - - 2 changed files: - bin/make-src-dist.sh - bin/run-unit-tests.sh Changes: ===================================== bin/make-src-dist.sh ===================================== @@ -58,6 +58,7 @@ echo Creating source distribution set -x GTAR_OPTIONS="--exclude=.git --exclude='*.pot.~*~'" install -d ${GROUP} ${OWNER} -m 0755 $DESTDIR/share/cmucl/$VERSION/ +install ${GROUP} ${OWNER} -m 0755 bin/run-unit-tests.sh $DESTDIR/bin ${GTAR} ${GTAR_OPTIONS} -cf - src tests | (cd $DESTDIR/share/cmucl/$VERSION; ${GTAR} xf -) if [ -z "$INSTALL_DIR" ]; then # echo " Compressing with $ZIP" ===================================== bin/run-unit-tests.sh ===================================== @@ -6,7 +6,8 @@ # then just those tests are run. usage() { - echo "run-tests.sh [?] [-l lisp] [tests]" + echo "run-tests.sh [?] [-d test-dir] [-l lisp] [tests]" + echo " -d test-dir Directory containing the unit test files" echo " -l lisp Lisp to use for the tests; defaults to lisp" echo " -? This help message" echo "" @@ -23,10 +24,11 @@ usage() { } LISP=lisp -while getopts "h?l:" arg +while getopts "h?l:d:" arg do case $arg in l) LISP=$OPTARG ;; + d) TESTDIR=$OPTARG ;; \?) usage ;; esac done @@ -50,11 +52,18 @@ trap cleanup EXIT # Compile up the C file that is used for testing alien funcalls to # functions that return integer types of different lengths. We use # gcc since clang isn't always available. -(cd tests; gcc -m32 -O3 -c test-return.c) +(cd $TESTDIR; gcc -m32 -O3 -c test-return.c) if [ $# -eq 0 ]; then + # Test directory arg for run-all-tests if a non-default + if [ -n ${TESTDIR} ]; then + TESTDIRARG=" :test-directory \"${TESTDIR}/\"" + else + TESTDIR="tests/" + TESTDIRARG="" + fi # No args so run all the tests - $LISP -nositeinit -noinit -load tests/run-tests.lisp -eval '(cmucl-test-runner:run-all-tests)' + $LISP -nositeinit -noinit -load $TESTDIR/run-tests.lisp -eval "(cmucl-test-runner:run-all-tests ${TESTDIRARG})" else # Run selected files. Convert each file name to uppercase and append "-TESTS" result="" @@ -63,6 +72,6 @@ else new=`echo $f | tr '[a-z]' '[A-Z]'` result="$result "\"$new-TESTS\" done - $LISP -nositeinit -noinit -load tests/run-tests.lisp -eval "(progn (cmucl-test-runner:load-test-files) (cmucl-test-runner:run-test $result))" + $LISP -nositeinit -noinit -load $TESTDIR/run-tests.lisp -eval "(progn (cmucl-test-runner:load-test-files) (cmucl-test-runner:run-test $result))" fi View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f9383d9c016cc88b51fd605… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f9383d9c016cc88b51fd605… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-364-add-mkstemp-mkdtemp] Remove old version of unix-mkstemp
by Raymond Toy (＠rtoy) 08 Jan '25

08 Jan '25

Raymond Toy pushed to branch issue-364-add-mkstemp-mkdtemp at cmucl / cmucl Commits: 9a9609a4 by Raymond Toy at 2025-01-08T09:34:19-08:00 Remove old version of unix-mkstemp Forgot to remove the previous version. - - - - - 1 changed file: - src/code/unix.lisp Changes: ===================================== src/code/unix.lisp ===================================== @@ -2901,32 +2901,6 @@ (function (* char)))) c-string)) -(defun unix-mkstemp (template) - _N"Generates a unique temporary file name from TEMPLATE, and creates - and opens the file. On success, the corresponding file descriptor - and name of the file is returned. - - The last six characters of the template must be \"XXXXXX\"." - ;; Hope this buffer is large enough! - (let ((octets (%name->file template))) - (unless (< (length octets) 8192) - (error "Internal buffer is too small for encoded file name of ~D octets" - (length octets))) - (with-alien ((buf (array c-call:unsigned-char 8192))) - ;; Convert the Lisp string and copy it to the alien buffer, being - ;; sure to zero-terminate the buffer. - (loop for k from 0 - for c across octets - do - (setf (deref buf k) (char-code c)) - finally (setf (deref buf k) 0)) - - (syscall ("mkstemp" (* c-call:unsigned-char)) - (values result - ;; Convert the file name back to a Lisp string. - (%file->name (cast buf c-call:c-string))) - (cast buf (* c-call:unsigned-char)))))) - (defun unix-mkstemp (template) _N"Generates a unique temporary file name from TEMPLATE, and creates and opens the file. On success, the corresponding file descriptor View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9a9609a42827ada69c2e083… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9a9609a42827ada69c2e083… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-365-add-strerror] get-unix-error-msg calls unix-strerror
by Raymond Toy (＠rtoy) 08 Jan '25

08 Jan '25

Raymond Toy pushed to branch issue-365-add-strerror at cmucl / cmucl Commits: c8e3b367 by Raymond Toy at 2025-01-08T09:21:59-08:00 get-unix-error-msg calls unix-strerror - - - - - 1 changed file: - src/code/unix.lisp Changes: ===================================== src/code/unix.lisp ===================================== @@ -2053,9 +2053,7 @@ _N"Returns a string describing the error number which was returned by a UNIX system call." (declare (type integer error-number)) - (if (array-in-bounds-p *unix-errors* error-number) - (svref *unix-errors* error-number) - (format nil _"Unknown error [~d]" error-number))) + (unix::unix-strerror error-number)) ;;;; Lisp types used by syscalls. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c8e3b367dc215677f8e4453… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c8e3b367dc215677f8e4453… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-365-add-strerror
by Raymond Toy (＠rtoy) 08 Jan '25

08 Jan '25

Raymond Toy pushed new branch issue-365-add-strerror at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-365-add-strerror You're receiving this email because of your account on gitlab.common-lisp.net.

1 0