- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][issue-399-motif-server-fedora-42] Fix extern declarations
by Raymond Toy (＠rtoy) 20 Apr '25

20 Apr '25

Raymond Toy pushed to branch issue-399-motif-server-fedora-42 at cmucl / cmucl Commits: cd4f7b84 by Raymond Toy at 2025-04-20T07:50:46-07:00 Fix extern declarations Updated extern declarations for message_write_int, message_write_translation_table, and message_write_accelerator_table. Also, in translations.c, there's the call `message_write_int(reply,event,int_tag)` where `event` is an `XEvent*`. That's not an int, so I changed it to `event->type`. Not sure if that's correct or not. - - - - - 2 changed files: - src/motif/server/datatrans.h - src/motif/server/translations.c Changes: ===================================== src/motif/server/datatrans.h ===================================== @@ -15,12 +15,12 @@ #define combine_type_and_data(type,data) ((type<<24)|data) extern void message_write_string(message_t message,String string,int type_tag); -extern void message_write_widget(); +extern void message_write_widget(message_t message,Widget widget,int type_tag); extern void message_write_widget_class(); extern void message_write_function(); extern void message_write_short(); extern void message_write_boolean(); -extern void message_write_int(); +extern void message_write_int(message_t message,int value,int type_tag); extern void message_write_xid(); extern void message_write_atom(); extern void message_write_string_token(); @@ -29,8 +29,8 @@ extern void message_write_xm_string(); extern void message_write_enum(); extern void message_write_resource_names(); extern void message_write_widget_list(); -extern void message_write_translation_table(); -extern void message_write_accelerator_table(); +extern void message_write_translation_table(message_t m,XtTranslations t,int tag); +extern void message_write_accelerator_table(message_t m,XtAccelerators a,int tag); extern void message_write_font_list(); extern void message_write_string_table(); extern void message_write_xm_string_table(); ===================================== src/motif/server/translations.c ===================================== @@ -36,7 +36,7 @@ void LispActionProc(Widget w,XEvent *event,String *params,Cardinal *num_params) message_add_packet(reply); message_put_dblword(reply,ACTION_REPLY); message_write_widget(reply,w,widget_tag); - message_write_int(reply,event,int_tag); + message_write_int(reply,event->type,int_tag); message_write_string(reply,params[0],string_tag); message_send(client_socket,reply); View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/cd4f7b84c076c525efe3fd7… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/cd4f7b84c076c525efe3fd7… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-399-motif-server-fedora-42] Fix message_write_string and toolkit_read_value
by Raymond Toy (＠rtoy) 20 Apr '25

20 Apr '25

Raymond Toy pushed to branch issue-399-motif-server-fedora-42 at cmucl / cmucl Commits: 7861f16a by Raymond Toy at 2025-04-20T07:25:54-07:00 Fix message_write_string and toolkit_read_value Accidentally used the wrong arg types for message_write_string. For toolkit_read_value, change the second arg from `char *` to `void *` because the callers pass in many different pointer types. - - - - - 2 changed files: - src/motif/server/datatrans.c - src/motif/server/datatrans.h Changes: ===================================== src/motif/server/datatrans.c ===================================== @@ -547,7 +547,7 @@ void toolkit_write_value(message_t message, caddr_t value, String type) (*write_value)(message,value,type_tag); } -void toolkit_read_value(message_t message,char *dest,String type) +void toolkit_read_value(message_t message,void *dest,String type) { int tag,data; type_reader read_value; ===================================== src/motif/server/datatrans.h ===================================== @@ -14,7 +14,7 @@ #define combine_type_and_data(type,data) ((type<<24)|data) -extern void message_write_string(message_t message,int token,int tag); +extern void message_write_string(message_t message,String string,int type_tag); extern void message_write_widget(); extern void message_write_widget_class(); extern void message_write_function(); @@ -70,6 +70,6 @@ extern void message_read_float(); extern void toolkit_write_value(); -extern void toolkit_read_value(message_t message,char *dest,String type); +extern void toolkit_read_value(message_t message,void *dest,String type); #endif View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/7861f16ae9d71d329e82339… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/7861f16ae9d71d329e82339… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-399-motif-server-fedora-42
by Raymond Toy (＠rtoy) 20 Apr '25

20 Apr '25

Raymond Toy pushed new branch issue-399-motif-server-fedora-42 at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-399-motif-server-fe… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-397-const-mult-using-lea] 2 commits: Add test for multiplication by a constant
by Raymond Toy (＠rtoy) 02 Apr '25

02 Apr '25

Raymond Toy pushed to branch issue-397-const-mult-using-lea at cmucl / cmucl Commits: 6250a035 by Raymond Toy at 2025-04-02T08:44:08-07:00 Add test for multiplication by a constant Add some tests for the optimized fixnum multiplication vops on x86. These tests are only run for x86. - - - - - e8e4d22b by Raymond Toy at 2025-04-02T08:45:13-07:00 Fix bug in multiplication by 7 Forgot to move the computed result to the result vop. This was caught by tests/arith.lisp test. Hurray for tests! - - - - - 2 changed files: - src/compiler/x86/arith.lisp - + tests/arith.lisp Changes: ===================================== src/compiler/x86/arith.lisp ===================================== @@ -295,7 +295,8 @@ ;; temp = x*8 ;; r = temp - x (inst lea ,temp (make-ea :dword :index ,x :scale 8)) - (inst sub ,temp ,x)) + (inst sub ,temp ,x) + (move ,r ,temp)) ((= ,y 9) ;; r = x + x*8 (inst lea ,r (make-ea :dword :base ,x :index ,x :scale 8))) ===================================== tests/arith.lisp ===================================== @@ -0,0 +1,46 @@ +;; Test x86 multiplication by small constants + +(defpackage :arith-tests + (:use :cl :lisp-unit)) + +(in-package "ARITH-TESTS") + +#+x86 +(macrolet + ((frob (c arg expected) + (let ((test-name-fixnum (intern (format nil "X86-TEST-CONST-MUL-FIXNUM-~D" c)))) + `(define-test ,test-name-fixnum + (:tag :x86-arith) + (assert-eql ,expected + (funcall (compile nil #'(lambda (x) + (declare (type (signed-byte 24) x)) + (* x ,c))) + ,arg)))))) + ;; This is a test of #397. Test that the multiplication by small + ;; constants is correct for each of the constants defined for the + ;; fixnum-*-c/fixnum=>fixnum vop. + + (frob 2 10 20) + (frob 2 -10 -20) + (frob 3 10 30) + (frob 3 -10 -30) + (frob 4 10 40) + (frob 4 -10 -40) + (frob 5 10 50) + (frob 5 -10 -50) + (frob 6 10 60) + (frob 6 -10 -60) + (frob 7 10 70) + (frob 7 -10 -70) + (frob 8 10 80) + (frob 8 -10 -80) + (frob 9 10 90) + (frob 9 -10 -90) + (frob 10 10 100) + (frob 10 -10 -100) + (frob 11 10 110) + (frob 11 -10 -110) + (frob 12 10 120) + (frob 12 -10 -120) + (frob 13 10 130) + (frob 13 -10 -130)) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/a051c7a9a168382a073dbe… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/a051c7a9a168382a073dbe… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-397-const-mult-using-lea
by Raymond Toy (＠rtoy) 02 Apr '25

02 Apr '25

Raymond Toy pushed new branch issue-397-const-mult-using-lea at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-397-const-mult-usin… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-394-getcwd-retry-buffer-size] Remove old code and add docstring; update cmucl-unix.pot
by Raymond Toy (＠rtoy) 31 Mar '25

31 Mar '25

Raymond Toy pushed to branch issue-394-getcwd-retry-buffer-size at cmucl / cmucl Commits: cee8ce72 by Raymond Toy at 2025-03-31T14:40:40-07:00 Remove old code and add docstring; update cmucl-unix.pot Remove the old version of `unix-current-directory` and add a docstring for it as well. This means cmucl-unix.pot needs to be updated. - - - - - 3 changed files: - src/code/unix.lisp - src/i18n/locale/cmucl-unix.pot - src/i18n/locale/cmucl.pot Changes: ===================================== src/code/unix.lisp ===================================== @@ -370,26 +370,10 @@ nil) -;; Use getcwd instead of getwd. But what should we do if the path -;; won't fit? Try again with a larger size? We don't do that right -;; now. -#+nil -(defun unix-current-directory () - ;; 5120 is some randomly selected maximum size for the buffer for getcwd. - (with-alien ((buf (array c-call:char 5120))) - (let ((result - (alien-funcall - (extern-alien "getcwd" - (function (* c-call:char) - (* c-call:char) c-call:int)) - (cast buf (* c-call:char)) - 5120))) - - (values (not (zerop - (sap-int (alien-sap result)))) - (%file->name (cast buf c-call:c-string)))))) - (defun unix-current-directory () + "Get the current working directory. If the directory could be + determined, T and the directory name as a string are returned. + Otherwise, both values are NIL." (let (result) (unwind-protect (progn ===================================== src/i18n/locale/cmucl-unix.pot ===================================== @@ -28,6 +28,13 @@ msgstr "" msgid "Syscall ~A failed: ~A" msgstr "" +#: src/code/unix.lisp +msgid "" +"Get the current working directory. If the directory could be\n" +" determined, T and the directory name as a string are returned.\n" +" Otherwise, both values are NIL." +msgstr "" + #: src/code/unix.lisp msgid "Test for read permission" msgstr "" ===================================== src/i18n/locale/cmucl.pot ===================================== @@ -9667,6 +9667,15 @@ msgid "" " an otherwise undefined logical host." msgstr "" +#: src/code/pathname.lisp +msgid "" +"When non-NIL, pathnames are on Darwin are normalized when created.\n" +" Otherwise, the pathnames are unchanged.\n" +"\n" +" This must be NIL during bootstrapping because Unicode is not yet\n" +" available." +msgstr "" + #: src/code/pathname.lisp msgid "A path specification, either a string, file-stream or pathname." msgstr "" View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/cee8ce72ba333510f7b6d35… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/cee8ce72ba333510f7b6d35… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Update cmucl.pot
by Raymond Toy (＠rtoy) 31 Mar '25

31 Mar '25

Raymond Toy pushed to branch master at cmucl / cmucl Commits: e90fa5af by Raymond Toy at 2025-03-30T20:10:38-07:00 Update cmucl.pot This was updated in !280 landed and I forgot to update it there, so we're doing it now. - - - - - 1 changed file: - src/i18n/locale/cmucl.pot Changes: ===================================== src/i18n/locale/cmucl.pot ===================================== @@ -9667,6 +9667,15 @@ msgid "" " an otherwise undefined logical host." msgstr "" +#: src/code/pathname.lisp +msgid "" +"When non-NIL, pathnames are on Darwin are normalized when created.\n" +" Otherwise, the pathnames are unchanged.\n" +"\n" +" This must be NIL during bootstrapping because Unicode is not yet\n" +" available." +msgstr "" + #: src/code/pathname.lisp msgid "A path specification, either a string, file-stream or pathname." msgstr "" View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/e90fa5af893e3d5842b5064… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/e90fa5af893e3d5842b5064… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-394-getcwd-retry-buffer-size
by Raymond Toy (＠rtoy) 31 Mar '25

31 Mar '25

Raymond Toy pushed new branch issue-394-getcwd-retry-buffer-size at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-394-getcwd-retry-bu… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Address #381: Handle OS-specific docstring in pathname.lisp
by Raymond Toy (＠rtoy) 30 Mar '25

30 Mar '25

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 7e2d05db by Raymond Toy at 2025-03-30T21:16:32+00:00 Address #381: Handle OS-specific docstring in pathname.lisp - - - - - fea9f546 by Raymond Toy at 2025-03-30T21:16:32+00:00 Merge branch 'issue-381-darwin-pathname-docstring' into 'master' Address #381: Handle OS-specific docstring in pathname.lisp See merge request cmucl/cmucl!280 - - - - - 1 changed file: - src/code/pathname.lisp Changes: ===================================== src/code/pathname.lisp ===================================== @@ -269,7 +269,7 @@ #+darwin (defvar *enable-darwin-path-normalization* nil - "When non-NIL, pathnames are on Darwin are normalized when created. + _N"When non-NIL, pathnames are on Darwin are normalized when created. Otherwise, the pathnames are unchanged. This must be NIL during bootstrapping because Unicode is not yet View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/7aaca65e2cfbd1f36be145… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/7aaca65e2cfbd1f36be145… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-393-os-common-getpwuid] Fix errors introduced in renaming os-unix-info
by Raymond Toy (＠rtoy) 30 Mar '25

30 Mar '25

Raymond Toy pushed to branch issue-393-os-common-getpwuid at cmucl / cmucl Commits: 52a47a38 by Raymond Toy at 2025-03-30T08:31:56-07:00 Fix errors introduced in renaming os-unix-info We renamed `struct passwd` to `os-unix-info` in a previous commit, but we didn't update the use of `struct passwd` in `unix-getpwuid`. Fix this by first rename `os-unix-info` to `os-user-info` to match the name of the C struct. And update `unix-getpwuid` to use `os-user-info` instead of `passwd`. - - - - - 1 changed file: - src/code/unix.lisp Changes: ===================================== src/code/unix.lisp ===================================== @@ -2419,7 +2419,7 @@ ;; The C structure that is returned by os_getpwuid containing the info ;; that we use to fill the user-info object. (def-alien-type nil - (struct os-unix-info + (struct os-user-info (pw-name (* char)) ; user's login name (pw-passwd (* char)) ; no longer used (pw-uid uid-t) ; user id @@ -2535,7 +2535,7 @@ of the failure. In particular, if the second value is 0 (or ENONENT, ESRCH, EBADF, etc.), then the uid was not found." (declare (type unix-uid uid)) - (with-alien ((result (* (struct passwd)))) + (with-alien ((result (* (struct os-user-info)))) (let (result) (unwind-protect (progn @@ -2547,7 +2547,7 @@ (declare (optimize (ext:inhibit-warnings 3))) (alien-funcall (extern-alien "os_getpwuid" - (function (* (struct passwd)) + (function (* (struct os-user-info)) uid-t)) uid))) (if (null-alien result) @@ -2573,7 +2573,7 @@ (alien-funcall (extern-alien "os_free_getpwuid" (function c-call:void - (* (struct passwd)))) + (* (struct os-user-info)))) result)))))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/52a47a381d3a84be6ea4fa2… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/52a47a381d3a84be6ea4fa2… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0