- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][master] 2 commits: Fix the retry limit for resizing password entry buffer
by Carl Shapiro (＠cshapiro) 25 Apr '24

25 Apr '24

Carl Shapiro pushed to branch master at cmucl / cmucl Commits: 06958230 by Carl Shapiro at 2024-04-25T12:45:59-07:00 Fix the retry limit for resizing password entry buffer The previous version checked that the buffer had not exceeded the limit of 1MiB after the buffer was resized. In otherwords, the buffer is allowed to grow past the limit before the retry loop is exited. This change moves the check of the buffer size before the allocation occurs. Now, the retry loop is exited before the buffer would grow past the limit. - - - - - 520213dd by Carl Shapiro at 2024-04-26T02:00:30+00:00 Merge branch 'retry-limit' into 'master' Fix the retry limit for resizing password entry buffer See merge request cmucl/cmucl!212 - - - - - 1 changed file: - src/lisp/os-common.c Changes: ===================================== src/lisp/os-common.c ===================================== @@ -753,26 +753,27 @@ os_file_author(const char *path) * Keep trying with larger buffers until a maximum is reached. We * assume (1 << 20) is large enough for any OS. */ - while (size <= (1 << 20)) { - switch (getpwuid_r(sb.st_uid, &pwd, buffer, size, &ppwd)) { - case 0: - /* Success, though we might not have a matching entry */ - result = (ppwd == NULL) ? NULL : strdup(pwd.pw_name); - goto exit; - case ERANGE: - /* Buffer is too small, double its size and try again */ - size *= 2; - if ((buffer = realloc(obuffer, size)) == NULL) { - goto exit; - } - obuffer = buffer; - continue; - default: - /* All other errors */ - goto exit; - } +again: + switch (getpwuid_r(sb.st_uid, &pwd, buffer, size, &ppwd)) { + case 0: + /* Success, though we might not have a matching entry */ + result = (ppwd == NULL) ? NULL : strdup(pwd.pw_name); + break; + case ERANGE: + /* Buffer is too small, double its size and try again */ + size *= 2; + if (size > (1 << 20)) { + break; + } + if ((buffer = realloc(obuffer, size)) == NULL) { + break; + } + obuffer = buffer; + goto again; + default: + /* All other errors */ + break; } -exit: free(obuffer); return result; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/99abb703b68b67143b6a77… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/99abb703b68b67143b6a77… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix an incorrect error check detected by the GCC analyzer
by Carl Shapiro (＠cshapiro) 25 Apr '24

25 Apr '24

Carl Shapiro pushed to branch master at cmucl / cmucl Commits: 57c9f9b7 by Carl Shapiro at 2024-04-25T12:30:13-07:00 Fix an incorrect error check detected by the GCC analyzer The return value of open(2) should be compared with -1 to check for an error but it was compared with 0 instead. - - - - - 99abb703 by Carl Shapiro at 2024-04-26T01:53:53+00:00 Merge branch 'open-error' into 'master' Fix an incorrect error check detected by the GCC analyzer See merge request cmucl/cmucl!211 - - - - - 1 changed file: - src/lisp/elf.c Changes: ===================================== src/lisp/elf.c ===================================== @@ -442,7 +442,7 @@ map_core_sections(const char *exec_name) image_static_space_size, image_read_only_space_size; - if (!(exec_fd = open(exec_name, O_RDONLY))) { + if ((exec_fd = open(exec_name, O_RDONLY)) == -1) { perror("Can't open executable!"); exit(-1); } View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/7c91087e17dd1145e04843… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/7c91087e17dd1145e04843… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix a double free detected by the GCC analyzer
by Carl Shapiro (＠cshapiro) 25 Apr '24

25 Apr '24

Carl Shapiro pushed to branch master at cmucl / cmucl Commits: 729fae26 by Carl Shapiro at 2024-04-25T01:15:17-07:00 Fix a double free detected by the GCC analyzer The obuffer variable contained a pointer to a block of memory freed by realloc(3) if the ERANGE case was executed more than once. Afterward, if the 0 case executed, obuffer would be passed to free(3) causing a double free. This change sets the value of obuffer to buffer immediately after a successful call to realloc(3) ensure it is always NULL or a valid block of memory. - - - - - 7c91087e by Carl Shapiro at 2024-04-25T16:37:26+00:00 Merge branch 'file-author' into 'master' Fix a double free detected by the GCC analyzer See merge request cmucl/cmucl!210 - - - - - 1 changed file: - src/lisp/os-common.c Changes: ===================================== src/lisp/os-common.c ===================================== @@ -762,10 +762,10 @@ os_file_author(const char *path) case ERANGE: /* Buffer is too small, double its size and try again */ size *= 2; - obuffer = (buffer == initial) ? NULL : buffer; if ((buffer = realloc(obuffer, size)) == NULL) { goto exit; } + obuffer = buffer; continue; default: /* All other errors */ View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/8de3c927c724813022110b… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/8de3c927c724813022110b… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #303: Remove unused var *assert-not-standard-readtable*
by Raymond Toy (＠rtoy) 22 Apr '24

22 Apr '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: b040810c by Raymond Toy at 2024-04-22T13:57:52+00:00 Fix #303: Remove unused var *assert-not-standard-readtable* - - - - - 8de3c927 by Raymond Toy at 2024-04-22T13:57:57+00:00 Merge branch 'issue-303-remove-unused-assert-not-standard-readtable' into 'master' Fix #303: Remove unused var *assert-not-standard-readtable* Closes #303 See merge request cmucl/cmucl!209 - - - - - 1 changed file: - src/code/reader.lisp Changes: ===================================== src/code/reader.lisp ===================================== @@ -620,8 +620,7 @@ ;; Of course, we want to be able to modify the standard ;; readtable here! (invoke-restart 'kernel::continue)))) - (let ((*readtable* std-lisp-readtable) - (*assert-not-standard-readtable* nil)) + (let ((*readtable* std-lisp-readtable)) (set-cat-entry #\tab #.whitespace) (set-cat-entry #\linefeed #.whitespace) (set-cat-entry #\space #.whitespace) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/1abdcb329d945247acc210… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/1abdcb329d945247acc210… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-303-remove-unused-assert-not-standard-readtable
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy pushed new branch issue-303-remove-unused-assert-not-standard-readtable at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-303-remove-unused-a… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Use snapshot-2024-04 to run the CI
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 83df8fec by Raymond Toy at 2024-04-19T12:01:18-07:00 Use snapshot-2024-04 to run the CI Snapshots have been uploaded so use them for running the CI. - - - - - 1abdcb32 by Raymond Toy at 2024-04-19T15:08:49-07:00 Remove // comment According to [fc0bd2a6f0] this change was supposed to be removed but never was. Let's do it now. This was also the only place where we used C++ comment-style. - - - - - 2 changed files: - .gitlab-ci.yml - src/lisp/gencgc.c Changes: ===================================== .gitlab-ci.yml ===================================== @@ -1,6 +1,6 @@ variables: - download_url: "https://common-lisp.net/project/cmucl/downloads/snapshots/2023/08" - version: "xoroshiro-assembly-x86" + download_url: "https://common-lisp.net/project/cmucl/downloads/snapshots/2024/04" + version: "2024-04-x86" bootstrap: "" ===================================== src/lisp/gencgc.c ===================================== @@ -4325,7 +4325,7 @@ u32_vector(lispobj obj, unsigned *length) static inline void free_hash_entry(struct hash_table *hash_table, int hash_index, int kv_index) { - unsigned length = UINT_MAX; // to compare to + unsigned length = UINT_MAX; unsigned *index_vector = u32_vector(hash_table->index_vector, &length); unsigned *next_vector = u32_vector(hash_table->next_vector, 0); int free_p = 1; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/a33e75aed5ec46cd2ec116… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/a33e75aed5ec46cd2ec116… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new tag snapshot-2024-04
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy pushed new tag snapshot-2024-04 at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/snapshot-2024-04 You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Deleted tag snapshot-2024-04
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy deleted tag snapshot-2024-04 at cmucl / cmucl -- You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Update with fixed tickets that we forgot to add earlier.
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: a33e75ae by Raymond Toy at 2024-04-19T07:36:31-07:00 Update with fixed tickets that we forgot to add earlier. - - - - - 1 changed file: - src/general-info/release-21f.md Changes: ===================================== src/general-info/release-21f.md ===================================== @@ -30,14 +30,17 @@ public domain. * ANSI compliance fixes: * Bug fixes: * Gitlab tickets: + * * ~~#154~~ piglatin translation does not work anymore - * ~~#171~~ Readably print `(make-pathname :name :unspecfic)` + * ~~#171~~ Readably print `(make-pathname :name :unspecfic)` + * ~~#180~~ Move `get-page-size` to C * ~~#196~~ Fix issues with mapping and nconc accumulation (mapcan) * ~~#216~~ `enough-namestring` with relative pathname fails * ~~#234~~ Make :ASCII external format builtin * ~~#240~~ Speed up set operations * ~~#242~~ Fix bug in `alien-funcall` with `c-call:char` as result type * ~~#244~~ Add `c-call:signed-char` + * ~~#245~~ Replace `egrep` with `grep -E` in `make-dist.sh` * ~~#248~~ Print MOVS instruction with correct case * ~~#249~~ Replace LEA instruction with simpler shorter instructions in arithmetic vops for x86 * ~~#253~~ Block-compile list-to-hashtable and callers @@ -53,6 +56,7 @@ public domain. * ~~#265~~ CI for mac os is broken * ~~#266~~ Support "~user" in namestrings * ~~#269~~ Add function to get user's home directory + * ~~#270~~ Simplify `os_file_author` interface * ~~#271~~ Update ASDF to 3.3.7 * ~~#272~~ Move scavenge code for static vectors to its own function * ~~#274~~ 1d99999999 hangs @@ -67,7 +71,11 @@ public domain. * ~~#290~~ Pprint `with-float-traps-masked` better * ~~#291~~ Pprint `handler-case` neatly. * ~~#293~~ Allow restarts for FP overflow in reader. + * ~~#294~~ Implement assembly routine for xoroshiro update function + * ~~#296~~ Disassembly of movd instruction broken * ~~#297~~ Pprint `new-assem:assemble` with less indentation. + * ~~#298~~ Add `with-float-rounding-mode` macro + * ~~#299~~ Enable xoroshiro assembly routine * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a33e75aed5ec46cd2ec116c… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a33e75aed5ec46cd2ec116c… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new tag snapshot-2024-04
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy pushed new tag snapshot-2024-04 at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/snapshot-2024-04 You're receiving this email because of your account on gitlab.common-lisp.net.

1 0