- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][issue-269-unix-get-user-homedir] Fix typos in test.
by Raymond Toy (＠rtoy) 17 Nov '23

17 Nov '23

Raymond Toy pushed to branch issue-269-unix-get-user-homedir at cmucl / cmucl Commits: 6066da35 by Raymond Toy at 2023-11-17T09:10:44-08:00 Fix typos in test. It should be `LET*` instead of `LET` and it's `info-name` instead of `user-name`. - - - - - 1 changed file: - tests/os.lisp Changes: ===================================== tests/os.lisp ===================================== @@ -13,11 +13,11 @@ (user-info (unix:unix-getpwuid uid))) (assert-true uid) (assert-true user-info) - (let ((info-dir (unix:user-info-dir user-info)) - (info-name (unix:user-info-name user-info)) - (expected-home-pathname (pathname - (concatenate 'string info-dir "/"))) - (home-pathname (unix:unix-get-user-homedir user-name))) + (let* ((info-dir (unix:user-info-dir user-info)) + (info-name (unix:user-info-name user-info)) + (expected-home-pathname (pathname + (concatenate 'string info-dir "/"))) + (home-pathname (unix:unix-get-user-homedir info-name))) (assert-true info-dir) (assert-true info-name) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6066da35b2229646412b5be… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6066da35b2229646412b5be… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-269-unix-get-user-homedir] Rewrite test to use getuid/getpwuid to get expected values.
by Raymond Toy (＠rtoy) 17 Nov '23

17 Nov '23

Raymond Toy pushed to branch issue-269-unix-get-user-homedir at cmucl / cmucl Commits: 16eae5a2 by Raymond Toy at 2023-11-17T08:59:30-08:00 Rewrite test to use getuid/getpwuid to get expected values. The envvar `USERNAME` isn't defined when running CI, so we can't use that. Use getuid and getpwuid to get the user name and home directory to use with `unix-get-user-homedir`. - - - - - 1 changed file: - tests/os.lisp Changes: ===================================== tests/os.lisp ===================================== @@ -7,15 +7,18 @@ "Test user-homedir" (:tag :issues) ;; Simple test to see if unix-get-user-homedir returns the expected - ;; value. We assume the envvar USERNAME and HOME exist and are - ;; correctly set up for the user running this test. - (let ((user-name (unix:unix-getenv "USERNAME"))) - (assert-true user-name) - (when user-name - (let ((expected-homedir (pathname - (concatenate 'string - (unix:unix-getenv "HOME") - "/"))) - (homedir (unix:unix-get-user-homedir user-name))) - (assert-true expected-homedir) - (assert-equal homedir expected-homedir))))) + ;; value. Use getuid and getpwuid to figure out what the name and + ;; home directory should be. + (let* ((uid (unix:unix-getuid)) + (user-info (unix:unix-getpwuid uid))) + (assert-true uid) + (assert-true user-info) + (let ((info-dir (unix:user-info-dir user-info)) + (info-name (unix:user-info-name user-info)) + (expected-home-pathname (pathname + (concatenate 'string info-dir "/"))) + (home-pathname (unix:unix-get-user-homedir user-name))) + (assert-true info-dir) + (assert-true info-name) + + (assert-equal home-pathname expected-home-pathname)))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/16eae5a214dbdb92c6ba1e7… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/16eae5a214dbdb92c6ba1e7… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-269-unix-get-user-homedir] Debugging: printenv to see what envvars are avaliabie during CI
by Raymond Toy (＠rtoy) 17 Nov '23

17 Nov '23

Raymond Toy pushed to branch issue-269-unix-get-user-homedir at cmucl / cmucl Commits: 2ec0a02c by Raymond Toy at 2023-11-17T08:14:24-08:00 Debugging: printenv to see what envvars are avaliabie during CI - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -62,6 +62,7 @@ linux:test: - job: linux:build artifacts: true script: + - printenv - bin/run-unit-tests.sh -l dist/bin/lisp 2>&1 | tee test.log linux:ansi-test: @@ -146,6 +147,7 @@ osx:test: artifacts: true script: - echo LANG = $LANG + - printenv - bin/run-unit-tests.sh -l dist/bin/lisp 2>&1 | tee test.log osx:ansi-test: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/2ec0a02c060153335a88bb9… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/2ec0a02c060153335a88bb9… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-269-unix-get-user-homedir] 3 commits: Fix #265: Broken CI on Mac OS X
by Raymond Toy (＠rtoy) 17 Nov '23

17 Nov '23

Raymond Toy pushed to branch issue-269-unix-get-user-homedir at cmucl / cmucl Commits: 24fd8012 by Raymond Toy at 2023-11-14T23:44:10+00:00 Fix #265: Broken CI on Mac OS X - - - - - cdaa5def by Raymond Toy at 2023-11-14T23:44:44+00:00 Merge branch 'issue-265-ci-broken-on-mac-os' into 'master' Fix #265: Broken CI on Mac OS X Closes #265 See merge request cmucl/cmucl!176 - - - - - f2c62f43 by Raymond Toy at 2023-11-16T18:44:11-08:00 Merge branch 'master' into issue-269-unix-get-user-homedir - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -127,8 +127,9 @@ osx:build: #- bin/create-target.sh xtarget x86_darwin #- bin/create-target.sh xcross x86_darwin #- bin/cross-build-world.sh -crl -B boot-2020-04-1 xtarget xcross src/tools/cross-scripts/cross-x86-x86.lisp snapshot/bin/lisp - # Regular build using the cross-compiled result or snapshot - - bin/build.sh $bootstrap -R -C "" -o snapshot/bin/lisp + # Regular build using the cross-compiled result or snapshot. + # Need /opt/local/bin to get msgmerge and msgfmt programs. + - PATH=/opt/local/bin:$PATH bin/build.sh $bootstrap -R -C "" -o snapshot/bin/lisp - bin/make-dist.sh -I dist darwin-4 osx:test: @@ -137,12 +138,14 @@ osx:test: - osx artifacts: paths: + - ansi-test/test.out - test.log needs: # Needs artifacts from build (dist/) - job: osx:build artifacts: true script: + - echo LANG = $LANG - bin/run-unit-tests.sh -l dist/bin/lisp 2>&1 | tee test.log osx:ansi-test: @@ -157,6 +160,9 @@ osx:ansi-test: - job: osx:build artifacts: true script: + # NB: sometimes we can't clone the ansi-test repo (bad cert!?!). + # Manually cloning it in the gitlab build dir helps with this + # issue until we can figure out what's going on. - bin/run-ansi-tests.sh -l dist/bin/lisp osx:benchmark: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/f642b12f9beaf179e93acb… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/f642b12f9beaf179e93acb… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-269-unix-get-user-homedir] Add simple test for unix:unix-get-user-homedir
by Raymond Toy (＠rtoy) 17 Nov '23

17 Nov '23

Raymond Toy pushed to branch issue-269-unix-get-user-homedir at cmucl / cmucl Commits: f642b12f by Raymond Toy at 2023-11-16T18:31:59-08:00 Add simple test for unix:unix-get-user-homedir - - - - - 1 changed file: - + tests/os.lisp Changes: ===================================== tests/os.lisp ===================================== @@ -0,0 +1,21 @@ +(defpackage :os-tests + (:use :cl :lisp-unit)) + +(in-package "OS-TESTS") + +(define-test user-homedir + "Test user-homedir" + (:tag :issues) + ;; Simple test to see if unix-get-user-homedir returns the expected + ;; value. We assume the envvar USERNAME and HOME exist and are + ;; correctly set up for the user running this test. + (let ((user-name (unix:unix-getenv "USERNAME"))) + (assert-true user-name) + (when user-name + (let ((expected-homedir (pathname + (concatenate 'string + (unix:unix-getenv "HOME") + "/"))) + (homedir (unix:unix-get-user-homedir user-name))) + (assert-true expected-homedir) + (assert-equal homedir expected-homedir))))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f642b12f9beaf179e93acb5… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f642b12f9beaf179e93acb5… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-269-unix-get-user-homedir
by Raymond Toy (＠rtoy) 17 Nov '23

17 Nov '23

Raymond Toy pushed new branch issue-269-unix-get-user-homedir at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-269-unix-get-user-h… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-265-ci-broken-on-mac-os] Clean up unneeded script and add comment
by Raymond Toy (＠rtoy) 14 Nov '23

14 Nov '23

Raymond Toy pushed to branch issue-265-ci-broken-on-mac-os at cmucl / cmucl Commits: 6e9732d5 by Raymond Toy at 2023-11-14T14:10:46-08:00 Clean up unneeded script and add comment Don't need the ls commands anymore. Add comment about ansi-test failures because we can't clone the ansi-test repo. Provide a work-around for that issue for now. - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -131,7 +131,6 @@ osx:build: # Need /opt/local/bin to get msgmerge and msgfmt programs. - PATH=/opt/local/bin:$PATH bin/build.sh $bootstrap -R -C "" -o snapshot/bin/lisp - bin/make-dist.sh -I dist darwin-4 - - ls dist/lib/cmucl/lib/locale/en\@piglatin/LC_MESSAGES osx:test: stage: test @@ -147,7 +146,6 @@ osx:test: artifacts: true script: - echo LANG = $LANG - - ls dist/lib/cmucl/lib/locale/en\@piglatin/LC_MESSAGES - bin/run-unit-tests.sh -l dist/bin/lisp 2>&1 | tee test.log osx:ansi-test: @@ -162,6 +160,9 @@ osx:ansi-test: - job: osx:build artifacts: true script: + # NB: sometimes we can't clone the ansi-test repo (bad cert!?!). + # Manually cloning it in the gitlab build dir helps with this + # issue until we can figure out what's going on. - bin/run-ansi-tests.sh -l dist/bin/lisp osx:benchmark: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6e9732d5dd669a309fcf6e3… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6e9732d5dd669a309fcf6e3… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-265-ci-broken-on-mac-os] Add /opt/local/bin to PATH to find msgmerge and msgfmt
by Raymond Toy (＠rtoy) 14 Nov '23

14 Nov '23

Raymond Toy pushed to branch issue-265-ci-broken-on-mac-os at cmucl / cmucl Commits: c6815acf by Raymond Toy at 2023-11-14T11:13:29-08:00 Add /opt/local/bin to PATH to find msgmerge and msgfmt - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -127,8 +127,9 @@ osx:build: #- bin/create-target.sh xtarget x86_darwin #- bin/create-target.sh xcross x86_darwin #- bin/cross-build-world.sh -crl -B boot-2020-04-1 xtarget xcross src/tools/cross-scripts/cross-x86-x86.lisp snapshot/bin/lisp - # Regular build using the cross-compiled result or snapshot - - bin/build.sh $bootstrap -R -C "" -o snapshot/bin/lisp + # Regular build using the cross-compiled result or snapshot. + # Need /opt/local/bin to get msgmerge and msgfmt programs. + - PATH=/opt/local/bin:$PATH bin/build.sh $bootstrap -R -C "" -o snapshot/bin/lisp - bin/make-dist.sh -I dist darwin-4 - ls dist/lib/cmucl/lib/locale/en\@piglatin/LC_MESSAGES View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c6815acf59127336ff979bf… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c6815acf59127336ff979bf… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-265-ci-broken-on-mac-os] Debugging: print out directory contents after make-dist
by Raymond Toy (＠rtoy) 14 Nov '23

14 Nov '23

Raymond Toy pushed to branch issue-265-ci-broken-on-mac-os at cmucl / cmucl Commits: 82a16bc8 by Raymond Toy at 2023-11-14T11:02:37-08:00 Debugging: print out directory contents after make-dist Does en@piglatin/LC_MESSAGES have the expected contents? - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -130,6 +130,7 @@ osx:build: # Regular build using the cross-compiled result or snapshot - bin/build.sh $bootstrap -R -C "" -o snapshot/bin/lisp - bin/make-dist.sh -I dist darwin-4 + - ls dist/lib/cmucl/lib/locale/en\@piglatin/LC_MESSAGES osx:test: stage: test @@ -137,6 +138,7 @@ osx:test: - osx artifacts: paths: + - ansi-test/test.out - test.log needs: # Needs artifacts from build (dist/) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/82a16bc8579cf1418f6e4ca… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/82a16bc8579cf1418f6e4ca… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-265-ci-broken-on-mac-os] Debugging: print out directory contents
by Raymond Toy (＠rtoy) 14 Nov '23

14 Nov '23

Raymond Toy pushed to branch issue-265-ci-broken-on-mac-os at cmucl / cmucl Commits: 280d13c2 by Raymond Toy at 2023-11-14T10:14:26-08:00 Debugging: print out directory contents Does en@piglatin/LC_MESSAGES have the expected contents? - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -144,6 +144,7 @@ osx:test: artifacts: true script: - echo LANG = $LANG + - ls dist/lib/cmucl/lib/locale/en\@piglatin/LC_MESSAGES - bin/run-unit-tests.sh -l dist/bin/lisp 2>&1 | tee test.log osx:ansi-test: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/280d13c2a337abe43c516ba… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/280d13c2a337abe43c516ba… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0