GitLab

at 2023-06-16T07:07:11-07:00

Add original C test from the bug report.

Add tests for this as well from the original bug report and an
additional test that uses alien:boolean as the return type.

 		 (- n #x100)

 		 n))))

     (dolist (x '(99 -99 1023 -1023))

-      (assert-equal (sign-extend x) (fun x)))))

+      (assert-equal (sign-extend x) (fun x) x))))

 (define-test issue.242.test-alien-return-signed-short

   (:tag :issues)

 		 (- n #x10000)

 		 n))))

     (dolist (x '(1023 -1023 100000 -100000))

-      (assert-equal (sign-extend x) (fun x)))))

+      (assert-equal (sign-extend x) (fun x) x))))

 (define-test issue.242.test-alien-return-signed-int

   (:tag :issues)

 				(function c-call:int c-call:int))

 	    n)))

     (dolist (x '(1023 -1023 #x7fffffff #x-80000000))

-      (assert-equal x (fun x)))))

+      (assert-equal x (fun x) x))))

 (define-test issue.242.test-alien-return-unsigned-char

   (:tag :issues)

 	 (expected (n)

 	   (ldb (byte 8 0) n)))

     (dolist (x '(99 -99 1023 -1023))

-      (assert-equal (expected x) (fun x)))))

+      (assert-equal (expected x) (fun x) x))))

 (define-test issue.242.test-alien-return-unsigned-short

   (:tag :issues)

 	 (expected (n)

 	   (ldb (byte 16 0) n)))

     (dolist (x '(1023 -1023 100000 -100000))

-      (assert-equal (expected x) (fun x)))))

+      (assert-equal (expected x) (fun x) x))))

 (define-test issue.242.test-alien-return-unsigned-int

   (:tag :issues)

 	 (expected (n)

 	   (ldb (byte 32 0) n)))

     (dolist (x '(1023 -1023 #x7fffffff #x-80000000))

-      (assert-equal (expected x) (fun x)))))
+      (assert-equal (expected x) (fun x) x))))

+

+(define-test issue.242.test-alien-return-bool

+  (:tag :issues)

+  (flet ((fun (n)

+	   (alien:alien-funcall

+	    (alien:extern-alien "unsigned_to_bool"

+				(function c-call:char c-call:unsigned-int))

+	    n))

+	 (expected (n)

+	   (if (zerop n)

+	       0

+	       1)))

+    (dolist (x '(0 1 1000))

+      (assert-equal (expected x) (fun x) x))))

+

+(define-test issue.242.test-alien-return-bool.2

+  (:tag :issues)

+  (flet ((fun (n)

+	   (alien:alien-funcall

+	    (alien:extern-alien "unsigned_to_bool"

+				(function alien:boolean c-call:unsigned-int))

+	    n))

+	 (expected (n)

+	   (not (zerop n))))

+    (dolist (x '(0 1 1000))

+      (assert-equal (expected x) (fun x) x))))
+#include <stdbool.h>

+

 signed char

 int_to_signed_char(int x)

 {

 unsigned char

 int_to_unsigned_char(int x)

 {

-  return (signed char) x;

+  return (unsigned char) x;

 }

 unsigned short

 int_to_unsigned_short(int x)

 {

-  return (signed short) x;

+  return (unsigned short) x;

 }

 unsigned int

 int_to_unsigned_int(int x)

 {

-  return (int) x;

+  return (unsigned int) x;

+}

+

+_Bool unsigned_to_bool(unsigned u)

+{

+  return (_Bool) u;

 }

	1	+#include <stdbool.h>
	2	+
1	3	signed char
2	4	int_to_signed_char(int x)
3	5	{
...	...	@@ -19,18 +21,23 @@ int_to_int(int x)
19	21	unsigned char
20	22	int_to_unsigned_char(int x)
21	23	{
22		- return (signed char) x;
	24	+ return (unsigned char) x;
23	25	}
24	26
25	27	unsigned short
26	28	int_to_unsigned_short(int x)
27	29	{
28		- return (signed short) x;
	30	+ return (unsigned short) x;
29	31	}
30	32
31	33	unsigned int
32	34	int_to_unsigned_int(int x)
33	35	{
34		- return (int) x;
	36	+ return (unsigned int) x;
	37	+}
	38	+
	39	+_Bool unsigned_to_bool(unsigned u)
	40	+{
	41	+ return (_Bool) u;
35	42	}
36	43

Raymond Toy pushed to branch issue-242-c-call-char-result-wrong at cmucl / cmucl

Commits:

2 changed files:

Changes: