GitLab

at 2018-09-16T23:29:06Z

Fix typo in declaration for verify-generations

Assert rehash threshold is in (0,1]

Not 100% sure, but I think 0.1 is too large in some cases.  Possibly
if GC happens after allocating a hash table but before it's
initialized.

Maybe we should prevent GC from happening before we've initialized
some of the slots of the hash table?

 "

     (declare (type (and fixnum unsigned-byte) assert-level)

 	     (type boolean verify-after-free-heap)

-	     (type (integer 0 6) verify-generation)

+	     (type (integer 0 6) verify-generations)

 	     (type boolean verify-new-objects))

     (when assert-level-p

       (setf gc-assert-level assert-level))

     if (gc_assert_level > 0) {

         /*

          * Check to see that hash-table-rehash-threshold is a single

-         * float in the range [0.1, 1]

+         * float in the range (0, 1]

          */

         lispobj threshold_obj = (lispobj) hash_table->rehash_threshold;

         struct single_float* float_slot = (struct single_float*) PTR(threshold_obj);

         float threshold = float_slot->value;

-        gc_assert(threshold >= 0.1 && threshold <= 1);

+        gc_assert(threshold > 0 && threshold <= 1);

     }

     scavenge((lispobj *) hash_table, HASH_TABLE_SIZE);

Raymond Toy pushed to branch issue-69-compile-in-gc-assert at cmucl / cmucl

Commits:

2 changed files:

Changes: