GitLab

at 2023-02-27T15:33:25+00:00

Fix #166: integer-decode-float has incorrect type for exponent

Merge branch 'issue-166-integer-decode-float-min-float' into 'master'

Fix #166: integer-decode-float has incorrect type for exponent

Closes #166

See merge request cmucl/cmucl!117
Merge branch 'master' into issue-168-no-negated-forms-for-jmp

 variables:

   download_url: "https://common-lisp.net/project/cmucl/downloads/snapshots/2021/07"

   version: "2021-07-x86"

-  bootstrap: "-B boot-2021-07-2"

+  bootstrap: "-B boot-2021-07-1 -B boot-2021-07-2"

 

 stages:

   - install

+;; Bootstrap file

+;;

+;; Use "bin/build.sh -B boot-2021-07-1" to build this.

+;;

+;; We want to export the symbols from the KERNEL package which also

+;; exists in the C package, so we unintern the conflicting symbols from

+;; the C package.

+

+(in-package "KERNEL")

+(ext:without-package-locks

+  (handler-bind

+      ((error (lambda (c)

+		(declare (ignore c))

+		(invoke-restart 'lisp::unintern-conflicting-symbols))))

+    (export '(DOUBLE-FLOAT-INT-EXPONENT

+	      SINGLE-FLOAT-INT-EXPONENT))))

+
 	   "DOUBLE-FLOAT-EXPONENT"

 	   "DOUBLE-FLOAT-BITS"

 	   "DOUBLE-FLOAT-HIGH-BITS"

+	   "DOUBLE-FLOAT-INT-EXPONENT"

 	   "DOUBLE-FLOAT-LOW-BITS" "DOUBLE-FLOAT-P" "FLOAT-WAIT"

 	   "DYNAMIC-SPACE-FREE-POINTER" "ERROR-NUMBER-OR-LOSE" "FILENAME"

 	   "FLOAT-DIGITS" "FLOAT-EXPONENT" "FLOAT-FORMAT-DIGITS"

-	   "FLOAT-FORMAT-MAX" "FLOAT-RADIX" "FORM" "FUNCALLABLE-INSTANCE-P"

+	   "FLOAT-FORMAT-MAX" "FLOAT-INT-EXPONENT" "FLOAT-RADIX" "FORM" "FUNCALLABLE-INSTANCE-P"

 	   "FUNCTION-CODE-HEADER" "FUNCTION-TYPE" "FUNCTION-TYPE-ALLOWP"

 	   "FUNCTION-TYPE-KEYP" "FUNCTION-TYPE-KEYWORDS"

 	   "FUNCTION-TYPE-NARGS" "FUNCTION-TYPE-OPTIONAL" "FUNCTION-TYPE-P"

  	   "SIMPLE-ARRAY-SIGNED-BYTE-16-P" "SIMPLE-ARRAY-SIGNED-BYTE-30-P"

 	   "SIMPLE-ARRAY-SIGNED-BYTE-32-P" "SIMPLE-ARRAY-SIGNED-BYTE-8-P" 

 	   "SIMPLE-UNBOXED-ARRAY" "SINGLE-FLOAT-BITS" "SINGLE-FLOAT-EXPONENT"

+	   "SINGLE-FLOAT-INT-EXPONENT"

 	   "SINGLE-FLOAT-P" "SINGLE-VALUE-TYPE" "SPECIFIER-TYPE" "STACK-REF"

 	   "STD-COMPUTE-CLASS-PRECEDENCE-LIST"

 	   "STREAMLIKE" "SIMPLE-STREAM-BUFFER" "STRINGABLE" "STRINGLIKE"

 (defknown (float-digits float-precision) (float) float-digits

   (movable foldable flushable explicit-check))

 (defknown integer-decode-float (float)

-	  (values integer float-exponent (member -1 1))

+	  (values integer float-int-exponent (member -1 1))

 	  (movable foldable flushable explicit-check))

 

 (defknown complex (real &optional real) number

 (deftype float-exponent ()

   #-long-float 'double-float-exponent

   #+long-float 'long-float-exponent)

+(deftype float-int-exponent ()

+  'double-float-int-exponent)

 (deftype float-digits ()

   #-long-float `(integer 0 ,vm:double-float-digits)

   #+long-float `(integer 0 ,vm:long-float-digits))

 	(*compile-print* nil))

     (assert-true (stream::find-external-format :euckr))

     (assert-true (stream::find-external-format :cp949))))

+

+

+

+(define-test issue.166

+    (:tag :issues)

+  ;; While this tests for the correct return value, the problem was

+  ;; that the compiler was miscompiling the function below and causing

+  ;; an error when the function run.

+  (let ((f (compile nil #'(lambda ()

+			    (nth-value 1 (integer-decode-float least-positive-double-float))))))

+    (assert-equal -1126 (funcall f))))

Raymond Toy pushed to branch issue-168-no-negated-forms-for-jmp at cmucl / cmucl

Commits:

6 changed files:

Changes: