Raymond Toy pushed to branch issue-375-mkstemp-return-filename at cmucl / cmucl Commits: 5814e20d by Raymond Toy at 2025-02-07T12:50:18-08:00 Remove invalid tests and update pot file On linux, the only requirement on the template is the last 6 chars are X's. There could be more. Hence remove these tests. Update the pot file for the changed docstrings. - - - - - 2 changed files: - src/i18n/locale/cmucl-unix.pot - tests/unix.lisp Changes: ===================================== src/i18n/locale/cmucl-unix.pot ===================================== @@ -1441,9 +1441,7 @@ msgid "" "Generates a unique temporary file name from TEMPLATE, and creates\n" " and opens the file. On success, the corresponding file descriptor\n" " and name of the file is returned. Otherwise, NIL and the UNIX error\n" -" code is returned.\n" -"\n" -" The last six characters of the template must be \"XXXXXX\"." +" code is returned." msgstr "" #: src/code/unix.lisp ===================================== tests/unix.lisp ===================================== @@ -56,18 +56,7 @@ (assert-false fd) (assert-true (and (integerp errno) (plusp errno))))) -;; Darwin allows any number of X's. -#-darwin (define-test mkstemp.bad-template.2 - (:tag :issues) - (multiple-value-bind (fd errno) - (unix::unix-mkstemp "test-XXXXXXX") - ;; The template has too many X's so the FD should be NIL, and a - ;; positive Unix errno value should be returned. - (assert-false fd) - (assert-true (and (integerp errno) (plusp errno))))) - -(define-test mkstemp.bad-template.3 (:tag :issues) (multiple-value-bind (fd errno) (unix::unix-mkstemp "test-XXXXXXa") @@ -123,16 +112,6 @@ (assert-false result) (assert-true (and (integerp errno) (plusp errno))))) -;; Darwin allows any number of X's. -#-darwin -(define-test mkdtemp.bad-template.2 - (:tag :issues) - (multiple-value-bind (result errno) - (unix::unix-mkdtemp "dir-XXXXXXX") - ;; Too many X's in template. - (assert-false result) - (assert-true (and (integerp errno) (plusp errno))))) - (define-test mkdtemp.bad-template.2 (:tag :issues) (multiple-value-bind (result errno) @@ -140,4 +119,3 @@ ;; Template doesn't end in X's (assert-false result) (assert-true (and (integerp errno) (plusp errno))))) - View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/5814e20dd2ca56c5d9cc5177... -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/5814e20dd2ca56c5d9cc5177... You're receiving this email because of your account on gitlab.common-lisp.net.