GitLab

at 2022-09-19T18:22:05-07:00

Address review comments

Use alien::null-alien to check for C NULL ptr.

Remove debugging print from os_file_author.

 			       (alien:extern-alien "os_file_author"

 						   (function (alien:* c-call:c-string) c-call:c-string))

 			       (unix::%name->file name)))

-		 (unless (zerop (sap-int (alien:alien-sap author)))

+		 (unless (alien:null-alien author)

 		   (alien:cast author c-call:c-string)))

-	    (when author

-	      (alien:free-alien author)))))))

+	    (alien:free-alien author))))))

 ;;;; DIRECTORY.

         }

     }

 exit:

-    fprintf(stderr, "buffer, initial = %p %p\n", buffer, initial);

-    

     if (buffer != initial) {

         free(buffer);

     }

...	...	@@ -774,8 +774,6 @@ os_file_author(const char *path)
774	774	}
775	775	}
776	776	exit:
777		- fprintf(stderr, "buffer, initial = %p %p\n", buffer, initial);
778		-
779	777	if (buffer != initial) {
780	778	free(buffer);
781	779	}

Raymond Toy pushed to branch issue-130-file-author-in-c at cmucl / cmucl

Commits:

2 changed files:

Changes: