Raymond Toy pushed to branch issue-243-weak-pointer-to-static-array at cmucl / cmucl Commits: a1da802f by Raymond Toy at 2024-02-01T17:13:41-08:00 Clean up code and prints a bit If there are no weak pointers, exit right away. Add a few more prints and remove a misleading print. - - - - - 1 changed file: - src/lisp/gencgc.c Changes: ===================================== src/lisp/gencgc.c ===================================== @@ -5411,17 +5411,23 @@ scan_weak_pointers(void) max_vectors++; } + printf("weak pointer count = %d\n", max_vectors); + + /* Nothing to do if there are no weak pointers */ + if (max_vectors == 0) { + return; + } + /* * Allocate max space */ vectors_to_free = (lispobj*) malloc(max_vectors * sizeof(lispobj)); gc_assert(vectors_to_free); - printf("weak pointer count = %d\n", max_vectors); printf("vectors_to_free = %p\n", vectors_to_free); /* - * Now process the weak pointers + * Now process the weak pointers. */ for (wp = weak_pointers; wp; wp = wp->next) { lispobj value = wp->value; @@ -5440,16 +5446,14 @@ scan_weak_pointers(void) /* The value may be a static vector */ lispobj *header = (lispobj *) PTR(value); + printf("value %p, header = %p\n", (lispobj*) value, header); + if (maybe_static_array_p(*header)) { if (HeaderValue(*header) == 1) { /* * We have a static array with the mark * cleared which means it's not used. - */ - printf(" vectors_to_free[%d] = %p %08lx\n", - k, (lispobj *) value, *header); - - /* + * * Only add it if we don't already have it. */ int m; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a1da802f25ba8a5c68e3879c... -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a1da802f25ba8a5c68e3879c... You're receiving this email because of your account on gitlab.common-lisp.net.