GitLab

at 2024-07-24T09:15:12-07:00

Add check_ptr(cmucllib,...)

Make sure that cmucllib is not NULL after we gone through all the
cases to determine a value for cmucllib.

Handle leak of searched_core

The initial fix of just returning NULL when `core` is NULL or when
`core` is not accessible like so:
```
     if (core && access(core, R_OK) != 0) {
       return NULL;
     }
```
fixed the analyzer warning that we were leaking `core`.

I think the analyzer is wrong here.  If `core` was set by
`search_core` but it is inaccessible, we'd return NULL without freeing
the space returned by search_core.

Instead we do this so that we the searched core is NULL or if it's not
accessible, we free the space before returning.  This also fixes the
analyzer warning.

     }

     if (core && access(core, R_OK) != 0) {

-      core = NULL;

+      return NULL;

     }

     return core;

         }

     }

+    check_ptr(cmucllib, "cmucllib must not be NULL");

+

     /* Only look for a core file if we're not using a built-in image. */

     if (builtin_image_flag == 0) {

 	/*

...	...	@@ -451,7 +451,7 @@ locate_core(const char* cmucllib, const char* core, const char* default_core)
451	451	}
452	452
453	453	if (core && access(core, R_OK) != 0) {
454		- core = NULL;
	454	+ return NULL;
455	455	}
456	456
457	457	return core;
...	...	@@ -789,6 +789,8 @@ main(int argc, const char argv[], const char envp[])
789	789	}
790	790	}
791	791
	792	+ check_ptr(cmucllib, "cmucllib must not be NULL");
	793	+
792	794	/* Only look for a core file if we're not using a built-in image. */
793	795	if (builtin_image_flag == 0) {
794	796	/*

Raymond Toy pushed to branch issue-306-lisp.c at cmucl / cmucl

Commits:

1 changed file:

Changes: