Raymond Toy pushed to branch issue-380-p2-clean-up-shell-scripts at cmucl / cmucl

Commits:

• 9b796002
  by Raymond Toy at 2025-08-20T13:04:37-07:00

  Address comments and update disable shellcheck notes
  
  Don't want to use :lower: and :upper: for tr.
  
  Disable some the warnings/notes that shellcheck produces for the
  :lower: note and also for the suggesiong on using shell variable
  pattern matching and replacement.
  

1 changed file:

• bin/make-dist.sh

Changes:

 		GTAR=gtar ;;

 	  esac

 	  uname_r=$(uname -r)

+	  # shellcheck disable=SC2001

+	  # sed is ok here instead of shell variable pattern matching

 	  case $uname_r in

 	    5.*) rel=$(echo "$uname_r" | sed 's/5\.//') ;;

 	    *) rel=$uname_r;;

 	  ;;

       FreeBSD)

 	  ARCH=x86

-	  OS=freebsd_$(uname -r | tr '[:upper:]' '[:lower:]')

+	  # shellcheck disable=SC2018,SC2019

+	  # Don't want to use :lower: and :upper here since that depends on the locale.

+	  OS=freebsd_$(uname -r | tr 'A-Z' 'a-z')

 	  ;;

       esac

 }

     fi

 fi   

+# shellcheck disable=SC2001

 TARGET="$(echo "$1" | sed 's:/*$::')"

 # Choose a version based on the git hash as the default version.  We