GitLab

at 2023-12-07T14:49:30-08:00

Update release notes

Add tests for ~user in pathnames

Update tests for changes in get-user-homedir-namestring

The function name has changed and we return a namestring instead of a
pathname.

     * ~~#253~~ Block-compile list-to-hashtable and callers

     * ~~#258~~ Remove `get-page-size` from linux-os.lisp

     * ~~#269~~ Add function to get user's home directory

+    * ~~#266~~ Support "~user" in namestrings

   * Other changes:

   * Improvements to the PCL implementation of CLOS:

   * Changes to building procedure:

 (define-test user-homedir.1

   "Test user-homedir"

   (:tag :issues)

-  ;; Simple test to see if get-user-homedir-pathname returns the

+  ;; Simple test to see if get-user-homedir-namestring returns the

   ;; expected value.  Use getuid and getpwuid to figure out what the

   ;; name and home directory should be.

   (let* ((uid (unix:unix-getuid))

     (assert-true uid)

     (assert-true user-info)

     (let* ((info-dir (unix:user-info-dir user-info))

-           (info-name (unix:user-info-name user-info))

-           (expected-home-pathname (pathname

-                                    (concatenate 'string info-dir "/"))))

-      (multiple-value-bind (home-pathname status)

-          (system:get-user-homedir-pathname info-name)

+           (info-name (unix:user-info-name user-info)))

+      (multiple-value-bind (home-namestring status)

+          (system:get-user-homedir-namestring info-name)

         (assert-true info-dir)

         (assert-true info-name)

-        (assert-equal home-pathname expected-home-pathname)

+        (assert-equal home-namestring info-dir)

         (assert-eql status 0)))))

 (define-test user-homedir.2

   ;; value for a user that does not exist.  Well, we assume such a

   ;; user doesn't exist.

       (multiple-value-bind (home-pathname status)

-          (system:get-user-homedir-pathname "zotuserunknown")

+          (system:get-user-homedir-namestring "zotuserunknown")

         (assert-eql home-pathname nil)

         (assert-eql status 0)))
 	  test

 	(assert-equal printed-value (output pathname))

 	(assert-equal namestring (namestring pathname))))))

+

+(define-test issue.266.pathname-tilde.unknown-user

+    (:tag :issues)

+  ;; This assumes that there's no user named "zotunknown".

+  (assert-error 'simple-error (parse-namestring "~zotunknown/*.*")))

+

+(define-test issue.266.pathname-tilde.1

+    (:tag :issues)

+  ;; Simple test for ~ in pathnames.  Get a directory list using

+  ;; #P"~/*.*".  This should produce exactly the same list as the

+  ;; #search-list P"home:*.*".

+  (let ((dir-home (directory #p"home:*.*" :truenamep nil :follow-links nil))

+        (dir-tilde (directory #p"~/*.*" :truenamep nil :follow-links nil)))

+    (assert-equal dir-tilde dir-home)))

+

+(define-test issue.266.pathname-tilde.2

+    (:tag :issues)

+  ;; Simple test for ~ in pathnames.  Get a directory list using

+  ;; #P"~user/*.*".  This should produce exactly the same list as the

+  ;; #search-list P"home:*.*".  We determine the user name via getuid

+  ;; #and getpwuid.

+  (let ((user-name (unix:user-info-name (unix:unix-getpwuid (unix:unix-getuid)))))

+    (assert-true user-name)

+    (let* ((dir-home (directory #p"home:*.*" :truenamep nil :follow-links nil))

+         

+           (dir-tilde (directory (concatenate 'string

+                                              "~"

+                                              user-name

+                                              "/*.*")

+                                 :truenamep nil :follow-links nil)))

+      (assert-equal dir-tilde dir-home))))

Raymond Toy pushed to branch issue-266-b-tilde-pathname-support at cmucl / cmucl

Commits:

3 changed files:

Changes: