GitLab

at 2016-11-10T19:13:53-08:00

Fix #36: encode-universal-time errors on valid time

Allow 1899 as a year, but also add a check that the resulting time is
a non-negative integer.

Add a test for this too in issues.lisp.

 	   (type (mod 24) hour)

 	   (type (integer 1 31) date)

 	   (type (integer 1 12) month)

 	   (type (or (integer 0 99) (integer 1900)) year)

 	   (type (or null rational) time-zone))

 	   ;; 1899 to account for time zones that are equivalent to 1900.

 	   (type (or (integer 0 99) (integer 1899)) year)

 	   (type (or null rational) time-zone)

 	   ;; Result must be non-negative integer!

 	   (values (integer 0)))

   (let* ((year (if (< year 100)

 		   (pick-obvious-year year)

 		   year))

     (assert (null (set-difference directories

                                   '(".dir" "dir")

                                   :test #'string-equal)))))

 (define-test issue.36

     (:tag :issues)

   (loop for k from 1 to 24 do

     (assert-equal 0 (encode-universal-time 0 0 (- 24 k) 31 12 1899 k))))

Raymond Toy pushed to branch master at cmucl / cmucl

Commits:

2 changed files:

Changes: