GitLab

at 2022-10-16T14:26:39+00:00

Fix #142: (random 0) signals incorrect error

Merge branch 'issue-142-random-0-wrong-error' into 'master'

Fix #142: (random 0) signals incorrect error

Closes #142

See merge request cmucl/cmucl!99
Fix #136: ensure-directories-exist should return the given pathspec

Merge branch 'issue-136-ansi-test-ensure-directories-exist.8' into 'master'

Fix #136: ensure-directories-exist should return the given pathspec

Closes #136

See merge request cmucl/cmucl!92
Update release notes based on recent merges

Forgot to update the release notes with recent merges that fixed a few
issues.  Hence update the notes now.

Also testing see if we need to add a strikeout for closed issues, so
didn't add strikeout for these.

Add strikeout for closed issues

Nope, gitlab doesn't mark closed issues in anyway, unlike Trac that
would automatically strikeout references to closed issues.  We have to
do it ourselves.

Fix #146: CI passes incorrectly

We forgot to update the script for macos to use separate `grep`
commands like we did for linux.

Merge branch 'master' into issue-130-file-author-in-c

Address review comments

Remove the assert and change the loop limit from 16384 to 1<<20.

Change so we only free in one place.

   script:

     - cd ansi-test

     - make LISP="../dist/bin/lisp -batch -noinit -nositeinit"

-    - grep 'No unexpected \(successes\|failures\)' test.out 

+    # There should be no unexpected successes or failures; check these separately.

+    - grep -a 'No unexpected successes' test.out && grep -a 'No unexpected failures' test.out

 osx:benchmark:

   stage: benchmark

 			 (retry () :report "Try to create the directory again"

 				(go retry))))))

 	 ;; Only the first path in a search-list is considered.

-	 (return (values pathname created-p))))))
+	 (return (values pathspec created-p))))))
     (t

      (error 'simple-type-error

 	    :expected-type '(or (integer 1) (float (0.0))) :datum arg

-	    :format-control _"Argument is not a positive integer or a positive float: ~S")

-	    :format-arguments (list arg))))

+	    :format-control _"Argument is not a positive integer or a positive float: ~S"

+	    :format-arguments (list arg)))))

 ;; Jump function for the generator.  See the jump function in

 ;; http://xoroshiro.di.unimi.it/xoroshiro128plus.c

     * ~~#113~~ REQUIRE on contribs can pull in the wrong things via ASDF.

     * ~~#121~~ Wrong column index in FILL-POINTER-OUTPUT-STREAM

     * ~~#122~~ gcc 11 can't build cmucl

+    * ~~#125~~ Linux `unix-stat` returning incorrect values

     * ~~#127~~ Linux unix-getpwuid segfaults when given non-existent uid.

     * ~~#128~~ `QUIT` accepts an exit code

+    * ~~#132~~ Ansi test `RENAME-FILE.1` no fails

+    * ~~#134~~ Handle the case of `(expt complex complex-rational)`

+    * ~~#136~~ `ensure-directories-exist` should return the given pathspec

+    * ~~#142~~ `(random 0)` signals incorrect error

   * Other changes:

   * Improvements to the PCL implementation of CLOS:

   * Changes to building procedure:

 {

     struct stat sb;

     char initial[1024];

-    char *buffer, *obuffer;

+    char *buffer, *newbuffer;

     size_t size;

     struct passwd pwd;

     struct passwd *ppwd;

     size = sizeof(initial) / sizeof(initial[0]);

     /*

-     * Assume a buffer of size 16384 is enough to for getpwuid_r to do

-     * it's thing.

+     * Keep trying with larger buffers until a maximum is reached.  We

+     * assume (1 << 20) is large enough for any OS.

      */

-    assert(sysconf(_SC_GETPW_R_SIZE_MAX) <= 16384);

-

-    /*

-     * Keep trying with larger buffers until a maximum is reached.

-     */

-    while (size <= 16384) {

+    while (size <= (1 << 20)) {

         switch (getpwuid_r(sb.st_uid, &pwd, buffer, size, &ppwd)) {

           case 0:

               /* Success, though we might not have a matching entry */

           case ERANGE:

               /* Buffer is too small, double its size and try again */

               size *= 2;

-              obuffer = (buffer == initial) ? NULL : buffer;

-              if ((buffer = realloc(obuffer, size)) == NULL) {

-                  free(obuffer); 

+              if ((newbuffer = realloc((buffer == initial) ? NULL : buffer,

+                                       size)) == NULL) {

                   goto exit;

               }

+              buffer = newbuffer;

               continue;

           default:

               /* All other errors */

 (define-test unix-namestring.1.exists

   ;; Make sure the desired directories exist.

-  (assert-equal #P"/tmp/foo/bar/hello.txt"

+  (assert-equal "/tmp/foo/bar/hello.txt"

 		(ensure-directories-exist "/tmp/foo/bar/hello.txt"))

   (dolist (path '("/tmp/hello.txt"

 		  "/tmp/foo/"

 (define-test unix-namestring.1.non-existent

   ;; Make sure the desired directories exist.

-  (assert-equal #P"/tmp/foo/bar/hello.txt"

+  (assert-equal "/tmp/foo/bar/hello.txt"

 		(ensure-directories-exist "/tmp/foo/bar/hello.txt"))

   ;; These paths contain directories that don't exist.

   (dolist (path '("/tmp/oops/"

 (define-test unix-namestring.2

   ;; Make sure the desired directories exist.

-  (assert-equal #P"/tmp/foo/bar/hello.txt"

+  (assert-equal "/tmp/foo/bar/hello.txt"

 		(ensure-directories-exist "/tmp/foo/bar/hello.txt"))

   (unwind-protect

        (progn

Raymond Toy pushed to branch issue-130-file-author-in-c at cmucl / cmucl

Commits:

6 changed files:

Changes: