Raymond Toy pushed to branch issue-397-const-mult-using-lea at cmucl / cmucl Commits: 6250a035 by Raymond Toy at 2025-04-02T08:44:08-07:00 Add test for multiplication by a constant Add some tests for the optimized fixnum multiplication vops on x86. These tests are only run for x86. - - - - - e8e4d22b by Raymond Toy at 2025-04-02T08:45:13-07:00 Fix bug in multiplication by 7 Forgot to move the computed result to the result vop. This was caught by tests/arith.lisp test. Hurray for tests! - - - - - 2 changed files: - src/compiler/x86/arith.lisp - + tests/arith.lisp Changes: ===================================== src/compiler/x86/arith.lisp ===================================== @@ -295,7 +295,8 @@ ;; temp = x*8 ;; r = temp - x (inst lea ,temp (make-ea :dword :index ,x :scale 8)) - (inst sub ,temp ,x)) + (inst sub ,temp ,x) + (move ,r ,temp)) ((= ,y 9) ;; r = x + x*8 (inst lea ,r (make-ea :dword :base ,x :index ,x :scale 8))) ===================================== tests/arith.lisp ===================================== @@ -0,0 +1,46 @@ +;; Test x86 multiplication by small constants + +(defpackage :arith-tests + (:use :cl :lisp-unit)) + +(in-package "ARITH-TESTS") + +#+x86 +(macrolet + ((frob (c arg expected) + (let ((test-name-fixnum (intern (format nil "X86-TEST-CONST-MUL-FIXNUM-~D" c)))) + `(define-test ,test-name-fixnum + (:tag :x86-arith) + (assert-eql ,expected + (funcall (compile nil #'(lambda (x) + (declare (type (signed-byte 24) x)) + (* x ,c))) + ,arg)))))) + ;; This is a test of #397. Test that the multiplication by small + ;; constants is correct for each of the constants defined for the + ;; fixnum-*-c/fixnum=>fixnum vop. + + (frob 2 10 20) + (frob 2 -10 -20) + (frob 3 10 30) + (frob 3 -10 -30) + (frob 4 10 40) + (frob 4 -10 -40) + (frob 5 10 50) + (frob 5 -10 -50) + (frob 6 10 60) + (frob 6 -10 -60) + (frob 7 10 70) + (frob 7 -10 -70) + (frob 8 10 80) + (frob 8 -10 -80) + (frob 9 10 90) + (frob 9 -10 -90) + (frob 10 10 100) + (frob 10 -10 -100) + (frob 11 10 110) + (frob 11 -10 -110) + (frob 12 10 120) + (frob 12 -10 -120) + (frob 13 10 130) + (frob 13 -10 -130)) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/a051c7a9a168382a073dbec... -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/a051c7a9a168382a073dbec... You're receiving this email because of your account on gitlab.common-lisp.net.