Raymond Toy pushed to branch issue-460-ci-fails-if-unit-tests-do at cmucl / cmucl Commits: a8aa9974 by Raymond Toy at 2025-12-18T19:16:55-08:00 Don't run float-x86 tests on Darwin As hinted by in float-trap.lisp, we don't use x87 FP mode stuff on Darwin. (`floating-point-modes` for Darwin doesn't play with x87 bits.) Hence the test in float-trap.lisp doesn't apply to Darwin so don't run it. Add a comment here too. - - - - - 1 changed file: - tests/float-x86.lisp Changes: ===================================== tests/float-x86.lisp ===================================== @@ -5,6 +5,11 @@ (in-package "FLOAT-X86-TESTS") +;; This tests the floating-point modes for x86. This works only if we +;; have the feature :sse2 but not :darwin since darwin has always used +;; sse2 and not x87. But see also how FLOATING-POINT-MODES is +;; implemented in src/code/float-trap.lisp. +#+(and sse2 (not darwin)) (define-test set-floating-point-modes (let ((old-x87-modes (x86::x87-floating-point-modes)) (old-sse2-modes (x86::sse2-floating-point-modes)) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a8aa9974fa91b6a51cce7fde... -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a8aa9974fa91b6a51cce7fde... You're receiving this email because of your account on gitlab.common-lisp.net.