January 2021 - cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl] Pushed new tag snapshot-2021-01
by Raymond Toy 30 Jan '21

30 Jan '21

Raymond Toy pushed new tag snapshot-2021-01 at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/snapshot-2021-01 You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Update notes in preparation for snapshot.
by Raymond Toy 30 Jan '21

30 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: e349bf1d by Raymond Toy at 2021-01-30T09:51:59-08:00 Update notes in preparation for snapshot. Just updated based on the issues that were closed. - - - - - 1 changed file: - src/general-info/release-21e.md Changes: ===================================== src/general-info/release-21e.md ===================================== @@ -19,8 +19,6 @@ public domain. ## New in this release: * Known issues: - * Building with gcc8 or later doesn't work with the default -O option. Use -O1 instead. This shouldn't really impact overall speed much. - * Added simple support to compile with clang instead, which works. (Use x86_linux_clang). * Feature enhancements * Changes * Update to ASDF 3.3.4 @@ -35,6 +33,12 @@ public domain. * ~~#80~~ Use ASDF to load contribs. cmu-contribs still exists but does nothing. The contrib names are the same, except it's best to use a keyword instead of a string. So, `:contrib-demos` instead of `"contrib-demos"`. * ~~#81~~ Added contribs from Eric Marsden * ~~#82~~ Replace bc with expr in GNUMakefile + * ~~#86~~ Building with gcc 8 and later works when using -O2 optimization + * ~~#90~~ Some static symbols have been removed. This probably makes the fasl files incompatible with older versions. + * ~~#91~~ Loop destructuring no longer incorrectly signals an error + * ~~#95~~ Disassembler syntax of x86 je and movzx is incorrect + * ~~#98~~ fstpd is not an Intel instruction; disassemble as `fstp dword ptr [addr]` + * ~~#100~~ ldb prints out unicode base-chars correctly instead of just the low 8 bits. * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/e349bf1da7a83e19650aff2… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/e349bf1da7a83e19650aff2… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: ldb prints out Unicode characters
by Raymond Toy 30 Jan '21

30 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 19f274f0 by Raymond Toy at 2021-01-29T17:30:03-08:00 ldb prints out Unicode characters When printing out a base-char, only the low 8 bits of the code were used. But with Unicode support, we need to take all the bits and print them out. For control codes we use the form "#\^x". (Was #\C-x, which isn't a valid supported character form.) Ascii is printed as normal "#\a", and everything else use uses "#\u+<hex>". While we're at it, we also added special cases like #\Vt that are listed in https://cmucl.org/docs/cmu-user/html/Characters.html#Characters. With this, we can print out all unicode characters in a form that can be pasted back into lisp. - - - - - 832e116a by Raymond Toy at 2021-01-30T01:54:08+00:00 Merge branch 'issue-100-ldb-base-char-printing' into 'master' ldb prints out Unicode characters See merge request cmucl/cmucl!67 - - - - - 1 changed file: - src/lisp/print.c Changes: ===================================== src/lisp/print.c ===================================== @@ -212,12 +212,15 @@ static void brief_otherimm(lispobj obj) { int type, c, idx; - char buffer[10]; type = TypeOf(obj); switch (type) { case type_BaseChar: - c = (obj >> 8) & 0xff; + /* + * A base-char should only be 16 bits long now. But + * sometimes it uses all 24. So just grab all the bits. + */ + c = (obj >> 8) & 0xfffff; switch (c) { case '\0': printf("#\\Null"); @@ -228,20 +231,35 @@ brief_otherimm(lispobj obj) case '\b': printf("#\\Backspace"); break; + case '\11': + printf("#\\Tab"); + break; + case '\13': + printf("#\\Vt"); + break; + case '\15': + printf("#\\Return"); + break; + case '\33': + printf("#\\Escape"); + break; + case '\40': + printf("#\\Space"); + break; case '\177': printf("#\\Delete"); break; default: - strcpy(buffer, "#\\"); if (c >= 128) { - strcat(buffer, "m-"); - c -= 128; - } - if (c < 32) { - strcat(buffer, "c-"); - c += '@'; - } - printf("%s%c", buffer, c); + /* Just print out the code value */ + printf("#\\u+%04X", c); + } else if (c < 32) { + /* Print it out as a control character */ + printf("#\\^%c", c + '@'); + } else { + /* Plain ASCII character */ + printf("#\\%c", c); + } break; } break; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/ef9fc1bced6dbad3b63213… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/ef9fc1bced6dbad3b63213… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-100-ldb-base-char-printing
by Raymond Toy 30 Jan '21

30 Jan '21

Raymond Toy pushed new branch issue-100-ldb-base-char-printing at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-100-ldb-base-char-p… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][native-image] Support type_BaseChar and type_ValueCellHeader
by Raymond Toy 27 Jan '21

27 Jan '21

Raymond Toy pushed to branch native-image at cmucl / cmucl Commits: 9f71e8eb by Raymond Toy at 2021-01-26T22:30:52-08:00 Support type_BaseChar and type_ValueCellHeader Value cells are dumped as some boxed object. - - - - - 1 changed file: - src/lisp/save.c Changes: ===================================== src/lisp/save.c ===================================== @@ -680,6 +680,9 @@ init_asmtab() asmtab[type_SimpleVector] = asm_simple_vector; asmtab[type_FuncallableInstanceHeader] = asm_closure_header; asmtab[type_ComplexVector] = asm_boxed; + asmtab[type_BaseChar] = asm_immediate; + /* Just use asm_boxed or have a special version for a value cell? */ + asmtab[type_ValueCellHeader] = asm_boxed; } void View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9f71e8eb109c45a709c03c1… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9f71e8eb109c45a709c03c1… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][native-image] Round up length for boxed objects and simple vector
by Raymond Toy 27 Jan '21

27 Jan '21

Raymond Toy pushed to branch native-image at cmucl / cmucl Commits: f6b1c916 by Raymond Toy at 2021-01-26T21:36:17-08:00 Round up length for boxed objects and simple vector These objects should end on a double-word boundary, so round up the len (from the header) to a double word before printing out the contents. If we don't round and we don't end on a boundary, we'll probably just print an immediate word of 0. Harmless, I think, but we'll add a label that wastes space. - - - - - 1 changed file: - src/lisp/save.c Changes: ===================================== src/lisp/save.c ===================================== @@ -26,6 +26,9 @@ #include "gencgc.h" #endif +/* Like (ceiling x y), but y is constrained to be a power of two */ +#define CEILING(x,y) (((x) + ((y) - 1)) & (~((y) - 1))) + #ifdef FEATURE_EXECUTABLE #include "elf.h" #if !(defined(DARWIN) && defined(__ppc__)) @@ -454,6 +457,7 @@ int asm_boxed(lispobj* ptr, lispobj object, FILE* f) { int len = 1 + HeaderValue(object); + len = CEILING(len, 2); int k; asm_label(ptr, object, f); @@ -464,8 +468,6 @@ asm_boxed(lispobj* ptr, lispobj object, FILE* f) asm_lispobj(ptr + k, ptr[k], f); } - asm_align(f); - return len; } @@ -535,6 +537,7 @@ asm_simple_vector(lispobj* ptr, lispobj object, FILE* f) { int k; int len = ptr[1] >> 2; + len = CEILING(len, 2); lispobj* data = ptr + 2; asm_label(ptr, object, f); View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f6b1c916b14484b0d777dd5… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f6b1c916b14484b0d777dd5… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][native-image] More updates
by Raymond Toy 24 Jan '21

24 Jan '21

Raymond Toy pushed to branch native-image at cmucl / cmucl Commits: 8dc1b098 by Raymond Toy at 2021-01-24T09:02:12-08:00 More updates Add asm_ni as the default to dump out one object with a comment that this is not yet implemented. Fix bug in asm_list_pointer to print just one object. The car and cdr that follow can be handled as more lisp pointers or NIL. asm_function_pointer should just print one object since it's just a pointer and not a function itself. asm_other_pointer should do the same as asm_function_pointer. Add asm_instance_pointer which prints out just the pointer (with label). Add asm_simple_vector which prints out the simple vector header and length followed by all of the lispobjs in the array. Add asm_closure_header which is a simple boxed object containing only lispobjs. Add asm_complex_vector for complex vectors. But just call asm_ni for now for debugging. Update init_asmtab appropriately for the new printers. - - - - - 1 changed file: - src/lisp/save.c Changes: ===================================== src/lisp/save.c ===================================== @@ -438,6 +438,15 @@ asm_header_word(lispobj* ptr, lispobj object, FILE* f) } +int +asm_ni(lispobj* ptr, lispobj object, FILE* f) +{ + asm_label(ptr, object, f); + fprintf(f, "\t.4byte\t0x%lx\t# NOT IMPLEMENTED\n", + object); + return 1; +} + /* * Handles all objects that consists of only of lispobjs */ @@ -476,51 +485,35 @@ asm_list_pointer(lispobj* ptr, lispobj object, FILE* f) asm_label(ptr, object, f); asm_lispobj(ptr, object, f); - asm_lispobj(ptr + 1, ptr[1], f); - return 2; + return 1; } int asm_function_pointer(lispobj* ptr, lispobj object, FILE* f) { - int k; - int len = HeaderValue(object); + printf("function pointer 0x%lx\n", object); asm_label(ptr, object, f); - for (k = 0; k < 6; ++k) { - asm_lispobj(ptr, *ptr, f); - ++ptr; - } - fprintf(f, "# function code\n"); - - unsigned char *c = (unsigned char*) ptr; - - for (k = 0; k < len - 5*4; ++k) { - fprintf(f, "\t.byte\t0x%x\n", *c++); - } - - return len + 1; + asm_lispobj(ptr, object, f); + return 1; } int asm_other_pointer(lispobj* ptr, lispobj object, FILE* f) { - int len; - asm_label(ptr, object, f); asm_lispobj(ptr, object, f); - len = asmtab[TypeOf(ptr[1])](ptr + 1, ptr[1], f); - return len + 1; + return 1; } int asm_fdefn(lispobj* ptr, lispobj object, FILE* f) { - asm_label(ptr, *ptr, f); + asm_label(ptr, object, f); - asm_header_word(ptr, *ptr, f); + asm_header_word(ptr, object, f); asm_lispobj(ptr + 1, ptr[1], f); asm_lispobj(ptr + 2, ptr[2], f); @@ -529,6 +522,43 @@ asm_fdefn(lispobj* ptr, lispobj object, FILE* f) return 4; } +int +asm_instance_pointer(lispobj* ptr, lispobj object, FILE* f) +{ + asm_label(ptr, object, f); + asm_lispobj(ptr, object, f); + return 1; +} + +int +asm_simple_vector(lispobj* ptr, lispobj object, FILE* f) +{ + int k; + int len = ptr[1] >> 2; + lispobj* data = ptr + 2; + + asm_label(ptr, object, f); + asm_header_word(ptr, object, f); + asm_lispobj(ptr + 1, ptr[1], f); + + for (k = 0; k < len; ++k) { + asm_lispobj(data + k, data[k], f); + } + + return len + 2; +} + +int +asm_closure_header(lispobj* ptr, lispobj object, FILE* f) +{ + return asm_boxed(ptr, object, f); +} + +int +asm_complex_vector(lispobj* ptr, lispobj object, FILE* f) +{ + return asm_ni(ptr, object, f); +} #if 0 int @@ -627,24 +657,26 @@ init_asmtab() int k = 0; for (k = 0; k < 256; ++k) { - asmtab[k] = asm_boxed; + asmtab[k] = asm_ni; } for (k = 0; k < 32; ++k) { asmtab[type_EvenFixnum | (k << 3)] = asm_immediate; asmtab[type_FunctionPointer | (k << 3)] = asm_function_pointer; - /* OtherImmediate0 */ + asmtab[type_OtherImmediate0 | (k << 3)] = asm_ni; asmtab[type_ListPointer | (k << 3)] = asm_list_pointer; asmtab[type_OddFixnum | (k << 3)] = asm_immediate; -#if 0 asmtab[type_InstancePointer | (k << 3)] = asm_instance_pointer; -#endif - /* OtherImmediate1 */ + asmtab[type_OtherImmediate1 | (k << 3) ] = asm_ni; asmtab[type_OtherPointer | (k << 3)] = asm_other_pointer; } asmtab[type_SymbolHeader] = asm_boxed; asmtab[type_Fdefn] = asm_fdefn; + asmtab[type_InstanceHeader] = asm_boxed; + asmtab[type_SimpleVector] = asm_simple_vector; + asmtab[type_FuncallableInstanceHeader] = asm_closure_header; + asmtab[type_ComplexVector] = asm_boxed; } void View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/8dc1b098315486424544033… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/8dc1b098315486424544033… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch native-image
by Raymond Toy 18 Jan '21

18 Jan '21

Raymond Toy pushed new branch native-image at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/native-image You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Minor tweak to put use the right EI_OSABI value
by Raymond Toy 15 Jan '21

15 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: ef9fc1bc by Raymond Toy at 2021-01-15T13:59:13-08:00 Minor tweak to put use the right EI_OSABI value Previously, the EI_OSABI value was either ELFOSAB_SOLARIS for solaris or ELFOSABI_FREEBSD for everything else. Let's update this to include NetBSD and Linux. Unlikely we'll ever support other things like HP-UX, AIX, IRIX, Tru64, etc. The value currently doesn't seem matter, but it seems nice to get it right. - - - - - 1 changed file: - src/lisp/elf.c Changes: ===================================== src/lisp/elf.c ===================================== @@ -132,8 +132,15 @@ write_elf_header(int fd) eh.e_ident[EI_VERSION] = EV_CURRENT; #ifdef SOLARIS eh.e_ident[EI_OSABI] = ELFOSABI_SOLARIS; -#else +#elif defined(__FREEBSD__) eh.e_ident[EI_OSABI] = ELFOSABI_FREEBSD; +#elif defined(__NetBSD__) + eh.e_ident[EI_OSABI] = ELFOSABI_NETBSD; +#elif defined(__linux__) + eh.e_ident[EI_OSABI] = ELFOSABI_LINUX; +#else + /* Default to NONE */ + eh.e_ident[EI_OSABI] = ELFOSABI_NONE; #endif #ifdef SOLARIS View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/ef9fc1bced6dbad3b63213d… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/ef9fc1bced6dbad3b63213d… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Address #89: Remove C code to scavenge read-only space
by Raymond Toy 13 Jan '21

13 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 22e573f3 by Raymond Toy at 2021-01-12T16:44:14-08:00 Address #89: Remove C code to scavenge read-only space Since we got rid of the symbol `*scavenge-read-only-space*`, we can never scavenge the read-only space, so remove the C code that scavenges the space. Get rid of the unused var `read_only_space_size` too. - - - - - 3593ca90 by Raymond Toy at 2021-01-13T01:05:13+00:00 Merge branch 'issue-89-unused-var' into 'master' Address #89: Remove C code to scavenge read-only space See merge request cmucl/cmucl!66 - - - - - 1 changed file: - src/lisp/gencgc.c Changes: ===================================== src/lisp/gencgc.c ===================================== @@ -7722,7 +7722,7 @@ static void garbage_collect_generation(int generation, int raise) { unsigned long i; - unsigned long read_only_space_size, static_space_size; + unsigned long static_space_size; #if defined(i386) || defined(__x86_64) invalid_stack_start = (void *) control_stack; @@ -7865,17 +7865,6 @@ garbage_collect_generation(int generation, int raise) printf("Done scavenging the scavenger hooks.\n"); #endif -#if 0 - if (SymbolValue(SCAVENGE_READ_ONLY_SPACE) != NIL) { - read_only_space_size = - (lispobj *) SymbolValue(READ_ONLY_SPACE_FREE_POINTER) - - read_only_space; - fprintf(stderr, "Scavenge read only space: %ld bytes\n", - read_only_space_size * sizeof(lispobj)); - scavenge(read_only_space, read_only_space_size); - } -#endif - static_space_size = (lispobj *) SymbolValue(STATIC_SPACE_FREE_POINTER) - static_space; if (gencgc_verbose > 1) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/9c0c857dd10067e1cf90ec… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/9c0c857dd10067e1cf90ec… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-89-unused-var
by Raymond Toy 13 Jan '21

13 Jan '21

Raymond Toy pushed new branch issue-89-unused-var at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-89-unused-var You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #98: Use FSTP instruction with appropriate size
by Raymond Toy 12 Jan '21

12 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 755f7a80 by Raymond Toy at 2021-01-11T20:05:32-08:00 Fix #98: Use FSTP instruction with appropriate size Instead of printing `FSTP` and `FSTPD`, print `FSTP DWORD PTR` and `FSTP QWORD PTR` to store a single-float and double-float value to memory. Clang likes this form better than the original, but gcc accepts both. - - - - - 9c0c857d by Raymond Toy at 2021-01-12T04:27:13+00:00 Merge branch 'issue-98-fstpd-formatting' into 'master' Fix #98: Use FSTP instruction with appropriate size Closes #98 See merge request cmucl/cmucl!65 - - - - - 1 changed file: - src/compiler/x86/insts.lisp Changes: ===================================== src/compiler/x86/insts.lisp ===================================== @@ -2636,7 +2636,8 @@ ;;; store single from st(0) and pop ;;; (define-instruction fstp (segment dest) - (:printer floating-point ((op '(#b001 #b011)))) + (:printer floating-point ((op '(#b001 #b011))) + '('fstp :tab 'dword " " 'ptr " " reg/mem)) (:emitter (cond ((fp-reg-tn-p dest) (emit-byte segment #b11011101) @@ -2648,7 +2649,8 @@ ;;; store double from st(0) and pop ;;; (define-instruction fstpd (segment dest) - (:printer floating-point ((op '(#b101 #b011)))) + (:printer floating-point ((op '(#b101 #b011))) + '('fstp :tab 'qword " " 'ptr " " reg/mem)) (:printer floating-point-fp ((op '(#b101 #b011)))) (:emitter (cond ((fp-reg-tn-p dest) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5e87a39ad45b1dde4d565a… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5e87a39ad45b1dde4d565a… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-98-fstpd-formatting
by Raymond Toy 12 Jan '21

12 Jan '21

Raymond Toy pushed new branch issue-98-fstpd-formatting at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-98-fstpd-formatting You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #95: Fix disassembly for je and movzx/movsx instructions
by Raymond Toy 11 Jan '21

11 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: b5bfb153 by Raymond Toy at 2021-01-11T05:37:39+00:00 Fix #95: Fix disassembly for je and movzx/movsx instructions We were printing `jeq` for the branch on equal instruction, but it should be `je`. This is fixed by changing the order of the options in the `defconstant` `conditions`. The first in the list is the preferred value, so we can write `je`, `jeq`, or `jz`, but these will all get printed out as `je` instead of the previous `jeq`. For `movzx` and `movsx`, we need to specify the size of the memory object to match Intel syntax. This is done by changing the size of the `ext-reg-reg/mem` format so that the reg/mem field has type `sized-reg/mem` instead of just `reg/mem`. Finally, we just added a note that the `break` instruction is really the `int3` instruction. I don't know why it's called `break` instead of `int3`. - - - - - 5e87a39a by Raymond Toy at 2021-01-11T05:37:39+00:00 Merge branch 'issue-95-fix-disassem-syntax' into 'master' Fix #95: Fix disassembly for je and movzx/movsx instructions Closes #95 See merge request cmucl/cmucl!64 - - - - - 2 changed files: - src/bootfiles/21d/boot-2020-04-1.lisp - src/compiler/x86/insts.lisp Changes: ===================================== src/bootfiles/21d/boot-2020-04-1.lisp ===================================== @@ -10,3 +10,8 @@ ;; x86: cross-x86-x86 ;; sparc: cross-sparc-sparc +;; This is also used to easily change the order of x86::conditions +;; constant so that we prefer je instead of jeq. Without a +;; cross-compile we'd need to handle the refefintion of the +;; defconstant in a different way. See issue #95. + ===================================== src/compiler/x86/insts.lisp ===================================== @@ -255,12 +255,15 @@ (= (tn-offset thing) 0))) (eval-when (compile load eval) +;; If a line has more than one value, then these are all synonyms, but +;; the first one is the one that is preferred when printing the +;; condition code out. (defconstant conditions '((:o . 0) (:no . 1) (:b . 2) (:nae . 2) (:c . 2) (:nb . 3) (:ae . 3) (:nc . 3) - (:eq . 4) (:e . 4) (:z . 4) + (:e . 4) (:eq . 4) (:z . 4) (:ne . 5) (:nz . 5) (:be . 6) (:na . 6) (:nbe . 7) (:a . 7) @@ -794,7 +797,7 @@ (op :field (byte 7 1)) (width :field (byte 1 0) :type 'width) (reg/mem :fields (list (byte 2 14) (byte 3 8)) - :type 'reg/mem) + :type 'sized-reg/mem) (reg :field (byte 3 11) :type 'reg) ;; optional fields (imm)) @@ -832,7 +835,10 @@ (disassem:define-instruction-format (accum-reg/mem 16 :include 'reg/mem :default-printer '(:name :tab accum ", " reg/mem)) - (reg/mem :type 'reg/mem) ; don't need a size + ;; This format uses the accumulator, so the size is known; therefore + ;; we don't really need to print out the memory size, but let's do + ;; it for consistency. + (reg/mem :type 'sized-reg/mem) (accum :type 'accum)) ;;; Same as reg-reg/mem, but with a prefix of #b00001111 @@ -843,7 +849,7 @@ (op :field (byte 7 9)) (width :field (byte 1 8) :type 'width) (reg/mem :fields (list (byte 2 22) (byte 3 16)) - :type 'reg/mem) + :type 'sized-reg/mem) (reg :field (byte 3 19) :type 'reg) ;; optional fields (imm)) @@ -865,7 +871,7 @@ (prefix :field (byte 8 0) :value #b00001111) (op :field (byte 8 8)) (reg/mem :fields (list (byte 2 22) (byte 3 16)) - :type 'reg/mem) + :type 'sized-reg/mem) (reg :field (byte 3 19) :type 'reg) ;; optional fields (imm)) @@ -1129,7 +1135,8 @@ (error "Bogus args to XCHG: ~S ~S" operand1 operand2))))))) (define-instruction lea (segment dst src) - (:printer reg-reg/mem ((op #b1000110) (width 1))) + ;; Don't need to print out the width for the LEA instruction + (:printer reg-reg/mem ((op #b1000110) (width 1) (reg/mem nil :type 'reg/mem))) (:emitter (assert (dword-reg-p dst)) (emit-byte segment #b10001101) @@ -2112,6 +2119,7 @@ (nt "Function end breakpoint trap")) ))) +;; This is really the int3 instruction. (define-instruction break (segment code) (:declare (type (unsigned-byte 8) code)) (:printer byte-imm ((op #b11001100)) '(:name :tab code) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5b5082c6cbe682d5805630… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5b5082c6cbe682d5805630… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-95-fix-disassem-syntax] Make more mem access print out the size
by Raymond Toy 10 Jan '21

10 Jan '21

Raymond Toy pushed to branch issue-95-fix-disassem-syntax at cmucl / cmucl Commits: a99465d8 by Raymond Toy at 2021-01-10T11:06:53-08:00 Make more mem access print out the size But we don't want to do that for the LEA instruction. gcc doesn't require it and objdump doesn't print out a size. - - - - - 1 changed file: - src/compiler/x86/insts.lisp Changes: ===================================== src/compiler/x86/insts.lisp ===================================== @@ -797,7 +797,7 @@ (op :field (byte 7 1)) (width :field (byte 1 0) :type 'width) (reg/mem :fields (list (byte 2 14) (byte 3 8)) - :type 'reg/mem) + :type 'sized-reg/mem) (reg :field (byte 3 11) :type 'reg) ;; optional fields (imm)) @@ -835,7 +835,10 @@ (disassem:define-instruction-format (accum-reg/mem 16 :include 'reg/mem :default-printer '(:name :tab accum ", " reg/mem)) - (reg/mem :type 'reg/mem) ; don't need a size + ;; This format uses the accumulator, so the size is known; therefore + ;; we don't really need to print out the memory size, but let's do + ;; it for consistency. + (reg/mem :type 'sized-reg/mem) (accum :type 'accum)) ;;; Same as reg-reg/mem, but with a prefix of #b00001111 @@ -1132,7 +1135,8 @@ (error "Bogus args to XCHG: ~S ~S" operand1 operand2))))))) (define-instruction lea (segment dst src) - (:printer reg-reg/mem ((op #b1000110) (width 1))) + ;; Don't need to print out the width for the LEA instruction + (:printer reg-reg/mem ((op #b1000110) (width 1) (reg/mem nil :type 'reg/mem))) (:emitter (assert (dword-reg-p dst)) (emit-byte segment #b10001101) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a99465d8e3c6cb2f245b278… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a99465d8e3c6cb2f245b278… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-95-fix-disassem-syntax
by Raymond Toy 10 Jan '21

10 Jan '21

Raymond Toy pushed new branch issue-95-fix-disassem-syntax at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-95-fix-disassem-syn… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #91: Handle loop destructuring
by Raymond Toy 10 Jan '21

10 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 1144015f by Raymond Toy at 2021-01-10T04:33:03+00:00 Fix #91: Handle loop destructuring The destructuring shortcut in loop doesn't require all the parts be available. If they're not, each item is replaced by NIL. This is fixed by still using `destructuring-bind`, except we mark everything as optional. - - - - - 5b5082c6 by Raymond Toy at 2021-01-10T04:33:04+00:00 Merge branch 'issue-91-loop-destructuring-bind' into 'master' Fix #91: loop destructuring bind Closes #91 See merge request cmucl/cmucl!63 - - - - - 1 changed file: - src/code/loop.lisp Changes: ===================================== src/code/loop.lisp ===================================== @@ -995,7 +995,10 @@ collected result will be returned as the value of the LOOP." (if crocks (let ((*ignores* ())) (declare (special *ignores*)) - `((destructuring-bind ,(subst-gensyms-for-nil (car crocks)) + ;; Destructuring in loop doesn't require that the values be + ;; available. The missing elements are filled with NIL. So, + ;; make everything &optional + `((destructuring-bind (&optional ,@(subst-gensyms-for-nil (car crocks))) ,(cadr crocks) (declare (ignore ,@*ignores*)) ,@(loop-build-destructuring-bindings (cddr crocks) forms)))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/fdeafbc630fd3599062a68… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/fdeafbc630fd3599062a68… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-91-loop-destructuring-bind
by Raymond Toy 07 Jan '21

07 Jan '21

Raymond Toy pushed new branch issue-91-loop-destructuring-bind at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-91-loop-destructuri… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #93: Use our fork of ansi-test
by Raymond Toy 07 Jan '21

07 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: f993ea43 by Raymond Toy at 2021-01-06T17:11:03-08:00 Fix #93: Use our fork of ansi-test Instead of using the upstream ansi-test for CI, use our own fork. - - - - - fdeafbc6 by Raymond Toy at 2021-01-07T05:36:53+00:00 Merge branch 'issue-93-update-ansi-test-location' into 'master' Fix #93: Use our fork of ansi-test Closes #93 See merge request cmucl/cmucl!62 - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -57,7 +57,7 @@ linux:test: - job: linux:build artifacts: true before_script: - - git clone https://gitlab.common-lisp.net/ansi-test/ansi-test.git + - git clone https://gitlab.common-lisp.net/cmucl/ansi-test.git - (cd ansi-test; git checkout rtoy-cmucl-expected-failures) script: - bin/run-tests.sh -l dist/bin/lisp 2>&1 | tee test.log @@ -128,7 +128,7 @@ osx:test: - job: osx:build artifacts: true before_script: - - git clone https://gitlab.common-lisp.net/ansi-test/ansi-test.git + - git clone https://gitlab.common-lisp.net/cmucl/ansi-test.git - (cd ansi-test; git checkout rtoy-cmucl-expected-failures) script: - bin/run-tests.sh -l dist/bin/lisp 2>&1 | tee test.log View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/18a3be34f2a3cadebc9949… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/18a3be34f2a3cadebc9949… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-93-update-ansi-test-location
by Raymond Toy 07 Jan '21

07 Jan '21

Raymond Toy pushed new branch issue-93-update-ansi-test-location at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-93-update-ansi-test… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-89-update-page-flags
by Raymond Toy 04 Jan '21

04 Jan '21

Raymond Toy pushed new branch issue-89-update-page-flags at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-89-update-page-flags You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 3 commits: Fix #90: Remove unused FP static symbols on x86
by Raymond Toy 04 Jan '21

04 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 952c3759 by Raymond Toy at 2021-01-03T15:33:35-08:00 Fix #90: Remove unused FP static symbols on x86 We no longer support x87, so the static symbols for the long float constants aren't used anymore. And we don't use `*fp-constant-1d0*` anywhere, so we can remove the constants for 1f0 and 1d0. - - - - - 852e455b by Raymond Toy at 2021-01-04T09:18:59-08:00 Rename *fp-constant-0s0* to *fp-constant-0f0* Besides the obvious, we need to update genesis to fill in the slot with the correct value. - - - - - 18a3be34 by Raymond Toy at 2021-01-04T17:41:32+00:00 Merge branch 'issue-90-remove-unused-static-float-syms' into 'master' Fix #90: Remove unused FP static symbols on x86 Closes #90 See merge request cmucl/cmucl!60 - - - - - 4 changed files: - src/code/x86-vm.lisp - src/compiler/generic/new-genesis.lisp - src/compiler/x86/float-sse2.lisp - src/compiler/x86/parms.lisp Changes: ===================================== src/code/x86-vm.lisp ===================================== @@ -430,18 +430,8 @@ ;;; cases. Note these are initialise by genesis as they are needed ;;; early. ;;; -(defvar *fp-constant-0s0*) -(defvar *fp-constant-1s0*) +(defvar *fp-constant-0f0*) (defvar *fp-constant-0d0*) -(defvar *fp-constant-1d0*) -;;; The long-float constants. -(defvar *fp-constant-0l0*) -(defvar *fp-constant-1l0*) -(defvar *fp-constant-pi*) -(defvar *fp-constant-l2t*) -(defvar *fp-constant-l2e*) -(defvar *fp-constant-lg2*) -(defvar *fp-constant-ln2*) ;;; The current alien stack pointer; saved/restored for non-local ;;; exits. ===================================== src/compiler/generic/new-genesis.lisp ===================================== @@ -914,22 +914,8 @@ (macrolet ((frob (name pkg value) `(cold-setq (cold-intern (intern ,name ,pkg)) ,value))) (frob "*FP-CONSTANT-0D0*" "X86" (number-to-core 0d0)) - (frob "*FP-CONSTANT-1D0*" "X86" (number-to-core 1d0)) - (frob "*FP-CONSTANT-0S0*" "X86" (number-to-core 0s0)) - (frob "*FP-CONSTANT-1S0*" "X86" (number-to-core 1s0)) - #+long-float - (when (c:backend-featurep :long-float) - (frob "*FP-CONSTANT-0L0*" "X86" (number-to-core 0l0)) - (frob "*FP-CONSTANT-1L0*" "X86" (number-to-core 1l0)) - (frob "*FP-CONSTANT-PI*" "X86" (number-to-core pi)) - (frob "*FP-CONSTANT-L2T*" "X86" (number-to-core (log 10l0 2l0))) - (frob "*FP-CONSTANT-L2E*" "X86" - (number-to-core - (log 2.718281828459045235360287471352662L0 2l0))) - (frob "*FP-CONSTANT-LG2*" "X86" (number-to-core (log 2l0 10l0))) - (frob "*FP-CONSTANT-LN2*" "X86" - (number-to-core - (log 2l0 2.718281828459045235360287471352662L0)))) + (frob "*FP-CONSTANT-0F0*" "X86" (number-to-core 0f0)) + (when (c:backend-featurep :gencgc) (frob "*SCAVENGE-READ-ONLY-SPACE*" "X86" (cold-intern nil))))) ===================================== src/compiler/x86/float-sse2.lisp ===================================== @@ -449,7 +449,7 @@ (:results (y :scs (descriptor-reg))) (:generator 2 (ecase (c::constant-value (c::tn-leaf x)) - (0f0 (load-symbol-value y *fp-constant-0s0*)) + (0f0 (load-symbol-value y *fp-constant-0f0*)) #+nil (1f0 (load-symbol-value y *fp-constant-1s0*)) (0d0 (load-symbol-value y *fp-constant-0d0*)) ===================================== src/compiler/x86/parms.lisp ===================================== @@ -351,17 +351,7 @@ ;; The FP constants *fp-constant-0d0* - *fp-constant-1d0* - *fp-constant-0s0* - *fp-constant-1s0* - ;; Following are all long-floats. - *fp-constant-0l0* - *fp-constant-1l0* - *fp-constant-pi* - *fp-constant-l2t* - *fp-constant-l2e* - *fp-constant-lg2* - *fp-constant-ln2* + *fp-constant-0f0* ;; Multi-process support. *control-stacks* View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/e7916afe7c6ab7ef60abd4… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/e7916afe7c6ab7ef60abd4… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-90-remove-unused-static-float-syms] Rename *fp-constant-0s0* to *fp-constant-0f0*
by Raymond Toy 04 Jan '21

04 Jan '21

Raymond Toy pushed to branch issue-90-remove-unused-static-float-syms at cmucl / cmucl Commits: 852e455b by Raymond Toy at 2021-01-04T09:18:59-08:00 Rename *fp-constant-0s0* to *fp-constant-0f0* Besides the obvious, we need to update genesis to fill in the slot with the correct value. - - - - - 4 changed files: - src/code/x86-vm.lisp - src/compiler/generic/new-genesis.lisp - src/compiler/x86/float-sse2.lisp - src/compiler/x86/parms.lisp Changes: ===================================== src/code/x86-vm.lisp ===================================== @@ -430,7 +430,7 @@ ;;; cases. Note these are initialise by genesis as they are needed ;;; early. ;;; -(defvar *fp-constant-0s0*) +(defvar *fp-constant-0f0*) (defvar *fp-constant-0d0*) ;;; The current alien stack pointer; saved/restored for non-local ===================================== src/compiler/generic/new-genesis.lisp ===================================== @@ -914,22 +914,8 @@ (macrolet ((frob (name pkg value) `(cold-setq (cold-intern (intern ,name ,pkg)) ,value))) (frob "*FP-CONSTANT-0D0*" "X86" (number-to-core 0d0)) - (frob "*FP-CONSTANT-1D0*" "X86" (number-to-core 1d0)) - (frob "*FP-CONSTANT-0S0*" "X86" (number-to-core 0s0)) - (frob "*FP-CONSTANT-1S0*" "X86" (number-to-core 1s0)) - #+long-float - (when (c:backend-featurep :long-float) - (frob "*FP-CONSTANT-0L0*" "X86" (number-to-core 0l0)) - (frob "*FP-CONSTANT-1L0*" "X86" (number-to-core 1l0)) - (frob "*FP-CONSTANT-PI*" "X86" (number-to-core pi)) - (frob "*FP-CONSTANT-L2T*" "X86" (number-to-core (log 10l0 2l0))) - (frob "*FP-CONSTANT-L2E*" "X86" - (number-to-core - (log 2.718281828459045235360287471352662L0 2l0))) - (frob "*FP-CONSTANT-LG2*" "X86" (number-to-core (log 2l0 10l0))) - (frob "*FP-CONSTANT-LN2*" "X86" - (number-to-core - (log 2l0 2.718281828459045235360287471352662L0)))) + (frob "*FP-CONSTANT-0F0*" "X86" (number-to-core 0f0)) + (when (c:backend-featurep :gencgc) (frob "*SCAVENGE-READ-ONLY-SPACE*" "X86" (cold-intern nil))))) ===================================== src/compiler/x86/float-sse2.lisp ===================================== @@ -449,7 +449,7 @@ (:results (y :scs (descriptor-reg))) (:generator 2 (ecase (c::constant-value (c::tn-leaf x)) - (0f0 (load-symbol-value y *fp-constant-0s0*)) + (0f0 (load-symbol-value y *fp-constant-0f0*)) #+nil (1f0 (load-symbol-value y *fp-constant-1s0*)) (0d0 (load-symbol-value y *fp-constant-0d0*)) ===================================== src/compiler/x86/parms.lisp ===================================== @@ -351,7 +351,7 @@ ;; The FP constants *fp-constant-0d0* - *fp-constant-0s0* + *fp-constant-0f0* ;; Multi-process support. *control-stacks* View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/852e455b2a027776b8e50bd… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/852e455b2a027776b8e50bd… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-90-remove-unused-static-float-syms
by Raymond Toy 03 Jan '21

03 Jan '21

Raymond Toy pushed new branch issue-90-remove-unused-static-float-syms at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-90-remove-unused-st… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Address #89: Really remove *scavenge-read-only-space*
by Raymond Toy 03 Jan '21

03 Jan '21

Raymond Toy pushed to branch master at cmucl / cmucl Commits: cf7c8acc by Raymond Toy at 2021-01-03T14:19:39-08:00 Address #89: Really remove *scavenge-read-only-space* The previous changes didn't actually completely remove `*scavenge-read-only-space*`. We removed it from the static space, but it's also defined in `code/x86-vm.lisp` so we need to remove it from there as well. And we forgot to commit the boot file, so we're doing that now. - - - - - e7916afe by Raymond Toy at 2021-01-03T22:56:09+00:00 Merge branch 'issue-89-really-remove-scavenge-read-only' into 'master' Address #89: Really remove *scavenge-read-only-space* See merge request cmucl/cmucl!59 - - - - - 2 changed files: - + src/bootfiles/21d/boot-2020-04-1.lisp - src/code/x86-vm.lisp Changes: ===================================== src/bootfiles/21d/boot-2020-04-1.lisp ===================================== @@ -0,0 +1,12 @@ +;; Simple cross-compile script to remove `*scavenge-read-only-space*` +;; which is no longer needed +;; +;; Nothing special needs to be done for the cross-compile. Just use +;; this file for the -B option (not really necessary), and use the +;; standard cross-compile scripts in src/tools/cross-scripts. +;; +;; cross-build-world.sh -crl -B boot-2020-04-1 xtarget xcross src/tools/cross-scripts/cross-foo.lisp old-lisp +;; +;; x86: cross-x86-x86 +;; sparc: cross-sparc-sparc + ===================================== src/code/x86-vm.lisp ===================================== @@ -443,9 +443,6 @@ (defvar *fp-constant-lg2*) (defvar *fp-constant-ln2*) -;;; Enable/Disable scavenging of the read-only space. -(defvar *scavenge-read-only-space* nil) - ;;; The current alien stack pointer; saved/restored for non-local ;;; exits. (defvar *alien-stack*) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/b334db9faee003375a25f5… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/b334db9faee003375a25f5… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0