March 2026 - cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][issue-435-add-core-math-lisp-support] Address review comments
by Raymond Toy (＠rtoy) 04 Mar '26

04 Mar '26

Raymond Toy pushed to branch issue-435-add-core-math-lisp-support at cmucl / cmucl Commits: 06d942be by Raymond Toy at 2026-03-03T19:26:00-08:00 Address review comments Update exports.lisp. Add new file openlibm/e_log2f.c to get the function log2f and use it in irrat.c. This requires updating Config.x86_common too. - - - - - 4 changed files: - src/code/exports.lisp - src/lisp/Config.x86_common - src/lisp/irrat.c - + src/lisp/openlibm/e_log2f.c Changes: ===================================== src/code/exports.lisp ===================================== @@ -2190,7 +2190,30 @@ "STANDARD-PPRINT-DISPATCH-TABLE-MODIFIED-ERROR" "%IEEE754-REM-PI/2" - "%SINCOS") + "%SINCOS" + ;; Single-float functions + "%ACOSF" + "%ACOSHF" + "%ASINF" + "%ASINHF" + "%ATAN2F" + "%ATANF" + "%ATANHF" + "%COSF" + "%COSHF" + "%EXPF" + "%EXPM1F" + "%HYPOTF" + "%LOG10F" + "%LOG1PF" + "%LOG2F" + "%LOGF" + "%POWF" + "%SINF" + "%SINHF" + "%TANF" + "%TANHF" + ) #+heap-overflow-check (:export "DYNAMIC-SPACE-OVERFLOW-WARNING-HIT" "DYNAMIC-SPACE-OVERFLOW-ERROR-HIT" @@ -2227,30 +2250,7 @@ "DD-PI" "INVALID-CASE") #+random-xoroshiro - (:export "RANDOM-STATE-JUMP") - ;; Single-float functions - (:export "%ACOSF" - "%ACOSHF" - "%ASINF" - "%ASINHF" - "%ATAN2F" - "%ATANF" - "%ATANHF" - "%COSF" - "%COSHF" - "%EXPF" - "%EXPM1F" - "%HYPOTF" - "%LOG10F" - "%LOG1PF" - "%LOG2F" - "%LOGF" - "%POWF" - "%SINF" - "%SINHF" - "%TANF" - "%TANHF" - )) + (:export "RANDOM-STATE-JUMP")) (dolist (name ===================================== src/lisp/Config.x86_common ===================================== @@ -110,6 +110,7 @@ OPENLIBM_SRCS = \ $(OPENLIBM_DIR)/e_hypotf.c \ $(OPENLIBM_DIR)/e_log10f.c \ $(OPENLIBM_DIR)/e_logf.c \ + $(OPENLIBM_DIR)/e_log2f.c \ $(OPENLIBM_DIR)/e_powf.c \ $(OPENLIBM_DIR)/e_rem_pio2f.c \ $(OPENLIBM_DIR)/e_sinhf.c \ ===================================== src/lisp/irrat.c ===================================== @@ -596,6 +596,6 @@ lisp_log2f(float x) #ifdef FEATURE_CORE_MATH return cr_log2f(x); #else - return (float) fdlibm_log2((double) x); + return log2f(x); #endif } ===================================== src/lisp/openlibm/e_log2f.c ===================================== @@ -0,0 +1,85 @@ +/* + * ==================================================== + * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved. + * + * Developed at SunPro, a Sun Microsystems, Inc. business. + * Permission to use, copy, modify, and distribute this + * software is freely granted, provided that this notice + * is preserved. + * ==================================================== + */ + +#include "cdefs-compat.h" +//__FBSDID("$FreeBSD: src/lib/msun/src/e_log2f.c,v 1.5 2011/10/15 05:23:28 das Exp $"); + +/* + * Float version of e_log2.c. See the latter for most comments. + */ + +#include <openlibm_math.h> + +#include "math_private.h" +#include "k_logf.h" + +// VBS +#define float_t float + +static const float +two25 = 3.3554432000e+07, /* 0x4c000000 */ +ivln2hi = 1.4428710938e+00, /* 0x3fb8b000 */ +ivln2lo = -1.7605285393e-04; /* 0xb9389ad4 */ + +static const float zero = 0.0; + +OLM_DLLEXPORT float +__ieee754_log2f(float x) +{ + float f,hfsq,hi,lo,r,y; + int32_t i,k,hx; + + GET_FLOAT_WORD(hx,x); + + k=0; + if (hx < 0x00800000) { /* x < 2**-126 */ + if ((hx&0x7fffffff)==0) + return -two25/zero; /* log(+-0)=-inf */ + if (hx<0) return (x-x)/zero; /* log(-#) = NaN */ + k -= 25; x *= two25; /* subnormal number, scale up x */ + GET_FLOAT_WORD(hx,x); + } + if (hx >= 0x7f800000) return x+x; + if (hx == 0x3f800000) + return zero; /* log(1) = +0 */ + k += (hx>>23)-127; + hx &= 0x007fffff; + i = (hx+(0x4afb0d))&0x800000; + SET_FLOAT_WORD(x,hx|(i^0x3f800000)); /* normalize x or x/2 */ + k += (i>>23); + y = (float)k; + f = x - (float)1.0; + hfsq = (float)0.5*f*f; + r = k_log1pf(f); + + /* + * We no longer need to avoid falling into the multi-precision + * calculations due to compiler bugs breaking Dekker's theorem. + * Keep avoiding this as an optimization. See e_log2.c for more + * details (some details are here only because the optimization + * is not yet available in double precision). + * + * Another compiler bug turned up. With gcc on i386, + * (ivln2lo + ivln2hi) would be evaluated in float precision + * despite runtime evaluations using double precision. So we + * must cast one of its terms to float_t. This makes the whole + * expression have type float_t, so return is forced to waste + * time clobbering its extra precision. + */ + if (sizeof(float_t) > sizeof(float)) + return (r - hfsq + f) * ((float_t)ivln2lo + ivln2hi) + y; + + hi = f - hfsq; + GET_FLOAT_WORD(hx,hi); + SET_FLOAT_WORD(hi,hx&0xfffff000); + lo = (f - hi) - hfsq + r; + return (lo+hi)*ivln2lo + lo*ivln2hi + hi*ivln2hi + y; +} View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/06d942be90150dd2ab2a003… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/06d942be90150dd2ab2a003… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-435-add-core-math-lisp-support] Fix bad merge in lisp_expf
by Raymond Toy (＠rtoy) 03 Mar '26

03 Mar '26

Raymond Toy pushed to branch issue-435-add-core-math-lisp-support at cmucl / cmucl Commits: 54a53672 by Raymond Toy at 2026-03-03T08:28:42-08:00 Fix bad merge in lisp_expf Extra `#endif` removed. - - - - - 1 changed file: - src/lisp/irrat.c Changes: ===================================== src/lisp/irrat.c ===================================== @@ -504,7 +504,6 @@ lisp_expf(float x) #else return expf(x); #endif -#endif } float View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/54a53672b8c88b066fc13f4… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/54a53672b8c88b066fc13f4… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-435-add-core-math-lisp-support] 7 commits: Fix #479: Clean up macros in irrat.c
by Raymond Toy (＠rtoy) 03 Mar '26

03 Mar '26

Raymond Toy pushed to branch issue-435-add-core-math-lisp-support at cmucl / cmucl Commits: a225bbb5 by Raymond Toy at 2026-02-28T09:36:55-08:00 Fix #479: Clean up macros in irrat.c - - - - - 1a961701 by Raymond Toy at 2026-02-28T09:36:55-08:00 Merge branch 'issue-479-clean-up-irrat-signal-macros' into 'master' Fix #479: Clean up macros in irrat.c Closes #479 See merge request cmucl/cmucl!359 - - - - - 5cac5fa2 by Raymond Toy at 2026-03-02T08:32:39-08:00 Fix #485: Import openlibm single-float functions - - - - - 0418eaf3 by Raymond Toy at 2026-03-02T08:32:39-08:00 Merge branch 'issue-485-import-openlibm-single-float-functions' into 'master' Fix #485: Import openlibm single-float functions Closes #485 See merge request cmucl/cmucl!361 - - - - - 3b80b535 by Raymond Toy at 2026-03-02T11:28:59-08:00 Fix #484: Use openlibm single-float functions for lisp - - - - - 66c5af54 by Raymond Toy at 2026-03-02T11:28:59-08:00 Merge branch 'issue-484-use-openlibm' into 'master' Fix #484: Use openlibm single-float functions for lisp Closes #484 and #485 See merge request cmucl/cmucl!362 - - - - - ee3c0218 by Raymond Toy at 2026-03-03T07:50:58-08:00 Merge branch 'master' into issue-435-add-core-math-lisp-support - - - - - 39 changed files: - src/lisp/Config.x86_common - src/lisp/GNUmakefile - src/lisp/irrat.c - + src/lisp/openlibm/cdefs-compat.h - + src/lisp/openlibm/e_acosf.c - + src/lisp/openlibm/e_acoshf.c - + src/lisp/openlibm/e_asinf.c - + src/lisp/openlibm/e_atan2f.c - + src/lisp/openlibm/e_atanhf.c - + src/lisp/openlibm/e_coshf.c - + src/lisp/openlibm/e_expf.c - + src/lisp/openlibm/e_hypotf.c - + src/lisp/openlibm/e_log10f.c - + src/lisp/openlibm/e_logf.c - + src/lisp/openlibm/e_powf.c - + src/lisp/openlibm/e_rem_pio2f.c - + src/lisp/openlibm/e_sinhf.c - + src/lisp/openlibm/fpmath.h - + src/lisp/openlibm/i386_fpmath.h - + src/lisp/openlibm/k_cosf.c - + src/lisp/openlibm/k_expf.c - + src/lisp/openlibm/k_logf.h - + src/lisp/openlibm/k_sinf.c - + src/lisp/openlibm/k_tanf.c - + src/lisp/openlibm/math_private.h - + src/lisp/openlibm/math_private_openbsd.h - + src/lisp/openlibm/openlibm_complex.h - + src/lisp/openlibm/openlibm_defs.h - + src/lisp/openlibm/openlibm_math.h - + src/lisp/openlibm/s_asinhf.c - + src/lisp/openlibm/s_atanf.c - + src/lisp/openlibm/s_cosf.c - + src/lisp/openlibm/s_expm1f.c - + src/lisp/openlibm/s_log1pf.c - + src/lisp/openlibm/s_sincosf.c - + src/lisp/openlibm/s_sinf.c - + src/lisp/openlibm/s_tanf.c - + src/lisp/openlibm/s_tanhf.c - + src/lisp/openlibm/types-compat.h The diff was not included because it is too large. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/2ce06664397eeaa5de6557… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/2ce06664397eeaa5de6557… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #484: Use openlibm single-float functions for lisp
by Raymond Toy (＠rtoy) 02 Mar '26

02 Mar '26

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 3b80b535 by Raymond Toy at 2026-03-02T11:28:59-08:00 Fix #484: Use openlibm single-float functions for lisp - - - - - 66c5af54 by Raymond Toy at 2026-03-02T11:28:59-08:00 Merge branch 'issue-484-use-openlibm' into 'master' Fix #484: Use openlibm single-float functions for lisp Closes #484 and #485 See merge request cmucl/cmucl!362 - - - - - 3 changed files: - src/lisp/Config.x86_common - src/lisp/GNUmakefile - src/lisp/irrat.c Changes: ===================================== src/lisp/Config.x86_common ===================================== @@ -95,10 +95,49 @@ CORE_MATH_SRCS = $(CORE64_SRCS) $(CORE32_SRCS) endif +# If core-math is not defined such as on Darwin, we use the code from +# openlibm to implement the special functions for single-floats. +ifndef FEATURE_CORE_MATH +OPENLIBM_DIR = openlibm +OPENLIBM_SRCS = \ + $(OPENLIBM_DIR)/e_acosf.c \ + $(OPENLIBM_DIR)/e_acoshf.c \ + $(OPENLIBM_DIR)/e_asinf.c \ + $(OPENLIBM_DIR)/e_atan2f.c \ + $(OPENLIBM_DIR)/e_atanhf.c \ + $(OPENLIBM_DIR)/e_coshf.c \ + $(OPENLIBM_DIR)/e_expf.c \ + $(OPENLIBM_DIR)/e_hypotf.c \ + $(OPENLIBM_DIR)/e_log10f.c \ + $(OPENLIBM_DIR)/e_logf.c \ + $(OPENLIBM_DIR)/e_powf.c \ + $(OPENLIBM_DIR)/e_rem_pio2f.c \ + $(OPENLIBM_DIR)/e_sinhf.c \ + $(OPENLIBM_DIR)/k_cosf.c \ + $(OPENLIBM_DIR)/k_sinf.c \ + $(OPENLIBM_DIR)/k_tanf.c \ + $(OPENLIBM_DIR)/k_expf.c \ + $(OPENLIBM_DIR)/s_asinhf.c \ + $(OPENLIBM_DIR)/s_atanf.c \ + $(OPENLIBM_DIR)/s_cosf.c \ + $(OPENLIBM_DIR)/s_expm1f.c \ + $(OPENLIBM_DIR)/s_log1pf.c \ + $(OPENLIBM_DIR)/s_sinf.c \ + $(OPENLIBM_DIR)/s_sincosf.c \ + $(OPENLIBM_DIR)/s_tanf.c \ + $(OPENLIBM_DIR)/s_tanhf.c +endif + ifeq ($(filter 2% 3%, $(shell $(CC) -dumpversion)),) CPP_INCLUDE_OPTIONS := -iquote . -iquote $(PATH1) +ifndef FEATURE_CORE_MATH +CPP_INCLUDE_OPTIONS += -I $(PATH1)/$(OPENLIBM_DIR) -DOPENLIBM_USE_HOST_MATH_H +endif else -CPP_INCLUDE_OPTIONS := -I. -I$(PATH1) -I- +CPP_INCLUDE_OPTIONS := -I. -I$(PATH1) -I $(OPENLIBM_DIR) -I- +ifndef FEATURE_CORE_MATH +CPP_INCLUDE_OPTIONS += -I $(PATH1)/$(OPENLIBM_DIR) +endif endif CPPFLAGS := $(CPP_DEFINE_OPTIONS) $(CPP_INCLUDE_OPTIONS) ===================================== src/lisp/GNUmakefile ===================================== @@ -37,6 +37,7 @@ SRCS = lisp.c coreparse.c alloc.c monitor.c print.c interr.c \ runprog.c time.c case-mapping.c exec-init.c \ irrat.c \ ${CORE_MATH_SRCS} \ + ${OPENLIBM_SRCS} \ ${FDLIBM} ${ARCH_SRC} ${ASSEM_SRC} ${OS_SRC} ${GC_SRC} ===================================== src/lisp/irrat.c ===================================== @@ -54,6 +54,8 @@ extern float cr_hypotf(float, float); extern float cr_log1pf(float); extern float cr_expm1f(float); extern void cr_sincosf(float, float *, float *); +#else +#include "openlibm_math.h" #endif @@ -348,7 +350,7 @@ lisp_sinf(float x) #ifdef FEATURE_CORE_MATH return cr_sinf(x); #else - return (float) fdlibm_sin((double) x); + return sinf(x); #endif } @@ -358,7 +360,7 @@ lisp_cosf(float x) #ifdef FEATURE_CORE_MATH return cr_cosf(x); #else - return (float) fdlibm_cos((double) x); + return cosf(x); #endif } @@ -368,7 +370,7 @@ lisp_tanf(float x) #ifdef FEATURE_CORE_MATH return cr_tanf(x); #else - return (float) fdlibm_tan((double) x); + return tanf(x); #endif } @@ -378,7 +380,7 @@ lisp_atanf(float x) #ifdef FEATURE_CORE_MATH return cr_atanf(x); #else - return (float) fdlibm_atan((double) x); + return atanf(x); #endif } @@ -388,7 +390,7 @@ lisp_atan2f(float y, float x) #ifdef FEATURE_CORE_MATH return cr_atan2f(y, x); #else - return (float) __ieee754_atan2((double) y, (double) x); + return atan2f(y, x); #endif } @@ -398,7 +400,7 @@ lisp_asinf(float x) #ifdef FEATURE_CORE_MATH return cr_asinf(x); #else - return (float) __ieee754_asin((double) x); + return asinf(x); #endif } @@ -408,7 +410,7 @@ lisp_acosf(float x) #ifdef FEATURE_CORE_MATH return cr_acosf(x); #else - return (float) __ieee754_acos((double) x); + return acosf(x); #endif } @@ -418,7 +420,7 @@ lisp_sinhf(float x) #ifdef FEATURE_CORE_MATH return cr_sinhf(x); #else - return (float) __ieee754_sinh((double) x); + return sinhf(x); #endif } @@ -428,7 +430,7 @@ lisp_coshf(float x) #ifdef FEATURE_CORE_MATH return cr_coshf(x); #else - return (float) __ieee754_cosh((double) x); + return coshf(x); #endif } @@ -438,7 +440,7 @@ lisp_tanhf(float x) #ifdef FEATURE_CORE_MATH return cr_tanhf(x); #else - return (float) fdlibm_tanh((double) x); + return tanhf(x); #endif } @@ -448,7 +450,7 @@ lisp_asinhf(float x) #ifdef FEATURE_CORE_MATH return cr_asinhf(x); #else - return (float) fdlibm_asinh((double) x); + return asinhf((double) x); #endif } @@ -458,7 +460,7 @@ lisp_acoshf(float x) #ifdef FEATURE_CORE_MATH return cr_acoshf(x); #else - return (float) __ieee754_acosh((double) x); + return acoshf(x); #endif } @@ -468,7 +470,7 @@ lisp_atanhf(float x) #ifdef FEATURE_CORE_MATH return cr_atanhf(x); #else - return (float) __ieee754_atanh((double) x); + return atanhf(x); #endif } @@ -478,7 +480,7 @@ lisp_expf(float x) #ifdef FEATURE_CORE_MATH return cr_expf(x); #else - return (float) __ieee754_exp((double) x); + return expf(x); #endif } @@ -488,7 +490,7 @@ lisp_logf(float x) #ifdef FEATURE_CORE_MATH return cr_logf(x); #else - return (float) __ieee754_log((double) x); + return log(x); #endif } @@ -498,7 +500,7 @@ lisp_log10f(float x) #ifdef FEATURE_CORE_MATH return cr_log10f(x); #else - return (float) __ieee754_log10((double) x); + return log10f(x); #endif } @@ -520,7 +522,7 @@ lisp_powf(float x, float y) * just use fdlibm for now until we can figure out what's causing * the failure. */ - return (float) __ieee754_pow((double) x, (double) y); + return pow(x, y); #endif } @@ -530,7 +532,7 @@ lisp_hypotf(float x, float y) #ifdef FEATURE_CORE_MATH return cr_hypotf(x, y); #else - return (float) __ieee754_hypot((double) x, (double) y); + return hypotf(x, y); #endif } @@ -540,7 +542,7 @@ lisp_log1pf(float x) #ifdef FEATURE_CORE_MATH return cr_log1pf(x); #else - return (float) fdlibm_log1p((double) x); + return log1pf(x); #endif } @@ -550,7 +552,7 @@ lisp_expm1f(float x) #ifdef FEATURE_CORE_MATH return cr_expm1f(x); #else - return (float) fdlibm_expm1((double) x); + return expm1f(x); #endif } @@ -560,11 +562,8 @@ lisp_sincosf(float x, float *s, float *c) #ifdef FEATURE_CORE_MATH cr_sincosf(x, s, c); #else - extern void cmucl_sincos(double, double*, double*); - double ds, dc; - - cmucl_sincos((double) x, &ds, &dc); - *s = (float) ds; - *c = (float) dc; + extern void sincosf(float x, float *s, float *c); + + sincosf(x, s, c); #endif } View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/0418eaf3371f98d907dfd9… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/0418eaf3371f98d907dfd9… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-484-use-openlibm] Use -I instead of -isystem
by Raymond Toy (＠rtoy) 02 Mar '26

02 Mar '26

Raymond Toy pushed to branch issue-484-use-openlibm at cmucl / cmucl Commits: d460d570 by Raymond Toy at 2026-03-02T08:59:01-08:00 Use -I instead of -isystem - - - - - 1 changed file: - src/lisp/Config.x86_common Changes: ===================================== src/lisp/Config.x86_common ===================================== @@ -131,7 +131,7 @@ endif ifeq ($(filter 2% 3%, $(shell $(CC) -dumpversion)),) CPP_INCLUDE_OPTIONS := -iquote . -iquote $(PATH1) ifndef FEATURE_CORE_MATH -CPP_INCLUDE_OPTIONS += -isystem $(PATH1)/$(OPENLIBM_DIR) -DOPENLIBM_USE_HOST_MATH_H +CPP_INCLUDE_OPTIONS += -I $(PATH1)/$(OPENLIBM_DIR) -DOPENLIBM_USE_HOST_MATH_H endif else CPP_INCLUDE_OPTIONS := -I. -I$(PATH1) -I $(OPENLIBM_DIR) -I- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d460d570098836f125f7c4f… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d460d570098836f125f7c4f… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-484-use-openlibm] 3 commits: Fix #485: Import openlibm single-float functions
by Raymond Toy (＠rtoy) 02 Mar '26

02 Mar '26

Raymond Toy pushed to branch issue-484-use-openlibm at cmucl / cmucl Commits: 5cac5fa2 by Raymond Toy at 2026-03-02T08:32:39-08:00 Fix #485: Import openlibm single-float functions - - - - - 0418eaf3 by Raymond Toy at 2026-03-02T08:32:39-08:00 Merge branch 'issue-485-import-openlibm-single-float-functions' into 'master' Fix #485: Import openlibm single-float functions Closes #485 See merge request cmucl/cmucl!361 - - - - - 69a5b1a5 by Raymond Toy at 2026-03-02T08:44:52-08:00 Merge branch 'master' into issue-484-use-openlibm - - - - - 0 changed files: Changes: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/32e491a1dcd862a1610ff8… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/32e491a1dcd862a1610ff8… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #485: Import openlibm single-float functions
by Raymond Toy (＠rtoy) 02 Mar '26

02 Mar '26

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 5cac5fa2 by Raymond Toy at 2026-03-02T08:32:39-08:00 Fix #485: Import openlibm single-float functions - - - - - 0418eaf3 by Raymond Toy at 2026-03-02T08:32:39-08:00 Merge branch 'issue-485-import-openlibm-single-float-functions' into 'master' Fix #485: Import openlibm single-float functions Closes #485 See merge request cmucl/cmucl!361 - - - - - 36 changed files: - + src/lisp/openlibm/cdefs-compat.h - + src/lisp/openlibm/e_acosf.c - + src/lisp/openlibm/e_acoshf.c - + src/lisp/openlibm/e_asinf.c - + src/lisp/openlibm/e_atan2f.c - + src/lisp/openlibm/e_atanhf.c - + src/lisp/openlibm/e_coshf.c - + src/lisp/openlibm/e_expf.c - + src/lisp/openlibm/e_hypotf.c - + src/lisp/openlibm/e_log10f.c - + src/lisp/openlibm/e_logf.c - + src/lisp/openlibm/e_powf.c - + src/lisp/openlibm/e_rem_pio2f.c - + src/lisp/openlibm/e_sinhf.c - + src/lisp/openlibm/fpmath.h - + src/lisp/openlibm/i386_fpmath.h - + src/lisp/openlibm/k_cosf.c - + src/lisp/openlibm/k_expf.c - + src/lisp/openlibm/k_logf.h - + src/lisp/openlibm/k_sinf.c - + src/lisp/openlibm/k_tanf.c - + src/lisp/openlibm/math_private.h - + src/lisp/openlibm/math_private_openbsd.h - + src/lisp/openlibm/openlibm_complex.h - + src/lisp/openlibm/openlibm_defs.h - + src/lisp/openlibm/openlibm_math.h - + src/lisp/openlibm/s_asinhf.c - + src/lisp/openlibm/s_atanf.c - + src/lisp/openlibm/s_cosf.c - + src/lisp/openlibm/s_expm1f.c - + src/lisp/openlibm/s_log1pf.c - + src/lisp/openlibm/s_sincosf.c - + src/lisp/openlibm/s_sinf.c - + src/lisp/openlibm/s_tanf.c - + src/lisp/openlibm/s_tanhf.c - + src/lisp/openlibm/types-compat.h The diff was not included because it is too large. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/1a961701b3d332206f3e88… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/1a961701b3d332206f3e88… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-485-import-openlibm-single-float-functions] Address review comments
by Raymond Toy (＠rtoy) 02 Mar '26

02 Mar '26

Raymond Toy pushed to branch issue-485-import-openlibm-single-float-functions at cmucl / cmucl Commits: 9b4cb111 by Raymond Toy at 2026-03-02T07:34:32-08:00 Address review comments Undo changes to GNUmakefile and Config.x86_common. Thus, this MR is just adding the openlibm files. - - - - - 2 changed files: - src/lisp/Config.x86_common - src/lisp/GNUmakefile Changes: ===================================== src/lisp/Config.x86_common ===================================== @@ -95,49 +95,10 @@ CORE_MATH_SRCS = $(CORE64_SRCS) $(CORE32_SRCS) endif -# If core-math is not defined such as on Darwin, we use the code from -# openlibm to implement the special functions for single-floats. -ifndef FEATURE_CORE_MATH -OPENLIBM_DIR = openlibm -OPENLIBM_SRCS = \ - $(OPENLIBM_DIR)/e_acosf.c \ - $(OPENLIBM_DIR)/e_acoshf.c \ - $(OPENLIBM_DIR)/e_asinf.c \ - $(OPENLIBM_DIR)/e_atan2f.c \ - $(OPENLIBM_DIR)/e_atanhf.c \ - $(OPENLIBM_DIR)/e_coshf.c \ - $(OPENLIBM_DIR)/e_expf.c \ - $(OPENLIBM_DIR)/e_hypotf.c \ - $(OPENLIBM_DIR)/e_log10f.c \ - $(OPENLIBM_DIR)/e_logf.c \ - $(OPENLIBM_DIR)/e_powf.c \ - $(OPENLIBM_DIR)/e_rem_pio2f.c \ - $(OPENLIBM_DIR)/e_sinhf.c \ - $(OPENLIBM_DIR)/k_cosf.c \ - $(OPENLIBM_DIR)/k_sinf.c \ - $(OPENLIBM_DIR)/k_tanf.c \ - $(OPENLIBM_DIR)/k_expf.c \ - $(OPENLIBM_DIR)/s_asinhf.c \ - $(OPENLIBM_DIR)/s_atanf.c \ - $(OPENLIBM_DIR)/s_cosf.c \ - $(OPENLIBM_DIR)/s_expm1f.c \ - $(OPENLIBM_DIR)/s_log1pf.c \ - $(OPENLIBM_DIR)/s_sinf.c \ - $(OPENLIBM_DIR)/s_sincosf.c \ - $(OPENLIBM_DIR)/s_tanf.c \ - $(OPENLIBM_DIR)/s_tanhf.c -endif - ifeq ($(filter 2% 3%, $(shell $(CC) -dumpversion)),) CPP_INCLUDE_OPTIONS := -iquote . -iquote $(PATH1) -ifndef FEATURE_CORE_MATH -CPP_INCLUDE_OPTIONS += -isystem $(PATH1)/$(OPENLIBM_DIR) -DOPENLIBM_USE_HOST_MATH_H -endif else -CPP_INCLUDE_OPTIONS := -I. -I$(PATH1) -I $(OPENLIBM_DIR) -I- -ifndef FEATURE_CORE_MATH -CPP_INCLUDE_OPTIONS += -I $(PATH1)/$(OPENLIBM_DIR) -endif +CPP_INCLUDE_OPTIONS := -I. -I$(PATH1) -I- endif CPPFLAGS := $(CPP_DEFINE_OPTIONS) $(CPP_INCLUDE_OPTIONS) ===================================== src/lisp/GNUmakefile ===================================== @@ -37,7 +37,6 @@ SRCS = lisp.c coreparse.c alloc.c monitor.c print.c interr.c \ runprog.c time.c case-mapping.c exec-init.c \ irrat.c \ ${CORE_MATH_SRCS} \ - ${OPENLIBM_SRCS} \ ${FDLIBM} ${ARCH_SRC} ${ASSEM_SRC} ${OS_SRC} ${GC_SRC} View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9b4cb111c22b791587b4775… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9b4cb111c22b791587b4775… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-484-use-openlibm] Fix build problems
by Raymond Toy (＠rtoy) 02 Mar '26

02 Mar '26

Raymond Toy pushed to branch issue-484-use-openlibm at cmucl / cmucl Commits: 32e491a1 by Raymond Toy at 2026-03-01T17:40:20-08:00 Fix build problems With core-math enabled, we need math.h. Without it openlibm_math.h is enough because it will include math.h. Remove the openlibm extern declarations we added. They were wrong and aren't needed since we don't use those names anyway. - - - - - 1 changed file: - src/lisp/irrat.c Changes: ===================================== src/lisp/irrat.c ===================================== @@ -9,8 +9,8 @@ #include "internals.h" #include "fdlibm.h" -#include "openlibm_math.h" #ifdef FEATURE_CORE_MATH +#include <math.h> extern double cr_sin(double); extern double cr_cos(double); extern double cr_tan(double); @@ -55,18 +55,7 @@ extern float cr_log1pf(float); extern float cr_expm1f(float); extern void cr_sincosf(float, float *, float *); #else -extern float __ieee754_atan2f(float y, float x); -extern float __ieee754_asinf(float x); -extern float __ieee754_acosf(float x); -extern float __ieee754_acoshf(float x); -extern float __ieee754_atanhf(float x); -extern float __ieee754_sinhf(float x); -extern float __ieee754_coshf(float x); -extern float __ieee754_tanhf(float x); -extern float __ieee754_expf(float x); -extern float __ieee754_log10f(float x); -extern float __ieee754_hypotf(float x, float y); -extern float __ieee754_expf(float x); +#include "openlibm_math.h" #endif View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/32e491a1dcd862a1610ff85… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/32e491a1dcd862a1610ff85… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-484-use-openlibm
by Raymond Toy (＠rtoy) 01 Mar '26

01 Mar '26

Raymond Toy pushed new branch issue-484-use-openlibm at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-484-use-openlibm You're receiving this email because of your account on gitlab.common-lisp.net.

1 0