- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl] Pushed new branch issue-489-update-gitlab-to-extends-syntax
by Raymond Toy (＠rtoy) 11 Mar '26

11 Mar '26

Raymond Toy pushed new branch issue-489-update-gitlab-to-extends-syntax at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-489-update-gitlab-t… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-478-run-analyzer-link-chcker-on-schedule] Allow analyzer and link-checker to run when RUN_CHECKS var is set
by Raymond Toy (＠rtoy) 11 Mar '26

11 Mar '26

Raymond Toy pushed to branch issue-478-run-analyzer-link-chcker-on-schedule at cmucl / cmucl Commits: 9090260c by Raymond Toy at 2026-03-11T16:17:13-07:00 Allow analyzer and link-checker to run when RUN_CHECKS var is set When the variable RUN_CHECKS is set to any value, the analyzer and link-checker are run. This can be can set it as a pipeline variable when triggering a pipeline manually via the GitLab UI, via the API, or by defining it in a scheduled pipeline's variable list. - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -302,6 +302,7 @@ linux:static-analyzer: artifacts: true rules: - if: $CI_PIPELINE_SOURCE == "schedule" + - if: $RUN_CHECKS - when: manual allow_failure: true script: @@ -370,6 +371,7 @@ markdown-link-check: needs: [] rules: - if: $CI_PIPELINE_SOURCE == "schedule" + - if: $RUN_CHECKS - when: manual allow_failure: true script: @@ -380,3 +382,4 @@ markdown-link-check: # https://gitlab.com/gitlab-org/gitlab/-/issues/17845. - git clone https://gitlab.common-lisp.net/cmucl/cmucl.wiki.git - find cmucl.wiki -name \*.md -print0 | xargs -0 -n1 markdown-link-check + View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9090260c0ef06d3b6d63f54… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9090260c0ef06d3b6d63f54… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-478-run-analyzer-link-chcker-on-schedule] Make link-checker independent of any previous stage
by Raymond Toy (＠rtoy) 11 Mar '26

11 Mar '26

Raymond Toy pushed to branch issue-478-run-analyzer-link-chcker-on-schedule at cmucl / cmucl Commits: 4c62881f by Raymond Toy at 2026-03-11T16:05:53-07:00 Make link-checker independent of any previous stage The link checker doesn't depend on anything, so make that explicit so it can be run manually at any time. We also noticed that linux cross-build was depending on the linux build stage. As the comment says, this was true for #337, but we don't need that anymore. Remove the comment and the dependency. We only depend on linux install now. - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -171,13 +171,7 @@ linux:cross-build: CONFIG: "x86_linux" needs: - - # Normally need the linux:install stage to get the compiler to - # use. But for #337, we need the normal build from linux:build to - # do the cross-compile. Once the snapshot is made, we can use - # linux:install instead. - - job: linux:build - #- job: linux:install + - job: linux:install artifacts: true script: - bin/create-target.sh xtarget $CONFIG @@ -372,6 +366,8 @@ markdown-link-check: # It's ok if this fails; we don't want to declare the entire # pipeline as having failed. allow_failure: true + # This job doesn't depend on any others. + needs: [] rules: - if: $CI_PIPELINE_SOURCE == "schedule" - when: manual @@ -384,4 +380,3 @@ markdown-link-check: # https://gitlab.com/gitlab-org/gitlab/-/issues/17845. - git clone https://gitlab.common-lisp.net/cmucl/cmucl.wiki.git - find cmucl.wiki -name \*.md -print0 | xargs -0 -n1 markdown-link-check - View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/4c62881fa001d26564576d5… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/4c62881fa001d26564576d5… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-478-run-analyzer-link-chcker-on-schedule] Restore comments
by Raymond Toy (＠rtoy) 11 Mar '26

11 Mar '26

Raymond Toy pushed to branch issue-478-run-analyzer-link-chcker-on-schedule at cmucl / cmucl Commits: d14f058d by Raymond Toy at 2026-03-11T15:09:34-07:00 Restore comments These were accidentally removed. - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -21,6 +21,8 @@ workflow: - if: $CI_COMMIT_BRANCH - if: $CI_COMMIT_TAG +# Default install configuration to download the cmucl tarballs to use +# for building. .install_template: &install_configuration stage: install artifacts: @@ -29,12 +31,20 @@ workflow: script: - echo PATH = $PATH - ls -F /usr/local/bin + # Make sure gitlab-runner is available because it's needed by the + # VM to upload artifacts. - type -all gitlab-runner + # Download binaries. (Do we really need the extras tarball?) - $CURL -o cmucl-$version-$osname.tar.$tar_ext $download_url/cmucl-$version-$osname.tar.$tar_ext - $CURL -o cmucl-$version-$osname.extra.tar.$tar_ext $download_url/cmucl-$version-$osname.extra.tar.$tar_ext - mkdir snapshot - (cd snapshot; tar xf ../cmucl-$version-$osname.tar.$tar_ext; tar xf ../cmucl-$version-$osname.extra.tar.$tar_ext) +# Default build configuration to be added to each build stage for each +# OS. This assumes we don't need anything special between OSes, and +# the option '-C ""' is good enough. We also override the default +# build dirs by using the -b option so that we know where the results +# are, independent of OS. .build_template: &build_configuration stage: build artifacts: @@ -44,14 +54,30 @@ workflow: - build-3/*.log - build-4/ - cmucl* + # Needed by Linux analyzer stage - src/lisp/cmucl-version.h + # Save this so we can see the generated errno - src/code/errno.lisp script: + # Do cross compile first + #- bin/create-target.sh xtarget x86_linux_clang + #- bin/create-target.sh xcross x86_linux_clang + #- bin/cross-build-world.sh -crl -B boot-2020-04-1 xtarget xcross src/tools/cross-scripts/cross-x86-x86.lisp snapshot/bin/lisp + # Regular build using the cross-compiled result or snapshot. The + # analyzer job requires gcc, so make sure we build with gcc here + # instead of clang. + # + # Set CONFIG in appropriately each build. - bin/build.sh $bootstrap -b build -R -C $CONFIG -o snapshot/bin/lisp + # When the result of `git describe` cannot be used as a version + # string, an alternative can be provided with the -V flag + # The following stages need this to run tests and such. - sh -x bin/git-version.sh - bin/make-dist.sh -I dist build-4 + # Also make some tarballs so it's easy to download the artifacts. - bin/make-dist.sh -S build-4 +# Default configuration for running the ansi-tests. .ansi_test_template: &ansi_test_configuration stage: ansi-test artifacts: @@ -61,6 +87,7 @@ workflow: - bin/run-ansi-tests.sh -l dist/bin/lisp - cp ../ansi-test/test.out ansi-test.out +# Default configuration for running unit tests. .unit_test_template: &unit_test_configuration stage: test artifacts: @@ -70,13 +97,19 @@ workflow: - echo LANG = $LANG - bin/run-unit-tests.sh -l dist/bin/lisp 2>&1 | tee test.log +# Default configuration to test creation of lisp executable and +# testing the exectuable works. .exec_test_template: &exec_test_configuration stage: test script: + # Create an executable and test it by printing the version. - dist/bin/lisp -eval '(save-lisp "saved-lisp-executable" :executable t)' - ./saved-lisp-executable --version + # Run the unit tests with the executable, just to make sure the + # executable works as expected. - bin/run-unit-tests.sh -l ./saved-lisp-executable +# Default configuration for running the benchmarks. .benchmark_template: &benchmark_configuration stage: benchmark artifacts: @@ -88,7 +121,7 @@ workflow: - CMUCL=../../snapshot/bin/lisp ./run-cmucl.sh - CMUCL=../../dist/bin/lisp ./run-cmucl.sh - ../../snapshot/bin/lisp -load report - + stages: - install - build @@ -117,6 +150,8 @@ linux:build: - job: linux:install artifacts: true variables: + # Fedora 41 must build with gcc because the clang build fails some + # ansi-tests. See [#469]. CONFIG: "x86_linux" linux:cross-build: @@ -129,11 +164,20 @@ linux:cross-build: - linux-2/*.log - linux-3/*.log - linux-4/*.log + # The lisp directory is needed for the static analyzer job. - linux-4/lisp variables: + # This must match the config used for the linux build! CONFIG: "x86_linux" + needs: + + # Normally need the linux:install stage to get the compiler to + # use. But for #337, we need the normal build from linux:build to + # do the cross-compile. Once the snapshot is made, we can use + # linux:install instead. - job: linux:build + #- job: linux:install artifacts: true script: - bin/create-target.sh xtarget $CONFIG @@ -147,6 +191,7 @@ linux:test: tags: - linux needs: + # Needs artifacts from build (dist/) - job: linux:build artifacts: true @@ -167,6 +212,7 @@ linux:cross-test: - ansi-test/test.out - cross-test.log needs: + # Needs artifacts from build (dist/) - job: linux:cross-build artifacts: true script: @@ -177,14 +223,16 @@ linux:ansi-test: tags: - linux needs: + # Needs artifacts from build (dist/) - job: linux:build artifacts: true - + linux:benchmark: <<: *benchmark_configuration tags: - linux needs: + # Needs artifacts from install (snapshot/) and build (dist/) - job: linux:install artifacts: true - job: linux:build @@ -213,6 +261,7 @@ osx:test: tags: - macos-virtualbox needs: + # Needs artifacts from build (dist/) - job: osx:build artifacts: true @@ -223,23 +272,51 @@ osx:exec-test: needs: - job: osx:build artifacts: true - + osx:ansi-test: <<: *ansi_test_configuration tags: - macos-virtualbox needs: + # Needs artifacts from build (dist/) - job: osx:build artifacts: true - + osx:benchmark: <<: *benchmark_configuration tags: - macos-virtualbox needs: + # Needs artifacts from install (snapshot/) and build (dist/) - job: osx:install artifacts: true - - job: osx:build + - job: osx:build + +# Optional job that runs the static analyzer. It needs the files from +# the linux-4 directory built in the linux:build job. +linux:static-analyzer: + stage: analyze + + tags: + - linux + artifacts: + when: always + paths: + - analyzer.log + needs: + - job: linux:build + artifacts: true + rules: + - if: $CI_PIPELINE_SOURCE == "schedule" + - when: manual + allow_failure: true + script: + # Analysis can generate huge amounts of output. For now just save + # the results to the log file instead of also having it go to the + # console. If someday there's less or no output, we can consider + # having the logs go to the console too. + - make -C build-4/lisp clean + - make -C build-4/lisp ANALYZER=-fanalyzer > analyzer.log 2>&1 #### OpenSUSE jobs #### ubuntu:install: @@ -258,6 +335,9 @@ ubuntu:build: - job: ubuntu:install artifacts: true variables: + # Build with gcc on Ubuntu 25.10. It produces a lisp than passes + # the ansi-tests. Clang seems to fail the ansi-tests WRITE.1, + # PRINT.1, and friends when cr_pow is used. CONFIG: "x86_linux" ubuntu:test: @@ -265,6 +345,7 @@ ubuntu:test: tags: - ubuntu needs: + # Needs artifacts from build (dist/) - job: ubuntu:build artifacts: true @@ -273,39 +354,34 @@ ubuntu:ansi-test: tags: - ubuntu needs: + # Needs artifacts from build (dist/) - job: ubuntu:build artifacts: true -linux:static-analyzer: - stage: analyze - tags: - - linux - artifacts: - when: always - paths: - - analyzer.log - needs: - - job: linux:build - artifacts: true - rules: - - if: $CI_PIPELINE_SOURCE == "schedule" - - when: manual - allow_failure: true - script: - - make -C build-4/lisp clean - - make -C build-4/lisp ANALYZER=-fanalyzer > analyzer.log 2>&1 - +# Optional job that runs the markdown link checker. This is optional +# because it's very slow, of course; you have to run it manually. +# +# From https://github.com/tcort/markdown-link-check +# Checks links on the wiki pages whenever any wiki markdown pages change. markdown-link-check: stage: markdown-link-check + + # Only the linux runner has markdown-link-check installed tags: - linux + # It's ok if this fails; we don't want to declare the entire + # pipeline as having failed. allow_failure: true rules: - if: $CI_PIPELINE_SOURCE == "schedule" - when: manual allow_failure: true script: + # Check links in the main repo - find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check + # Clone the wiki pages and check the links there. Lots of + # failures here because of + # https://gitlab.com/gitlab-org/gitlab/-/issues/17845. - git clone https://gitlab.common-lisp.net/cmucl/cmucl.wiki.git - find cmucl.wiki -name \*.md -print0 | xargs -0 -n1 markdown-link-check View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d14f058d28a2aeefab700dc… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d14f058d28a2aeefab700dc… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-478-run-analyzer-link-chcker-on-schedule] Use workflow rules to limit pipelines
by Raymond Toy (＠rtoy) 11 Mar '26

11 Mar '26

Raymond Toy pushed to branch issue-478-run-analyzer-link-chcker-on-schedule at cmucl / cmucl Commits: d69ccb8a by Raymond Toy at 2026-03-11T14:56:56-07:00 Use workflow rules to limit pipelines Let's see if this works. - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -9,8 +9,18 @@ variables: tar_ext: "xz" bootstrap: "" -# Default install configuration to download the cmucl tarballs to use -# for building. +workflow: + rules: + # Always run on schedules (for analyze and markdown-link-check stages) + - if: $CI_PIPELINE_SOURCE == "schedule" + # Run on merge requests + - if: $CI_PIPELINE_SOURCE == "merge_request_event" + # Don't create a branch pipeline when an MR pipeline already exists + - if: $CI_COMMIT_BRANCH && $CI_OPEN_MERGE_REQUESTS + when: never + - if: $CI_COMMIT_BRANCH + - if: $CI_COMMIT_TAG + .install_template: &install_configuration stage: install artifacts: @@ -19,20 +29,12 @@ variables: script: - echo PATH = $PATH - ls -F /usr/local/bin - # Make sure gitlab-runner is available because it's needed by the - # VM to upload artifacts. - type -all gitlab-runner - # Download binaries. (Do we really need the extras tarball?) - $CURL -o cmucl-$version-$osname.tar.$tar_ext $download_url/cmucl-$version-$osname.tar.$tar_ext - $CURL -o cmucl-$version-$osname.extra.tar.$tar_ext $download_url/cmucl-$version-$osname.extra.tar.$tar_ext - mkdir snapshot - (cd snapshot; tar xf ../cmucl-$version-$osname.tar.$tar_ext; tar xf ../cmucl-$version-$osname.extra.tar.$tar_ext) -# Default build configuration to be added to each build stage for each -# OS. This assumes we don't need anything special between OSes, and -# the option '-C ""' is good enough. We also override the default -# build dirs by using the -b option so that we know where the results -# are, independent of OS. .build_template: &build_configuration stage: build artifacts: @@ -42,30 +44,14 @@ variables: - build-3/*.log - build-4/ - cmucl* - # Needed by Linux analyzer stage - src/lisp/cmucl-version.h - # Save this so we can see the generated errno - src/code/errno.lisp script: - # Do cross compile first - #- bin/create-target.sh xtarget x86_linux_clang - #- bin/create-target.sh xcross x86_linux_clang - #- bin/cross-build-world.sh -crl -B boot-2020-04-1 xtarget xcross src/tools/cross-scripts/cross-x86-x86.lisp snapshot/bin/lisp - # Regular build using the cross-compiled result or snapshot. The - # analyzer job requires gcc, so make sure we build with gcc here - # instead of clang. - # - # Set CONFIG in appropriately each build. - bin/build.sh $bootstrap -b build -R -C $CONFIG -o snapshot/bin/lisp - # When the result of `git describe` cannot be used as a version - # string, an alternative can be provided with the -V flag - # The following stages need this to run tests and such. - sh -x bin/git-version.sh - bin/make-dist.sh -I dist build-4 - # Also make some tarballs so it's easy to download the artifacts. - bin/make-dist.sh -S build-4 -# Default configuration for running the ansi-tests. .ansi_test_template: &ansi_test_configuration stage: ansi-test artifacts: @@ -75,7 +61,6 @@ variables: - bin/run-ansi-tests.sh -l dist/bin/lisp - cp ../ansi-test/test.out ansi-test.out -# Default configuration for running unit tests. .unit_test_template: &unit_test_configuration stage: test artifacts: @@ -85,19 +70,13 @@ variables: - echo LANG = $LANG - bin/run-unit-tests.sh -l dist/bin/lisp 2>&1 | tee test.log -# Default configuration to test creation of lisp executable and -# testing the exectuable works. .exec_test_template: &exec_test_configuration stage: test script: - # Create an executable and test it by printing the version. - dist/bin/lisp -eval '(save-lisp "saved-lisp-executable" :executable t)' - ./saved-lisp-executable --version - # Run the unit tests with the executable, just to make sure the - # executable works as expected. - bin/run-unit-tests.sh -l ./saved-lisp-executable -# Default configuration for running the benchmarks. .benchmark_template: &benchmark_configuration stage: benchmark artifacts: @@ -109,7 +88,7 @@ variables: - CMUCL=../../snapshot/bin/lisp ./run-cmucl.sh - CMUCL=../../dist/bin/lisp ./run-cmucl.sh - ../../snapshot/bin/lisp -load report - + stages: - install - build @@ -129,15 +108,6 @@ linux:install: variables: osname: "linux" CURL: "curl" - rules: - # 1. Ensure build runs for schedules so the analyzer can use its files - - if: $CI_PIPELINE_SOURCE == "schedule" - when: on_success - # 2. Ensure build runs if the analyzer variable is set - - if: $RUN_ANALYSIS - when: on_success - # 3. Default: run for standard pushes/MRs - - when: on_success linux:build: <<: *build_configuration @@ -147,18 +117,7 @@ linux:build: - job: linux:install artifacts: true variables: - # Fedora 41 must build with gcc because the clang build fails some - # ansi-tests. See [#469]. CONFIG: "x86_linux" - rules: - # 1. Ensure build runs for schedules so the analyzer can use its files - - if: $CI_PIPELINE_SOURCE == "schedule" - when: on_success - # 2. Ensure build runs if the analyzer variable is set - - if: $RUN_ANALYSIS - when: on_success - # 3. Default: run for standard pushes/MRs - - when: on_success linux:cross-build: stage: build @@ -170,20 +129,11 @@ linux:cross-build: - linux-2/*.log - linux-3/*.log - linux-4/*.log - # The lisp directory is needed for the static analyzer job. - linux-4/lisp variables: - # This must match the config used for the linux build! CONFIG: "x86_linux" - needs: - - # Normally need the linux:install stage to get the compiler to - # use. But for #337, we need the normal build from linux:build to - # do the cross-compile. Once the snapshot is made, we can use - # linux:install instead. - job: linux:build - #- job: linux:install artifacts: true script: - bin/create-target.sh xtarget $CONFIG @@ -197,7 +147,6 @@ linux:test: tags: - linux needs: - # Needs artifacts from build (dist/) - job: linux:build artifacts: true @@ -218,7 +167,6 @@ linux:cross-test: - ansi-test/test.out - cross-test.log needs: - # Needs artifacts from build (dist/) - job: linux:cross-build artifacts: true script: @@ -229,16 +177,14 @@ linux:ansi-test: tags: - linux needs: - # Needs artifacts from build (dist/) - job: linux:build artifacts: true - + linux:benchmark: <<: *benchmark_configuration tags: - linux needs: - # Needs artifacts from install (snapshot/) and build (dist/) - job: linux:install artifacts: true - job: linux:build @@ -267,7 +213,6 @@ osx:test: tags: - macos-virtualbox needs: - # Needs artifacts from build (dist/) - job: osx:build artifacts: true @@ -278,59 +223,23 @@ osx:exec-test: needs: - job: osx:build artifacts: true - + osx:ansi-test: <<: *ansi_test_configuration tags: - macos-virtualbox needs: - # Needs artifacts from build (dist/) - job: osx:build artifacts: true - + osx:benchmark: <<: *benchmark_configuration tags: - macos-virtualbox needs: - # Needs artifacts from install (snapshot/) and build (dist/) - job: osx:install artifacts: true - - job: osx:build - -# Optional job that runs the static analyzer. It needs the files from -# the linux-4 directory built in the linux:build job. -linux:static-analyzer: - stage: analyze - - tags: - - linux - artifacts: - when: always - paths: - - analyzer.log - needs: - - job: linux:build - artifacts: true - rules: - # 1. If the pipeline is a scheduled run, run this job automatically - - if: $CI_PIPELINE_SOURCE == "schedule" - when: on_success - # 2. If the variable is set (manually via UI/API), run automatically. - - if: $RUN_ANALYSIS - when: on_success - # 3. Otherwise, the job remains a manual button in the pipeline. - - when: manual - # Allows the pipeline to proceed and show a "passed with warnings" - # status (orange) instead of "failed" (red) if this job exits with an error. - allow_failure: true - script: - # Analysis can generate huge amounts of output. For now just save - # the results to the log file instead of also having it go to the - # console. If someday there's less or no output, we can consider - # having the logs go to the console too. - - make -C build-4/lisp clean - - make -C build-4/lisp ANALYZER=-fanalyzer > analyzer.log 2>&1 + - job: osx:build #### OpenSUSE jobs #### ubuntu:install: @@ -349,9 +258,6 @@ ubuntu:build: - job: ubuntu:install artifacts: true variables: - # Build with gcc on Ubuntu 25.10. It produces a lisp than passes - # the ansi-tests. Clang seems to fail the ansi-tests WRITE.1, - # PRINT.1, and friends when cr_pow is used. CONFIG: "x86_linux" ubuntu:test: @@ -359,7 +265,6 @@ ubuntu:test: tags: - ubuntu needs: - # Needs artifacts from build (dist/) - job: ubuntu:build artifacts: true @@ -368,38 +273,39 @@ ubuntu:ansi-test: tags: - ubuntu needs: - # Needs artifacts from build (dist/) - job: ubuntu:build artifacts: true -# Optional job that runs the markdown link checker. This is optional -# because it's very slow, of course; you have to run it manually. -# -# From https://github.com/tcort/markdown-link-check -# Checks links on the wiki pages whenever any wiki markdown pages change. +linux:static-analyzer: + stage: analyze + tags: + - linux + artifacts: + when: always + paths: + - analyzer.log + needs: + - job: linux:build + artifacts: true + rules: + - if: $CI_PIPELINE_SOURCE == "schedule" + - when: manual + allow_failure: true + script: + - make -C build-4/lisp clean + - make -C build-4/lisp ANALYZER=-fanalyzer > analyzer.log 2>&1 + markdown-link-check: stage: markdown-link-check - - # Only the linux runner has markdown-link-check installed tags: - linux + allow_failure: true rules: - # 1. If the pipeline is a scheduled run, run this job automatically - if: $CI_PIPELINE_SOURCE == "schedule" - when: on_success - # 2. If the variable is set (manually via UI/API), run automatically. - - if: $RUN_ANALYSIS - when: on_success - # 3. Otherwise, the job remains a manual button in the pipeline. - when: manual - # It's ok if this fails; we don't want to declare the entire - # pipeline as having failed. - allow_failure: true + allow_failure: true script: - # Check links in the main repo - find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check - # Clone the wiki pages and check the links there. Lots of - # failures here because of - # https://gitlab.com/gitlab-org/gitlab/-/issues/17845. - git clone https://gitlab.common-lisp.net/cmucl/cmucl.wiki.git - find cmucl.wiki -name \*.md -print0 | xargs -0 -n1 markdown-link-check + View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d69ccb8a95b2dc5b8cba6d5… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d69ccb8a95b2dc5b8cba6d5… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-478-run-analyzer-link-chcker-on-schedule] Revert "Experiment: Add schedule rules to all tasks"
by Raymond Toy (＠rtoy) 11 Mar '26

11 Mar '26

Raymond Toy pushed to branch issue-478-run-analyzer-link-chcker-on-schedule at cmucl / cmucl Commits: 81e241ae by Raymond Toy at 2026-03-11T14:26:42-07:00 Revert "Experiment: Add schedule rules to all tasks" This reverts commit 3ba0ba2a191cfece43bd2ee64ceca1165503c718. [skip-ci] - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -110,18 +110,6 @@ variables: - CMUCL=../../dist/bin/lisp ./run-cmucl.sh - ../../snapshot/bin/lisp -load report -# Default rules to run things on a schedule -.rules_sched_template: &rules_schedule - rules: - # 1. Ensure build runs for schedules so the analyzer can use its files - - if: $CI_PIPELINE_SOURCE == "schedule" - when: on_success - # 2. Ensure build runs if the analyzer variable is set - - if: $RUN_ANALYSIS - when: on_success - # 3. Default: run for standard pushes/MRs - - when: on_success - stages: - install - build @@ -136,16 +124,23 @@ cache: #### Linux jobs #### linux:install: <<: *install_configuration - <<: *rules_schedule tags: - linux variables: osname: "linux" CURL: "curl" + rules: + # 1. Ensure build runs for schedules so the analyzer can use its files + - if: $CI_PIPELINE_SOURCE == "schedule" + when: on_success + # 2. Ensure build runs if the analyzer variable is set + - if: $RUN_ANALYSIS + when: on_success + # 3. Default: run for standard pushes/MRs + - when: on_success linux:build: <<: *build_configuration - <<: *rules_schedule tags: - linux needs: @@ -155,6 +150,15 @@ linux:build: # Fedora 41 must build with gcc because the clang build fails some # ansi-tests. See [#469]. CONFIG: "x86_linux" + rules: + # 1. Ensure build runs for schedules so the analyzer can use its files + - if: $CI_PIPELINE_SOURCE == "schedule" + when: on_success + # 2. Ensure build runs if the analyzer variable is set + - if: $RUN_ANALYSIS + when: on_success + # 3. Default: run for standard pushes/MRs + - when: on_success linux:cross-build: stage: build @@ -190,7 +194,6 @@ linux:cross-build: linux:test: <<: *unit_test_configuration - <<: *rules_schedule tags: - linux needs: @@ -200,7 +203,6 @@ linux:test: linux:exec-test: <<: *exec_test_configuration - <<: *rules_schedule tags: - linux needs: @@ -224,7 +226,6 @@ linux:cross-test: linux:ansi-test: <<: *ansi_test_configuration - <<: *rules_schedule tags: - linux needs: @@ -234,7 +235,6 @@ linux:ansi-test: linux:benchmark: <<: *benchmark_configuration - <<: *rules_schedule tags: - linux needs: @@ -246,7 +246,6 @@ linux:benchmark: #### OSX (Mac) jobs #### osx:install: <<: *install_configuration - <<: *rules_schedule tags: - macos-virtualbox variables: @@ -255,7 +254,6 @@ osx:install: osx:build: <<: *build_configuration - <<: *rules_schedule tags: - macos-virtualbox needs: @@ -266,7 +264,6 @@ osx:build: osx:test: <<: *unit_test_configuration - <<: *rules_schedule tags: - macos-virtualbox needs: @@ -276,7 +273,6 @@ osx:test: osx:exec-test: <<: *exec_test_configuration - <<: *rules_schedule tags: - macos-virtualbox needs: @@ -285,7 +281,6 @@ osx:exec-test: osx:ansi-test: <<: *ansi_test_configuration - <<: *rules_schedule tags: - macos-virtualbox needs: @@ -295,7 +290,6 @@ osx:ansi-test: osx:benchmark: <<: *benchmark_configuration - <<: *rules_schedule tags: - macos-virtualbox needs: @@ -307,7 +301,6 @@ osx:benchmark: # Optional job that runs the static analyzer. It needs the files from # the linux-4 directory built in the linux:build job. linux:static-analyzer: - <<: *rules_schedule stage: analyze tags: @@ -319,6 +312,15 @@ linux:static-analyzer: needs: - job: linux:build artifacts: true + rules: + # 1. If the pipeline is a scheduled run, run this job automatically + - if: $CI_PIPELINE_SOURCE == "schedule" + when: on_success + # 2. If the variable is set (manually via UI/API), run automatically. + - if: $RUN_ANALYSIS + when: on_success + # 3. Otherwise, the job remains a manual button in the pipeline. + - when: manual # Allows the pipeline to proceed and show a "passed with warnings" # status (orange) instead of "failed" (red) if this job exits with an error. allow_failure: true @@ -333,7 +335,6 @@ linux:static-analyzer: #### OpenSUSE jobs #### ubuntu:install: <<: *install_configuration - <<: *rules_schedule tags: - ubuntu variables: @@ -342,7 +343,6 @@ ubuntu:install: ubuntu:build: <<: *build_configuration - <<: *rules_schedule tags: - ubuntu needs: @@ -356,7 +356,6 @@ ubuntu:build: ubuntu:test: <<: *unit_test_configuration - <<: *rules_schedule tags: - ubuntu needs: @@ -366,7 +365,6 @@ ubuntu:test: ubuntu:ansi-test: <<: *ansi_test_configuration - <<: *rules_schedule tags: - ubuntu needs: @@ -380,12 +378,20 @@ ubuntu:ansi-test: # From https://github.com/tcort/markdown-link-check # Checks links on the wiki pages whenever any wiki markdown pages change. markdown-link-check: - <<: *rules_schedule stage: markdown-link-check # Only the linux runner has markdown-link-check installed tags: - linux + rules: + # 1. If the pipeline is a scheduled run, run this job automatically + - if: $CI_PIPELINE_SOURCE == "schedule" + when: on_success + # 2. If the variable is set (manually via UI/API), run automatically. + - if: $RUN_ANALYSIS + when: on_success + # 3. Otherwise, the job remains a manual button in the pipeline. + - when: manual # It's ok if this fails; we don't want to declare the entire # pipeline as having failed. allow_failure: true View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/81e241aebaa20093c22770d… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/81e241aebaa20093c22770d… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-478-run-analyzer-link-chcker-on-schedule] Experiment: Add schedule rules to all tasks
by Raymond Toy (＠rtoy) 11 Mar '26

11 Mar '26

Raymond Toy pushed to branch issue-478-run-analyzer-link-chcker-on-schedule at cmucl / cmucl Commits: 3ba0ba2a by Raymond Toy at 2026-03-11T14:16:18-07:00 Experiment: Add schedule rules to all tasks - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -110,6 +110,18 @@ variables: - CMUCL=../../dist/bin/lisp ./run-cmucl.sh - ../../snapshot/bin/lisp -load report +# Default rules to run things on a schedule +.rules_sched_template: &rules_schedule + rules: + # 1. Ensure build runs for schedules so the analyzer can use its files + - if: $CI_PIPELINE_SOURCE == "schedule" + when: on_success + # 2. Ensure build runs if the analyzer variable is set + - if: $RUN_ANALYSIS + when: on_success + # 3. Default: run for standard pushes/MRs + - when: on_success + stages: - install - build @@ -124,23 +136,16 @@ cache: #### Linux jobs #### linux:install: <<: *install_configuration + <<: *rules_schedule tags: - linux variables: osname: "linux" CURL: "curl" - rules: - # 1. Ensure build runs for schedules so the analyzer can use its files - - if: $CI_PIPELINE_SOURCE == "schedule" - when: on_success - # 2. Ensure build runs if the analyzer variable is set - - if: $RUN_ANALYSIS - when: on_success - # 3. Default: run for standard pushes/MRs - - when: on_success linux:build: <<: *build_configuration + <<: *rules_schedule tags: - linux needs: @@ -150,15 +155,6 @@ linux:build: # Fedora 41 must build with gcc because the clang build fails some # ansi-tests. See [#469]. CONFIG: "x86_linux" - rules: - # 1. Ensure build runs for schedules so the analyzer can use its files - - if: $CI_PIPELINE_SOURCE == "schedule" - when: on_success - # 2. Ensure build runs if the analyzer variable is set - - if: $RUN_ANALYSIS - when: on_success - # 3. Default: run for standard pushes/MRs - - when: on_success linux:cross-build: stage: build @@ -194,6 +190,7 @@ linux:cross-build: linux:test: <<: *unit_test_configuration + <<: *rules_schedule tags: - linux needs: @@ -203,6 +200,7 @@ linux:test: linux:exec-test: <<: *exec_test_configuration + <<: *rules_schedule tags: - linux needs: @@ -226,6 +224,7 @@ linux:cross-test: linux:ansi-test: <<: *ansi_test_configuration + <<: *rules_schedule tags: - linux needs: @@ -235,6 +234,7 @@ linux:ansi-test: linux:benchmark: <<: *benchmark_configuration + <<: *rules_schedule tags: - linux needs: @@ -246,6 +246,7 @@ linux:benchmark: #### OSX (Mac) jobs #### osx:install: <<: *install_configuration + <<: *rules_schedule tags: - macos-virtualbox variables: @@ -254,6 +255,7 @@ osx:install: osx:build: <<: *build_configuration + <<: *rules_schedule tags: - macos-virtualbox needs: @@ -264,6 +266,7 @@ osx:build: osx:test: <<: *unit_test_configuration + <<: *rules_schedule tags: - macos-virtualbox needs: @@ -273,6 +276,7 @@ osx:test: osx:exec-test: <<: *exec_test_configuration + <<: *rules_schedule tags: - macos-virtualbox needs: @@ -281,6 +285,7 @@ osx:exec-test: osx:ansi-test: <<: *ansi_test_configuration + <<: *rules_schedule tags: - macos-virtualbox needs: @@ -290,6 +295,7 @@ osx:ansi-test: osx:benchmark: <<: *benchmark_configuration + <<: *rules_schedule tags: - macos-virtualbox needs: @@ -301,6 +307,7 @@ osx:benchmark: # Optional job that runs the static analyzer. It needs the files from # the linux-4 directory built in the linux:build job. linux:static-analyzer: + <<: *rules_schedule stage: analyze tags: @@ -312,15 +319,6 @@ linux:static-analyzer: needs: - job: linux:build artifacts: true - rules: - # 1. If the pipeline is a scheduled run, run this job automatically - - if: $CI_PIPELINE_SOURCE == "schedule" - when: on_success - # 2. If the variable is set (manually via UI/API), run automatically. - - if: $RUN_ANALYSIS - when: on_success - # 3. Otherwise, the job remains a manual button in the pipeline. - - when: manual # Allows the pipeline to proceed and show a "passed with warnings" # status (orange) instead of "failed" (red) if this job exits with an error. allow_failure: true @@ -335,6 +333,7 @@ linux:static-analyzer: #### OpenSUSE jobs #### ubuntu:install: <<: *install_configuration + <<: *rules_schedule tags: - ubuntu variables: @@ -343,6 +342,7 @@ ubuntu:install: ubuntu:build: <<: *build_configuration + <<: *rules_schedule tags: - ubuntu needs: @@ -356,6 +356,7 @@ ubuntu:build: ubuntu:test: <<: *unit_test_configuration + <<: *rules_schedule tags: - ubuntu needs: @@ -365,6 +366,7 @@ ubuntu:test: ubuntu:ansi-test: <<: *ansi_test_configuration + <<: *rules_schedule tags: - ubuntu needs: @@ -378,20 +380,12 @@ ubuntu:ansi-test: # From https://github.com/tcort/markdown-link-check # Checks links on the wiki pages whenever any wiki markdown pages change. markdown-link-check: + <<: *rules_schedule stage: markdown-link-check # Only the linux runner has markdown-link-check installed tags: - linux - rules: - # 1. If the pipeline is a scheduled run, run this job automatically - - if: $CI_PIPELINE_SOURCE == "schedule" - when: on_success - # 2. If the variable is set (manually via UI/API), run automatically. - - if: $RUN_ANALYSIS - when: on_success - # 3. Otherwise, the job remains a manual button in the pipeline. - - when: manual # It's ok if this fails; we don't want to declare the entire # pipeline as having failed. allow_failure: true View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/3ba0ba2a191cfece43bd2ee… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/3ba0ba2a191cfece43bd2ee… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-464-lisp-version-uses-branch-name] Change algorithm so we don't use --all anymore
by Raymond Toy (＠rtoy) 11 Mar '26

11 Mar '26

Raymond Toy pushed to branch issue-464-lisp-version-uses-branch-name at cmucl / cmucl Commits: c4b2c55f by Raymond Toy at 2026-03-11T08:46:27-07:00 Change algorithm so we don't use --all anymore The new algorithm is: 1. If we're on the master branch, use plain "--dirty" to get a version. 2. If we're on a branch, just use the branch name. 3. Otherwise: 1. If it looks like snapshot-yyyy-mm, use yyyy-mm as the version. 2. If it 4 or more decimal digits, assume it's a pipeline and prepend with "ci-" 3. Just use "--dirty" - - - - - 1 changed file: - bin/git-version.sh Changes: ===================================== bin/git-version.sh ===================================== @@ -51,7 +51,7 @@ else # However, we have to remove everything before the first slash # which contains things like "tags/", "head/", or "pipelines/" # (from CI). - GIT_DESC="`git describe --all --dirty || git describe 2>/dev/null`" + GIT_DESC="`git describe --dirty || git describe 2>/dev/null`" GIT_HASH="`echo ${GIT_DESC} | sed 's;^[^/]*/;;' 2>/dev/null`" case "$GIT_HASH" in @@ -65,7 +65,7 @@ else # Use it as is. DEFAULT_VERSION="${GIT_HASH}" ;; - [0-9]*) + [0-9][0-9][0-9][0-9][0-9]*) # Assuming this is CI which seems to produce a githash like # "pipeline/<digits>". Make the version include "ci-" so we # know this was done via CI. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c4b2c55f1c10befec899fd5… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c4b2c55f1c10befec899fd5… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-480-double-double-hex-printer] 2 commits: Clean up docstrings and update cmucl.pot
by Raymond Toy (＠rtoy) 10 Mar '26

10 Mar '26

Raymond Toy pushed to branch issue-480-double-double-hex-printer at cmucl / cmucl Commits: 014a18a0 by Raymond Toy at 2026-03-10T15:11:21-07:00 Clean up docstrings and update cmucl.pot - - - - - 116c26e9 by Raymond Toy at 2026-03-10T15:11:41-07:00 Add tests for printing double-double special values Make sure double-double-float NaN and infinities are printed in hex format correctly. - - - - - 3 changed files: - src/code/ext-code.lisp - src/i18n/locale/cmucl.pot - tests/extensions.lisp Changes: ===================================== src/code/ext-code.lisp ===================================== @@ -36,7 +36,7 @@ (defun write-hex-float-double (x stream) "Print a single- or double-float in hex format onto STREAM. - Float type and mantissa width are derived from the type of X." + Float type and mantissa width are derived from the type of X." (multiple-value-bind (mantissa-bits suffix-char min-c-exp) (etypecase x (single-float (values (1- (float-digits 1f0)) #\f (- vm:single-float-bias))) @@ -111,9 +111,7 @@ #+double-double (defun write-hex-float-double-double (x stream) - "Print a double-double-float in hex format onto STREAM. - Reconstructs the full significand from hi and lo components - using exact integer arithmetic before formatting." + "Print a double-double-float in hex format onto STREAM." (let* ((hi (kernel:double-double-hi x)) (lo (kernel:double-double-lo x))) ;; Print the sign, but not for NaN since float-sign is unreliable there. @@ -196,7 +194,8 @@ ;;; Writes a float value (single, double, or double-double) in hex ;;; format to a stream, defaulting to *standard-output*. (defun write-hex-float (x &optional (stream *standard-output*)) - "Write float X to STREAM in C-style hex format. STREAM defaults to *standard-output*. + "Write float X to STREAM in C-style hex format. STREAM defaults to + *standard-output*. single-float => 0x<mantissa>p<exp>f double-float => 0x<mantissa>p<exp> @@ -230,10 +229,11 @@ ;;; ;;; Function that can be used in a FORMAT ~/ (defun format-hex-float (stream x colonp atsignp &rest args) - "Format function for use with ~/package:format-hex-float/. + "Format function for use with ~/ext:format-hex-float/. Ignores colon modifier. At-sign modifier forces a leading + sign on - non-negative values. Example: (format t \"~@/ext:format-hex-float/\" - 3.0d0) => +0x1.8p+1" + non-negative values. + + Example: (format t \"~@/ext:format-hex-float/\" 3.0d0) => +0x1.8p+1" (declare (ignore colonp args)) (when (and atsignp (not (float-nan-p x)) @@ -393,8 +393,10 @@ (defun read-hex-float-from-string (s &key (start 0) end) "Read a C-style hex float from string S. START and END bound the region to read (default: entire string). + Signals HEX-FLOAT-PARSE-ERROR on malformed input. + Returns two values: the float and the index of the first character - not consumed. Signals HEX-FLOAT-PARSE-ERROR on malformed input." + not consumed." (with-input-from-string (stream s :start start :end end) (values (read-hex-float-from-stream stream) (file-position stream)))) @@ -403,7 +405,7 @@ ;;; READ-HEX-FLOAT -- Public ;;; ;;; Read a C-style hex float number from either a string or a stream. -(defun ext:read-hex-float (stream-or-string &key (start 0) end) +(defun read-hex-float (stream-or-string &key (start 0) end) "Read a C-style hex float from STREAM-OR-STRING. If a string, START and END bound the region to read. When reading from a string, returns two values: the float and the index of the ===================================== src/i18n/locale/cmucl.pot ===================================== @@ -6066,7 +6066,9 @@ msgid "" msgstr "" #: src/code/ext-code.lisp -msgid "Print a single-float or double-float in hex format onto STREAM." +msgid "" +"Print a single- or double-float in hex format onto STREAM.\n" +" Float type and mantissa width are derived from the type of X." msgstr "" #: src/code/ext-code.lisp @@ -6075,8 +6077,8 @@ msgstr "" #: src/code/ext-code.lisp msgid "" -"Write float X to STREAM in C-style hex format. STREAM defaults to *standard-" -"output*.\n" +"Write float X to STREAM in C-style hex format. STREAM defaults to\n" +" *standard-output*.\n" "\n" " single-float => 0x<mantissa>p<exp>f\n" " double-float => 0x<mantissa>p<exp>\n" @@ -6095,10 +6097,11 @@ msgstr "" #: src/code/ext-code.lisp msgid "" -"Format function for use with ~/package:format-hex-float/.\n" +"Format function for use with ~/ext:format-hex-float/.\n" " Ignores colon modifier. At-sign modifier forces a leading + sign on\n" -" non-negative values. Example: (format t \"~@/ext:format-hex-float/\"\n" -" 3.0d0) => +0x1.8p+1" +" non-negative values.\n" +"\n" +" Example: (format t \"~@/ext:format-hex-float/\" 3.0d0) => +0x1.8p+1" msgstr "" #: src/code/ext-code.lisp @@ -6120,8 +6123,10 @@ msgstr "" msgid "" "Read a C-style hex float from string S.\n" " START and END bound the region to read (default: entire string).\n" +" Signals HEX-FLOAT-PARSE-ERROR on malformed input.\n" +"\n" " Returns two values: the float and the index of the first character\n" -" not consumed. Signals HEX-FLOAT-PARSE-ERROR on malformed input." +" not consumed." msgstr "" #: src/code/ext-code.lisp ===================================== tests/extensions.lisp ===================================== @@ -84,6 +84,17 @@ (assert-equal "0x1.fffffffffffff8p-1w" (ext:float-to-hex-string (- 1.0w0 (scale-float 1.0w0 -54))))) +(define-test write-double-double-special + (assert-equal "0x1.0p+infw" + (ext:float-to-hex-string (float ext:double-float-positive-infinity 1w0))) + (assert-equal "-0x1.0p+infw" + (ext:float-to-hex-string (float ext:double-float-negative-infinity 1w0))) + (assert-equal "0x0.0p+nanw" + (ext:float-to-hex-string + (ext:with-float-traps-masked (:invalid) + (- (float ext:double-float-positive-infinity 1w0) + (float ext:double-float-positive-infinity 1w0)))))) + ;;; ---- read-hex-float tests ------------------------------------------------ View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/a15d70c535d7959d2ba2c7… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/a15d70c535d7959d2ba2c7… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-480-double-double-hex-printer] 2 commits: Add comments to the write-hex-float subroutines
by Raymond Toy (＠rtoy) 10 Mar '26

10 Mar '26

Raymond Toy pushed to branch issue-480-double-double-hex-printer at cmucl / cmucl Commits: b9279317 by Raymond Toy at 2026-03-10T08:15:54-07:00 Add comments to the write-hex-float subroutines Generated by Claude. - - - - - a15d70c5 by Raymond Toy at 2026-03-10T08:26:57-07:00 Write-hex-float was not handling NaN and infinity for double-double Handle NaN and infinity for double-doubles in the same way as done for write-hex-float-double. - - - - - 1 changed file: - src/code/ext-code.lisp Changes: ===================================== src/code/ext-code.lisp ===================================== @@ -35,119 +35,161 @@ ""))) (defun write-hex-float-double (x stream) - "Print a single-float or double-float in hex format onto STREAM." - ;; Float type and mantissa width are derived from the type of X. + "Print a single- or double-float in hex format onto STREAM. + Float type and mantissa width are derived from the type of X." (multiple-value-bind (mantissa-bits suffix-char min-c-exp) (etypecase x - (single-float (values 23 #\f -126)) - (double-float (values 52 nil -1022))) + (single-float (values (1- (float-digits 1f0)) #\f (- vm:single-float-bias))) + (double-float (values (1- (float-digits 1d0)) nil (- vm:double-float-bias)))) + ;; Print the sign, but not for NaN since float-sign is unreliable there. (when (and (not (float-nan-p x)) (minusp (float-sign x))) (write-char #\- stream)) (let ((x (abs x))) (cond ((float-nan-p x) (write-string "0x0.0p+nan" stream) - (when suffix-char - (write-char suffix-char stream))) + (when suffix-char (write-char suffix-char stream))) ((float-infinity-p x) (write-string "0x1.0p+inf" stream) - (when suffix-char - (write-char suffix-char stream))) + (when suffix-char (write-char suffix-char stream))) ((zerop x) (write-string "0x0p+0" stream) - (when suffix-char - (write-char suffix-char stream))) + (when suffix-char (write-char suffix-char stream))) (t + ;; integer-decode-float returns (significand exponent sign) where + ;; x = significand * 2^exponent. The significand has mantissa-bits+1 + ;; bits for normal numbers (including the implicit leading 1 bit) and + ;; fewer for denormals, which CMUCL normalizes so that the significand + ;; always has exactly mantissa-bits+1 bits, adjusting the exponent + ;; accordingly. (multiple-value-bind (significand exponent sign) (integer-decode-float x) (declare (ignore sign)) + ;; c-exp is the C-style binary exponent, i.e. the exponent of the + ;; leading 1 bit. For a normal number with a (mantissa-bits+1)-bit + ;; significand, c-exp = exponent + mantissa-bits. (let* ((c-exp (+ exponent mantissa-bits)) + ;; A number is denormal if its c-exp is below the minimum + ;; normal exponent. We cannot detect this by checking the + ;; significand bit width because CMUCL normalizes denormals. (denormalp (< c-exp min-c-exp)) + ;; We print the fraction in hex, rounding up the number of + ;; mantissa bits to a multiple of 4. (hex-digits (ceiling mantissa-bits 4)) + ;; frac-shift aligns the mantissa-bits fraction bits to the + ;; hex-digits*4 grid. (frac-shift (- (* 4 hex-digits) mantissa-bits)) + ;; For a normal number, mask off the implicit leading 1 bit + ;; to get just the fraction, then shift to align to hex grid. + ;; For a denormal, the leading bit is 0 so there is nothing + ;; to mask; instead shift right to account for the reduced + ;; exponent. (frac (if denormalp (ash significand (+ (- c-exp min-c-exp) frac-shift)) (ash (logand significand (1- (ash 1 mantissa-bits))) frac-shift))) + ;; Denormals are printed with exponent min-c-exp and a + ;; leading 0 digit rather than 1. (out-exp (if denormalp min-c-exp c-exp)) (frac-str (trim-trailing-zeros - (format nil "~v,'0X" hex-digits frac)))) + (format nil "~v,'0X" hex-digits frac)))) (write-string "0x" stream) - (write-char (if denormalp #\0 #\1) - stream) + (write-char (if denormalp #\0 #\1) stream) (unless (zerop (length frac-str)) (write-char #\. stream) (write-string frac-str stream)) (write-char #\p stream) - (when (>= out-exp 0) - (write-char #\+ stream)) + (when (>= out-exp 0) (write-char #\+ stream)) (format stream "~D" out-exp) - (when suffix-char - (write-char suffix-char stream))))))) + (when suffix-char (write-char suffix-char stream))))))) (values))) #+double-double (defun write-hex-float-double-double (x stream) - "Print a double-double-float in hex format onto STREAM." - ;; Reconstructs the full significand from hi and lo components using - ;; exact integer arithmetic before formatting." + "Print a double-double-float in hex format onto STREAM. + Reconstructs the full significand from hi and lo components + using exact integer arithmetic before formatting." (let* ((hi (kernel:double-double-hi x)) - (lo (kernel:double-double-lo x)) - (hi (abs hi))) - (when (minusp (float-sign (kernel:double-double-hi x))) + (lo (kernel:double-double-lo x))) + ;; Print the sign, but not for NaN since float-sign is unreliable there. + (when (and (not (float-nan-p x)) (minusp (float-sign hi))) (write-char #\- stream)) - (cond - ((zerop hi) - (write-string "0x0p+0w" stream)) - (t - (multiple-value-bind (sig-hi exp-hi sign-hi) - (integer-decode-float hi) - (declare (ignore sign-hi)) - (multiple-value-bind (sig-lo exp-lo sign-lo) - (integer-decode-float lo) - (let* ((signed-sig-lo (* sign-lo sig-lo)) - (combined-sig (if (zerop lo) - sig-hi - (+ (ash sig-hi (- exp-hi exp-lo)) - signed-sig-lo))) - (combined-exp (if (zerop lo) exp-hi exp-lo)) - (total-bits (integer-length combined-sig)) - (c-exp (+ combined-exp total-bits -1)) - (min-c-exp -1022) - (denormalp (< c-exp min-c-exp)) - (raw-frac-bits (if (zerop lo) - 52 - (+ (- exp-hi exp-lo) - 52))) - (frac-bits (* 4 (ceiling raw-frac-bits 4))) - (hex-digits (/ frac-bits 4)) - (shift (if denormalp - (+ (- frac-bits (1- total-bits)) - (- c-exp min-c-exp)) - (- frac-bits (1- total-bits)))) - (frac (if denormalp - (ash combined-sig shift) - (logand (ash combined-sig shift) - (1- (ash 1 frac-bits))))) - (out-exp (if denormalp min-c-exp c-exp)) - (frac-str (trim-trailing-zeros - (format nil "~v,'0X" hex-digits frac)))) - (write-string "0x" stream) - (write-char (if denormalp #\0 #\1) stream) - (unless (zerop (length frac-str)) - (write-char #\. stream) - (write-string frac-str stream)) - (write-char #\p stream) - (when (>= out-exp 0) - (write-char #\+ stream)) - (format stream "~D" out-exp) - (write-char #\w stream)))))) - (values))) + (let ((hi (abs hi))) + (cond + ((float-nan-p x) + (write-string "0x0.0p+nanw" stream)) + + ((float-infinity-p x) + (write-string "0x1.0p+infw" stream)) + + ((zerop hi) + (write-string "0x0p+0w" stream)) + + (t + (multiple-value-bind (sig-hi exp-hi sign-hi) + (integer-decode-float hi) + (declare (ignore sign-hi)) + (multiple-value-bind (sig-lo exp-lo sign-lo) + (integer-decode-float lo) + (let* ((double-mant-bits (1- (float-digits 1d0))) + (min-c-exp (- vm:double-float-bias)) + ;; Preserve the sign of lo when combining with hi. + (signed-sig-lo (* sign-lo sig-lo)) + ;; Reconstruct the full integer significand by shifting + ;; sig-hi up to align with sig-lo's exponent, then adding. + ;; If lo is zero there is nothing to add. + (combined-sig (if (zerop lo) + sig-hi + (+ (ash sig-hi (- exp-hi exp-lo)) + signed-sig-lo))) + ;; The combined significand is at the scale of lo's exponent + ;; (or hi's if lo is zero). + (combined-exp (if (zerop lo) exp-hi exp-lo)) + (total-bits (integer-length combined-sig)) + ;; c-exp is the exponent of the leading 1 bit, i.e. the + ;; C-style binary exponent. + (c-exp (+ combined-exp total-bits -1)) + (denormalp (< c-exp min-c-exp)) + ;; The number of fraction bits we need to print spans from + ;; the leading bit of hi down to the last bit of lo. When + ;; lo is zero we only need double-mant-bits fraction bits. + ;; We round up to a multiple of 4 for clean hex output. + (raw-frac-bits (if (zerop lo) + double-mant-bits + (+ (- exp-hi exp-lo) double-mant-bits))) + (frac-bits (* 4 (ceiling raw-frac-bits 4))) + (hex-digits (/ frac-bits 4)) + ;; Shift the combined significand so the fraction bits are + ;; left-aligned in a frac-bits-wide field. For denormals, + ;; adjust the shift to account for the reduced exponent. + (shift (if denormalp + (+ (- frac-bits (1- total-bits)) + (- c-exp min-c-exp)) + (- frac-bits (1- total-bits)))) + ;; For normal numbers mask off the leading 1 bit; for + ;; denormals the leading bit is already 0 so no mask needed. + (frac (if denormalp + (ash combined-sig shift) + (logand (ash combined-sig shift) + (1- (ash 1 frac-bits))))) + (out-exp (if denormalp min-c-exp c-exp)) + (frac-str (trim-trailing-zeros + (format nil "~v,'0X" hex-digits frac)))) + (write-string "0x" stream) + (write-char (if denormalp #\0 #\1) stream) + (unless (zerop (length frac-str)) + (write-char #\. stream) + (write-string frac-str stream)) + (write-char #\p stream) + (when (>= out-exp 0) (write-char #\+ stream)) + (format stream "~D" out-exp) + (write-char #\w stream)))))) + (values)))) ;;; WRITE-HEX-FLOAT -- Public ;;; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/528946709fcb5b5c50458f… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/528946709fcb5b5c50458f… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0