- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][master] Fix typo in version in header banner
by Raymond Toy 05 Oct '16

05 Oct '16

Raymond Toy pushed to branch master at cmucl / cmucl Commits: b5598138 by Raymond Toy at 2016-10-04T20:34:48-07:00 Fix typo in version in header banner - - - - - 1 changed file: - src/general-info/release-21b.txt Changes: ===================================== src/general-info/release-21b.txt ===================================== --- a/src/general-info/release-21b.txt +++ b/src/general-info/release-21b.txt @@ -1,4 +1,4 @@ -========================== C M U C L 21 a ============================= +========================== C M U C L 21 b ============================= The CMUCL project is pleased to announce the release of CMUCL 21b. This is a major release which contains numerous enhancements and View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/b55981380a3ce59d860be724e…

1 0

[Git][cmucl/cmucl][master] 2 commits: Update from logs.
by Raymond Toy 05 Oct '16

05 Oct '16

Raymond Toy pushed to branch master at cmucl / cmucl Commits: c494f688 by Raymond Toy at 2016-10-04T20:33:43-07:00 Update from logs. - - - - - 298917a8 by Raymond Toy at 2016-10-04T20:34:08-07:00 Remove work in progress tag. - - - - - 1 changed file: - src/general-info/release-21b.txt Changes: ===================================== src/general-info/release-21b.txt ===================================== --- a/src/general-info/release-21b.txt +++ b/src/general-info/release-21b.txt @@ -1,7 +1,5 @@ ========================== C M U C L 21 a ============================= -[Work in progress] - The CMUCL project is pleased to announce the release of CMUCL 21b. This is a major release which contains numerous enhancements and bug fixes from the 21a release. @@ -75,6 +73,9 @@ New in this release: clang). (See ticket #12.) * Cleanups in handling floating-point exceptions. See Tickets #15 and #16. + * DIRECTORY with :FOLLOW-LINKS T (and :TRUENAME NIL) will follow + directory links. Previously, the directories that were links + weren't followed. * Trac Tickets: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/6d30fdd63c822201fc5c13d6…

1 0

[Git][cmucl/cmucl][master] Add test case for issue #24.
by Raymond Toy 04 Oct '16

04 Oct '16

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 6d30fdd6 by Raymond Toy at 2016-10-03T19:02:46-07:00 Add test case for issue #24. Forgot to check this in with the fix for issue #24. - - - - - 1 changed file: - + tests/resources/issue-24.lisp Changes: ===================================== tests/resources/issue-24.lisp ===================================== --- /dev/null +++ b/tests/resources/issue-24.lisp @@ -0,0 +1,5 @@ +;; Test case from issue #24. +(defun foo () + (print "Hello world")) + +(compile 'foo) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/6d30fdd63c822201fc5c13d60…

1 0

[Git][cmucl/cmucl] Pushed new branch netbsd7
by Robert Swindells 03 Oct '16

03 Oct '16

Robert Swindells pushed new branch netbsd7 at cmucl / cmucl

1 0

[Git][cmucl/cmucl][master] 2 commits: Add a test for MR !15
by Raymond Toy 03 Oct '16

03 Oct '16

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 7b85c61b by Elias Pipping at 2016-10-03T01:05:41+00:00 Add a test for MR !15 - - - - - 59328877 by Raymond Toy at 2016-10-03T02:52:35+00:00 Merge branch 'test-for-mr.15' into 'master' Add a test for MR !15 See merge request !16 - - - - - 6 changed files: - tests/issues.lisp - + tests/resources/mr.15/dir/file-in-dir - + tests/resources/mr.15/file - + tests/resources/mr.15/link-to-dir - + tests/resources/mr.15/link-to-dir-in-dir - + tests/resources/mr.15/link-to-file Changes: ===================================== tests/issues.lisp ===================================== --- a/tests/issues.lisp +++ b/tests/issues.lisp @@ -12,6 +12,12 @@ (declare (ignore arg)) form) +(defparameter *test-path* + (merge-pathnames (make-pathname :name :unspecific :type :unspecific + :version :unspecific) + *load-truename*) + "Directory for temporary test files.") + (define-test issue.1.a (:tag :issues) (assert-equal @@ -321,3 +327,23 @@ (assert-error 'kernel:simple-program-error (ext:run-program "cat" nil :before-execve t))) + +(define-test mr.15 + (:tag :issues) + (let (directories files) + (dolist (entry (directory (merge-pathnames "resources/mr.15/*.*" *test-path*) + :check-for-subdirs t + :follow-links nil + :truenamep nil)) + (let ((filename (pathname-name entry)) + (directory (first (last (pathname-directory entry))))) + (if filename + (push filename files) + (push directory directories)))) + (assert (null (set-difference files + '("file" "link-to-dir" + "link-to-dir-in-dir" "link-to-file") + :test #'string-equal))) + (assert (null (set-difference directories + '(".dir" "dir") + :test #'string-equal))))) ===================================== tests/resources/mr.15/dir/file-in-dir ===================================== --- /dev/null +++ b/tests/resources/mr.15/dir/file-in-dir ===================================== tests/resources/mr.15/file ===================================== --- /dev/null +++ b/tests/resources/mr.15/file ===================================== tests/resources/mr.15/link-to-dir ===================================== --- /dev/null +++ b/tests/resources/mr.15/link-to-dir @@ -0,0 +1 @@ +dir \ No newline at end of file ===================================== tests/resources/mr.15/link-to-dir-in-dir ===================================== --- /dev/null +++ b/tests/resources/mr.15/link-to-dir-in-dir @@ -0,0 +1 @@ +dir/dir-in-dir \ No newline at end of file ===================================== tests/resources/mr.15/link-to-file ===================================== --- /dev/null +++ b/tests/resources/mr.15/link-to-file @@ -0,0 +1 @@ +file \ No newline at end of file View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/4bf2062f18694d662f79d25c…

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix: directory followed symlinks with :follow-links nil
by Raymond Toy 02 Oct '16

02 Oct '16

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 17499591 by Elias Pipping at 2016-09-28T21:21:52+00:00 Fix: directory followed symlinks with :follow-links nil - - - - - 4bf2062f by Raymond Toy at 2016-10-02T16:48:11+00:00 Merge branch 'master' into 'master' Fix: directory followed symlinks with :follow-links nil I'm on Linux. I'm looking at a directory that contains both physical directories and symbolic links to directories. ### What I would expect: ```common-lisp (directory "/path/to/dir/*.*" :check-for-subdirs t :follow-links t :truenamep nil) ``` will show both (because it will show everything in that directory) and mark both types as directories with trailing slashes. ```common-lisp (directory "/path/to/dir/*.*" :check-for-subdirs t :follow-links nil :truenamep nil) ``` will again show all files but only add trailing slashes to the physical subdirectories. ### What actually happens Both commands give me the same output. That is because `directory` calls `unix:unix-file-kind` to categorise files into directory/link/etc., which internally calls `stat`. It will only use `lstat` if the second, optional argument is passed as **t**. In default mode (the way it currently is) symlinks to directories will be assigned the type :directory regardless of the flags passed to `directory`. I believe the change contained in this merge request is thus the correct fix. See merge request !15 - - - - - 1 changed file: - src/code/filesys.lisp Changes: ===================================== src/code/filesys.lisp ===================================== --- a/src/code/filesys.lisp +++ b/src/code/filesys.lisp @@ -1125,7 +1125,7 @@ optionally keeping some of the most recent old versions." (let ((*ignore-wildcards* t)) (mapcar #'(lambda (name) (let ((name (if (and check-for-subdirs - (eq (unix:unix-file-kind name) + (eq (unix:unix-file-kind name (not follow-links)) :directory)) (concatenate 'string name "/") name))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/3d18025d13e030958e44641c…

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #29: Update processing of command line
by Raymond Toy 01 Oct '16

01 Oct '16

Raymond Toy pushed to branch master at cmucl / cmucl Commits: d9090138 by Raymond Toy at 2016-09-18T21:09:13-07:00 Fix #29: Update processing of command line Several related changes here. o If :process-command-line is NIL, *command-line-strings* and *command-line-application-arguments* weren't getting updated. They should get updated so that the resulting core can get updated command line options instead of using the values dumped with the core. The command line switch demons are still not run, as before. o Add a :quiet option as if -quiet were given. - - - - - 3d18025d by Raymond Toy at 2016-10-01T17:45:23+00:00 Merge branch 'rtoy-29-process-command-line' into 'master' Fix #29: Update processing of command line Several related changes here. - If `:process-command-line` is NIL, `*command-line-strings*` and `*command-line-application-arguments*` weren't getting updated. They should get updated so that the resulting core can get updated command line options instead of using the values dumped with the core. The command line switch demons are still not run, as before. - Add a `:quiet` option as if `-quiet` were given. See merge request !13 - - - - - 3 changed files: - src/code/commandline.lisp - src/code/save.lisp - src/i18n/locale/cmucl.pot Changes: ===================================== src/code/commandline.lisp ===================================== --- a/src/code/commandline.lisp +++ b/src/code/commandline.lisp @@ -72,7 +72,7 @@ ;;;; Processing the command strings. -(defun process-command-strings () +(defun process-command-strings (init-command-switches-p) (setq *command-line-words* nil) (setq *command-line-switches* nil) (let ((cmd-strings lisp::lisp-command-line-list) @@ -103,7 +103,7 @@ (return-from process-command-strings nil)) ;; Set command line switches. - ;; + ;; (loop (unless str (return (setf *command-line-switches* @@ -119,14 +119,16 @@ (let (word-list) (loop (unless str - (push (make-cmd-switch switch value (nreverse word-list)) - *command-line-switches*) + (when init-command-switches-p + (push (make-cmd-switch switch value (nreverse word-list)) + *command-line-switches*)) (return nil)) (unless (zerop (length (the simple-string str))) (when (char= #\- (schar str 0)) - (push (make-cmd-switch switch value (nreverse word-list)) - *command-line-switches*) + (when init-command-switches-p + (push (make-cmd-switch switch value (nreverse word-list)) + *command-line-switches*)) (when (and (= (length str) 2) (char= #\- (schar str 1))) ;; Gather up everything after --, and exit. @@ -134,7 +136,7 @@ (setf str nil)) (return nil)) (push str word-list)) - (setq str (pop cmd-strings)))))))) + (setq str (pop cmd-strings))))))))) (defun get-command-line-switch (sname) "Accepts the name of a switch as a string and returns the value of ===================================== src/code/save.lisp ===================================== --- a/src/code/save.lisp +++ b/src/code/save.lisp @@ -153,7 +153,8 @@ (process-command-line t) #+:executable (executable nil) - (batch-mode nil)) + (batch-mode nil) + (quiet nil)) "Saves a CMU Common Lisp core image in the file of the specified name. The following keywords are defined: @@ -191,8 +192,10 @@ :process-command-line If true (the default), process command-line switches via the normal - mechanisms, otherwise ignore all switches (except those processed by the - C startup code). + mechanisms, otherwise ignore all switches (except those processed by + the C startup code). In either case, the command line switches are + saved in *COMMAND-LINE-STRINGS* and + *COMMAND-LINE-APPLICATION-ARGUMENTS*. :executable If nil (the default), save-lisp will save using the traditional @@ -203,7 +206,14 @@ :batch-mode If nil (the default), then the presence of the -batch command-line switch will invoke batch-mode processing. If true, the produced core - will always be in batch-mode, regardless of any command-line switches." + will always be in batch-mode, regardless of any command-line switches. + + :quiet + If non-NIL, loading, compiling, and GC messages are suppressed. + This is equivalent to setting *load-verbose*, *compile-verbose*, + *compile-print*, *compile-progress*, *require-verbose*, and + *gc-verbose* all to NIL. If NIL (the default), the default + values of these variables are used." (unless (probe-file (directory-namestring core-file-name)) (error 'simple-file-error @@ -240,8 +250,7 @@ (environment-init) (dolist (f *after-save-initializations*) (funcall f)) (intl::setlocale) - (when process-command-line - (ext::process-command-strings)) + (ext::process-command-strings process-command-line) (setf *editor-lisp-p* nil) (macrolet ((find-switch (name) `(find ,name *command-line-switches* @@ -249,7 +258,8 @@ :test #'(lambda (x y) (declare (simple-string x y)) (string-equal x y))))) - (when (and process-command-line (find-switch "quiet")) + (when (or quiet + (and process-command-line (find-switch "quiet"))) (setq *load-verbose* nil *compile-verbose* nil *compile-print* nil @@ -285,8 +295,9 @@ (ext::invoke-switch-demons *command-line-switches* *command-switch-demons*)) (when (and print-herald - (not (and process-command-line - (find-switch "quiet")))) + (not (or quiet + (and process-command-line + (find-switch "quiet"))))) ;; Don't print the herald if -quiet is given. (print-herald))))) (funcall init-function)) ===================================== src/i18n/locale/cmucl.pot ===================================== --- a/src/i18n/locale/cmucl.pot +++ b/src/i18n/locale/cmucl.pot @@ -6713,8 +6713,10 @@ msgid "" "\n" " :process-command-line\n" " If true (the default), process command-line switches via the normal\n" -" mechanisms, otherwise ignore all switches (except those processed by the\n" -" C startup code).\n" +" mechanisms, otherwise ignore all switches (except those processed by\n" +" the C startup code). In either case, the command line switches are\n" +" saved in *COMMAND-LINE-STRINGS* and\n" +" *COMMAND-LINE-APPLICATION-ARGUMENTS*.\n" "\n" " :executable\n" " If nil (the default), save-lisp will save using the traditional\n" @@ -6725,7 +6727,14 @@ msgid "" " :batch-mode\n" " If nil (the default), then the presence of the -batch command-line\n" " switch will invoke batch-mode processing. If true, the produced core\n" -" will always be in batch-mode, regardless of any command-line switches." +" will always be in batch-mode, regardless of any command-line switches.\n" +"\n" +" :quiet\n" +" If non-NIL, loading, compiling, and GC messages are suppressed.\n" +" This is equivalent to setting *load-verbose*, *compile-verbose*,\n" +" *compile-print*, *compile-progress*, *require-verbose*, and\n" +" *gc-verbose* all to NIL. If NIL (the default), the default\n" +" values of these variables are used." msgstr "" #: src/code/save.lisp View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/1b8f72ed832bba4c49187a0e…

1 0

[Git][cmucl/cmucl][master] 3 commits: Add documentation for run-program
by Raymond Toy 27 Sep '16

27 Sep '16

Raymond Toy pushed to branch master at cmucl / cmucl Commits: a773ea60 by Raymond Toy at 2016-09-26T19:50:47-07:00 Add documentation for run-program * Document :input and :output behavior when they are string streams. * Document :element-type and :external-format - - - - - 48c1dd59 by Raymond Toy at 2016-09-26T19:51:12-07:00 Update the date Prepare for release 21b. - - - - - 1b8f72ed by Raymond Toy at 2016-09-26T20:03:24-07:00 Update from logs Fix some typos too. - - - - - 3 changed files: - src/docs/cmu-user/cmu-user.tex - src/docs/cmu-user/extensions.tex - src/general-info/release-21b.txt Changes: ===================================== src/docs/cmu-user/cmu-user.tex ===================================== --- a/src/docs/cmu-user/cmu-user.tex +++ b/src/docs/cmu-user/cmu-user.tex @@ -48,7 +48,7 @@ \newcommand{\keywords}{lisp, Common Lisp, manual, compiler, programming language implementation, programming environment} -\date{October 2014 \\ 20f} +\date{October 2016 \\ 21b} \begin{document} ===================================== src/docs/cmu-user/extensions.tex ===================================== --- a/src/docs/cmu-user/extensions.tex +++ b/src/docs/cmu-user/extensions.tex @@ -1099,7 +1099,8 @@ It is possible to run programs from Lisp by using the following function. \morekeys{\kwd{if-input-does-not-exist}} \yetmorekeys{\kwd{output} \kwd{if-output-exists}} \yetmorekeys{\kwd{error} \kwd{if-error-exists}} - \yetmorekeys{\kwd{status-hook}}}} + \yetmorekeys{\kwd{status-hook} \kwd{external-format}} + \yetmorekeys{\kwd{element-type}}}} \code{run-program} runs \var{program} in a child process. \var{Program} should be a pathname or string naming the program. @@ -1154,6 +1155,11 @@ It is possible to run programs from Lisp by using the following function. already contains all the input for the process. In this case \code{run-program} reads all the input from this stream before returning, so this cannot be used to interact with the process. + If \kwd{input} is a string stream, it is up to the caller to call + \code{string-encode} or other function to convert the string to + the appropriate encoding. In either case, the least significant 8 + bits of the \code{char-code} of each \code{character} is + sent to the program. \item[\kwd{if-input-does-not-exist}] This specifies what to do if the input file does not exist. The following values are valid: @@ -1172,7 +1178,10 @@ It is possible to run programs from Lisp by using the following function. \code{process-output} slot contains an input stream from which you can read the program's output. \kwd{output} can also be a stream in which case all output from the process is written to this - stream. + stream. If \kwd{output} is a string-stream, each octet read from + the program is converted to a character using \code{code-char}. + It is up to the caller to convert this using the appropriate + external format to create the desired encoded string. \item[\kwd{if-output-exists}] This specifies what to do if the output file already exists. The following values are valid: @@ -1197,6 +1206,15 @@ It is possible to run programs from Lisp by using the following function. the process changes status. This is especially useful when specifying \kwd{wait} as \nil. The function takes the process as a required argument. + + \item[\kwd{external-format}] This specifies the external format to + use for streams created for \code{run-program}. This does not + apply to string streams passed in as \kwd{input} or \kwd{output} + parameters. + + \item[\kwd{element-type}] If streams are created \code{run-program}, + use this as the \kwd{element-type} for the stream. Defaults to + \code{BASE-CHAR}. % \item[\kwd{before-execve}] This specifies a function to run in the % child process before it becomes the program to run. This is ===================================== src/general-info/release-21b.txt ===================================== --- a/src/general-info/release-21b.txt +++ b/src/general-info/release-21b.txt @@ -48,7 +48,7 @@ New in this release: WITH-FLOAT-TRAPS-MASKED. * (EXPT 0 power) doesn't throw INTEXP-LIMIT-ERROR anymore for any integer value of power. - * Starting cmucl with "-dyanmic-space-size 0" means using the + * Starting cmucl with "-dynamic-space-size 0" means using the maximum possible heap size for the platform. * More descriptive docstring for * *environment-list* @@ -56,16 +56,21 @@ New in this release: * Maximum dynamic-space-size on Linux reduced to 1530 MB because that's the largest available space on 32-bit Ubuntu 11.10. * For linux, darwin, and solaris/sparc, the binding stack and - control stack are now mapped into memory whereever the OS wishes + control stack are now mapped into memory wherever the OS wishes to place them instead of being mapped into a fixed location. This is indicated by new feature :relocatable-stacks. * ANSI compliance fixes: * PATHNAME-MATCH-P did not accept search-lists. + * (compile 'foo) returns the compiled function if foo is already + compiled. (See Ticket #24). This is a change in behavior for + developers where foo would be recompiled if the source was + available. Developers might want to investigate uncompile + combined with compile to get the old behavior back. - * Bugfixes: + * Bug fixes: * Linux was missing unix-setitimer which prevented saving cores. - * Generate inxact exceptions more carefully. + * Generate inexact exceptions more carefully. * Fix FP issue when building with Xcode 7.2 (and newer versions of clang). (See ticket #12.) * Cleanups in handling floating-point exceptions. See Tickets #15 @@ -94,8 +99,13 @@ New in this release: * Ticket #27 fixed: Regression: ASDF test failures * Ticket #28 fixed: Recursive function definition during cross-compile + * Ticket #30 fixed: Compilation of (describe 'foo) + * Ticket #31 fixed: (compile #'foo) fails + * Ticket #24 fixed: Compilation of (compile 'foo) + * Ticket #32 fixed: doc fix: ext:run-program has no before-execve option * Other changes: + * Update user manual. * Improvements to the PCL implementation of CLOS: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/9fe2a7d9699b1a60d874868c…

1 0

[Git][cmucl/cmucl][master] 4 commits: Remove :before-execve option
by Raymond Toy 26 Sep '16

26 Sep '16

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 47b1e69b by Raymond Toy at 2016-09-25T19:10:25-07:00 Remove :before-execve option The documentation for this keyward option to run-program was commented, but the actual option was not removed from the list of options for run-program. Remove it. - - - - - 21ae1a78 by Raymond Toy at 2016-09-25T19:26:54-07:00 Merge branch 'master' into rtoy-32-no-before-execve-option - - - - - 2cc0df30 by Raymond Toy at 2016-09-25T19:28:17-07:00 Add test for issue #32. - - - - - 9fe2a7d9 by Raymond Toy at 2016-09-26T02:29:33+00:00 Merge branch 'rtoy-32-no-before-execve-option' into 'master' Fix #32: Remove :before-execve option The documentation for this keyward option to run-program was commented, but the actual option was not removed from the list of options for run-program. Remove it. See merge request !14 - - - - - 2 changed files: - src/docs/cmu-user/extensions.tex - tests/issues.lisp Changes: ===================================== src/docs/cmu-user/extensions.tex ===================================== --- a/src/docs/cmu-user/extensions.tex +++ b/src/docs/cmu-user/extensions.tex @@ -1099,7 +1099,7 @@ It is possible to run programs from Lisp by using the following function. \morekeys{\kwd{if-input-does-not-exist}} \yetmorekeys{\kwd{output} \kwd{if-output-exists}} \yetmorekeys{\kwd{error} \kwd{if-error-exists}} - \yetmorekeys{\kwd{status-hook} \kwd{before-execve}}}} + \yetmorekeys{\kwd{status-hook}}}} \code{run-program} runs \var{program} in a child process. \var{Program} should be a pathname or string naming the program. ===================================== tests/issues.lisp ===================================== --- a/tests/issues.lisp +++ b/tests/issues.lisp @@ -315,3 +315,9 @@ (:tag :issues) (let* ((test-file #.(merge-pathnames #p"resources/issue-24.lisp" cl:*load-pathname*))) (assert-true (compile-file test-file :load t)))) + +(define-test issue.32 + (:tag :issues) + (assert-error 'kernel:simple-program-error + (ext:run-program "cat" nil + :before-execve t))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/d6ae3337990d21c6e9fb236f…

1 0

[Git][cmucl/cmucl][rtoy-32-no-before-execve-option] 6 commits: Fix #24: compile already compiled function
by Raymond Toy 26 Sep '16

26 Sep '16

Raymond Toy pushed to branch rtoy-32-no-before-execve-option at cmucl / cmucl Commits: 48d1f01f by Raymond Toy at 2016-09-10T12:40:03-07:00 Fix #24: compile already compiled function If the function is already compiled and we don't have the source for it any more, just return without recompiling anything. - - - - - ae93b43b by Raymond Toy at 2016-09-10T12:40:34-07:00 Add test for issue #24. - - - - - 94259938 by Raymond Toy at 2016-09-25T18:59:48-07:00 Don't try to get the lambda-expression for a function Since we're just going to return the original compiled function, there's no point in trying to get the function-lambda-expression of the function. So, if we're given a function, just return the (default) definition. - - - - - d6ae3337 by Raymond Toy at 2016-09-26T02:01:07+00:00 Merge branch 'rtoy-fix-24-compile-foo' into 'master' Fix #24: compilation of (compile 'foo) If the function is already compiled and we don't have the source for it, we don't need to do anything, per CLHS. Test case added as well. See merge request !12 - - - - - 21ae1a78 by Raymond Toy at 2016-09-25T19:26:54-07:00 Merge branch 'master' into rtoy-32-no-before-execve-option - - - - - 2cc0df30 by Raymond Toy at 2016-09-25T19:28:17-07:00 Add test for issue #32. - - - - - 2 changed files: - src/compiler/main.lisp - tests/issues.lisp Changes: ===================================== src/compiler/main.lisp ===================================== --- a/src/compiler/main.lisp +++ b/src/compiler/main.lisp @@ -2041,11 +2041,7 @@ ((or cons eval:interpreted-function) `#',(get-lambda-to-compile definition)) (function - (multiple-value-bind (exp lexenv) - (function-lambda-expression definition) - (if (and exp (not lexenv)) - `#',exp - `',definition))))) + definition))) (*source-info* (make-lisp-source-info form)) (*top-level-lambdas* ()) (*converting-for-interpreter* nil) @@ -2069,6 +2065,14 @@ (*gensym-counter* 0) (*current-function-names* (list name)) (intl::*default-domain* intl::*default-domain*)) + ;; As mentioned above, we can return the same function if the + ;; function was already compiled. We do this when FORM is EQ + ;; to DEFINITION (which happens above if we have a compiled + ;; function that we don't have the source for or was defined + ;; in a non-null environment. + (when (and name (eq form definition)) + (return-from compile + (values name nil nil))) (with-debug-counters (clear-stuff) (find-source-paths form 0) ===================================== tests/issues.lisp ===================================== --- a/tests/issues.lisp +++ b/tests/issues.lisp @@ -310,3 +310,14 @@ (assert-true (pathnamep fasl-file)) (assert-equalp (list fasl-file nil nil) (multiple-value-list (compile-file test-file :load t))))) + +(define-test issue.24 + (:tag :issues) + (let* ((test-file #.(merge-pathnames #p"resources/issue-24.lisp" cl:*load-pathname*))) + (assert-true (compile-file test-file :load t)))) + +(define-test issue.32 + (:tag :issues) + (assert-error 'kernel:simple-program-error + (ext:run-program "cat" nil + :before-execve t))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/47b1e69b80394e6bc8fb56cf…

1 0