drakma-devel May 2010

drakma-devel@common-lisp.net

4 participants
6 discussions

[drakma-devel] New version 1.2.1
by Edi Weitz 19 May '10

19 May '10

Yeah, sorry, I should have been more careful. At least this was reported by three persons in a couple of minutes which gives me the warm and fuzzy feeling that there are enough users to catch mistakes... :) Thanks. Bugfix release online. Edi. On Wed, May 19, 2010 at 8:36 PM, Zach Beane <xach(a)xach.com> wrote: > Edi Weitz <edi(a)agharta.de> writes: > >> Available from http://weitz.de/ as usual. ChangeLog below, thanks to >> anyone who sent patches or bug reports. > > This version does not compile for me; make-ssl-stream in util.lisp has > an extra paren at the end of line 334. > > Zach > >

1 0

[drakma-devel] New version 1.2.0
by Edi Weitz 19 May '10

19 May '10

Available from http://weitz.de/ as usual. ChangeLog below, thanks to anyone who sent patches or bug reports. Edi. Version 1.2.0 2010-05-19 Introduced *REMOVE-DUPLICATE-COOKIES-P* (Ryan Davis) Enabled https through a proxy (Bill St. Clair and Dave Lambert) Bugfix for redirect of a request through a proxy (Bill St. Clair) Export PARSE-COOKIE-DATE Safer method to render URIs Allowed for GET/POST parameters without a value (seen on Lotus webservers)

2 1

[drakma-devel] New Chunga version 1.1.1
by Edi Weitz 19 May '10

19 May '10

And, again on weitz.de, there's also a new release of Chunga. Version 1.1.1 2010-05-19 Read quoted cookie values (Red Daly)

1 0

[drakma-devel] Cookie-parsing patch for chunga
by Red Daly 17 May '10

17 May '10

Cookies often have quoted-strings, as described in http://www.w3.org/Protocols/rfc2109/rfc2109 . This patch adds quoted string support to the auxiliary cookie parsing functionality provided by Chunga. *crossing my fingers that I formatted the patch properly* - Red

1 0

Re: [drakma-devel] https through a proxy (Edi Weitz)
by Bill St. Clair 09 May '10

09 May '10

On 5/8/10 12:00PM, drakma-devel-request(a)common-lisp.net wrote: > Date: Fri, 7 May 2010 21:43:17 +0200 > From: Edi Weitz <edi(a)agharta.de> > Subject: Re: [drakma-devel] https through a proxy > To: General interest list for Drakma and Chunga > <drakma-devel(a)common-lisp.net> > Thanks for the patch. I can't really read it because your email > client broke it, but I think I get the idea. Yes, I didn't integrate > the old patch and IIRC I didn't do it because it was a LW-only > solution. Obviously, I don't like the new solution either because it > uses unexported symbols (and you can't change the underlying stream > for a reason). > > As far as I understand, all this happens while the headers are still > sent and while chunking isn't really needed. I haven't really thought > about the details, but maybe it would be possible to change the order > of how and when the streams are wrapped and use only exported > functionality. In the worst case, one could "unwrap" the stream, > attach SSL, and then "rewrap" it. Of course, the easiest solution > would be if CL+SSL and AllegroCL had something similar to LispWorks' > comm:attach-ssl. > > Anyway, if someone wants to work on a "clean" solution to this > problem, I'll happily review it. I cleaned up my patch. It now contains no double-colons. It ends up wrapping with the flexi-stream and chunking-stream twice in the https through a proxy case, as not wrapping didn't work (it may work to wrap the proxy communication with only a flexi-stream, but I didn't try that). I also fixed a bug that caused it to include on the first (GET) line to the server the entire URI instead of only the path part of it when a request through a proxy with keep-alive gets redirected. Patch attached. -Bill

1 0

[drakma-devel] https through a proxy
by Bill St. Clair 07 May '10

07 May '10

I have an application where I need to do https requests through a proxy server. It hangs in Drakma 1.1.0. I found the fix, for Lispworks only, at http://www.mail-archive.com/drakma-devel@common-lisp.net/msg00200.html . I guess Edi didn't integrate it yet. I made it work in CCL 1.5, meaning it will probably work everywhere, but I did't test Allegro. My fix is a little ugly, as I'm setting a slot with no writer inside of the chunga stream, but it works for me. Patch below. -Bill St. Clair wws(a)clozure.com ==== diff -rN old-drakma/request.lisp new-drakma/request.lisp 429c429,430 < (let (http-stream must-close done) --- > (let ((proxying-https? (and proxy (not stream) (eq :https (puri:uri-scheme uri)))) > http-stream raw-http-stream must-close done) 437,438c438,440 < (use-ssl (or force-ssl < (eq (uri-scheme uri) :https)))) --- > (use-ssl (and (not proxying-https?) > (or force-ssl > (eq (uri-scheme uri) :https))))) 470a473 > (setq raw-http-stream http-stream) 498a502,528 > (when proxying-https? > ;; Setup a tunnel through the proxy server to the > ;; final destination. > (write-http-line "CONNECT ~A:~A HTTP/1.1"(puri:uri-host uri) > (or (puri:uri-port uri) 443)) > (write-http-line "Host: ~A:~A" (puri:uri-host uri) > (or (puri:uri-port uri) 443)) > (write-http-line "") > (force-output http-stream) > ;; Check we get a 200 response before proceeding. > (let ((line (read-status-line http-stream *header-stream*))) > (unless (eq (second line) 200) > (error "Unable to establish HTTPS tunnel through proxy."))) > ;; Got a connection. We have to read a blank line, > ;; turn on SSL, and then we can transmit. > (read-line* http-stream) > #+:lispworks > (comm:attach-ssl raw-http-stream :ssl-side :client) > #-lispworks > (setf (slot-value (flexi-stream-stream http-stream) 'chunga::real-stream) ;evil > #+:allegro > (socket:make-ssl-client-stream raw-http-stream) > #-:allegro > (let ((s raw-http-stream)) > (cl+ssl:make-ssl-client-stream > (cl+ssl:stream-fd s) > :close-callback (lambda () (close s)))))) 513c543 < (cond (proxy (render-uri uri nil)) --- > (cond ((and proxy (not proxying-https?)) (render-uri uri nil))

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

drakma-devel May 2010