July 2010 - drakma-devel@common-lisp.net - mailman3.common-lisp.net

Re: [drakma-devel] duplicate cookies problem with proposed patch
by Vsevolod Dyomkin 29 Jul '10

29 Jul '10

Hi, I want to re-raise the topic of duplicate cookies. I've had this issue with the older version of Drakma (1.1.0) and was unaware of the patch with *remove-duplicate-cookies-p*. But investigating the problem (before I've read the discussion in the mailing list), I've encountered it's cause in the source code, that is highlighted in the attached diff. The problem is, that SET-DIFFERENCE and UNION are not supplied COOKIE= tests in UPDATE-COOKIES. It still remains in the current version (1.2.2) and can be tested like this: CL-USER> (defvar *cookies* (make-instance 'drakma:cookie-jar)) *COOKIES* CL-USER> (drakma::update-cookies (list (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/") (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/")) *cookies*) #<DRAKMA:COOKIE-JAR (with 2 cookies) {B629521}> I think, that this is a bug, because without the TEST argument, for example, SET-DIFFERENCE in this case will constantly return the first set (see below), so either the code should be simplified or the test argument should be added. CL-USER> (set-difference (list (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/") (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/")) (list (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/") (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/"))) (#<DRAKMA:COOKIE lang=en; path=/; domain=site.com> #<DRAKMA:COOKIE lang=en; path=/; domain=site.com>) So, I believe, that this part should also be fixed, especially, since UPDATE-COOKIES is called alongside with GET-COOKIES. Best regards, Vsevolod

1 0

[drakma-devel] Regarding URL encoding...
by Herbert Snorrason 21 Jul '10

21 Jul '10

Although I understand why it's not done by default, it seems slightly odd to me that Drakma doesn't provide a URL-ENCODE function whereas Hunchentoot does. I would've thought the need was considerably more immediate in Drakma... With greetings, Herbert Snorrason

2 2

[drakma-devel] Patch: Unclosed <code> node in doc/index.html
by Walter GR 14 Jul '10

14 Jul '10

Patch attached. An unclosed <code> node in doc/index.html causes all text after the documentation for *allow-dotless-cookie-domains-p* to render in a monospaced font. This is my first patch ever, so let me know if I did it wrong. Thanks, Walter -- The Online Slang Dictionary - Now a wiki! http://onlineslangdictionary.com/

2 2

[drakma-devel] New Drakma release 1.2.2
by Edi Weitz 10 Jul '10

10 Jul '10

There's a new release of Drakma out at weitz.de. This is a bugfix release. ChangeLog: http://weitz.de/drakma/CHANGELOG.txt

1 0