drakma-devel

drakma-devel@common-lisp.net

182 discussions

[drakma-devel] Patch: Unclosed <code> node in doc/index.html
by Walter GR 14 Jul '10

14 Jul '10

Patch attached. An unclosed <code> node in doc/index.html causes all text after the documentation for *allow-dotless-cookie-domains-p* to render in a monospaced font. This is my first patch ever, so let me know if I did it wrong. Thanks, Walter -- The Online Slang Dictionary - Now a wiki! http://onlineslangdictionary.com/

2 2

[drakma-devel] New Drakma release 1.2.2
by Edi Weitz 10 Jul '10

10 Jul '10

There's a new release of Drakma out at weitz.de. This is a bugfix release. ChangeLog: http://weitz.de/drakma/CHANGELOG.txt

1 0

[drakma-devel] New version 1.2.1
by Edi Weitz 19 May '10

19 May '10

Yeah, sorry, I should have been more careful. At least this was reported by three persons in a couple of minutes which gives me the warm and fuzzy feeling that there are enough users to catch mistakes... :) Thanks. Bugfix release online. Edi. On Wed, May 19, 2010 at 8:36 PM, Zach Beane <xach(a)xach.com> wrote: > Edi Weitz <edi(a)agharta.de> writes: > >> Available from http://weitz.de/ as usual. ChangeLog below, thanks to >> anyone who sent patches or bug reports. > > This version does not compile for me; make-ssl-stream in util.lisp has > an extra paren at the end of line 334. > > Zach > >

1 0

[drakma-devel] New version 1.2.0
by Edi Weitz 19 May '10

19 May '10

Available from http://weitz.de/ as usual. ChangeLog below, thanks to anyone who sent patches or bug reports. Edi. Version 1.2.0 2010-05-19 Introduced *REMOVE-DUPLICATE-COOKIES-P* (Ryan Davis) Enabled https through a proxy (Bill St. Clair and Dave Lambert) Bugfix for redirect of a request through a proxy (Bill St. Clair) Export PARSE-COOKIE-DATE Safer method to render URIs Allowed for GET/POST parameters without a value (seen on Lotus webservers)

2 1

[drakma-devel] New Chunga version 1.1.1
by Edi Weitz 19 May '10

19 May '10

And, again on weitz.de, there's also a new release of Chunga. Version 1.1.1 2010-05-19 Read quoted cookie values (Red Daly)

1 0

[drakma-devel] Cookie-parsing patch for chunga
by Red Daly 17 May '10

17 May '10

Cookies often have quoted-strings, as described in http://www.w3.org/Protocols/rfc2109/rfc2109 . This patch adds quoted string support to the auxiliary cookie parsing functionality provided by Chunga. *crossing my fingers that I formatted the patch properly* - Red

1 0

Re: [drakma-devel] https through a proxy (Edi Weitz)
by Bill St. Clair 09 May '10

09 May '10

On 5/8/10 12:00PM, drakma-devel-request(a)common-lisp.net wrote: > Date: Fri, 7 May 2010 21:43:17 +0200 > From: Edi Weitz <edi(a)agharta.de> > Subject: Re: [drakma-devel] https through a proxy > To: General interest list for Drakma and Chunga > <drakma-devel(a)common-lisp.net> > Thanks for the patch. I can't really read it because your email > client broke it, but I think I get the idea. Yes, I didn't integrate > the old patch and IIRC I didn't do it because it was a LW-only > solution. Obviously, I don't like the new solution either because it > uses unexported symbols (and you can't change the underlying stream > for a reason). > > As far as I understand, all this happens while the headers are still > sent and while chunking isn't really needed. I haven't really thought > about the details, but maybe it would be possible to change the order > of how and when the streams are wrapped and use only exported > functionality. In the worst case, one could "unwrap" the stream, > attach SSL, and then "rewrap" it. Of course, the easiest solution > would be if CL+SSL and AllegroCL had something similar to LispWorks' > comm:attach-ssl. > > Anyway, if someone wants to work on a "clean" solution to this > problem, I'll happily review it. I cleaned up my patch. It now contains no double-colons. It ends up wrapping with the flexi-stream and chunking-stream twice in the https through a proxy case, as not wrapping didn't work (it may work to wrap the proxy communication with only a flexi-stream, but I didn't try that). I also fixed a bug that caused it to include on the first (GET) line to the server the entire URI instead of only the path part of it when a request through a proxy with keep-alive gets redirected. Patch attached. -Bill

1 0

[drakma-devel] https through a proxy
by Bill St. Clair 07 May '10

07 May '10

I have an application where I need to do https requests through a proxy server. It hangs in Drakma 1.1.0. I found the fix, for Lispworks only, at http://www.mail-archive.com/drakma-devel@common-lisp.net/msg00200.html . I guess Edi didn't integrate it yet. I made it work in CCL 1.5, meaning it will probably work everywhere, but I did't test Allegro. My fix is a little ugly, as I'm setting a slot with no writer inside of the chunga stream, but it works for me. Patch below. -Bill St. Clair wws(a)clozure.com ==== diff -rN old-drakma/request.lisp new-drakma/request.lisp 429c429,430 < (let (http-stream must-close done) --- > (let ((proxying-https? (and proxy (not stream) (eq :https (puri:uri-scheme uri)))) > http-stream raw-http-stream must-close done) 437,438c438,440 < (use-ssl (or force-ssl < (eq (uri-scheme uri) :https)))) --- > (use-ssl (and (not proxying-https?) > (or force-ssl > (eq (uri-scheme uri) :https))))) 470a473 > (setq raw-http-stream http-stream) 498a502,528 > (when proxying-https? > ;; Setup a tunnel through the proxy server to the > ;; final destination. > (write-http-line "CONNECT ~A:~A HTTP/1.1"(puri:uri-host uri) > (or (puri:uri-port uri) 443)) > (write-http-line "Host: ~A:~A" (puri:uri-host uri) > (or (puri:uri-port uri) 443)) > (write-http-line "") > (force-output http-stream) > ;; Check we get a 200 response before proceeding. > (let ((line (read-status-line http-stream *header-stream*))) > (unless (eq (second line) 200) > (error "Unable to establish HTTPS tunnel through proxy."))) > ;; Got a connection. We have to read a blank line, > ;; turn on SSL, and then we can transmit. > (read-line* http-stream) > #+:lispworks > (comm:attach-ssl raw-http-stream :ssl-side :client) > #-lispworks > (setf (slot-value (flexi-stream-stream http-stream) 'chunga::real-stream) ;evil > #+:allegro > (socket:make-ssl-client-stream raw-http-stream) > #-:allegro > (let ((s raw-http-stream)) > (cl+ssl:make-ssl-client-stream > (cl+ssl:stream-fd s) > :close-callback (lambda () (close s)))))) 513c543 < (cond (proxy (render-uri uri nil)) --- > (cond ((and proxy (not proxying-https?)) (render-uri uri nil))

2 1

[drakma-devel] duplicate cookies problem with proposed patch
by Ryan Davis 07 Apr '10

07 Apr '10

I'm running into a problem with duplicated cookies. This is due to misbehaving servers sending back duplicate Set-Cookie headers in the same response, like this: Set-Cookie: JSESSIONID=foo; Path=/; Secure Set-Cookie: JSESSIONID=bar; Path=/; Secure Firefox deals with this by picked the last cookie value specified. There is no logic in drakma currently to handle that, and so my cookie-jar is getting two JSESSION cookies, and further requests are sending both cookies. I do not control the servers returning me these duplicate headers. This patch adds a unique-cookies function that iterates through cookie objects, keeping only the last one. This is then called in get-cookies to ensure no duplicate cookie objects are propagated to the rest of the system. I've got my "make it work on a friday afternoon" solution in the attached patch, but I'm not really happy with it long term, and wanted some advice. Problems I see: * I think the dolist/find combination is a recipe for performance problems with many cookies * It seems odd to build up a list of cookies, then rebuild it * The most common case of no duplicate cookies has an extra bunch of consing to rebuilding up the list * I think there should be a user choice of "ignore all but the last cookie" vs "ignore all but the first cookie" vs "leave them all in there" Some thoughts on how to proceed: 1. Add a exported *redundant-cookie-strategy* variable, with values :keep-all, :keep-first, and :keep-last, defaulting to :keep-all (the current behavior). 2. remove the unique-cookies function and rewrite get-cookies to implement the *redundant-cookie-strategy*, making one pass through parsed-cookies. 3. leave get-cookies mostly as-is, but add some detection for duplicates, and run unique-cookies only if it we need to Thanks, Ryan PS: I'm still kinda new to contributing on open source projects via emailed patches, sorry if this is in a bad format. I read http://weitz.de/patches.html and created this patch from my working copy using >diff -u ../drakma-1.1.0/cookies.lisp cookies.lisp

2 6

[drakma-devel] DelegationFailure with Amazon CloudWatch
by David Young 24 Feb '10

24 Feb '10

Hi. I really doubt this is a drakma issue but Amazon has been of no help. I've written a Lisp interface to the EC2 Query API (CL-EC2<http://common-lisp.net/project/cl-ec2/>); it uses Drakma has its http client. All of the implemented API calls work just fine with the exception of the Cloudwatch ListMetrics call, which for some reason began failing this week. Amazon's cloudwatch scratchpad tool fails now also with the same error, but I tried the python boto library and it works fine, as does the Amazon command-line tool mon-list-metrics. Here's the header output: SIERRA(29): (ec2:with-header-stream () (cw:list-metrics)) GET /?AWSAccessKeyId=<our access key>?Action=ListMetrics&SignatureMethod=HmacSHA256&SignatureVersion=2&Timestamp=2010-02-24T20%3A46%3A25Z&Version=2009-05-15&Signature=BHAB8OAeGU6IRp6Ki%2BDuEKM9%2FOiKKOSu%2FGntICOotqI%3D HTTP/1.1 Host: monitoring.amazonaws.com User-Agent: Drakma/1.1.0 (SBCL 1.0.30; Linux; 2.6.30.10-105.2.16.fc11.x86_64; http://weitz.de/drakma/) Accept: */* Connection: close HTTP/1.1 400 Bad Request x-amzn-RequestId: ac7304ba-2185-11df-a0eb-cd40a3846a7b Content-Type: text/xml Content-Length: 270 Date: Wed, 24 Feb 2010 20:46:25 GMT And here's the condition as reported by our library: Amazon EC2 Error: Bad Request: status: 400 uri: http://monitoring.amazonaws.com?AWSAccessKeyId=<our access key>&Action=ListMetrics&SignatureMethod=HmacSHA256&SignatureVersion=2&Timestamp=2010-02-24T20%3A46%3A25Z&Version=2009-05-15&Signature=BHAB8OAeGU6IRp6Ki%2BDuEKM9%2FOiKKOSu%2FGntICOotqI%3D headers: ((X-AMZN-REQUESTID . ac7304ba-2185-11df-a0eb-cd40a3846a7b) (CONTENT-TYPE . text/xml) (CONTENT-LENGTH . 270) (DATE . Wed, 24 Feb 2010 20:46:25 GMT)) body: ((ErrorResponse xmlns http://monitoring.amazonaws.com/doc/2009-05-15/) (Error (Type Sender) (Code DelegationFailure) (Message Malformed token)) (RequestId ac7304ba-2185-11df-a0eb-cd40a3846a7b)) [Condition of type EC2:EC2-ERROR] I'm just looking for some ideas, so forgive me if I've bothered anyone. What the hell is a DelegationFailure anyway? Sorry to trouble you folks. Thanks. -- david -- And now these three remain: faith, hope, and love. But the greatest of these is love. -- 1 Corinthians 13:13 To truly engage with how the world is, our hearts are going to be broken again and again. -- Rob Bell, "Velvet Elvis, Repainting the Christian Faith" To produce without possessing, to work without expecting, to enlarge without usurping. This is the supreme virtue. -- Lao-Tzu

1 0

← Newer
1
2
3
4
5
6
7
8
...
19
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

drakma-devel