Sorry for typing your name wrong... and thanks for trying this. I'll debug it on Linux here when I get a chance. Was gone most of the day.
Here's my asdf directory which I think has the latest of everything.
drwxr-xr-x 5 ross ross 4096 2007-08-14 07:33 asdf-install lrwxrwxrwx 1 ross ross 42 2007-09-28 22:13 asdf-install.asd -> asdf-install/asdf-install/asdf-install.asd drwxr-xr-x 3 ross ross 4096 2007-09-28 21:44 chunga-0.4.0 lrwxrwxrwx 1 ross ross 23 2007-09-28 22:14 chunga.asd -> chunga-0.4.0/chunga.asd drwxr-xr-x 2 ross ross 4096 2007-09-28 21:41 cl-base64-3.3.2 lrwxrwxrwx 1 ross ross 29 2007-09-28 22:14 cl-base64.asd -> cl-base64-3.3.2/cl-base64.asd drwxr-xr-x 3 ross ross 4096 2007-09-14 12:15 cl-log lrwxrwxrwx 1 ross ross 18 2007-09-28 22:14 cl-log.asd -> cl-log/cl-log.asdf drwxr-xr-x 3 ross ross 4096 2007-09-24 13:36 cl-utilities-1.2.4 lrwxrwxrwx 1 ross ross 35 2007-09-28 22:14 cl-utilities.asd -> cl-utilities-1.2.4/cl-utilities.asd drwxr-xr-x 3 ross ross 4096 2007-09-29 00:01 drakma-0.10.1 lrwxrwxrwx 1 ross ross 24 2007-09-28 22:14 drakma.asd -> drakma-0.10.1/drakma.asd drwxr-xr-x 4 ross ross 4096 2007-09-29 16:50 flexi-streams-0.13.0 lrwxrwxrwx 1 ross ross 38 2007-09-28 22:15 flexi-streams.asd -> flexi-streams-0.13.0/flexi-streams.asd drwxr-xr-x 2 ross ross 4096 2007-09-28 21:44 puri-1.5.1 lrwxrwxrwx 1 ross ross 19 2007-09-28 22:15 puri.asd -> puri-1.5.1/puri.asd drwxr-xr-x 3 ross ross 4096 2007-09-28 21:49 trivial-gray-streams-2006-09-16 lrwxrwxrwx 1 ross ross 56 2007-09-28 22:15 trivial-gray-streams.asd -> trivial-gray-streams-2006-09-16/trivial-gray-streams.asd drwxr-xr-x 6 ross ross 4096 2007-09-28 21:42 usocket-0.3.5 lrwxrwxrwx 1 ross ross 25 2007-09-28 22:16 usocket.asd -> usocket-0.3.5/usocket.asd drwxr-xr-x 2 ross ross 4096 2007-09-14 12:21 xml-emitter-1.0.2 lrwxrwxrwx 1 ross ross 33 2007-09-28 22:16 xml-emitter.asd -> xml-emitter-1.0.2/xml-emitter.asd
Thanks, Ross
----- Original Message ----- From: "Edi Weitz" edi@agharta.de To: "General interest list for Drakma and Chunga" drakma-devel@common-lisp.net Sent: Saturday, September 29, 2007 12:55:33 PM (GMT-0800) America/Los_Angeles Subject: Re: [drakma-devel] utf-8 question
On Sat, 29 Sep 2007 09:21:50 -0700 (PDT), Ross Jekel ross@sourcelabs.com wrote:
Thanks for your help, Eli.
Edi...
Here's what I get. I'll try to debug this as well a bit later today.
I also just tried with Allegro CL 8.1 (but I only have it on Windows). Works fine for me. Could you check if you're using the newest versions of all the dependencies, specifically of Chunga and FLEXI-STREAMS? _______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel
Okay, I tracked down my problem.
I'm using Allegro CL in case-sensitive modern mode (the default). There are several places in chunga and drakma that might do something like (intern (string-upper somevalue) :keyword) making uppercase symbols such as :CONTENT-TYPE for headers or :UTF-8 for encoding types. If there is any code that compares against the lower-case symbol (such as :content-type in get-content-type in drakma/read.lisp), the match fails.
I guess I haven't had a need for case-sensitivity, so it is probably more trouble than it is worth to have it on.
Ross ----- Original Message ----- From: "Ross Jekel" ross@sourcelabs.com To: "General interest list for Drakma and Chunga" drakma-devel@common-lisp.net Sent: Saturday, September 29, 2007 4:52:28 PM (GMT-0800) America/Los_Angeles Subject: Re: [drakma-devel] utf-8 question
Sorry for typing your name wrong... and thanks for trying this. I'll debug it on Linux here when I get a chance. Was gone most of the day.
Here's my asdf directory which I think has the latest of everything.
drwxr-xr-x 5 ross ross 4096 2007-08-14 07:33 asdf-install lrwxrwxrwx 1 ross ross 42 2007-09-28 22:13 asdf-install.asd -> asdf-install/asdf-install/asdf-install.asd drwxr-xr-x 3 ross ross 4096 2007-09-28 21:44 chunga-0.4.0 lrwxrwxrwx 1 ross ross 23 2007-09-28 22:14 chunga.asd -> chunga-0.4.0/chunga.asd drwxr-xr-x 2 ross ross 4096 2007-09-28 21:41 cl-base64-3.3.2 lrwxrwxrwx 1 ross ross 29 2007-09-28 22:14 cl-base64.asd -> cl-base64-3.3.2/cl-base64.asd drwxr-xr-x 3 ross ross 4096 2007-09-14 12:15 cl-log lrwxrwxrwx 1 ross ross 18 2007-09-28 22:14 cl-log.asd -> cl-log/cl-log.asdf drwxr-xr-x 3 ross ross 4096 2007-09-24 13:36 cl-utilities-1.2.4 lrwxrwxrwx 1 ross ross 35 2007-09-28 22:14 cl-utilities.asd -> cl-utilities-1.2.4/cl-utilities.asd drwxr-xr-x 3 ross ross 4096 2007-09-29 00:01 drakma-0.10.1 lrwxrwxrwx 1 ross ross 24 2007-09-28 22:14 drakma.asd -> drakma-0.10.1/drakma.asd drwxr-xr-x 4 ross ross 4096 2007-09-29 16:50 flexi-streams-0.13.0 lrwxrwxrwx 1 ross ross 38 2007-09-28 22:15 flexi-streams.asd -> flexi-streams-0.13.0/flexi-streams.asd drwxr-xr-x 2 ross ross 4096 2007-09-28 21:44 puri-1.5.1 lrwxrwxrwx 1 ross ross 19 2007-09-28 22:15 puri.asd -> puri-1.5.1/puri.asd drwxr-xr-x 3 ross ross 4096 2007-09-28 21:49 trivial-gray-streams-2006-09-16 lrwxrwxrwx 1 ross ross 56 2007-09-28 22:15 trivial-gray-streams.asd -> trivial-gray-streams-2006-09-16/trivial-gray-streams.asd drwxr-xr-x 6 ross ross 4096 2007-09-28 21:42 usocket-0.3.5 lrwxrwxrwx 1 ross ross 25 2007-09-28 22:16 usocket.asd -> usocket-0.3.5/usocket.asd drwxr-xr-x 2 ross ross 4096 2007-09-14 12:21 xml-emitter-1.0.2 lrwxrwxrwx 1 ross ross 33 2007-09-28 22:16 xml-emitter.asd -> xml-emitter-1.0.2/xml-emitter.asd
Thanks, Ross
----- Original Message ----- From: "Edi Weitz" edi@agharta.de To: "General interest list for Drakma and Chunga" drakma-devel@common-lisp.net Sent: Saturday, September 29, 2007 12:55:33 PM (GMT-0800) America/Los_Angeles Subject: Re: [drakma-devel] utf-8 question
On Sat, 29 Sep 2007 09:21:50 -0700 (PDT), Ross Jekel ross@sourcelabs.com wrote:
Thanks for your help, Eli.
Edi...
Here's what I get. I'll try to debug this as well a bit later today.
I also just tried with Allegro CL 8.1 (but I only have it on Windows). Works fine for me. Could you check if you're using the newest versions of all the dependencies, specifically of Chunga and FLEXI-STREAMS? _______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel
_______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel
On Sun, 30 Sep 2007 10:40:24 -0700 (PDT), Ross Jekel ross@sourcelabs.com wrote:
I'm using Allegro CL in case-sensitive modern mode (the default). There are several places in chunga and drakma that might do something like (intern (string-upper somevalue) :keyword) making uppercase symbols such as :CONTENT-TYPE for headers or :UTF-8 for encoding types. If there is any code that compares against the lower-case symbol (such as :content-type in get-content-type in drakma/read.lisp), the match fails.
Ah, good, thanks for the analysis. I myself have never used "modern mode" and I don't really care about it, so I won't "fix" this myself, but if someone is interested in doing it, I'll gladly accept clean patches, of course.
Thanks again, Edi.
To the best of my knowledge, the two attached patches should work on all common lisp implementations. Basically I just added an "as-keyword" function to the util.lisp of both chunga and drakma that checks the readtable-case and uses #'string-upcase to convert the string if it is :upcase, otherwise it uses #'string-downcase (since the symbols in your source files are typically typed in all lowercase).
The two places (one in chunga read.lisp and one in drakma request.lisp) that call (intern (string-upcase ..) :keyword) were replaced with the (as-keyword ) form.
I've attached the diff -u output trying to follow your patching rules.
If the attachment doesn't go through, I'll paste the patches in.
Ross ----- Original Message ----- From: "Edi Weitz" edi@agharta.de To: "General interest list for Drakma and Chunga" drakma-devel@common-lisp.net Sent: Sunday, September 30, 2007 11:37:46 AM (GMT-0800) America/Los_Angeles Subject: Re: [drakma-devel] utf-8 question
On Sun, 30 Sep 2007 10:40:24 -0700 (PDT), Ross Jekel ross@sourcelabs.com wrote:
I'm using Allegro CL in case-sensitive modern mode (the default). There are several places in chunga and drakma that might do something like (intern (string-upper somevalue) :keyword) making uppercase symbols such as :CONTENT-TYPE for headers or :UTF-8 for encoding types. If there is any code that compares against the lower-case symbol (such as :content-type in get-content-type in drakma/read.lisp), the match fails.
Ah, good, thanks for the analysis. I myself have never used "modern mode" and I don't really care about it, so I won't "fix" this myself, but if someone is interested in doing it, I'll gladly accept clean patches, of course.
Thanks again, Edi. _______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel
On Mon, 1 Oct 2007 22:44:14 -0700 (PDT), Ross Jekel ross@sourcelabs.com wrote:
To the best of my knowledge, the two attached patches should work on all common lisp implementations. Basically I just added an "as-keyword" function to the util.lisp of both chunga and drakma that checks the readtable-case and uses #'string-upcase to convert the string if it is :upcase, otherwise it uses #'string-downcase (since the symbols in your source files are typically typed in all lowercase).
The two places (one in chunga read.lisp and one in drakma request.lisp) that call (intern (string-upcase ..) :keyword) were replaced with the (as-keyword ) form.
I've attached the diff -u output trying to follow your patching rules.
Thanks and sorry for the delay. This is now in the latest releases - see subject line. If you're using "modern mode", you should also update FLEXI-STREAMS.
Cheers, Edi.
Hmm, it's strange, because you've released drakma 0.11.0 on 1 October. The changelog entry stated:
Version 0.11.0 2007-10-01 Added *TEXT-CONTENT-TYPES* and *BODY-FORMAT-FUNCTION* (suggested by Peter Eddy)
Now, this is gone.
On 10/11/07, Edi Weitz edi@agharta.de wrote:
On Mon, 1 Oct 2007 22:44:14 -0700 (PDT), Ross Jekel ross@sourcelabs.com wrote:
To the best of my knowledge, the two attached patches should work on all common lisp implementations. Basically I just added an "as-keyword" function to the util.lisp of both chunga and drakma that checks the readtable-case and uses #'string-upcase to convert the string if it is :upcase, otherwise it uses #'string-downcase (since the symbols in your source files are typically typed in all lowercase).
The two places (one in chunga read.lisp and one in drakma request.lisp) that call (intern (string-upcase ..) :keyword) were replaced with the (as-keyword ) form.
I've attached the diff -u output trying to follow your patching rules.
Thanks and sorry for the delay. This is now in the latest releases - see subject line. If you're using "modern mode", you should also update FLEXI-STREAMS.
Cheers, Edi. _______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel
On Thu, 11 Oct 2007 11:43:10 +0300, "Ivan Toshkov" ivan@toshkov.org wrote:
Hmm, it's strange, because you've released drakma 0.11.0 on 1 October.
Yes, sorry, Sébastien Saint-Sevin also just emailed me about this. I switched laptops recently and it seems I released 0.11.0 from the old one after I had already copied my repository to the new machine. Should be fixed now, i.e. 0.11.1 is online which includes the additions from both 0.11.0 and "0.10.3".
Thanks to you both, Edi.
I didn't notice any need for this in FLEXI-STREAMS. Using grep it looks like the only place it interns is in the asd file:
(funcall (intern (symbol-name :run-tests) (find-package :flexi-streams-test)))
And this method of interning a symbol-name is portable in all casemodes as long as the cases of the typed in :run-tests and function definition name match.
Is there something I'm missing?
Thanks so much for creating this library. AServe's client does not use streams, which is annoying, and doesn't current support chunking with https requests (not a blocker because I could revert to http/1.0, but...). In a shop that is mostly Java programmers, you saved me from having to apologize for some embarrassingly silly work-arounds using the other library. I just recently replaced do-http-request from Aserve with http-request from Drakma in soap calls and it works great.
Thank you! Ross ----- Original Message ----- From: "Edi Weitz" edi@agharta.de To: "General interest list for Drakma and Chunga" drakma-devel@common-lisp.net Sent: Thursday, October 11, 2007 12:05:24 AM (GMT-0800) America/Los_Angeles Subject: [drakma-devel] New releases 0.10.3 (Drakma) and 0.4.1 (Chunga) (Was: utf-8 question)
On Mon, 1 Oct 2007 22:44:14 -0700 (PDT), Ross Jekel ross@sourcelabs.com wrote:
To the best of my knowledge, the two attached patches should work on all common lisp implementations. Basically I just added an "as-keyword" function to the util.lisp of both chunga and drakma that checks the readtable-case and uses #'string-upcase to convert the string if it is :upcase, otherwise it uses #'string-downcase (since the symbols in your source files are typically typed in all lowercase).
The two places (one in chunga read.lisp and one in drakma request.lisp) that call (intern (string-upcase ..) :keyword) were replaced with the (as-keyword ) form.
I've attached the diff -u output trying to follow your patching rules.
Thanks and sorry for the delay. This is now in the latest releases - see subject line. If you're using "modern mode", you should also update FLEXI-STREAMS.
Cheers, Edi. _______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel
On Thu, 11 Oct 2007 09:29:55 -0700 (PDT), Ross Jekel ross@sourcelabs.com wrote:
I didn't notice any need for this in FLEXI-STREAMS. Using grep it looks like the only place it interns is in the asd file:
(funcall (intern (symbol-name :run-tests) (find-package :flexi-streams-test)))
And this method of interning a symbol-name is portable in all casemodes as long as the cases of the typed in :run-tests and function definition name match.
Is there something I'm missing?
Look at the start of packages.lisp.
Thanks so much for creating this library. AServe's client does not use streams, which is annoying, and doesn't current support chunking with https requests (not a blocker because I could revert to http/1.0, but...). In a shop that is mostly Java programmers, you saved me from having to apologize for some embarrassingly silly work-arounds using the other library. I just recently replaced do-http-request from Aserve with http-request from Drakma in soap calls and it works great.
Thanks for the feedback, that's good to hear!
Cheers, Edi.
Ah yes, I hand edited that when asdf-install failed to compile it and I forgot about it.
This works as a replacement:
(unless (find-symbol (symbol-name :stream-file-position) :trivial-gray-streams) (error "You need a newer version of TRIVIAL-GRAY-STREAMS."))
Ross ----- Original Message ----- From: "Edi Weitz" edi@agharta.de To: "General interest list for Drakma and Chunga" drakma-devel@common-lisp.net Sent: Thursday, October 11, 2007 11:56:19 AM (GMT-0800) America/Los_Angeles Subject: Re: [drakma-devel] New releases 0.10.3 (Drakma) and 0.4.1 (Chunga)
On Thu, 11 Oct 2007 09:29:55 -0700 (PDT), Ross Jekel ross@sourcelabs.com wrote:
I didn't notice any need for this in FLEXI-STREAMS. Using grep it looks like the only place it interns is in the asd file:
(funcall (intern (symbol-name :run-tests) (find-package :flexi-streams-test)))
And this method of interning a symbol-name is portable in all casemodes as long as the cases of the typed in :run-tests and function definition name match.
Is there something I'm missing?
Look at the start of packages.lisp.
Thanks so much for creating this library. AServe's client does not use streams, which is annoying, and doesn't current support chunking with https requests (not a blocker because I could revert to http/1.0, but...). In a shop that is mostly Java programmers, you saved me from having to apologize for some embarrassingly silly work-arounds using the other library. I just recently replaced do-http-request from Aserve with http-request from Drakma in soap calls and it works great.
Thanks for the feedback, that's good to hear!
Cheers, Edi. _______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel
-
Edi Weitz -
Ivan Toshkov -
Ross Jekel