[drakma-devel] Patch - Accept-Encoding: gzip

Dear drakma users, I made drakma accept gzipped message bodies by default, and also automatically decode them. A patch is attached. Unfortunately this adds a new dependency on gzip-sequence (which in turn depends on salza2). See the docstrings for more details. To sum it up: if WANT-STREAM is T, It wraps the returned stream in a flexi-stream that wraps a gzip-input-stream. Otherwise, it decodes the sequence before returning from HTTP-REQUEST. Thanks, Red

Hi Red, Thanks for the patch. (But note the guidelines at <http://weitz.de/patches.html>...) I'm unsure whether I want to accept the patch, though. I don't really want to add a dependency on another library which in turn depends on another library for a pretty rare case. I'd rather implement a hook or something so that Drakma users can pre-process the content externally. Cheers, Edi. On Thu, Jan 21, 2010 at 10:57 AM, Red Daly <reddaly@gmail.com> wrote:
Dear drakma users,
I made drakma accept gzipped message bodies by default, and also automatically decode them. A patch is attached.
Unfortunately this adds a new dependency on gzip-sequence (which in turn depends on salza2). See the docstrings for more details. To sum it up: if WANT-STREAM is T, It wraps the returned stream in a flexi-stream that wraps a gzip-input-stream. Otherwise, it decodes the sequence before returning from HTTP-REQUEST.
Thanks, Red
_______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel

Hi Edi, This started off as a simple wrapper around a drakma call, but I found it handy enough that I used it in a few different places. Since Drakma is a non-trivial HTTP client, I thought it might be appropriate. Next time I have a chance I will hookify the patch On Mon, Jan 25, 2010 at 12:52 PM, Edi Weitz <edi@agharta.de> wrote:
Hi Red,
Thanks for the patch. (But note the guidelines at <http://weitz.de/patches.html>...)
I thought I obeyed most of them except for "If you're going to send a patch which makes significant changes, ask me first if I'm actually willing to integrate your changes before you end up doing a lot of work in vain." Just for future reference--did I miss anything else?
I'm unsure whether I want to accept the patch, though. I don't really want to add a dependency on another library which in turn depends on another library for a pretty rare case. I'd rather implement a hook or something so that Drakma users can pre-process the content externally.
Cheers, Edi.
Thanks for the libraries! Red
On Thu, Jan 21, 2010 at 10:57 AM, Red Daly <reddaly@gmail.com> wrote:
Dear drakma users,
I made drakma accept gzipped message bodies by default, and also automatically decode them. A patch is attached.
Unfortunately this adds a new dependency on gzip-sequence (which in turn depends on salza2). See the docstrings for more details. To sum it up: if WANT-STREAM is T, It wraps the returned stream in a flexi-stream that wraps a gzip-input-stream. Otherwise, it decodes the sequence before returning from HTTP-REQUEST.
Thanks, Red
_______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel
_______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel

On Fri, Feb 5, 2010 at 11:03 AM, Red Daly <reddaly@gmail.com> wrote:
Next time I have a chance I will hookify the patch
Good. Looking forward to that.
I thought I obeyed most of them except for "If you're going to send a patch which makes significant changes, ask me first if I'm actually willing to integrate your changes before you end up doing a lot of work in vain." Just for future reference--did I miss anything else?
There were TABs in the patch, and the HTML documentation wasn't updated IIRC. Thanks, Edi.
participants (2)
-
Edi Weitz
-
Red Daly