- ecl-devel - mailman3.common-lisp.net

[PATCH] Improved error detection and reporting in RESTART-BIND
by Spiros Bousbouras 20 Jul '19

20 Jul '19

If you do (restart-bind ((locutus (function cdr) :report-function "23")) (error "This is an error")) you get Excessive debugger depth! Probable infinite recursion! Quitting process: #<process TOP-LEVEL>. and ECL exits. This isn't very useful. One can find various similar examples. After the patch one would get { Condition of type: SIMPLE-ERROR Macro RESTART-BIND : "23" is not a function object Available restarts: 1. (RESTART-TOPLEVEL) Go back to Top-Level REPL. Broken at SI:BYTECODES. [Evaluation of: (RESTART-BIND ((LOCUTUS #'CDR :REPORT-FUNCTION "23")) (ERROR "This is an error"))] In: #<process TOP-LEVEL>. } which is better. The new RESTART-BIND does improved error detection and reporting in other situations too. The patch follows below. You go to directory ecl-16.1.3/src/clos/ and , assuming you have saved the patch with the filename patch , you do patch -F 0 --verbose --posix conditions.lsp patch .This assumes GNU patch , otherwise skip the --verbose --posix part. I didn't make an entry in ecl-16.1.3/CHANGELOG because I'm not sure what the required format is. The file indicates near the top that it is for version 16.1.3 .So where should one mention changes which might appear in a newer version ? @===================================================================================== *** conditions.lsp Fri Jul 19 19:37:53 2019 --- conditions.lsp.new Fri Jul 19 19:39:05 2019 *************** *** 99,118 **** for n in (if (atom names) (list names) names) for f = (simple-handler-function tag i) collect (cons n f)) *handler-clusters*))) ! (defmacro restart-bind (bindings &body forms) ! `(let ((*restart-clusters* ! (cons (list ,@(mapcar #'(lambda (binding) ! `(make-restart ! :NAME ',(car binding) ! :FUNCTION ,(cadr binding) ! ,@(cddr binding))) ! bindings)) ! *restart-clusters*))) ! ,@forms)) (defun find-restart (name &optional condition) (dolist (restart (compute-restarts condition)) (when (or (eq restart name) (eq (restart-name restart) name)) (return-from find-restart restart)))) --- 99,159 ---- for n in (if (atom names) (list names) names) for f = (simple-handler-function tag i) collect (cons n f)) *handler-clusters*))) ! (defun restart-bind-check-binding ! (name foo &rest rest ! &aux int-foo rep-foo test-foo ! (err-mes (format nil "Macro ~S :" 'restart-bind))) ! (unless (symbolp name) (error "~a ~s is not a symbol" err-mes name)) ! (unless (functionp foo) (error "~a ~s is not a function object" err-mes foo)) ! (do ((br rest (cddr br))) ! ((eq br nil) (make-restart :name name :function foo ! :report-function rep-foo ! :interactive-function int-foo ! :test-function (if test-foo test-foo ! (constantly t)))) ! (let ((key (first br)) (obj (second br))) ! (unless (functionp obj) ! (error "~a ~s is not a function object" err-mes obj)) ! (cond ((eq key :interactive-function) ! (when int-foo ! (error "~a ~s given more than once" ! err-mes :interactive-function)) ! (setq int-foo obj)) ! ((eq key :report-function) ! (when rep-foo ! (error "~a ~s given more than once" ! err-mes :report-function)) ! (setq rep-foo obj)) ! ((eq key :test-function) ! (when test-foo ! (error "~a ~s given more than once" ! err-mes :test-function)) ! (setq test-foo obj)) ! (t (error "~a Inappropriate keyword ~s" err-mes key)))))) ! ! (defmacro restart-bind (bindings &body forms ! &aux (new (list 'list)) (tail new) fb eta ! (err-mes (format nil "Macro ~S :" 'restart-bind))) ! (dolist (b bindings) ! (unless (listp b) (error "~a ~s is not a list" err-mes b)) ! (setq fb (first b)) ! (unless (symbolp fb) (error "~a ~s is not a symbol" err-mes fb)) ! (unless (second b) (error "~a ~s does not have a function argument" ! err-mes b)) ! (setq eta (list 'restart-bind-check-binding `(quote ,fb) (second b))) ! (do ((l (cddr b) (cdr l)) ! (t2 (cddr eta) (cdr t2))) ! ((eql nil l)) ! (rplacd t2 (list (first l)))) ! (rplacd tail (list eta)) ! (setq tail (cdr tail))) ! `(let ((*restart-clusters* (cons ,new *restart-clusters*))) ! ,@forms)) ! (defun find-restart (name &optional condition) (dolist (restart (compute-restarts condition)) (when (or (eq restart name) (eq (restart-name restart) name)) (return-from find-restart restart))))

2 3

Compilation failure on cygwin
by Иван Трусков 17 Jul '19

17 Jul '19

Hello I am trying to build and use ECL on windows machine under cygwin environment However, evter it is built, there arises a problem when i try to compile any lisp files, for example when running examples/build/readme.lisp Inspecting with gsb gives the picture of stack overflow on handling some exception across threads, overflow occuring in the bad case of circular calls to acquiring thread-local data (pthreads_getspecific) and processing error message from failure of it. is there recommended configuration for cygwin that would allow to overcome that kind of problem? Alternatively, what data exactly are needed for a full bug report? I would gladly provide everything relevant

3 4

Evaluating with a lexical environment
by Spiros Bousbouras 13 Jul '19

13 Jul '19

clisp provides a facility to evaluate a form in a non null lexical environment. It works as follows > (let ((a 1) (b 2)) (ext:eval-env '(format t "a is ~A b is ~A~%" a b) (ext:the-environment))) a is 1 b is 2 NIL The clisp documentation gives Macro EXT:THE-ENVIRONMENT. As in Scheme, the macro (EXT:THE-ENVIRONMENT) returns the current lexical environment. This works only in interpreted code and is not compilable! Function (EXT:EVAL-ENV form &OPTIONAL environment). evaluates a form in a given lexical environment, just as if the form had been a part of the program that the environment came from. I was wondering if ECL has something analogous or could be added easily. Looking in the ECL source I saw a si::eval-with-env function in file ecl-16.1.3/src/c/compiler.d .If you do > (find-symbol "EVAL-WITH-ENV" "SYSTEM") SI:EVAL-WITH-ENV :EXTERNAL which suggests that the function is not just for internal use. But scanning the documentation , I didn't see it mentioned. I tried (defmacro env-eval (form &environment env) `(ext:eval-with-env ,form (quote ,env))) ENV-EVAL > (let ((v 12)) (env-eval '(print v))) The variable V is unbound. Broken at EVAL.No restarts available. Broken at EVAL. So is there a way to achieve this ?

2 2

Infinite loop or blocking operation in main ECL thread - what to do?
by Не Скажу 08 Jul '19

08 Jul '19

Some portion of program is scriptable with ECL, which runs in its own separate thread. What I fear, however, is that users might do something stupid and enter an infinite loop or break into debugger wondering why does the scriptable part no longer responds. For the latter breaking into debugger is disabled by default with an option to reenable it, but nevertheless knowing Murphy's law I expect the worst to happen. I would like to keep the program responsive no matter what. I was hoping I could restart ECL in such cases, so I tried terminating ECL thread first but it results in a crash. And apparently after calling cl_shutdown ECL shuts down for good and a second call to cl_boot does not work so restarting does not appear as an option anyway. Is there anything I can do to keep the program running or just trust the user to do the right thing?

2 1

DEFSTRUCT non bug
by Spiros Bousbouras 01 Jul '19

01 Jul '19

This is regarding https://gitlab.com/embeddable-common-lisp/ecl/issues/469 .I don't think that the behaviour mentioned in there is a bug. (defstruct foo a b c) is top level inside file /tmp/foo.lisp and CLHS says If a defstruct form appears as a top level form, the compiler must make the structure type name recognized as a valid type name in subsequent declarations (as for deftype) and make the structure slot readers known to setf. So after (compile-file "/tmp/foo.lisp") it makes sense that FIND-CLASS would know about foo . SBCL behaves the same way.

1 0

What is the best version of ECL to use right now?
by Dennis Ogbe 10 Jun '19

10 Jun '19

Hello, I am working on embedding ECL in a reasonably-sized C++ program and I have been using v16.1.3 until now, since it seems like this is the latest official release. However, it seems like there is a lot of activity and bug fixes in the develop branch and I already ran into a few bugs (for example [1]) that are fixed in develop, but are not in any release. The documentation also seems to overlap more with the develop branch than the latest release. In your opinion, what is the best and most stable ECL version to use as of June 2019? I have some reservations about simply picking a random commit from a dev branch, so I wanted to reach out and ask y'all directly. Thanks for all the hard work, this project is great! [1] https://gitlab.com/embeddable-common-lisp/ecl/issues/418

2 6

debug setup
by Andrea Corallo 17 Mar '19

17 Mar '19

Hi all, I'm using ECL with a classic setup Emacs + Slime. Unfortunately when I get a type-error somewhere in my program I have some problem debugging it. Inside the sldb I cannot inspect the frame (no locals) and seams It has no informations on which is function responsible for this error inside the codebase. My program is loaded by quicklisp and I have no idea if is compiled by ecl or interpreted. Do you have any suggestion on what is the recommended setup? I've attached my .eclrc but is quite standard I would say. Thanks for the help Best regards Andrea

1 0

Static library for windows
by Jón Hallur Haraldsson 16 Mar '19

16 Mar '19

Hi, I was wonder if I could easily build a static version of ECL on windows to link into other C++ projects without having to ship the ECL.dll with it. There is a "ecl-static.lib" recipe in the Makefile in the ./msvc folder which I can build after having built "all", but when linking that into an application that does nothing but call cl_boot() the linker (VS2015) complains with LNK2019 unresolved external symbol __imp__cl_boot referenced in function _main When looking into the symbols of the ecl-static.lib (created by MS dumpbin /symbols) the cl_boot function is defined but is UNDEF-ed so that the linker tries to find __imp__cl_boot which is not in the ecl-static.lib Looking through the mail list I came upon the mention of using --disable-shared when configuring, which works for me on Linux, but I don't know how to add that flag to the nmake environment on Windows (or if it is there at all) Regards, Jón Hallur

2 1

The mailbox API is incomplete
by Не Скажу 15 Mar '19

15 Mar '19

Hello! The mailbox API is incomplete, lacking timeout option. I don't know whether there is a common standard for it, but according to this - http://cl-cookbook.sourceforge.net/process.html at least LispWorks has such feature. Having timeout would be a really useful, consider this scenario: 1) Main thread continuously passes some data to ECL thread, waiting for ECL thread to process it. 2) ECL thread processes this data and returns it back to main thread; 3) Main thread continues execution, gathers new data, etc. Main thread --> ECL thread --> Main thread User is given full control over ECL thread, being able to change anything within it, mainly how data should be processed. What if user makes a mistake and something goes wrong, like: 1) Debugger is entered; 2) User input is requested; 3) An infinite loop is created. That would mean that execution of ECL thread is halted, halting execution of main thread in return. Program is stuck. A timeout would save from such situation: after x number of milliseconds passed execution would go back to the main thread and program wold not freeze. Main thread would know that something went wrong within ECL thread and could skip it next time until it receives notification that whatever problems had arisen in ECL thread were fixed. Sure, ignore-errors could be used to prevent debugger from breaking execution, but it would be much better to still being able to use it. Besides, ignore-errors will not save from problems 2 and 3 mentioned above.

2 1

Erros cross-compiling for MIPS
by Jeronimo Pellegrini 15 Mar '19

15 Mar '19

Hello, I am trying to get ECL to run on a MIPS-based wireless router that runs OpenWRT. This one: system type : Qualcomm Atheros QCA956X ver 1 rev 0 machine : TP-Link Archer C7 v4 processor : 0 cpu model : MIPS 74Kc V5.0 BogoMIPS : 385.84 wait instruction : yes microsecond timers : yes tlb_entries : 32 extra interrupt vector : yes hardware watchpoint : yes, count: 4, address/irw mask: [0x0ffc, 0x0ffc, 0x0ffb, 0x0ffb] isa : mips1 mips2 mips32r1 mips32r2 ASEs implemented : mips16 dsp dsp2 Options implemented : tlb 4kex 4k_cache prefetch mcheck ejtag llsc dc_aliases perf_cntr_intr_bit cdmm nan_legacy nan_2008 contextconfig perf shadow register sets : 1 OpenWRT has a framework for building packages; almost everything is in one Makefile and possibly patches, but the system takes care of whatever is needed to cross compile, usually. So, I have tried creating an ECL package, and, well, it complained I was cross-compiling :-) and told me that I should fill in a cross_config file. So I did (the only change was to choose ECL_BIGENDIAN=yes): ECL_STACK_DIR=down CL_FIXNUM_TYPE=int CL_FIXNUM_BITS=32 CL_FIXNUM_MAX=536870911L CL_FIXNUM_MIN=-536870912L CL_INT_BITS=32 CL_LONG_BITS=32 ECL_BIGENDIAN=yes ECL_NEWLINE=LF ECL_FILE_CNT=0 ECL_STDINT_HEADER="#include <stdint.h>" ECL_UINT8_T=uint8_t ECL_UINT16_T=uint16_t ECL_UINT32_T=uint32_t ECL_UINT64_T=no ECL_INT8_T=int8_t ECL_INT16_T=int16_t ECL_INT32_T=int32_t ECL_INT64_T=no ECL_LONG_LONG_BITS=no ECL_WORKING_ENVIRON=yes ECL_TO_RUN=/usr/local/bin/ecl Then, when compiling, I got the error below. It seems that I probably got something wrong in the cross_config file (is that correct?) Does it look like something easy/obvious to fix? Is the output of the configure script necessary? Thank you! Jeronimo . . . Making all in src make[6]: Entering directory '/home/jeronimo/pkg/openwrt/build_dir/target-mips_24kc_musl/ecl-16.1.3/build/atomic/src' make[7]: Entering directory '/home/jeronimo/pkg/openwrt/build_dir/target-mips_24kc_musl/ecl-16.1.3/build/atomic/src' libtool: compile: mips-openwrt-linux-musl-gcc -DHAVE_CONFIG_H -I../src -I/home/jeronimo/pkg/openwrt/build_dir/target-mips_24kc_musl/ecl-16.1.3/src/bdwgc/libatomic_ops/src -I/home/jeronimo/pkg/openwrt/staging_dir/target-mips_24kc_musl/usr/include -I/home/jeronimo/pkg/openwrt/staging_dir/target-mips_24kc_musl/include -I/home/jeronimo/pkg/openwrt/staging_dir/toolchain-mips_24kc_gcc-7.4.0_musl/usr/include -I/home/jeronimo/pkg/openwrt/staging_dir/toolchain-mips_24kc_gcc-7.4.0_musl/include/fortify -I/home/jeronimo/pkg/openwrt/staging_dir/toolchain-mips_24kc_gcc-7.4.0_musl/include -fPIC -Wall -Wextra -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -Os -pipe -mno-branch-likely -mips32r2 -mtune=24kc -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable -Wno-error=unused-result -msoft-float -mips16 -minterlink-mips16 -iremap/home/jeronimo/pkg/openwrt/build_dir/target-mips_24kc_musl/ecl-16.1.3:ecl-16.1.3 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -I/home/jeronimo/pkg/openwrt/staging_dir/target-mips_24kc_musl/usr/include/ -fPIC -D_THREAD_SAFE -MT atomic_ops.lo -MD -MP -MF .deps/atomic_ops.Tpo -c /home/jeronimo/pkg/openwrt/build_dir/target-mips_24kc_musl/ecl-16.1.3/src/bdwgc/libatomic_ops/src/atomic_ops.c -fPIC -DPIC -o atomic_ops.o {standard input}: Assembler messages: {standard input}:24: Error: opcode not supported on this processor: mips2 (mips2) `sync ' {standard input}:47: Error: opcode not supported on this processor: mips2 (mips2) `ll $2,0($4)' {standard input}:49: Error: opcode not supported on this processor: mips2 (mips2) `sc $5,0($4)' make[7]: *** [Makefile:597: atomic_ops.lo] Error 1 make[7]: Leaving directory '/home/jeronimo/pkg/openwrt/build_dir/target-mips_24kc_musl/ecl-16.1.3/build/atomic/src' make[6]: *** [Makefile:460: all] Error 2

2 1