eclipse-cvs

eclipse-cvs@common-lisp.net

347 discussions

[Eclipse-cvs] CVS eclipse
by ihatchondo 23 Apr '08

23 Apr '08

Update of /project/eclipse/cvsroot/eclipse In directory clnet:/tmp/cvs-serv23411 Modified Files: global.lisp input.lisp misc.lisp wm.lisp Log Message: Fix: netwm-user-time usage, and some withdrawal glitches. --- /project/eclipse/cvsroot/eclipse/global.lisp 2005/03/01 22:41:31 1.29 +++ /project/eclipse/cvsroot/eclipse/global.lisp 2008/04/23 09:54:46 1.30 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: global.lisp,v 1.29 2005/03/01 22:41:31 ihatchondo Exp $ +;;; $Id: global.lisp,v 1.30 2008/04/23 09:54:46 ihatchondo Exp $ ;;; ;;; This file is part of Eclipse. ;;; Copyright (C) 2001, 2002 Iban HATCHONDO @@ -37,7 +37,7 @@ :_net_current_desktop :_net_active_window :_net_close_window :_net_workarea :_net_wm_desktop :_net_wm_window_type :_net_desktop_names :_net_restack_window :_net_moveresize_window :_net_wm_user_time - :_net_request_frame_extents :_net_frame_extents + :_net_wm_user_time_window :_net_request_frame_extents :_net_frame_extents :_net_wm_strut_partial :_net_wm_state :_net_wm_strut :_net_wm_window_type_desktop :_net_wm_window_type_dock :_net_wm_window_type_toolbar :_net_wm_window_type_menu --- /project/eclipse/cvsroot/eclipse/input.lisp 2007/05/07 13:22:50 1.47 +++ /project/eclipse/cvsroot/eclipse/input.lisp 2008/04/23 09:54:46 1.48 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: input.lisp,v 1.47 2007/05/07 13:22:50 ihatchondo Exp $ +;;; $Id: input.lisp,v 1.48 2008/04/23 09:54:46 ihatchondo Exp $ ;;; ;;; ECLIPSE. The Common Lisp Window Manager. ;;; Copyright (C) 2000, 2001, 2002 Iban HATCHONDO @@ -146,7 +146,14 @@ (undecore-application widget :state 0) (setf (wm-state window) 3))))) (decoration - (setf (wm-state (get-child widget :application :window t)) 3)))))) + (let ((application (get-child widget :application))) + (if (application-iconic-p application) + (setf (wm-state (widget-window application)) 3) + (with-slots (window send-event-p) event + (setf send-event-p t) + (setf window (widget-window application)) + (format t "about to withdraw: ~a ~%" (wm-name window)) + (event-process event root))))))))) (defmethod event-process ((event destroy-notify) (root root)) (let ((app (lookup-widget (event-window event)))) @@ -427,9 +434,9 @@ (with-slots ((pwindow window)) (root-property-holder *root*) (let* ((length (length data)) (time (if (> length 1) (aref data 1) 0)) - (wtime (or (netwm:net-wm-user-time pwindow) 0))) + (wtime (or (net-wm-user-time pwindow) 0))) (unless (> wtime time 0) - (setf (netwm:net-wm-user-time pwindow) time) + ;;(setf (netwm:net-wm-user-time pwindow) time) (focus-widget application time) (put-on-top application))))) (:_net_wm_desktop (migrate-application application (aref data 0))) --- /project/eclipse/cvsroot/eclipse/misc.lisp 2007/11/02 09:33:08 1.40 +++ /project/eclipse/cvsroot/eclipse/misc.lisp 2008/04/23 09:54:46 1.41 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: misc.lisp,v 1.40 2007/11/02 09:33:08 ihatchondo Exp $ +;;; $Id: misc.lisp,v 1.41 2008/04/23 09:54:46 ihatchondo Exp $ ;;; ;;; This file is part of Eclipse. ;;; Copyright (C) 2002 Iban HATCHONDO @@ -44,10 +44,11 @@ (defmacro current-desk () `(current-vscreen *root-window*)) (defmacro id->atom-name (id) - `(xlib:atom-name *display* ,id)) + `(when (typep ,id 'xlib:card29) + (xlib:atom-name *display* ,id))) (defmacro atom-name->id (name) - `(xlib:find-atom *display* ,name)) + `(xlib:find-atom *display* ,name)) (defmacro with-root-cursor ((new-cursor) &body body) `(unwind-protect @@ -176,6 +177,19 @@ (or (= (or (window-desktop-num window) -1) +any-desktop+) (logbitp 0 (or (gnome:win-state window :result-type t) 0)))) +(defun net-wm-user-time (window) + "Returns the _net_wm_user_time property using the _net_wm_user_time_window + if present. If the property is not defined return NIL." + (let ((user-time-window (netwm:net-wm-user-time-window window))) + (netwm:net-wm-user-time (or user-time-window window)))) + +(defsetf net-wm-user-time (window) (timestamp) + "Sets the _net_wm_user_time property using the _net_wm_user_time_window + if present, otherwise window is the property holder." + (let ((time-window (gensym))) + `(let ((,time-window (netwm:net-wm-user-time-window ,window))) + (setf (netwm:net-wm-user-time (or ,time-window ,window)) ,timestamp)))) + ;;;; Miscellaneous functions. (defun grab-root-pointer (&key cursor owner-p confine-to) --- /project/eclipse/cvsroot/eclipse/wm.lisp 2007/05/04 08:26:14 1.52 +++ /project/eclipse/cvsroot/eclipse/wm.lisp 2008/04/23 09:54:46 1.53 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: wm.lisp,v 1.52 2007/05/04 08:26:14 ihatchondo Exp $ +;;; $Id: wm.lisp,v 1.53 2008/04/23 09:54:46 ihatchondo Exp $ ;;; ;;; ECLIPSE. The Common Lisp Window Manager. ;;; Copyright (C) 2000, 2001, 2002 Iban HATCHONDO @@ -686,7 +686,7 @@ (defun procede-decoration (window) "Decore, if necessary, add/update properties, map or not, etc a window." - (let* ((time (or (ignore-errors (netwm:net-wm-user-time window)) 1)) + (let* ((time (or (ignore-errors (net-wm-user-time window)) 1)) (rw (xlib:drawable-root window)) (scr-num (current-vscreen rw)) (application (create-application window nil))

1 0

[Eclipse-cvs] CVS eclipse/lib
by ihatchondo 04 Nov '07

04 Nov '07

Update of /project/eclipse/cvsroot/eclipse/lib In directory clnet:/tmp/cvs-serv15021 Modified Files: netwm-manager.lisp Log Message: Update: according to 1.4 draft2, note that nothing has been done for the compositing manager selction owning, since this is a complete process to be handled rather than just a property ... --- /project/eclipse/cvsroot/eclipse/lib/netwm-manager.lisp 2005/03/01 22:41:34 1.22 +++ /project/eclipse/cvsroot/eclipse/lib/netwm-manager.lisp 2007/11/04 22:27:19 1.23 @@ -1,9 +1,9 @@ ;;; -*- Mode: Lisp; Package: EXTENDED-WINDOW-MANAGER-HINTS -*- -;;; $Id: netwm-manager.lisp,v 1.22 2005/03/01 22:41:34 ihatchondo Exp $ +;;; $Id: netwm-manager.lisp,v 1.23 2007/11/04 22:27:19 ihatchondo Exp $ ;;; ;;; This is the CLX support for the managing with gnome. ;;; -;;; Copyright (C) 2002 Iban HATCHONDO +;;; Copyright (C) 2002, 2003, 2004, 2005, 2006, 2007 Iban HATCHONDO ;;; contact : hatchond(a)yahoo.fr ;;; ;;; This program is free software; you can redistribute it and/or @@ -46,12 +46,12 @@ #:net-wm-icon-geometry #:net-wm-icon #:net-wm-pid #:net-wm-handled-icons #:net-wm-allowed-actions #:net-wm-strut-partial - #:net-wm-user-time + #:net-wm-user-time #:net-wm-user-time-window #:intern-atoms) (:documentation "This package implements the Extended Window Manager Hints - (from Freedesktop.org). - version 1.3 (June 19, 2003) - + (from Freedesktop.org). - version 1.4 draft2 - In order to use it, you should first call intern-atoms to be sure all atoms are in the server.")) @@ -70,7 +70,7 @@ "_NET_ACTIVE_WINDOW" "_NET_WORKAREA" "_NET_SUPPORTING_WM_CHECK" "_NET_VIRTUAL_ROOTS" "_NET_DESKTOP_LAYOUT" - + "_NET_RESTACK_WINDOW" "_NET_REQUEST_FRAME_EXTENTS" "_NET_MOVERESIZE_WINDOW" "_NET_CLOSE_WINDOW" "_NET_WM_MOVERESIZE" @@ -84,24 +84,29 @@ "_NET_WM_ICON_GEOMETRY" "_NET_WM_ICON" "_NET_WM_PID" "_NET_WM_HANDLED_ICONS" "_NET_WM_USER_TIME" "_NET_FRAME_EXTENTS" + "_NET_WM_USER_TIME_WINDOW" + "_NET_WM_FULL_PLACEMENT" ;; "_NET_WM_MOVE_ACTIONS" - "_NET_WM_WINDOW_TYPE_DESKTOP" "_NET_WM_STATE_MODAL" - "_NET_WM_WINDOW_TYPE_DOCK" "_NET_WM_STATE_STICKY" - "_NET_WM_WINDOW_TYPE_TOOLBAR" "_NET_WM_STATE_MAXIMIZED_VERT" - "_NET_WM_WINDOW_TYPE_MENU" "_NET_WM_STATE_MAXIMIZED_HORZ" - "_NET_WM_WINDOW_TYPE_UTILITY" "_NET_WM_STATE_SHADED" - "_NET_WM_WINDOW_TYPE_SPLASH" "_NET_WM_STATE_SKIP_TASKBAR" - "_NET_WM_WINDOW_TYPE_DIALOG" "_NET_WM_STATE_SKIP_PAGER" - "_NET_WM_WINDOW_TYPE_NORMAL" "_NET_WM_STATE_HIDDEN" - "_NET_WM_STATE_FULLSCREEN" - "_NET_WM_STATE_ABOVE" - "_NET_WM_STATE_BELOW" - "_NET_WM_STATE_DEMANDS_ATTENTION" - + "_NET_WM_WINDOW_TYPE_DESKTOP" "_NET_WM_STATE_MODAL" + "_NET_WM_WINDOW_TYPE_DOCK" "_NET_WM_STATE_STICKY" + "_NET_WM_WINDOW_TYPE_TOOLBAR" "_NET_WM_STATE_MAXIMIZED_VERT" + "_NET_WM_WINDOW_TYPE_MENU" "_NET_WM_STATE_MAXIMIZED_HORZ" + "_NET_WM_WINDOW_TYPE_UTILITY" "_NET_WM_STATE_SHADED" + "_NET_WM_WINDOW_TYPE_SPLASH" "_NET_WM_STATE_SKIP_TASKBAR" + "_NET_WM_WINDOW_TYPE_DIALOG" "_NET_WM_STATE_SKIP_PAGER" + "_NET_WM_WINDOW_TYPE_NORMAL" "_NET_WM_STATE_HIDDEN" + "_NET_WM_WINDOW_TYPE_DROPDOWN_MENU" "_NET_WM_STATE_FULLSCREEN" + "_NET_WM_WINDOW_TYPE_POPUP_MENU" "_NET_WM_STATE_ABOVE" + "_NET_WM_WINDOW_TYPE_TOOLTIP" "_NET_WM_STATE_BELOW" + "_NET_WM_WINDOW_TYPE_NOTIFICATION" "_NET_WM_STATE_DEMANDS_ATTENTION" + "_NET_WM_WINDOW_TYPE_COMBO" + "_NET_WM_WINDOW_TYPE_DND" + "_NET_WM_ALLOWED_ACTIONS" "_NET_WM_ACTION_MOVE" "_NET_WM_ACTION_RESIZE" + "_NET_WM_ACTION_MINIMIZE" "_NET_WM_ACTION_SHADE" "_NET_WM_ACTION_STICK" "_NET_WM_ACTION_MAXIMIZE_HORZ" @@ -431,9 +436,9 @@ (defun net-wm-icon (window) "Returns a vector of possible icons for the client. This is an vector - of (unsigned-byte 32) ARGB with high byte being A, low byte being B. - The first two cardinals are width, height. Data is in rows, left to right - and top to bottom." + of (unsigned-byte 32) ARGB with high byte being A, low byte being B. + The first two cardinals are width, height. Data is in rows, left to right + and top to bottom." (get-property window :_NET_WM_ICON :result-type 'vector)) ;; _NET_WM_HANDLED_ICONS @@ -478,6 +483,35 @@ (defsetf net-wm-user-time (window) (time) `(change-property ,window :_NET_WM_USER_TIME (list ,time) :cardinal 32)) +;; _NET_WM_USER_TIME_WINDOW + +(defun net-wm-user-time-window (window &key window-id) + "This property contains the XID of a window on which the client sets + the _NET_WM_USER_TIME property. Clients should check whether the window + manager supports _NET_WM_USER_TIME_WINDOW and fall back to setting the + _NET_WM_USER_TIME property on the toplevel window if it doesn't. + Rationale: Storing the frequently changing _NET_WM_USER_TIME property + on the toplevel window itself causes every application that is interested + in any of the properties of that window to be woken up on every keypress, + which is particularly bad for laptops running on battery power. + + - window (xlib:window): The window from which the property must be read. + - :window-id (boolean, default to nil): if t then the returned value is + an xlib:card29 window ID, otherwise an xilb:window is returned or nil if + the property is not set." + (car (get-window-property window :_NET_WM_USER_TIME_WINDOW (not window-id)))) + +(defsetf net-wm-user-time-window (window &key window-id) (value) + "Sets the _NET_WM_USER_TIME property. + - window (xlib:window): The window from which the property must be read. + - value (or xlib:window xlib:card29): property value. + - :window-id (boolean, default to nil): indicates how the value must + be interpreted." + `(change-property ,window + :_NET_WM_USER_TIME_WINDOW + (list ,value) :window 32 :mode :replace + :transform (unless ,window-id #'xlib:window-id))) + ;; _NET_FRAME_EXTENTS (defun net-frame-extents (window)

1 0

[Eclipse-cvs] CVS eclipse
by ihatchondo 02 Nov '07

02 Nov '07

Update of /project/eclipse/cvsroot/eclipse In directory clnet:/tmp/cvs-serv5582 Modified Files: widgets.lisp misc.lisp Log Message: Fix: bug, desktop window were restacked when one of their modal or transient for were. --- /project/eclipse/cvsroot/eclipse/widgets.lisp 2007/11/02 09:11:42 1.50 +++ /project/eclipse/cvsroot/eclipse/widgets.lisp 2007/11/02 09:33:08 1.51 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: widgets.lisp,v 1.50 2007/11/02 09:11:42 ihatchondo Exp $ +;;; $Id: widgets.lisp,v 1.51 2007/11/02 09:33:08 ihatchondo Exp $ ;;; ;;; ECLIPSE. The Common Lisp Window Manager. ;;; Copyright (C) 2000, 2001, 2002 Iban HATCHONDO @@ -274,6 +274,10 @@ (setf (window-priority (if master (widget-window master) window) desk-w) (if desk-w :above :below))))) +(defun application-netwm-type-p (application type) + "Returns t if application is of the given type." + (member type (application-type application))) + (defun application-panel-p (application) "Returns t if application is a panel (e.g: _net_wm_window_type_dock)." (member :_net_wm_window_type_dock (application-type application))) --- /project/eclipse/cvsroot/eclipse/misc.lisp 2007/05/07 13:22:50 1.39 +++ /project/eclipse/cvsroot/eclipse/misc.lisp 2007/11/02 09:33:08 1.40 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: misc.lisp,v 1.39 2007/05/07 13:22:50 ihatchondo Exp $ +;;; $Id: misc.lisp,v 1.40 2007/11/02 09:33:08 ihatchondo Exp $ ;;; ;;; This file is part of Eclipse. ;;; Copyright (C) 2002 Iban HATCHONDO @@ -210,11 +210,12 @@ (first-win (windows &optional above-p) (car (if above-p (last windows) windows))) (restack (app sib-app priority) - (let* ((window (widget-window (or (application-master app) app))) - (sm (when sib-app (application-master sib-app))) - (sibling (when sib-app (widget-window (or sm sib-app))))) - (unless (xlib:window-equal window sibling) - (setf (xlib:window-priority window sibling) priority))))) + (unless (application-netwm-type-p app :_net_wm_window_type_desktop) + (let* ((window (widget-window (or (application-master app) app))) + (sm (when sib-app (application-master sib-app))) + (sibling (when sib-app (widget-window (or sm sib-app))))) + (unless (xlib:window-equal window sibling) + (setf (xlib:window-priority window sibling) priority)))))) (let* ((win (or (lookup-app-w (lookup-widget window)) window)) (sib (or (lookup-app-w (lookup-widget sibling)) sibling)) (widget (lookup-widget win))

1 0

[Eclipse-cvs] CVS eclipse
by ihatchondo 02 Nov '07

02 Nov '07

Update of /project/eclipse/cvsroot/eclipse In directory clnet:/tmp/cvs-serv32135 Modified Files: widgets.lisp Log Message: Fix: focusing bug in application like citrix meta frame. --- /project/eclipse/cvsroot/eclipse/widgets.lisp 2007/05/11 12:28:40 1.49 +++ /project/eclipse/cvsroot/eclipse/widgets.lisp 2007/11/02 09:11:42 1.50 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: widgets.lisp,v 1.49 2007/05/11 12:28:40 ihatchondo Exp $ +;;; $Id: widgets.lisp,v 1.50 2007/11/02 09:11:42 ihatchondo Exp $ ;;; ;;; ECLIPSE. The Common Lisp Window Manager. ;;; Copyright (C) 2000, 2001, 2002 Iban HATCHONDO @@ -472,6 +472,11 @@ (protocols (ignore-errors (xlib:wm-protocols window))) (input-p (and hint (logbitp 0 (first hint)) (= 1 (second hint)))) (take-focus-p (ignore-errors (member :wm_take_focus protocols)))) + (when (or (not hint) (not (logbitp 0 (first hint)))) + ;; The input model is not set in the property. For some application + ;; that forgot to precise it we'll act as if it was (otherwise they + ;; can't get focused). + (setf input-p t)) (cond ((and (not input-p) (not take-focus-p)) :no-input) ((and (not input-p) take-focus-p) :globally-active) ((and input-p (not take-focus-p)) :passive)

1 0

[Eclipse-cvs] CVS eclipse
by ihatchondo 11 May '07

11 May '07

Update of /project/eclipse/cvsroot/eclipse In directory clnet:/tmp/cvs-serv14965 Modified Files: widgets.lisp Log Message: Fix: wm-size-hints might be nil. --- /project/eclipse/cvsroot/eclipse/widgets.lisp 2007/05/07 13:22:50 1.48 +++ /project/eclipse/cvsroot/eclipse/widgets.lisp 2007/05/11 12:28:40 1.49 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: widgets.lisp,v 1.48 2007/05/07 13:22:50 ihatchondo Exp $ +;;; $Id: widgets.lisp,v 1.49 2007/05/11 12:28:40 ihatchondo Exp $ ;;; ;;; ECLIPSE. The Common Lisp Window Manager. ;;; Copyright (C) 2000, 2001, 2002 Iban HATCHONDO @@ -281,8 +281,8 @@ (defun fullscreenable-p (application) (with-slots (window) application (let ((hint (ignore-errors (xlib:wm-normal-hints window)))) - (symbol-macrolet ((max-w (xlib:wm-size-hints-max-width hint)) - (max-h (xlib:wm-size-hints-max-height hint))) + (symbol-macrolet ((max-h (and hint (xlib:wm-size-hints-max-height hint))) + (max-w (and hint (xlib:wm-size-hints-max-width hint)))) (and (if max-w (= max-w (screen-width)) t) (if max-h (= max-h (screen-height)) t))))))

1 0

[Eclipse-cvs] CVS eclipse
by ihatchondo 08 May '07

08 May '07

Update of /project/eclipse/cvsroot/eclipse In directory clnet:/tmp/cvs-serv16158 Modified Files: eclipse.lisp Log Message: Fix: the settings of all the net-wm spec root properties is now surrounded with a with-server-grabbed to avoid tones of property change event on the root window. --- /project/eclipse/cvsroot/eclipse/eclipse.lisp 2006/01/14 15:40:55 1.25 +++ /project/eclipse/cvsroot/eclipse/eclipse.lisp 2007/05/08 22:33:17 1.26 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: eclipse.lisp,v 1.25 2006/01/14 15:40:55 ihatchondo Exp $ +;;; $Id: eclipse.lisp,v 1.26 2007/05/08 22:33:17 ihatchondo Exp $ ;;; ;;; ECLIPSE. The Common Lisp Window Manager. ;;; Copyright (C) 2002 Iban HATCHONDO @@ -129,27 +129,29 @@ (let ((first-desknum (current-vscreen window)) (nb-vs (number-of-virtual-screens window)) (srcw (screen-width)) (srch (screen-height))) - (delete-properties window (append +gnome-protocols+ +netwm-protocol+)) - (unless (< -1 first-desknum nb-vs) (setf first-desknum 0)) - (setf (gnome:win-protocols window) +gnome-protocols+ - (gnome:win-supporting-wm-check manager) manager - (gnome:win-supporting-wm-check window) manager - (gnome:win-workspace-count window) nb-vs - (gnome:win-workspace window) first-desknum - - (netwm:net-supported window) +netwm-protocol+ - (netwm:net-supporting-wm-check window) manager - (netwm:net-supporting-wm-check manager) manager - (netwm:net-wm-name manager) "eclipse" - (netwm:net-number-of-desktops window) nb-vs - (netwm:net-current-desktop window) first-desknum - (netwm:net-desktop-viewport window) (make-viewport-property nb-vs) - (netwm:net-desktop-geometry window) (list srcw srch) - (netwm:net-workarea window) (make-list nb-vs - :initial-element - (manager-commons:make-geometry-hint - :x 0 :y 0 :width srcw :height srch)) - ))) + (xlib:with-server-grabbed (*display*) + (delete-properties window +netwm-protocol+) + (unless (< -1 first-desknum nb-vs) (setf first-desknum 0)) + (setf (gnome:win-protocols window) +gnome-protocols+ + (gnome:win-supporting-wm-check manager) manager + (gnome:win-supporting-wm-check window) manager + (gnome:win-workspace-count window) nb-vs + (gnome:win-workspace window) first-desknum) + + (setf (netwm:net-supported window) +netwm-protocol+ + (netwm:net-supporting-wm-check window) manager + (netwm:net-supporting-wm-check manager) manager + (netwm:net-wm-name manager) "eclipse" + (netwm:net-number-of-desktops window) nb-vs + (netwm:net-current-desktop window) first-desknum + (netwm:net-desktop-viewport window) (make-viewport-property nb-vs) + (netwm:net-desktop-geometry window) (list srcw srch) + (netwm:net-workarea window) (make-list nb-vs + :initial-element + (manager-commons:make-geometry-hint + :x 0 :y 0 :width srcw :height srch)) + + )))) (defun initialize (display-specification sm-client-id) (multiple-value-bind (display screen)

1 0

[Eclipse-cvs] CVS eclipse
by ihatchondo 08 May '07

08 May '07

Update of /project/eclipse/cvsroot/eclipse In directory clnet:/tmp/cvs-serv15180 Modified Files: rectangles.lisp Log Message: Cosmetic changes. --- /project/eclipse/cvsroot/eclipse/rectangles.lisp 2005/01/17 09:30:40 1.4 +++ /project/eclipse/cvsroot/eclipse/rectangles.lisp 2007/05/08 22:30:47 1.5 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: rectangles.lisp,v 1.4 2005/01/17 09:30:40 ihatchondo Exp $ +;;; $Id: rectangles.lisp,v 1.5 2007/05/08 22:30:47 ihatchondo Exp $ ;;; ;;; This file is part of Eclipse. ;;; Copyright (C) 2003 Iban HATCHONDO @@ -188,12 +188,12 @@ (wm-state (car (wm-state window)))) (and (or (= n scr-num) (= n +any-desktop+)) (or (eq wm-state 1) (and iconify-p (eq wm-state 3))) - (or (multiple-value-bind (resource class) + (or (member :_net_wm_window_type_dock + (netwm:net-wm-window-type window)) + (multiple-value-bind (resource class) (xlib:get-wm-class window) (declare (ignore resource)) - (string= class "Panel")) - (member :_net_wm_window_type_dock - (netwm:net-wm-window-type window))))))) + (string= class "Panel"))))))) (defun find-largest-empty-area (application &key area-include-me-p (panels-only-p t) direction

1 0

[Eclipse-cvs] CVS eclipse
by ihatchondo 07 May '07

07 May '07

Update of /project/eclipse/cvsroot/eclipse In directory clnet:/tmp/cvs-serv26719 Modified Files: misc.lisp widgets.lisp input.lisp Log Message: Fix: - configure-window when configuring panel window should honor size without guessing anything (misc.lisp). - map-request race condition (input.lisp & widget.lisp) Added: - application-panel-p predicate (widget.lisp) --- /project/eclipse/cvsroot/eclipse/misc.lisp 2007/05/07 00:19:10 1.38 +++ /project/eclipse/cvsroot/eclipse/misc.lisp 2007/05/07 13:22:50 1.39 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: misc.lisp,v 1.38 2007/05/07 00:19:10 ihatchondo Exp $ +;;; $Id: misc.lisp,v 1.39 2007/05/07 13:22:50 ihatchondo Exp $ ;;; ;;; This file is part of Eclipse. ;;; Copyright (C) 2002 Iban HATCHONDO @@ -331,7 +331,7 @@ ;; update sizes. (when (or width height) (with-event-mask ((or parent win)) - (when application + (when (and application (not (application-panel-p application))) ;; ensure width or height are compatible with wm-size-hints. (let* ((prop (netwm:net-wm-state win)) (horz-p (member :_net_wm_state_maximized_horz prop)) --- /project/eclipse/cvsroot/eclipse/widgets.lisp 2007/05/04 08:26:14 1.47 +++ /project/eclipse/cvsroot/eclipse/widgets.lisp 2007/05/07 13:22:50 1.48 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: widgets.lisp,v 1.47 2007/05/04 08:26:14 ihatchondo Exp $ +;;; $Id: widgets.lisp,v 1.48 2007/05/07 13:22:50 ihatchondo Exp $ ;;; ;;; ECLIPSE. The Common Lisp Window Manager. ;;; Copyright (C) 2000, 2001, 2002 Iban HATCHONDO @@ -274,6 +274,10 @@ (setf (window-priority (if master (widget-window master) window) desk-w) (if desk-w :above :below))))) +(defun application-panel-p (application) + "Returns t if application is a panel (e.g: _net_wm_window_type_dock)." + (member :_net_wm_window_type_dock (application-type application))) + (defun fullscreenable-p (application) (with-slots (window) application (let ((hint (ignore-errors (xlib:wm-normal-hints window)))) @@ -443,7 +447,8 @@ (if master (multiple-value-bind (x y) (xlib:translate-coordinates window 0 0 *root-window*) - (xlib:reparent-window window *root-window* x y)) + (xlib:reparent-window window *root-window* x y) + (event-process (make-event :destroy-notify) master)) (event-process (make-event :destroy-notify :window window) *root*)) (when state (setf (wm-state window) state) --- /project/eclipse/cvsroot/eclipse/input.lisp 2007/05/07 00:23:05 1.46 +++ /project/eclipse/cvsroot/eclipse/input.lisp 2007/05/07 13:22:50 1.47 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: input.lisp,v 1.46 2007/05/07 00:23:05 ihatchondo Exp $ +;;; $Id: input.lisp,v 1.47 2007/05/07 13:22:50 ihatchondo Exp $ ;;; ;;; ECLIPSE. The Common Lisp Window Manager. ;;; Copyright (C) 2000, 2001, 2002 Iban HATCHONDO @@ -27,6 +27,30 @@ ;; Most general methods. +(defmethod event-process ((event map-request) null-widget) + ;; When a client has requested to withdraw its top-level and wants then + ;; to map it back so quickly that we haven't got honored yet its withdrawal + ;; demand, this event is in fact send to the wrong parent and should be re + ;; directed to the real parent of the client top-level. + ;; The events schema is: + ;; 1 -> map-request => procede-decoration + ;; 2 -> unmap-notify => unmap master + ;; 3 -> synthetic unmap-notify => undecore-application + ;; 4 -> map-request + ;; What happen is that the client ask for mapping its top-level (4) after + ;; sending the synthetic unmap-notify (3), but WE have not handled it yet + ;; (otherwise said undecore-application has not been called). So Xserver + ;; generates a map-request event for the known parent: US ! But as soon + ;; as undecore-application will occurred we won't be the parent anymore + ;; and this event should rather have been sent to the real parent + ;; (aka the root window). + (with-slots (window (candidat event-window)) event + (multiple-value-bind (children parent) (xlib:query-tree window) + (declare (ignore children)) + (unless (xlib:window-equal candidat parent) + (xlib:send-event parent :map-request + '(:substructure-redirect) :window window :event-window parent))))) + (defmethod event-process ((event mapping-notify) null-widget) (declare (ignorable null-widget)) (with-slots (request start count) event @@ -217,30 +241,7 @@ ;;; Events for master (type: decoration) (defmethod event-process ((event map-request) (master decoration)) - ;; When a client has requested to withdraw its top-level and wants then - ;; to map it back so quickly that we haven't got honored yet its withdrawal - ;; demand, this event is in fact send to the wrong parent and should be re - ;; directed to the real parent of the client top-level. - ;; The events schema is: - ;; 1 -> map-request => procede-decoration - ;; 2 -> unmap-notify => unmap master - ;; 3 -> synthetic unmap-notify => undecore-application - ;; 4 -> map-request - ;; What happen is that the client ask for mapping its top-level (4) after - ;; sending the synthetic unmap-notify (3), but WE have not handled it yet - ;; (otherwise said undecore-application has not been called). So Xserver - ;; generates a map-request event for the known parent: US ! But as soon - ;; as undecore-application will occurred we won't be the parent anymore - ;; and this event should rather have been sent to the real parent - ;; (aka the root window). - (with-slots (window (parent event-window)) event - (multiple-value-bind (children real-parent) (xlib:query-tree window) - (declare (ignore children)) - (if (xlib:window-equal parent real-parent) - (xlib:map-window (event-window event)) - (xlib:send-event real-parent :map-request - '(:substructure-redirect) - :window window :event-window real-parent))))) + (xlib:map-window (event-window event))) (defmethod event-process ((event configure-notify) (master decoration)) (with-slots ((master-window event-window) (app-window window)) event

1 0

[Eclipse-cvs] CVS eclipse
by ihatchondo 07 May '07

07 May '07

Update of /project/eclipse/cvsroot/eclipse In directory clnet:/tmp/cvs-serv9824 Modified Files: input.lisp Log Message: Fix: map-request race condition when client remap its top-level before we handled its withdrawal demand. --- /project/eclipse/cvsroot/eclipse/input.lisp 2007/05/04 08:26:14 1.45 +++ /project/eclipse/cvsroot/eclipse/input.lisp 2007/05/07 00:23:05 1.46 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: input.lisp,v 1.45 2007/05/04 08:26:14 ihatchondo Exp $ +;;; $Id: input.lisp,v 1.46 2007/05/07 00:23:05 ihatchondo Exp $ ;;; ;;; ECLIPSE. The Common Lisp Window Manager. ;;; Copyright (C) 2000, 2001, 2002 Iban HATCHONDO @@ -217,7 +217,30 @@ ;;; Events for master (type: decoration) (defmethod event-process ((event map-request) (master decoration)) - (xlib:map-window (event-window event))) + ;; When a client has requested to withdraw its top-level and wants then + ;; to map it back so quickly that we haven't got honored yet its withdrawal + ;; demand, this event is in fact send to the wrong parent and should be re + ;; directed to the real parent of the client top-level. + ;; The events schema is: + ;; 1 -> map-request => procede-decoration + ;; 2 -> unmap-notify => unmap master + ;; 3 -> synthetic unmap-notify => undecore-application + ;; 4 -> map-request + ;; What happen is that the client ask for mapping its top-level (4) after + ;; sending the synthetic unmap-notify (3), but WE have not handled it yet + ;; (otherwise said undecore-application has not been called). So Xserver + ;; generates a map-request event for the known parent: US ! But as soon + ;; as undecore-application will occurred we won't be the parent anymore + ;; and this event should rather have been sent to the real parent + ;; (aka the root window). + (with-slots (window (parent event-window)) event + (multiple-value-bind (children real-parent) (xlib:query-tree window) + (declare (ignore children)) + (if (xlib:window-equal parent real-parent) + (xlib:map-window (event-window event)) + (xlib:send-event real-parent :map-request + '(:substructure-redirect) + :window window :event-window real-parent))))) (defmethod event-process ((event configure-notify) (master decoration)) (with-slots ((master-window event-window) (app-window window)) event

1 0

[Eclipse-cvs] CVS eclipse
by ihatchondo 07 May '07

07 May '07

Update of /project/eclipse/cvsroot/eclipse In directory clnet:/tmp/cvs-serv7563 Modified Files: misc.lisp Log Message: Fix: - screen-window-layer computation when the window doesn't have any workspace number associated with. - make-viewport-property has only one viewport since we don't handled multiple viewport. --- /project/eclipse/cvsroot/eclipse/misc.lisp 2007/05/04 17:45:19 1.37 +++ /project/eclipse/cvsroot/eclipse/misc.lisp 2007/05/07 00:19:10 1.38 @@ -1,5 +1,5 @@ ;;; -*- Mode: Lisp; Package: ECLIPSE-INTERNALS -*- -;;; $Id: misc.lisp,v 1.37 2007/05/04 17:45:19 ihatchondo Exp $ +;;; $Id: misc.lisp,v 1.38 2007/05/07 00:19:10 ihatchondo Exp $ ;;; ;;; This file is part of Eclipse. ;;; Copyright (C) 2002 Iban HATCHONDO @@ -368,7 +368,7 @@ three layers (:_net_wm_state_below none :_net_wm_state_above) of the virtual screen that the given `window' argument belongs to. The given window will be filtered." - (loop with n = (if (eql i +any-desktop+) (current-desk) i) + (loop with n = (if (eql (or i +any-desktop+) +any-desktop+) (current-desk) i) for w in (screen-content n :skip-taskbar nil) for nwm-state = (netwm:net-wm-state w) unless (xlib:window-equal w window) @@ -454,7 +454,8 @@ rw :_eclipse_desktop_pointer_positions prop :CARDINAL 32)))) (defun make-viewport-property (n) - (make-list (* 2 n) :initial-element 0)) + (declare (ignore n)) + (make-list (* 2 1) :initial-element 0)) ;;;; Geometry structure and accessors.

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

eclipse-cvs