- elephant-cvs@lists.common-lisp.net - mailman3.common-lisp.net

[elephant-cvs] CVS elephant/src/elephant
by ieslick 05 Sep '06

05 Sep '06

Update of /project/elephant/cvsroot/elephant/src/elephant In directory clnet:/tmp/cvs-serv10674/src/elephant Modified Files: serializer.lisp variables.lisp Log Message: Extended thread support in thread-safe serializer to other lisps --- /project/elephant/cvsroot/elephant/src/elephant/serializer.lisp 2006/09/04 05:01:06 1.11 +++ /project/elephant/cvsroot/elephant/src/elephant/serializer.lisp 2006/09/05 03:23:17 1.12 @@ -60,25 +60,75 @@ (defconstant +fill-pointer-p+ #x40) (defconstant +adjustable-p+ #x80) +;; +;; This may be overkill, but is intended to avoid continually allocating +;; hashes each time we serialize an object. I added some adaptation +;; to keep it from dropping and re-allocating if the user continually saves +;; large collections of objects. However the defaults should handle most +;; apps just fine. The queue is useful because a system with 10 threads +;; will need 10 circularity queues if it is storing large objects +;; + (defvar *circularity-hash-queue* nil "Circularity ids for the serializer.") +;; quick portability hack, do we need to import 'port' or some +;; other thread layer to the elephant dependency list? + +(defun ele-make-lock () + #+allegro (mp::make-process-lock) + #+cmu (mp:make-lock) + #+sbcl (sb-thread:make-mutex) + #+mcl (ccl:make-lock) + #+lispworks (mp:make-lock) + #-(or allegro sbcl cmu lispworks mcl) nil ) + +(defmacro ele-with-lock ((lock) &body body) + #+allegro `(mp:with-process-lock (,lock) ,@body) + #+cmu `(mp:with-lock-held (,lock) ,@body) + #+sbcl `(sb-thread:with-mutex (,lock) ,@body) + #+lispworks `(mp:with-lock (,lock) ,@body) + #+mcl `(ccl:with-lock-grabbed (,lock) ,@body) + #-(or allegro sbcl cmu lispworks mcl) `(progn ,@body) ) + (defvar *circularity-lock* - #+allegro (mp::make-process-lock)) + (ele-make-lock)) + +(defun drop-circularity-hash-p (hash) + "This allows us to tune our memory usage to the application. + If grow-ceiling-p is enabled then we'll slowly adapt to + a growing demand so we balance GC load and reserved memory" + (if (> (hash-table-size hash) *circularity-max-hash-size*) + (if (and *circularity-grow-ceiling-p* + (>= (incf *circularity-adapt-count*) + *circularity-adapt-step-size*)) + (progn + (setf *circularity-max-hash-size* + (ceiling (* *circularity-growth-factor* + *circularity-max-hash-size*))) + nil) + t) + (progn + (decf *circularity-adapt-count* 0.5) + nil))) (defun get-circularity-hash () - (if *circularity-hash-queue* - (#+allegro - mp::with-process-lock (*circularity-lock*) - (pop *circularity-hash-queue*)) - (make-hash-table :test 'eq :size 50))) + (if (not *circularity-hash-queue*) + (make-hash-table :test 'eq :size 50) + (if *circularity-lock* + (ele-with-lock (*circularity-lock*) + (pop *circularity-hash-queue*)) + (pop *circularity-hash-queue*)))) (defun release-circularity-hash (hash) - (unless (> (hash-table-size hash) 100) + (unless (drop-circularity-hash-p hash) (clrhash hash) - (#+allegro - mp::with-process-lock (*circularity-lock*) - (push hash *circularity-hash-queue*)))) + (if *circularity-lock* + (ele-with-lock (*circularity-lock*) + (push hash *circularity-hash-queue*)) + (push hash *circularity-hash-queue*)))) + + (defun serialize (frob bs) "Serialize a lisp value into a buffer-stream." --- /project/elephant/cvsroot/elephant/src/elephant/variables.lisp 2006/09/04 00:09:15 1.3 +++ /project/elephant/cvsroot/elephant/src/elephant/variables.lisp 2006/09/05 03:23:17 1.4 @@ -43,6 +43,29 @@ Users attempting to directly write this variable will run into an error") +;;;;;;;;;;;;;;;;; +;;;; Serializer optimization parameters + +(defvar *circularity-initial-hash-size* 50 + "This is the default size of the circularity cache used in the serializer") +(defvar *circularity-max-hash-size* 100 + "This is the largest hash table that is maintained by the serializer. Larger + hash tables are dropped from the has queue assuming that it was a one of + transaction or an error.") +(defparameter *circularity-grow-ceiling-p* t + "This enables the system to slowly adapt to larger-than-average lists or other + collections of objects (like large trees) to avoid continually GC'ing large + data structures and reducing total copying over time") +(defparameter *circularity-adapt-step-size* 4 + "How many times we see something over the max in succession before we adapt + to a larger maximum size") +(defparameter *circularity-growth-factor* 0.5 + "How much to increase the max size after each adaptation step") +(defvar *circularity-adapt-count* 0 + "Maintains a count of how many times we've seen a hash table over the appropriate + size. This is reduced by 1/2 each time we don't have one that is oversized.") + + ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;;; Thread-local specials

1 0

[elephant-cvs] CVS elephant/src/db-bdb
by ieslick 05 Sep '06

05 Sep '06

Update of /project/elephant/cvsroot/elephant/src/db-bdb In directory clnet:/tmp/cvs-serv10674/src/db-bdb Modified Files: bdb-controller.lisp sleepycat.lisp Log Message: Extended thread support in thread-safe serializer to other lisps --- /project/elephant/cvsroot/elephant/src/db-bdb/bdb-controller.lisp 2006/09/04 00:09:12 1.11 +++ /project/elephant/cvsroot/elephant/src/db-bdb/bdb-controller.lisp 2006/09/05 03:23:16 1.12 @@ -212,7 +212,12 @@ "Tell the backend to optimize storage between key values" (with-buffer-streams (start stop end) (if (null start) - (db-compact (controller-db ctrl) nil nil end) + (progn + (db-compact (controller-db ctrl) nil nil end) + (db-compact (controller-btrees ctrl) nil nil end) + (db-compact (controller-indices ctrl) nil nil end) + (db-compact (controller-indices-assoc ctrl) nil nil end) + (db-compact (controller-oid-db ctrl) nil nil end)) (progn (serialize start-key start) (db-compact (controller-db ctrl) start --- /project/elephant/cvsroot/elephant/src/db-bdb/sleepycat.lisp 2006/09/04 00:09:12 1.6 +++ /project/elephant/cvsroot/elephant/src/db-bdb/sleepycat.lisp 2006/09/05 03:23:16 1.7 @@ -934,7 +934,8 @@ (flags :unsigned-int) (end array-or-pointer-char) (end-length :unsigned-int) - (end-size :unsigned-int :out))) + (end-size :unsigned-int :out)) + :returning :int) (defun db-compact (db start stop end &key (transaction *current-transaction*) freelist-only free-space)

1 0

[elephant-cvs] CVS elephant/tests
by ieslick 04 Sep '06

04 Sep '06

Update of /project/elephant/cvsroot/elephant/tests In directory clnet:/tmp/cvs-serv17940/tests Modified Files: testindexing.lisp Log Message: Further rethink of roadmap and TODO tasks --- /project/elephant/cvsroot/elephant/tests/testindexing.lisp 2006/05/06 19:18:01 1.18 +++ /project/elephant/cvsroot/elephant/tests/testindexing.lisp 2006/09/04 05:42:43 1.19 @@ -74,13 +74,14 @@ ;;(format t "~%basic store: ~A ~A~%" *store-controller* (elephant::controller-spec *store-controller*)) ;; (format t "auto-commit: ~A~%" *auto-commit*) - (when (class-indexedp-by-name 'idx-one ) + (when (class-indexedp-by-name 'idx-one) (disable-class-indexing 'idx-one :errorp nil) (setf (find-class 'idx-one nil) nil)) (defclass idx-one () ((slot1 :initarg :slot1 :initform 1 :accessor slot1 :index t)) (:metaclass persistent-metaclass)) + (defmethod print-object ((obj idx-one) stream) (if (slot-boundp obj 'slot1) (format stream "slot1 = ~A~%" (slot1 obj))

1 0

[elephant-cvs] CVS elephant
by ieslick 04 Sep '06

04 Sep '06

Update of /project/elephant/cvsroot/elephant In directory clnet:/tmp/cvs-serv17940 Modified Files: TODO Log Message: Further rethink of roadmap and TODO tasks --- /project/elephant/cvsroot/elephant/TODO 2006/09/04 05:01:05 1.24 +++ /project/elephant/cvsroot/elephant/TODO 2006/09/04 05:42:43 1.25 @@ -8,28 +8,19 @@ Bugs or Observations: -Multi-threading operation: -- Make elephant thread-bound variables dynamic and modifiable by backends -- Ensure serialization is multi-threaded -- Verify that operations such as indexing are thread safe - Stability: - Review all the NOTE comments in the code - Remove build gensym warnings in sleepycat -- Port elephant to closer-to-MOP to make it easier to support additional lisps (Both) -- (From Ben's e-mail) We are storing persistent objects incorrectly. They should be - stored only as OIDs, and we should have a separate OID->class table. This way - change-class can be handled correctly. This also non-trivially compresses storage - in the database as we only need to store oids rather than serialized class names. - [Ian comment: only problem with this is an extra access to oid table each time a - class is deserialized and overall storage is constant. Would make it easy to - invalidate objects though!] +- Remove sleepycat name. Change sleepycat to db-bdb to reflect oracle ownership and avoid + confusion for new users - Delete persistent slot values from the slot store with remove-kv to ensure that there's no data left lying around if you define then redefine a class and add back a persistent slot name that you thought was deleted and it gets the old value by default. +- Cleaner failure modes if operations are performed without repository or without + transaction or auto-commit (Both) -Stores: +Store variables: - Think through default *store-controller* vs. explicit parameter passing referencing all over the APIs - Think about dynamic vs. object based store & transaction resolution? @@ -37,57 +28,74 @@ - Current store specific *current-transaction* stack - Throw condition when store spec is invalid, etc -Transactionalism: -- Cleaner failure modes if operations are performed without repository or without - transaction or auto-commit (Both) +Multi-threading operation: +- Make elephant threads appropriately bind dynamic variables +- Verify that operations such as indexing are thread safe BDB Features: +~ Automatically run db_deadlock when opening a bdb backend? Requires path to + functions and ability to launch shell command. Closing the store stops the + sub-process. +- Always support locks that timeout? Tradeoffs? +- Roll deprecation of *auto-commit* through code base so leaf functions stop referring to it - Trace all paths to db-put or db-delete and ensure that there is a check or a default with-transaction around the primitive components - write a document clarifying transaction design & assumptions in the backend] Add asserts if *auto-index* is false and we're not in a transaction to help users avoid lockups in bdb? Should be able to turn off for performance but it will help catch missing with-transaction statemetns in user code. (Both) -~ Automatically run db_deadlock when opening a bdb backend? Requires path to - functions and ability to launch shell command. Closing the store stops the - sub-process. -- Always support locks that timeout? Tradeoffs? +- Figure out how to compact a specific btree and/or key-range using optimize-storage. + Probably need to update keyword part of the API + +Indexing efficiency and policies: +- Add :inverse-reader to slot options to create a named method that indexes into objects + based on slot values. Is this a GF or defun? Do we dispatch on class name or bake it in? +- Reclaim table storage on index drop? It's nice to be able to reconnect sometimes! + Perhaps an API command that allows explicit dropping of tables for a class and a policy + parameter that determines if this is the default? +- Should we delete slot-values in the db when redefining classes, currently those values + stay around - probably indefinitely unless we GC Performance: - Metering and understanding locking issues. Large transactions seem - to use a lot of locks. In general understanding how to use Sleepycat + to use a lot of locks. In general understanding how to use Berkeley DB efficiently seems like a good thing. (From Ben) - Add dependency information into secondary index callback functions so that we can more easily compute which indices need to be updated to avoid the global remove/add in order to maintain consistency (Ian) - Improve SQL serializer performance (Robert/Ian) -Indexing features: -- Add :inverse-reader to slot options to create a named method that indexes into objects - based on slot values. Is this a GF or defun? Do we dispatch on class name or bake it in? - -Compliance and Efficiency: - - Update to support BDB 4.4 - - Add ability from within lisp to reclaim DB space after deleting btree key-value pairs - - Reclaim table storage on index drop - - Should we delete slot-values in the db when redefining classes, currently those values - stay around - probably indefinitely unless we GC +Test coverage: +- Test for optimize storage method (just add probe-file methods to get file size) +- Multi-threading stress tests? Ensure that there are conflicts and lots of serialization + happening concurrently to make sure that multi-threading is in good shape + +Documentation: +- Add notes about with-transaction usage (abort & commit behavior on exit) +- Add notes about optimize-storage +- Add notes about new BDB 4.4 *auto-commit* behavior. Default for entire store-controller, + will auto create a transaction if none is active if open with :auto-commit t or will + never auto-commit (regardless of operator flags) if it is not. Make sure open-store + defaults to auto-commit and there is a flag to turn it off. 0.6.1 - Features COMPLETED to date ---------------------------------- +x Ensure serialization is multi-threaded and efficient x Determine how to detect deadlock conditions as an optional run-safe mode? x BDB overwrite of values makes DB grow [So far I can only find that it grows on the 2nd write, but not after that...artifact of page allocation or caching of memory pools?] x FEATURE: Investigate BDB record size; it's 2x larger than expected? [Ditto above] +x Update to support BDB 4.4 + x Add ability from within lisp to reclaim DB space after deleting btree key-value pairs -0.6.2 - Query & indexing expansion (Fall '06) + +0.6.2 - Advanded work, low-hanging fruit (Fall '06) -------------------------------------------------- - - Simple object query language (Ian - orthogonal, on main branch) - - Add needed support (if any) for persistent graph structures & queries (Ian on a branch) + - Port elephant to closer-to-MOP to make it easier to support additional lisps and to + seriously clean up metaclasses.lisp and classes.lisp protocols - A wrapper around migration that emulates a stop-and-copy GC - - Fast serializer port & upgrade strategy 0.6.3 - Documentation & Tools (Winter '06) -------------------------------------------------- @@ -99,21 +107,19 @@ - A guide to dealing with multiple open stores - A guide to performance - An overview of licensing issues... - - Repository browser (Ian - orthogonal, on main branch) - (a simple REPL tool to see what classes are in a repository and - what state they're in...useful for long-lived repositories) -0.6.4 - Additional datastructures (?) +0.7.0: Fast In-Memory Database (Not backwards compatible) -------------------------------------------------- - - Native BDB persistent hashes (easy; can do on SQL backends?) - - Support for cheap persistent sets (medium? can do on SQL?) - -Some placeholders & dreams features below... :) - -0.7+: Major features (Winter '07) --------------------------------------------------- - - A native lisp backend controller (Ian) - - Integrate prevalence-like in-memory database system (Robert?) + - Integrate prevalence-like in-memory database system + - Fast serializer port w/ upgrade strategy and prevalence like storage solution + - Further improve SQL 64-bit serialization performance (if possible) + - (From Ben's e-mail) We are storing persistent objects incorrectly. They should be + stored only as OIDs, and we should have a separate OID->class table. This way + change-class can be handled correctly. This also non-trivially compresses storage + in the database as we only need to store oids rather than serialized class names. + [Ian comment: only problem with this is an extra access to oid table each time a + class is deserialized and overall storage is constant. Would make it easy to + invalidate objects though!] - Richer controller modes: - Single-user mode (cache values in instance slots for fast reads, write-through) - Prevalence mode (read/write to normal slots except on object creation or synch) @@ -122,6 +128,31 @@ - Concurrent mode (for backends that allow multiple processes to connect, current default) - Controller 'switches' - NoSynch - allow transactions to be lost on failure but maintains consistency instead of performance + - Usage model examples + +0.7.1 - Elephant/BDB/SQL Production Release +-------------------------------------------------- + - More work on testing, examples and documentation + - Intent is for this to be a major, long-term supported release prior + to work on the new backend + +0.7.2 - Additional Tools +-------------------------------------------------- + - Add needed support (if any) for persistent graph structures & queries (Ian on a branch) + - Simple object query language (Ian - orthogonal, on main branch) + - Repository browser (Ian - orthogonal, on main branch) + (a simple REPL tool to see what classes are in a repository and + what state they're in...useful for long-lived repositories) + +0.8.0 - Native Backend & Datastructure Library ( +-------------------------------------------------- + - A native lisp backend controller (Ian) + - Native BDB persistent hashes (easy; can do on SQL backends?) + - Support for cheap persistent sets (medium? can do on SQL?) + - Usage model examples + + + ======================================================== ========================================================

1 0

[elephant-cvs] CVS elephant/tests
by ieslick 04 Sep '06

04 Sep '06

Update of /project/elephant/cvsroot/elephant/tests In directory clnet:/tmp/cvs-serv12920 Modified Files: testsleepycat.lisp Log Message: Fix for spurious error message --- /project/elephant/cvsroot/elephant/tests/testsleepycat.lisp 2006/02/19 04:53:02 1.7 +++ /project/elephant/cvsroot/elephant/tests/testsleepycat.lisp 2006/09/04 05:20:43 1.8 @@ -25,16 +25,16 @@ (setq db (sleepycat::db-create env)) (sleepycat::db-open db :file "testsleepycat" :database "bar" :type SLEEPYCAT::DB-BTREE - :auto-commit t :create t :thread t)) + :auto-commit t :create t :thread t)) (deftest prepares-sleepycat (progn - (if (not (find-package :sleepycat)) - (progn - (format t "sleepycat db not valid, so not runnning test prepares-sleepycat~%") - t) - (finishes (prepare-sleepycat)))) - t) + (if (find-package :sleepycat) + (finishes (prepare-sleepycat)) + (progn + (format t "Berkeley DB not loaded, so not runnning test prepares-sleepycat~%") + t))) + t) #| (deftest put-alot @@ -77,9 +77,9 @@ finally (sleepycat::db-sequence-remove seq :auto-commit t)))) (deftest test-seq1 - (if (not (find-package 'ele-bdb)) + (if (not (find-package :sleepycat)) (progn - (format t "database db not valid, so not runnning test test-seq1~%") + (format t "Berkeley db not loaded, so not runnning test test-seq1~%") t) (finishes (test-sequence1))) t) @@ -117,7 +117,7 @@ (deftest cleansup-sleepycat (if (not db) (progn - (format t "sleepycat db not valid, so not runnning test cleanup-sleepycat~%") + (format t "Berkeley DB not open, so not runnning test cleanup-sleepycat~%") t) (finishes (cleanup-sleepycat))) t)

1 0

[elephant-cvs] CVS elephant/src/elephant
by ieslick 04 Sep '06

04 Sep '06

Update of /project/elephant/cvsroot/elephant/src/elephant In directory clnet:/tmp/cvs-serv8012/src/elephant Modified Files: controller.lisp serializer.lisp Log Message: Added a convenient delete script for cleaning up prior state. BUGFIX: populate created incomplete secondary indices in add-index BUGFIX: generic function mistmatch with new optimize-storage method in bdb --- /project/elephant/cvsroot/elephant/src/elephant/controller.lisp 2006/09/04 00:09:15 1.12 +++ /project/elephant/cvsroot/elephant/src/elephant/controller.lisp 2006/09/04 05:01:06 1.13 @@ -323,7 +323,7 @@ (:documentation "Provides a persistent source of unique id's")) -(defgeneric optimize-storage ((sc store-controller) &allow-other-keys) +(defgeneric optimize-storage (sc &key &allow-other-keys) (:documentation "Tell the backend to reclaim any storage caused by key deletion, if possible. This should default to return space to the filesystem rather than just to the free list.")) --- /project/elephant/cvsroot/elephant/src/elephant/serializer.lisp 2006/09/04 00:09:15 1.10 +++ /project/elephant/cvsroot/elephant/src/elephant/serializer.lisp 2006/09/04 05:01:06 1.11 @@ -60,16 +60,6 @@ (defconstant +fill-pointer-p+ #x40) (defconstant +adjustable-p+ #x80) -(defun clear-circularity-hash () - "This handles the case where we store an object with lots - of object references. CLRHASH then starts to dominate - performance as it has to visit every spot in the table so - we're better off GCing the old table than clearing it" - (declare (optimize (speed 3) (safety 0))) - (if (> (hash-table-size *circularity-hash*) 100) - (setf *circularity-hash* (make-hash-table :test 'eq :size 50)) - (clrhash *circularity-hash*))) - (defvar *circularity-hash-queue* nil "Circularity ids for the serializer.")

1 0

[elephant-cvs] CVS elephant/tests
by ieslick 04 Sep '06

04 Sep '06

Update of /project/elephant/cvsroot/elephant/tests In directory clnet:/tmp/cvs-serv8012/tests Added Files: delscript.sh Log Message: Added a convenient delete script for cleaning up prior state. BUGFIX: populate created incomplete secondary indices in add-index BUGFIX: generic function mistmatch with new optimize-storage method in bdb --- /project/elephant/cvsroot/elephant/tests/delscript.sh 2006/09/04 05:01:07 NONE +++ /project/elephant/cvsroot/elephant/tests/delscript.sh 2006/09/04 05:01:07 1.1 rm testdb/__* rm testdb/%* rm testdb/log* rm testdb2/__* rm testdb2/%* rm testdb2/log* rm testsleepycat/testsleepycat rm testsleepycat/__* rm testsleepycat/log*

1 0

[elephant-cvs] CVS elephant
by ieslick 04 Sep '06

04 Sep '06

Update of /project/elephant/cvsroot/elephant In directory clnet:/tmp/cvs-serv8012 Modified Files: TODO Log Message: Added a convenient delete script for cleaning up prior state. BUGFIX: populate created incomplete secondary indices in add-index BUGFIX: generic function mistmatch with new optimize-storage method in bdb --- /project/elephant/cvsroot/elephant/TODO 2006/09/04 00:09:10 1.23 +++ /project/elephant/cvsroot/elephant/TODO 2006/09/04 05:01:05 1.24 @@ -70,6 +70,8 @@ - Update to support BDB 4.4 - Add ability from within lisp to reclaim DB space after deleting btree key-value pairs - Reclaim table storage on index drop + - Should we delete slot-values in the db when redefining classes, currently those values + stay around - probably indefinitely unless we GC 0.6.1 - Features COMPLETED to date ----------------------------------

1 0

[elephant-cvs] CVS elephant/src/db-bdb
by ieslick 04 Sep '06

04 Sep '06

Update of /project/elephant/cvsroot/elephant/src/db-bdb In directory clnet:/tmp/cvs-serv7921 Modified Files: bdb-collections.lisp Log Message: Fixed add-index bug leading to incomplete indices --- /project/elephant/cvsroot/elephant/src/db-bdb/bdb-collections.lisp 2006/06/19 00:47:24 1.8 +++ /project/elephant/cvsroot/elephant/src/db-bdb/bdb-collections.lisp 2006/09/04 04:56:50 1.9 @@ -134,14 +134,18 @@ (reset-buffer-stream primary-buf) (reset-buffer-stream secondary-buf))) (let ((key-fn (key-fn index)) - (last-key nil)) - (loop + (last-key nil) + (continue t)) + (loop while continue + do (with-transaction (:store-controller sc) (with-btree-cursor (cursor bt) (if last-key (cursor-set cursor last-key) (cursor-first cursor)) - (loop for i from 0 upto 1000 do + (loop for i from 0 upto 1000 + while continue + do (multiple-value-bind (valid? k v) (cursor-current cursor) (unless valid? (return-from populate t)) (multiple-value-bind (index? skey) (funcall key-fn index k v) @@ -150,7 +154,8 @@ (declare (ignore v)) (if valid? (setf last-key k) - (return-from populate t)))))))))))) + (setf continue nil)))))))))))) + (defmethod map-indices (fn (bt bdb-indexed-btree)) (maphash fn (indices-cache bt)))

1 0

[elephant-cvs] CVS elephant/src/memutil
by ieslick 04 Sep '06

04 Sep '06

Update of /project/elephant/cvsroot/elephant/src/memutil In directory clnet:/tmp/cvs-serv14802/src/memutil Modified Files: memutil.lisp Log Message: Berkeley DB Backend upgrade & compact API fn, bug fixes --- /project/elephant/cvsroot/elephant/src/memutil/memutil.lisp 2006/07/03 00:36:37 1.8 +++ /project/elephant/cvsroot/elephant/src/memutil/memutil.lisp 2006/09/04 00:09:16 1.9 @@ -321,11 +321,12 @@ "Return the number of bytes of the internal representation of a string." #+(and allegro ics) - ;; old: `(let ((l (length ,s))) (+ l l)) + ;; old: + ;; `(let ((l (length ,s))) (+ l l)) `(etypecase ,s - (base-string ;; (excl:native-string-sizeof ,s :external-format :unicode)) - (length ,s)) ;; fast 0.6.1 + (base-string (length ,s)) ;; fast 0.6.1 (string (excl:native-string-sizeof ,s :external-format :unicode))) + ;; (excl:native-string-sizeof ,s :external-format :unicode)) #+(or (and sbcl sb-unicode) lispworks) `(etypecase ,s (base-string (length ,s))

1 0