December 2015 - gsll-devel - mailman3.common-lisp.net

Re: Slight recode of gsll/data/permutations.lisp (Re: Bugfix for gsll/data/permutations.lisp)
by Mirko Vukovic 22 Jan '16

22 Jan '16

This is a follow-up on the previous patch. I applied the same principles on data/combination.lisp and recoded using GSL's combination functions only. Again this cleared up some errors or failures on my end. I hope that I did not mangle major pieces of your design intent. Mirko On Fri, Nov 27, 2015 at 10:43 PM, Mirko Vukovic <mirko.vukovic(a)gmail.com> wrote: > Liam, > > I am not trying to bludgeon this issue to death nor convince the you that > I am right and you are wrong. > > In a nutshell, I started on this path because of exception errors when > trying to > load GSLL on Windows (SBCL or CCL) using GSL compiled MinGW64. I > traced this to the initialization of the permutation structures and the > size of > the requested memory (see recent post on CFFI mailing list). > > I decided to rewrite a small part of permutation.lisp to use GSL's code to > directly > initialize and query permutation structure. The attached patch contains > the > rewrite and some minor edits. All the permutation and qrpt tests pass. > > The patch should be considered a proof-of-concept (or failure of concept). > > For me, this patch has cleared the exception errors that have started me > on this > trek. Even if it is not accepted, I learned something, and it was fun. > And I can > keep it on my GSLL so that it runs for me. > > Best, > > Mirko > > > > > On Thu, Nov 26, 2015 at 10:24 AM, Liam Healy <lhealy(a)common-lisp.net> > wrote: > >> Added thought: you can lookup any GSL (C) function to find the CL >> equivalent by using gsl-lookup. So for example >> >> (gsl:gsl-lookup "gsl_permute_vector") >> PERMUTE >> T >> >> tells you #'permute is the function you want. If there is no >> equivalent (there are some C functions with no interface in CL), you >> will get NIL as the return value of this function. >> >> Liam >> >> >> On Wed, Nov 25, 2015 at 11:20 PM, Mirko Vukovic <mirko.vukovic(a)gmail.com> >> wrote: >> > Thanks for the explanations - I missed the :generic and :method >> specifiers. >> > I'll study the macro-expansions. >> > >> > Sorry for the noise. >> > >> > Mirko >> > >> > On Tue, Nov 24, 2015 at 10:16 PM, Liam Healy <lhealy(a)common-lisp.net> >> wrote: >> >> >> >> The original code looks right to me. >> >> >> >> You have taken the generic function and the associated foreign vector >> >> methods #'permute and gratuitously renamed them #'permute-vector, >> >> leaving the method for raw C pointer with the original name and no >> >> generic function. Then you completely delete the generic function and >> >> vector methods for #'permute-inverse for no apparent reason, leaving a >> >> method for the raw C pointer only. >> >> >> >> There is no duplicated code here. There is certainly the equivalent of >> >> gsl_permute_vector, it is the GRID:VECTOR-DOUBLE-FLOAT (second arg) >> >> method of #'permute (which you renamed). >> >> >> >> I recommend macroexpansion as a way of seeing what's being defined. If >> >> you use emacs, place the cursor on the defmfun line and do C-c C-m. >> >> Then you will see all the generic functions and methods, and you will >> >> see there is no error in the original code. >> >> >> >> On Tue, Nov 24, 2015 at 5:43 PM, Mirko Vukovic < >> mirko.vukovic(a)gmail.com> >> >> wrote: >> >> > Because of a typo, GSLL did not have the equivalent of >> >> > GSL_PERMUTE_VECTOR. >> >> > >> >> > There was also a section of duplicated code. >> >> > >> >> > This patch should fix these errors. >> >> > >> >> > NOTE: I did not test this patch - My GSLL system is not behaving >> >> > super-cleanly on MSYS2 and GSL2.1. Proceed with care. >> >> > >> >> > Mirko >> > >> > >> > >

2 3

Re: [patch] fix gsl-config-pathname
by Munawar Cheema 29 Dec '15

29 Dec '15

I tried to check this on my OS X Mavericks system with CCL but I am getting readtable errors. Just to make sure this is what I did. I git cloned both antik and gsll to my local-projects directory from https://gitlab.common-lisp.net/groups/antik If I git log I see the commit of antik is:63fa8e0a0c04090... and for gsll it is: ad5409ec81f4af... When I try either (ql:quickload :antik) or (ql:quickload :gsll) i get errors like: Reader error on #<BASIC-FILE-CHARACTER-INPUT-STREAM ("/Users/mcheema/quicklisp/local-projects/antik/tests/physical-quantities-grid.lisp"/4 UTF-8) #x3020023E839D>, near position 2047, within "m)) #(1.0d0 5.0d": Undefined character #\( in a #\# dispatch macro. Reader error on #<BASIC-FILE-CHARACTER-INPUT-STREAM ("/Users/mcheema/quicklisp/local-projects/gsll/polynomial.lisp"/4 UTF-8) #x3020024DCCBD>, near position 1730, within "t x.\") #+fsbv (defm": Undefined character #\+ in a #\# dispatch macro. I see there was a commit relating to a named-readtable recently and maybe that is causing the problem or I am just not doing this correctly. -- Kind Regards Munawar

2 1

gsll+msys2, gsl2.0, antik patches
by Mirko Vukovic 06 Dec '15

06 Dec '15

For GSLL I am attaching two git patches that accomplish several things: - Loading of GSL that is part of MSYS2 on Windows - Removed dependency on Osicat library - Enable loading of GSL 2.0 by fixing a bit of code in nonlinear least squares fitter. - Disabled loading of basis-spline.lisp - Cosmetic fixes. I could not figure out the problem with basis-spline. I thus removed it. There may be a much better solution than that. I checked the above on latest CCL and SBCL on Windows 7. Warning: the two commits required some git surgery (splitting a commit into two). I hope that I did not introduce additional problems with the splits. For Antik I am attaching one patch that fixes the readtable problem on CCL: (named-readtables:defreadtable :antik (:merge :standard) #-ccl(:macro-char #\# :dispatch)) Without the patch all #... reader macros (CL and Antik) were deleted. With this patch both CL and Antik's reader macros work in CCL. I also tried the patch with SBCL, and I don't see a need for it. But since the macro-char redefinition did not hurt in SBCL, I left it in. Mirko

2 2

Antik split systems
by Liam Healy 04 Dec '15

04 Dec '15

I am planning to make a major branch merge for Antik soon which affects Antik and GSLL users. A couple years ago I reorganized Antik to split it up into separate systems so that, for example, if you just want to use GSLL, it will not load some parts of Antik that GSLL doesn't need. GSLL also split into two branches so that it could track that Antik branch. I made all updates in the new branches, so the master branches have not seen any progress in the last couple years. This weekend, prior to the Quicklisp December release, I plan to merge these branches into their respective master branches. I am sending this email because of the user-visible changes. On the current master branch of Antik, some global changes were made, notably to the reader, which meant that loading Antik affected completely different systems, which is undesirable. So, the readtable now must be changed manually if you want to use the Antik reader macros #m (grids), #d (dates and times), #_ (physical dimension quantities). Also, *read-default-float-format* was set to 'double-float and this no longer happens. As a convenience, I have defined (set-reader) (set-reader-in-file) to restore the old behavior. They must be invoked manually however, in each REPL or file (respectively) in which you want the desired reader behavior. In Antik, I've started to rewrite the documentation using Sphinx. However, this effort has just begun (and there are some problems with Sphinx I need to fix), so the texinfo documentation is still there. All the changes related to the new branch are in the Sphinx documentation. Thanks, Liam

1 0