I have been spending enjoyable time with gsll's (and gsl's) histogram routines.
A small bug in the code popped up. In histogram/histogram.lisp the grid:copy method calls histo-copy and histo-clone. The arguments in those calls are incorrect. This is what the method should look like:
(defmethod grid:copy ((source histogram) &key destination &allow-other-keys) (if destination (histo-copy source destination) (histo-clone source)))
In the original, source and destination were swapped.
The same fix applies to the method that specializes on histogram2d.
Mirko
Thanks. Fixed in dfbc975074, currently on the antik-multiple-systems branch.
Liam
On Tue, Aug 5, 2014 at 5:47 PM, Mirko Vukovic mirko.vukovic@gmail.com wrote:
I have been spending enjoyable time with gsll's (and gsl's) histogram routines.
A small bug in the code popped up. In histogram/histogram.lisp the grid:copy method calls histo-copy and histo-clone. The arguments in those calls are incorrect. This is what the method should look like:
(defmethod grid:copy ((source histogram) &key destination &allow-other-keys) (if destination (histo-copy source destination) (histo-clone source)))
In the original, source and destination were swapped.
The same fix applies to the method that specializes on histogram2d.
Mirko
Gsll-devel mailing list Gsll-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/gsll-devel
-
Liam Healy -
Mirko Vukovic