It looks like the definition of lu-decomp (linear-algebra/lu.lisp) is incorrect. Instead of (signum :int) it should read (signum :pointer), right? My code (see below) works with this change, but not without it (it complains that the pointer isn't a fixnum). However, signum is really just a return value of the function, depending on how high level this should all be, we may want to write a wrapper that allocates that memory and passes it back as a second value. But then we would have to worry about memory leaks (since the GC won't free the memory, right?) Further, this `function' really just modifies it's arguments. I guess the Lisp way would be to change this into a function that returns the modified structures and mark it as a destructive function... It is hard for me to make Lisp style and C style coexist in my head.
How were the GSL definitions generated? How did this :int :pointer confusion slip through? If the point here is to make a system where mathematics can be done interactively, i.e. (invert-matrix #2A((1 0) (3 4))) ==> #2A(...), then a big part of this is going to be making wrapper functions that hide the C like nuts and bolts that make GSL a bit annoying to use in the first place.
(defun invert-matrix (mat) (gsl:letm ((mat2 (gsl:matrix-double mat)) (per (gsl:permutation 2)) (inv (gsl:matrix-double 2 2)) (sig (cffi:foreign-alloc :int :count 1)) ) (gsl:lu-decomp mat2 per sig) (gsl:lu-invert mat2 per inv) (cffi:foreign-free sig) (gsl:data inv) ))
How can I get rid of the explicit foreign-alloc/free? Is this outside of the scope of GSLL (seems like a border case to me).
Thanks, Zach
If you update GSLL, you will now find the file ;; $Id: lu.lisp 36 2008-03-15 19:55:54Z lhealy $
with a defun at the end using the new definition of #'lu-decomp (defun invert-matrix (mat) "Invert the matrix." (letm ((mmat (matrix-double-float mat)) (dim (array-dimension mat 0)) (per (permutation dim)) (inv (matrix-double-float dim dim))) (lu-decomp mmat per) (lu-invert mmat per inv) (data inv)))
(also note that GSL matrices are now declared matrix-double-float). I hope this is what you're looking for.
On 3/10/08, Zach elzacho@gmail.com wrote:
It looks like the definition of lu-decomp (linear-algebra/lu.lisp) is incorrect. Instead of (signum :int) it should read (signum :pointer), right? My code (see below) works with this change, but not without it (it complains that the pointer isn't a fixnum). However, signum is really just a return value of the function, depending on how high level this should all be, we may want to write a wrapper that allocates that memory and passes it back as a second value. But then we would have to worry about memory leaks (since the GC won't free the memory, right?) Further, this `function' really just modifies it's arguments. I guess the Lisp way would be to change this into a function that returns the modified structures and mark it as a destructive function... It is hard for me to make Lisp style and C style coexist in my head.
How were the GSL definitions generated? How did this :int :pointer confusion slip through? If the point here is to make a system where mathematics can be done interactively, i.e. (invert-matrix #2A((1 0) (3 4))) ==> #2A(...), then a big part of this is going to be making wrapper functions that hide the C like nuts and bolts that make GSL a bit annoying to use in the first place.
(defun invert-matrix (mat) (gsl:letm ((mat2 (gsl:matrix-double mat)) (per (gsl:permutation 2)) (inv (gsl:matrix-double 2 2)) (sig (cffi:foreign-alloc :int :count 1)) ) (gsl:lu-decomp mat2 per sig) (gsl:lu-invert mat2 per inv) (cffi:foreign-free sig) (gsl:data inv) ))
How can I get rid of the explicit foreign-alloc/free? Is this outside of the scope of GSLL (seems like a border case to me).
Thanks, Zach
Gsll-devel mailing list Gsll-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/gsll-devel
On Sat, 15 Mar 2008, Liam Healy wrote:
If you update GSLL, you will now find the file ;; $Id: lu.lisp 36 2008-03-15 19:55:54Z lhealy $
with a defun at the end using the new definition of #'lu-decomp (defun invert-matrix (mat) "Invert the matrix." (letm ((mmat (matrix-double-float mat)) (dim (array-dimension mat 0)) (per (permutation dim)) (inv (matrix-double-float dim dim))) (lu-decomp mmat per) (lu-invert mmat per inv) (data inv)))
(also note that GSL matrices are now declared matrix-double-float). I hope this is what you're looking for.
Dear Liam,
With the latest svn checkout (36) sbcl 1.0.15 raises the following error:
There is no class named GSLL::MATRIX-DOUBLE-FLOAT. [Condition of type SIMPLE-ERROR]
Restarts: 0: [RETRY] Retry performing #<ASDF:LOAD-OP NIL {1003992C31}> on #<ASDF:CL-SOURCE-FILE "lu" {1003CB1B01}>. 1: [ACCEPT] Continue, treating #<ASDF:LOAD-OP NIL {1003992C31}> on #<ASDF:CL-SOURCE-FILE "lu" {1003CB1B01}> as having been successful. 2: [RETRY] Retry installation 3: [ABORT] Return to SLIME's top level. 4: [TERMINATE-THREAD] Terminate this thread (#<THREAD "repl-thread" {1003BC5301}>)
when compiling the lu code.
Jason
Weird. I just deleted all my fasls and recompiled with no trouble. Are you sure you did a complete checkout? I changed the class names in version 34. This affected a lot of different files, so perhaps those haven't been updated in your working directory?
Liam
On 3/15/08, Jason Nielsen jdn@math.carleton.ca wrote:
Dear Liam,
With the latest svn checkout (36) sbcl 1.0.15 raises the following error:
There is no class named GSLL::MATRIX-DOUBLE-FLOAT. [Condition of type SIMPLE-ERROR]
Restarts: 0: [RETRY] Retry performing #<ASDF:LOAD-OP NIL {1003992C31}> on #<ASDF:CL-SOURCE-FILE "lu" {1003CB1B01}>. 1: [ACCEPT] Continue, treating #<ASDF:LOAD-OP NIL {1003992C31}> on #<ASDF:CL-SOURCE-FILE "lu" {1003CB1B01}> as having been successful. 2: [RETRY] Retry installation 3: [ABORT] Return to SLIME's top level. 4: [TERMINATE-THREAD] Terminate this thread (#<THREAD "repl-thread" {1003BC5301}>)
when compiling the lu code.
Jason
Gsll-devel mailing list Gsll-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/gsll-devel
Dear Liam,
It would appear the link to the "Matrices and Vectors" document on the document page is broken. In fact the page referenced does not appear to exist in the source tree.
With kind regards, Jason
Thanks, fixed.
On 3/19/08, Jason Nielsen jdn@math.carleton.ca wrote:
Dear Liam,
It would appear the link to the "Matrices and Vectors" document on the document page is broken. In fact the page referenced does not appear to exist in the source tree.
With kind regards, Jason _______________________________________________ Gsll-devel mailing list Gsll-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/gsll-devel
-
Jason Nielsen -
Liam Healy -
Zach