- iterate-devel - mailman3.common-lisp.net

Re: Test status
by Robert Goldman 24 Jan '18

24 Jan '18

I think that must be using an older version of iterate, in quicklisp, because the latest version has `iterate/tests` instead (as it should). Best, r On 24 Jan 2018, at 17:12, Patrick Stein wrote: > I was going to recommend referring to cl-test-grid, but it seems that > testgrid cannot locate the iterate-tests system. > > https://common-lisp.net/project/cl-test-grid/library/iterate.html > > -- Patrick <pat(a)nklein.com> > >> On Jan 24, 2018, at 4:38 PM, Robert Goldman <rpgoldman(a)sift.info> >> wrote: >> >> On 24 Jan 2018, at 16:17, Ilya Perminov wrote: >> >> >> I think the warings are expected. A note just above them says "Note: >> These tests generate warnings involving MACROLET within Iterate". >> I am not sure why our test results are different. Maybe my SBCL >> version is too old, I'll try the latest one. >> >> Looks like these 5 failures are what I should be expecting. At the >> top of iterate-test.lisp I find this: >> >> ;; This is here to document which tests are failing at the time of >> ;; writing. It's not used directly here, but the tests of the >> ;; iterate-compat package of hu.dwim.reiterate expect it. >> (defvar *tests-expected-to-fail* >> '(always.finally >> never.finally >> thereis.finally >> bug/walk.2 >> bug/collect-at-beginning >> )) >> That suggests that the errors in code-movement.finally, >> code-movement.finally-protected and code-movement.else are unique to >> ACL and are not expected to fail. >> >> I'll try to make time to have a look at what is going on there. >> >> Best, >> r

1 0

Re: Test status
by Robert Goldman 24 Jan '18

24 Jan '18

On 24 Jan 2018, at 15:39, Ilya Perminov wrote: > Hi Robert, > > To "revert" my patch manually just revert this change: > > --- old-iterate/iterate.lisp 2018-01-15 16:49:24.171636397 -0800 > +++ new-iterate/iterate.lisp 2018-01-15 16:49:24.171636397 -0800 > @@ -3374,7 +3374,7 @@ > (if (not (and (integerp n) (> n 0))) > (clause-error "~a should be a positive integer" n-expr) > ;; Here, n is a positive integer. > - (let* ((p-i (intern-previous-info var)) > + (let* ((p-i (intern-previous-info var :next)) > (init-val (make-initial-value default default? (var-type > var))) > (temp (if (not (duplicable? init-val)) > (make-var-and-default-binding > > i.e. remove :next from (intern-previous-info var :next). > I only tested my patch on SBCL 1.3.0 and it did not break any tests. > The BUG > tests failed, but everything else passed. > > Ilya On MacOS, with SBCL 1.3.14, I get 5 failures: ``` 5 out of 268 total tests failed: ITERATE.TEST::ALWAYS.FINALLY, ITERATE.TEST::NEVER.FINALLY, ITERATE.TEST::THEREIS.FINALLY, ITERATE.TEST::BUG/WALK.2, ITERATE.TEST::BUG/COLLECT-AT-BEGINNING.; ``` I also see this: ``` ; caught STYLE-WARNING: ; undefined function: ITERATE:MULTIPLYING ; ; compilation unit finished ; Undefined function: ; ITERATE:MULTIPLYING ; caught 1 ERROR condition ; caught 1 WARNING condition ; caught 1 STYLE-WARNING condition ``` This is from loading the test system -- iterate itself loads without problems. I'm not sure why this happens: I see this: ``` iterate.lisp 2872:(defsynonym multiplying multiply) ``` and `multiplying` seems to be exported from package.lisp. The error occurs in `bug/macrolet.2` One thing I don't understand -- the test suite seems to use `:SB-RT` on SBCL, which is *not* the same as the `RT` package. Any idea what's going on here? Definitely caused me some confusion as a not-normally-SBCL user.

2 4

Test status
by Robert Goldman 24 Jan '18

24 Jan '18

I was just testing out the version of ITERATE with Ilya's new fixes. Question: what do we expect to happen when `ASDF:TEST-SYSTEM` is run on iterate? I see 8 test failures, on ACL 10.1, as follows: ``` 8 out of 267 total tests failed: ITERATE.TEST::ALWAYS.FINALLY, ITERATE.TEST::NEVER.FINALLY, ITERATE.TEST::THEREIS.FINALLY, ITERATE.TEST::CODE-MOVEMENT.ELSE, ITERATE.TEST::CODE-MOVEMENT.FINALLY, ITERATE.TEST::CODE-MOVEMENT.FINALLY-PROTECTED, ITERATE.TEST::BUG/WALK.2, ITERATE.TEST::BUG/COLLECT-AT-BEGINNING. ``` Is there some way for us to tell whether this is a regression, or if these are all known issues? I figure the tests prefixed with `BUG/` are probably known failures, but what about the other 6? Would it be possible to put a list of canonical test results on the iterate project page? Thanks!

1 1

Bug: (for X previous Y ...) does not check existence of Y
by Ilya Perminov 16 Jan '18

16 Jan '18

Hello, Iterate silently ignores "for ... previous" clauses that reference undefined variables, e.g, (iter (repeat 2) (for x previous y initially 0) (collect x)) returns (0 0). A patch to fix the bug is attached. Can someone apply it please. Thanks, Ilya

2 1

Patch for iterate.asd
by Robert P. Goldman 21 Apr '17

21 Apr '17

ASDF no longer is happy with system names like "iterate-test". Instead, subsidiary systems in the same .asd file should be named using a slash. So, "iterate/test". As a bonus in exchange for the need to rename, ASDF will now be able to find all the subsidiary systems. I.e., you can simply do (asdf:load-system "iterate/test") now, instead of (asdf:load-system "iterate) (asdf:load-system "iterate-test") which was necessary before, because until ASDF had loaded "iterate" it didn't know where to look for the definition of "iterate-test." At the same time I killed the block comment at the top, which was a complaint about ASDF that is no longer current (the feature requested has been added). I'm afraid darcs is one revision control system too many for my poor brain (any chance of changing the iterate repo to git?), so I am attaching a patch file that can be applied to iterate.asd.

2 2

.asd file IN-PACKAGE
by Robert P. Goldman 12 Jul '16

12 Jul '16

The ASD file is IN-PACKAGE ASDF, which is really not A Good Thing. You could at least potentially damage a user's working ASDF by smashing some symbol in that package. The comment at the header expresses a dislike for adding a new package. That's fine. If you don't put a package there, ASDF will load it into ASDF-USER. So we should either: 1. replace ASDF with ASDF-USER in the IN-PACKAGE -- that's what I would favor, since it allows a programmer to interact with this definition in the editor or 2. simply remove the IN-PACKAGE form altogether, and ASDF will automagically put it into an appropriate package. Best, r

2 3

License terms for ITERATE
by Robert P. Goldman 08 Jul '16

08 Jul '16

ITERATE has a GPL license. Does that mean that the developers intend that any system using ITERATE must, itself, be GPL? I am not certain what follows from GPL licensing, since Lisp code isn't linked with library code. But I fear it might, or might require some cumbersome expedient like forcing people who distribute non-GPL code to hand off the ITERATE code and require recipients to compile it in themselves. Is there any chance that this could be offered under LLGPL or some less-restrictive license? Thanks, r

1 1

usage with ECL on Android
by Helmut Jarausch 17 Apr '15

17 Apr '15

Hi, I just have a binary for ECL on my Android phone but no other Lisp infrastructure. How can I use iterate under these circumstances? Many thanks for a hint, Helmut

1 0

Re: [Iterate-devel] iterate-1.4.3 doesn't compile under SBCL-1.2.8
by Zach Kost-Smith 25 Feb '15

25 Feb '15

I do see the same error and cannot build Iterate 1.4.3, but that was all a bit of a surprise. That is because I use Iterate every day and trust that it will always work, and it has, if you are using the Quicklisp version of the library. So to you, Helmut, I would suggest that you start using Quicklisp (http://www.quicklisp.org/) and bask in the limited amount of quality control that it has. The bigger question here is what is going on with darcs/current tarball/Quicklisp? You don't see this problem with Quicklisp version of iterate, which should be taken from the darcs repo automatically on regular periods. So I cloned the darcs repo and (other than some misterious "hash failed" errors) it is identical to the quicklisp version and, naturally, it loads fine. The last time the quicklisp version was updated was sometime in June of last year which is after the last commit in the log of the darcs repo (on April 22: "make the #L reader macro standard conformant by not assuming anything about the representation of quasiquoted forms") . So what is 1.4.3? A diff between the Quicklisp version and the 1.4.3 version shows that there are substantial changes. I really don't know much about Darcs, but I assume that there is some other branch out there or something which is where "1.4.3" resides. Is this a rogue or development branch that somebody is accidentally giving as the current version on common-lisp.net? Zach KS On Wed, Feb 25, 2015 at 6:02 AM, Helmut Jarausch <jarausch(a)skynet.be> wrote: > Hi, > > please bear in mind that I'm Lisp newbee. > When I try to load iterate (1.4.3) I get the warnings and one error below. > > Many thanks for a hint, > Helmut > > > ; in: DEFMACRO WITH-TEMPORARY > ; `(LET ((,ITERATE::OLD-VAR ITERATE::*TEMPS-IN-USE*)) > ; (UNWIND-PROTECT > ; (LET ,(MAPCAR #'(LAMBDA # `#) ITERATE::VARS) > ; . ,ITERATE::BODY) > ; (SETQ ITERATE::*TEMPS-IN-USE* ,ITERATE::OLD-VAR))) > ; --> SB-IMPL::|List| SB-IMPL::|List| SB-IMPL::|List*| MAPCAR LET LET > ; --> SB-INT:DO-ANONYMOUS BLOCK LET TAGBODY TAGBODY SB-KERNEL:%RPLACD > ; --> SETQ THE LIST CONS > ; ==> > ; (SB-C::%FUNCALL #:G2 (CAR #:G1)) > ; > ; caught WARNING: > ; function called with one argument, but wants exactly zero > ; See also: > ; The ANSI Standard, Section 3.2.2.3 > > ; file: /home/jarausch/Lisp_My/TEST/iterate.lisp > ; in: DEFMACRO WITH-TEMPORARY > ; `(LET ((,ITERATE::OLD-VAR ITERATE::*TEMPS-IN-USE*)) > ; (UNWIND-PROTECT > ; (LET ,(MAPCAR #'(LAMBDA # `#) ITERATE::VARS) > ; . ,ITERATE::BODY) > ; (SETQ ITERATE::*TEMPS-IN-USE* ,ITERATE::OLD-VAR))) > ; --> SB-IMPL::|List| SB-IMPL::|List| SB-IMPL::|List*| MAPCAR LET > ; --> SB-KERNEL:%COERCE-CALLABLE-TO-FUN FUNCTION SB-INT:QUASIQUOTE > ; ==> > ; (SB-IMPL::|List*| ITERATE::!1 '((ITERATE::GET-FREE-TEMP))) > ; > ; caught WARNING: > ; undefined variable: !1 > ; > > The following errors occurs in several functions > > ; in: DEFUN RETURN-COLLECTION-CODE > ; (ITERATE::WITH-TEMPORARY ITERATE::TEMP-VAR > ; (LET* ((ITERATE::UPDATE-CODE > ; `(IF ,ITERATE::COLLECT-VAR > ; # > ; #)) > ; (ITERATE::MAIN-CODE (COND # # #))) > ; (ITERATE::RETURN-CODE :BODY > ; `((PROGN > ; ,.ITERATE::MAIN-CODE > ; ,ITERATE::COLLECT-VAR)) > ; :FINAL > ; (IF (EQ ITERATE::RESULT-TYPE 'LIST) > ; NIL > ; `(#))))) > ; > ; caught ERROR: > ; during macroexpansion of > ; (WITH-TEMPORARY TEMP-VAR > ; (LET* # > ; #)). > > > _______________________________________________ > Iterate-devel mailing list > Iterate-devel(a)common-lisp.net > https://mailman.common-lisp.net/cgi-bin/mailman/listinfo/iterate-devel >

1 0

[Iterate-devel] iterate-1.4.3 doesn't compile under SBCL-1.2.8
by Helmut Jarausch 25 Feb '15

25 Feb '15

Hi, please bear in mind that I'm Lisp newbee. When I try to load iterate (1.4.3) I get the warnings and one error below. Many thanks for a hint, Helmut ; in: DEFMACRO WITH-TEMPORARY ; `(LET ((,ITERATE::OLD-VAR ITERATE::*TEMPS-IN-USE*)) ; (UNWIND-PROTECT ; (LET ,(MAPCAR #'(LAMBDA # `#) ITERATE::VARS) ; . ,ITERATE::BODY) ; (SETQ ITERATE::*TEMPS-IN-USE* ,ITERATE::OLD-VAR))) ; --> SB-IMPL::|List| SB-IMPL::|List| SB-IMPL::|List*| MAPCAR LET LET ; --> SB-INT:DO-ANONYMOUS BLOCK LET TAGBODY TAGBODY SB-KERNEL:%RPLACD ; --> SETQ THE LIST CONS ; ==> ; (SB-C::%FUNCALL #:G2 (CAR #:G1)) ; ; caught WARNING: ; function called with one argument, but wants exactly zero ; See also: ; The ANSI Standard, Section 3.2.2.3 ; file: /home/jarausch/Lisp_My/TEST/iterate.lisp ; in: DEFMACRO WITH-TEMPORARY ; `(LET ((,ITERATE::OLD-VAR ITERATE::*TEMPS-IN-USE*)) ; (UNWIND-PROTECT ; (LET ,(MAPCAR #'(LAMBDA # `#) ITERATE::VARS) ; . ,ITERATE::BODY) ; (SETQ ITERATE::*TEMPS-IN-USE* ,ITERATE::OLD-VAR))) ; --> SB-IMPL::|List| SB-IMPL::|List| SB-IMPL::|List*| MAPCAR LET ; --> SB-KERNEL:%COERCE-CALLABLE-TO-FUN FUNCTION SB-INT:QUASIQUOTE ; ==> ; (SB-IMPL::|List*| ITERATE::!1 '((ITERATE::GET-FREE-TEMP))) ; ; caught WARNING: ; undefined variable: !1 ; The following errors occurs in several functions ; in: DEFUN RETURN-COLLECTION-CODE ; (ITERATE::WITH-TEMPORARY ITERATE::TEMP-VAR ; (LET* ((ITERATE::UPDATE-CODE ; `(IF ,ITERATE::COLLECT-VAR ; # ; #)) ; (ITERATE::MAIN-CODE (COND # # #))) ; (ITERATE::RETURN-CODE :BODY ; `((PROGN ; ,.ITERATE::MAIN-CODE ; ,ITERATE::COLLECT-VAR)) ; :FINAL ; (IF (EQ ITERATE::RESULT-TYPE 'LIST) ; NIL ; `(#))))) ; ; caught ERROR: ; during macroexpansion of ; (WITH-TEMPORARY TEMP-VAR ; (LET* # ; #)).

1 0