January 2008 - mcclim-devel - mailman3.common-lisp.net

[mcclim-devel] how to do pixel-by-pixel output?
by Nikodemus Siivola 22 Jan '08

22 Jan '08

I realize this may be a case of "Doctor, it hurts when I do this..", but I'm hoping there is some medicine to be had. I'm displaying images from my raytracer on a canvas as they are being rendered. I don't require per pixel updating -- any buffering scheme that updates the screen "every once in a while" is fine by me. Below is what I have now, and it sucks royally: DRAW-PIXEL* calls take ~8 seconds on a 400*600 region, and everything else takes < 1 second... (on CLX backend.) (defun render-scene (scene medium) (let* ((pixmap nil) (region (sheet-region medium)) (width (bounding-rectangle-width region)) (height (bounding-rectangle-height region)) (end (- width 1))) (unwind-protect (progn (setf pixmap (allocate-pixmap medium width height)) (raylisp::render scene (raylisp::scene-default-camera scene) width height (lambda (color x y) (declare (type (simple-array single-float (3)) color) (type fixnum x y)) (progn (draw-point* pixmap x y :ink (make-rgb-color (aref color 0) (aref color 1) (aref color 2))) (when (= x end) (copy-from-pixmap pixmap 0 y width 1 medium 0 y)))) :normalize-camera t)) (when pixmap (deallocate-pixmap pixmap))))) What I would like (and what the above tries to do, but fails) is to get hold of a some sort of object onto which I can efficiently blast colors pixel by pixel, and then update the screen using a convenient-for-me interval. Cheers, -- Nikodemus

1 0

[mcclim-devel] [PATCH] fix undefined-variable warnings in commands.lisp
by Nikodemus Siivola 22 Jan '08

22 Jan '08

...for once, these are mostly really undefined variables, left over from some refactoring or another... --- commands.lisp | 16 ++++++++-------- frames.lisp | 7 ++++--- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/commands.lisp b/commands.lisp index 66db758..5d163a9 100644 --- a/commands.lisp +++ b/commands.lisp @@ -332,7 +332,7 @@ (command-name-from-symbol command-name)) (errorp (error 'command-not-accessible :command-table-name - (command-table-designator-as-name table))) + (command-table-designator-as-name command-table))) (t nil))) (defun find-menu-item (menu-name command-table &key (errorp t)) @@ -436,7 +436,7 @@ (in-table (position gesture keystroke-accelerators :test #'equal))) (when (and in-table errorp) (error 'command-already-present :command-table-name - (command-table-designator-as-name table))) + (command-table-designator-as-name command-table))) (if in-table (setf (nth in-table keystroke-items) item) (progn @@ -474,7 +474,7 @@ (setf (cdr items-tail) (cddr items-tail)))) (when errorp (error 'command-not-present :command-table-name - (command-table-designator-as-name table))))))) + (command-table-designator-as-name command-table))))))) nil) (defun map-over-command-table-keystrokes (function command-table) @@ -499,7 +499,7 @@ do (return-from find-keystroke-item (values item command-table))) (if errorp (error 'command-not-present :command-table-name - (command-table-designator-as-name table)) + (command-table-designator-as-name command-table)) nil))) (defun lookup-keystroke-item (gesture command-table @@ -522,11 +522,11 @@ (values sub-item sub-command-table)))))) command-table)))) -(defun partial-command-from-name (command-name) +(defun partial-command-from-name (command-name command-table) (let ((parser (gethash command-name *command-parser-table*))) (if (null parser) (error 'command-not-present :command-table-name - (command-table-designator-as-name table)) + (command-table-designator-as-name command-table)) (cons command-name (mapcar #'(lambda (foo) (declare (ignore foo)) @@ -549,7 +549,7 @@ (if item (let* ((value (command-menu-item-value item)) (command (case (command-menu-item-type item) - (:command + (:command value) (:function (funcall value gesture numeric-arg)) @@ -558,7 +558,7 @@ (if command ; Return a literal command, or create a partial command from a command-name (substitute-numeric-argument-marker (if (symbolp command) - (partial-command-from-name command) + (partial-command-from-name command command-table) command) numeric-arg) gesture)) diff --git a/frames.lisp b/frames.lisp index 92376d3..ce7a551 100644 --- a/frames.lisp +++ b/frames.lisp @@ -521,13 +521,14 @@ documentation produced by presentations.") (object) (call-next-method) (menu-item - (let ((command (command-menu-item-value object))) + (let ((command (command-menu-item-value object)) + (table (frame-command-table frame))) (unless (listp command) - (setq command (partial-command-from-name command))) + (setq command (partial-command-from-name command table))) (if (and (typep stream 'interactor-pane) (partial-command-p command)) (command-line-read-remaining-arguments-for-partial-command - (frame-command-table frame) stream command 0) + table stream command 0) command))))) (defmethod read-frame-command ((frame application-frame) -- 1.5.3.1-dirty

2 1

[mcclim-devel] [PATCH] one more undefined variable
by Nikodemus Siivola 21 Jan '08

21 Jan '08

* Looks like a simple typo. --- recording.lisp | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/recording.lisp b/recording.lisp index b113b1c..8bb234a 100644 --- a/recording.lisp +++ b/recording.lisp @@ -1730,7 +1730,7 @@ were added." (:bottom (incf top (- point-y descent)) (incf bottom (- point-y descent))) (:center (incf top (+ point-y (ceiling (- ascent descent) 2))) - (incf bottom (+ point-xy (ceiling (- ascent descent) 2))))) + (incf bottom (+ point-y (ceiling (- ascent descent) 2))))) (values left top right bottom)))) (defmethod* (setf output-record-position) :around -- 1.5.3.1-dirty

1 0

[mcclim-devel] display glitch in interactor / accept
by Nikodemus Siivola 20 Jan '08

20 Jan '08

The glitch is visible in the screenshot: http://random-state.net/tmp/display-glitch-in-accept.png (see the vertical bar before xyz.) To reproduce, load the following code, and type "Test<enter>xyz" in the interactor. This is using Christophe's CLX from darcs, and CVS McCLIM, on: Darwin manic.local 8.11.1 Darwin Kernel Version 8.11.1: Wed Oct 10 18:23:28 PDT 2007; root:xnu-792.25.20~1/RELEASE_I386 i386 i386 and SBCL 1.0.13.45. Cheers, -- Nikodemus (require :mcclim) (defpackage "TEST-GUI" (:use "CLIM-LISP" "CLIM")) (in-package "TEST-GUI") (define-application-frame test-frame () () (:panes (canvas :application :display-time nil :height 400 :width 600) (repl :interactor)) (:layouts (default (vertically (:width 600 :height 600) canvas (:fill repl))))) (defmethod frame-standard-output ((frame test-frame)) (find-pane-named frame 'repl)) (define-test-frame-command (com-test :name t) () (let ((name (accept 'string :prompt "Foo"))) (format t "Foo ~A!" name))) (run-frame-top-level (make-application-frame 'test-frame))Te

2 1

[mcclim-devel] [patch] two defvars
by Nikodemus Siivola 20 Jan '08

20 Jan '08

Backends/CLX/port.lisp uses *FONTSET* and *CLX-PORT* before the corresponding defvars -- well, there is no defvar at all for the latter. The attached patch addresses this, eliminating the WARNINGs this may cause. Cheers, -- Nikodemus

1 0

[mcclim-devel] Re: [mcclim-cvs] CVS mcclim
by Andy Hefner 15 Jan '08

15 Jan '08

On Jan 15, 2008 10:45 AM, crhodes <crhodes(a)common-lisp.net> wrote: > Update of /project/mcclim/cvsroot/mcclim > In directory clnet:/tmp/cvs-serv8335 > > Modified Files: > regions.lisp > Log Message: > Frob standard-ellipse and standard-elliptical-arc superclasses > > (Otherwise, methods on clim:design are more specific than methods on > climi::elliptical-thing, which means that everything goes haywire.) Interesting. I guess this is what that comment from Gilbert, which I deleted, was about.

1 0

[mcclim-devel] status of mcclim
by Jan Brosius 13 Jan '08

13 Jan '08

Hi, I would like to use mcclim for making applications (exercises in Common Lisp) with sbcl. I looked around on the website. But some things are still not clear to me. So I have some questions about mcclim's status. Is mcclim built entirely on top of CLX? Is there a gtk backend for clx (other than motif)? Is mcclim in alpha stage? Thanks for any clarification Jan Brosius

6 7

Re: [mcclim-devel] IN-PACKAGE not defined in CLIM package
by Troels Henriksen 11 Jan '08

11 Jan '08

Andreas Davour <ante(a)Update.UU.SE> writes: > Since it USE's COMMON-LISP and it's the package SBCL puts me in with > the REPL I kind of figured it was the most appropriate choice to use > in my own packages. I wonder if it used to work in some other > implementation. CL-USER is a package that USEs COMMON-LISP, not a package that exports the symbols of COMMON-LISP. I don't think CL demands that CL-USER doesn't export any symbols, so it's possible some implementations decide to make it export interesting things. > BTW, this would be a good thing to note in a tutorial or best > prectices for package management, if someone is about to write > one... Here's another good thing to know, in case you want to write CLIM applications: don't USE the COMMON-LISP package, USE the CLIM-LISP package instead. You still have to USE the CLIM package and anything else you're interested in. -- \ Troels /\ Henriksen

1 0

Re: [mcclim-devel] IN-PACKAGE not defined in CLIM package
by Troels Henriksen 11 Jan '08

11 Jan '08

Andreas Davour <ante(a)Update.UU.SE> writes: > I have also noted when I create packaged that :USE "CL-USER" I seem to > loosem, while :USE "COMMON-LISP" works fine. I'm not sure I understand > why, and if that's how it always worked. Anyway, CLIM works fine > again. That's because CL-USER doesn't export many symbols, if any at all. -- \ Troels /\ Henriksen

1 0

[mcclim-devel] Image-reading in McCLIM
by Troels Henriksen 05 Jan '08

05 Jan '08

Currently, there is no obvious way to read images from a file and display them on a pane in McCLIM. If you know the secret rites, you can use CLIM-INTERNALS::XPM-PARSE-FILE, but: 1) It is limited to XPM files. 2) It is internal and looks scary. To rectify this, I think we should bundle some simple library with McCLIM for converting image files to CLIM patterns, just like CLIM-INTERNALS::XPM-PARSE-FILE does. (I see something called rgb-image.lisp in mcclim/Extensions, what is it used for?) It would not be loaded by default, but applications could depend on a MCCLIM-IMAGES ASDF system that would define a package, load some simple scaffolding code and export a symbol, LOAD-IMAGE, from its package. The MCCLIM-IMAGES system would not actually support any image formats, and thus not have any dependencies, and applications with specific needs could thus depend on systems like MCCLIM-IMAGES-XPM, MCCLIM-IMAGES-GIF, etc., all of which depend on MCCLIM-IMAGES and whatever libraries necessary to read the specific image file format. These format-support-systems would define a method on LOAD-IMAGE for the specific image format(s) handled by them. This way, an application that needs to read JPEG files would not have to drag in a library for reading, say, GIF files, and at the same time, the same well-defined function interface would be used for all image reading. Since image formats are different, and may have unique options for controlling exactly how they are loaded, the LOAD-IMAGE function would probably take an unspecified set of keywords, permitting each image format to define their own keywords semantics. Writing such a library would probably be extremely simple, if we are willing to use external libraries for most of the actual image reading. For example, here is how to turn the first image of a GIF file into a CLIM pattern using the Skippy library: (defun gif-to-pattern (pathname) (let* ((data-stream (skippy:load-data-stream pathname)) (first-image (aref (skippy:images data-stream) 0)) (pattern-array (make-array (list (skippy:height first-image) (skippy:width first-image)))) (designs (coerce (loop with color-table = (skippy:color-table data-stream) for i below 255 collecting (multiple-value-bind (r g b) (skippy:color-rgb (skippy:color-table-entry color-table i)) (make-rgb-color (/ r 255) (/ g 255) (/ b 255)))) 'vector))) (dotimes (y (skippy:height first-image)) (dotimes (x (skippy:width first-image)) (setf (aref pattern-array y x) (skippy:pixel-ref first-image x y)))) (make-pattern pattern-array designs))) -- \ Troels /\ Henriksen

3 4