mcclim-devel

mcclim-devel@common-lisp.net

820 discussions

[mcclim-devel] patch for graph-formatting.lisp
by rpgoldman＠real-time.com 13 May '05

13 May '05

I believe that there is a bug in graph-formatting.lisp where a graph, if it gets > 10 deep, will cause adjust-array to be called to create new array entries initialized to nil instead of to zero, meaning that comparisons cause a crash. Here's a patch. Will someone familiar with this code please vet it and apply it if appropriate? Thanks, Robert Index: graph-formatting.lisp =================================================================== RCS file: /project/mcclim/cvsroot/mcclim/graph-formatting.lisp,v retrieving revision 1.14 diff -u -F^(def -r1.14 graph-formatting.lisp --- graph-formatting.lisp 23 Apr 2005 20:02:01 -0000 1.14 +++ graph-formatting.lisp 13 May 2005 02:33:33 -0000 @@ -312,7 +312,7 @@ (defmethod layout-graph-nodes ((graph-ou (walk (node depth) (unless (graph-node-minor-size node) (when (>= depth (length generation-sizes)) - (setf generation-sizes (adjust-array generation-sizes (ceiling (* depth 1.2))))) + (setf generation-sizes (adjust-array generation-sizes (ceiling (* depth 1.2) :initial-element 0)))) (setf (aref generation-sizes depth) (max (aref generation-sizes depth) (node-major-dimension node))) (setf (graph-node-minor-size node) 0)

1 0

[mcclim-devel] question about layout-graph-nodes
by rpgoldman＠real-time.com 13 May '05

13 May '05

I managed to persuade format-graph-from-roots to crash, and it did so inside the WALK local function in layout-graph-nodes. Alas, this isn't too easy to debug, even with my beloved Allegro, because of all of the closures.... But I was wondering about the following piece of layout-graph-nodes. Perhaps I'm missing something, but there seems to be a call to MAX whose return is never harvested. (labels (... (walk (node depth) (unless (graph-node-minor-size node) (when (>= depth (length generation-sizes)) (setf generation-sizes (adjust-array generation-sizes (ceiling (* depth 1.2))))) (setf (aref generation-sizes depth) (max (aref generation-sizes depth) (node-major-dimension node))) (setf (graph-node-minor-size node) 0) ** (max (node-minor-dimension node) (setf (graph-node-minor-size node) (let ((sum 0) (n 0)) (map nil (lambda (child) (let ((x (walk child (+ depth 1)))) (when x (incf sum x) (incf n)))) (graph-node-children node)) (+ sum (* (max 0 (- n 1)) within-generation-separation)))))))) (map nil #'(lambda (x) (walk x 0)) root-nodes) ...) I confess that I am not a big user of MAP, nor do I fully grok what's going on here, but it seems like the MAX on the starred line does not serve any purpose. That suggests to me that the code mgiht be garbled somehow.... Any suggestions? For reference, I attach the full defmethod at the end of the message. BTW, the error occurring somehwere in here is a 'NIL' is not of expected type REAL error, which suggests to me that one of the comparisons has gone bad... I think it's because at generation 10, the array gets resized, and the initial value is NIL instead of 0... Thanks, R (defmethod layout-graph-nodes ((graph-output-record tree-graph-output-record) stream arc-drawer arc-drawing-options) ;; work in progress! --GB 2002-08-14 (declare (ignore arc-drawer arc-drawing-options)) (with-slots (orientation center-nodes generation-separation within-generation-separation root-nodes) graph-output-record (check-type orientation (member :horizontal :vertical)) ;xxx move to init.-inst. ;; here major dimension is the dimension in which we grow the ;; tree. (let ((within-generation-separation (parse-space stream within-generation-separation (case orientation (:horizontal :vertical) (:vertical :horizontal)))) (generation-separation (parse-space stream generation-separation orientation))) (let ((generation-sizes (make-array 10 :adjustable t :initial-element 0))) (labels ((node-major-dimension (node) (if (eq orientation :vertical) (bounding-rectangle-height node) (bounding-rectangle-width node))) (node-minor-dimension (node) (if (eq orientation :vertical) (bounding-rectangle-width node) (bounding-rectangle-height node))) (walk (node depth) (unless (graph-node-minor-size node) (when (>= depth (length generation-sizes)) (setf generation-sizes (adjust-array generation-sizes (ceiling (* depth 1.2))))) (setf (aref generation-sizes depth) (max (aref generation-sizes depth) (node-major-dimension node))) (setf (graph-node-minor-size node) 0) (max (node-minor-dimension node) (setf (graph-node-minor-size node) (let ((sum 0) (n 0)) (map nil (lambda (child) (let ((x (walk child (+ depth 1)))) (when x (incf sum x) (incf n)))) (graph-node-children node)) (+ sum (* (max 0 (- n 1)) within-generation-separation)))))))) (map nil #'(lambda (x) (walk x 0)) root-nodes) (let ((hash (make-hash-table :test #'eq))) (labels ((foo (node majors u0 v0) (cond ((gethash node hash) v0) (t (setf (gethash node hash) t) (let ((d (- (node-minor-dimension node) (graph-node-minor-size node)))) (let ((v (+ v0 (/ (min 0 d) -2)))) (setf (output-record-position node) (if (eq orientation :vertical) (transform-position (medium-transformation stream) v u0) (transform-position (medium-transformation stream) u0 v))) (add-output-record node graph-output-record)) ;; (let ((u (+ u0 (car majors))) (v (+ v0 (max 0 (/ d 2)))) (firstp t)) (map nil (lambda (q) (unless (gethash q hash) (if firstp (setf firstp nil) (incf v within-generation-separation)) (setf v (foo q (cdr majors) u v)))) (graph-node-children node))) ;; (+ v0 (max (node-minor-dimension node) (graph-node-minor-size node)))))))) ;; (let ((majors (mapcar (lambda (x) (+ x generation-separation)) (coerce generation-sizes 'list)))) (let ((u (+ 0 (car majors))) (v 0)) (maplist (lambda (rest) (setf v (foo (car rest) majors u v)) (unless (null rest) (incf v within-generation-separation))) (graph-root-nodes graph-output-record)))))))))))

1 0

Re: [mcclim-devel] question about CLIM spec
by C Y 11 May '05

11 May '05

Should we at least keep a backup in case something unforseen happens to his machine? CY --- Robert Strandh <strandh(a)labri.fr> wrote: > C Y writes: > > > > Wasn't the plan to move the annotated spec to common-lisp.net? Or > did > > I miss an update on that? > > I discussed that with Gilbert a few days ago, and now it seems that > he > prefers keeping it on his home machine. > > -- > Robert Strandh > > --------------------------------------------------------------------- > Greenspun's Tenth Rule of Programming: any sufficiently complicated C > or Fortran program contains an ad hoc informally-specified bug-ridden > slow implementation of half of Common Lisp. > --------------------------------------------------------------------- > Yahoo! Mail Stay connected, organized, and protected. Take the tour: http://tour.mail.yahoo.com/mailtour.html

2 1

Re: [mcclim-devel] question about CLIM spec
by C Y 11 May '05

11 May '05

Wasn't the plan to move the annotated spec to common-lisp.net? Or did I miss an update on that? CY --- "Robert P. Goldman" <rpgoldman(a)sift.info> wrote: > >>>>> "RS" == Robert Strandh <strandh(a)labri.fr> writes: > > RS> rpgoldman(a)real-time.com writes: > >> > >> Question: have I misread the specification, or is this a > deficiency > >> in it? > > RS> The latter is very likely. You can do us a favor and go to > the > RS> annotatable spec at > > RS> http://bauhh.dyndns.org:8000/clim-spec/index.html > > RS> and enter your comments at the appropriate place. > > OK, I had a preliminary whack at it. I hope the comments are useful. > I am hardly an expert on this subject! > > R > _______________________________________________ > mcclim-devel mailing list > mcclim-devel(a)common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/mcclim-devel > Yahoo! Mail Stay connected, organized, and protected. Take the tour: http://tour.mail.yahoo.com/mailtour.html

2 1

[mcclim-devel] question about CLIM spec
by rpgoldman＠real-time.com 11 May '05

11 May '05

I was looking over Christophe's dendrogram sample code, and was surprised to find the following in the comments: "...this one is technically non-conforming, in that FORMAT-GRAPH-FROM-ROOTS isn't specified as &KEY &ALLOW-OTHER-KEYS" I went back to the spec and yes, AFAICT, the format-graph-from-roots function is specified as NOT being extendible with new keyword arguments. With all due respect, this seems kooky, since FORMAT-GRAPH-FROM-ROOTS' interface seems poorly structured to do much of anything beyond trees or graphs that are essentially tree-like. The interface seems poor if you want to have edges of different flavors, if you want to control the assignment of depths, etc. Now, of course, you can do a pretty arbitrary amount of customization by developing new graph-output-records. BUT... the spec as written (to the best of my understanding) doesn't provide any way to customize these new output record classes with initargs. Not only doesn't format-graph-from-roots as specified allow for extending its argument set, it also doesn't specify (again, as far as I can tell), how to pass initargs to the new class. The McCLIM implementation takes what seems to me to be a very sensible approach of passing extra keyword arguments from format-graph-from-roots into the make-instance for the GRAPH-OUTPUT-RECORD, but this is an extension to the specification. Question: have I misread the specification, or is this a deficiency in it? Cheers, Robert

4 4

[mcclim-devel] possible buglet in highlighting shapes
by rpgoldman＠real-time.com 10 May '05

10 May '05

I have built a grapher-based tool, that allows me to distinguish between multiple types of node by using shapes. When I highlight rectangular nodes, all is well. But I have "roundtangle" nodes, and when I pass the mouse over them, instead of seeing a box around them, or a highlight outline around the roundtangle, McCLIM gives me THREE rectangles, one around the body of the node, and one each around the semi-circles on the end. Actually, even the rectangle highlighting seems to me a little odd, since the highlight outline is drawn INSIDE the node, instead of around its outline. Here's the code that draws the nodes: (defun draw-taems-node (object stream) (declare (special normal-ink text-style)) (with-drawing-options (stream :ink normal-ink :text-style text-style) (with-output-as-presentation (stream object 'taems-node) (if (typep object 'taems:tmethod) (surrounding-output-with-border (stream :shape :rectangle) (format stream "~D: ~A" (musliner:name object) (taems:taems-name object))) (surrounding-output-with-border (stream :shape :oval) (format stream "~D: ~A" (musliner:name object) (taems:taems-name object))))))) Alas, I am too stupid to figure out how to grab a screendump from X to illustrate this; any suggestions? I wasn't sure how to get xwd to wait until I had a node highlighted before writing its output.... Thanks, R

12 38

[mcclim-devel] new graph type: first drawf
by rpgoldman＠real-time.com 07 May '05

07 May '05

I have developed a tentative first version of a new graph type, which is a tree with cross-edges. I.e., you have a graph which is basically a tree, but where you are allowed to have cross edges. The cross edges are NOT the same as graph edges, and in particular, don't cause additions to the PARENT/CHILD relationships, nor (for this reason) do they cause depths to be incremented. Note that these cross-edges do NOT have to be only one one level of the tree --- they can cross levels. To build such a graph you need to add two more arguments to format-graph-from-roots: :CROSS-ARC-DRAWER a function that takes all the arguments accepted by a normal arc-drawer, but also an edge-type keyword argument, which it is free to ignore. :CROSS-ARC-PRODUCER a function that takes a graph-node as argument, like inferior-producer, but that returns two values: a list of destination nodes and (optionally) a list of type-designators, that can be passed to the cross-arc-drawer, as the value of the :edge-type keyword argument. I have posted the source for this to the following URL, hoping that it will attract comments and suggestions: http://rpgoldman.real-time.com/lisp/tree-with-cross-edges.lisp I'd love to see this integrated into McCLIM some day! KNOWN BUGS: 1. Currently only works on :horizontal orientation (I don't have the arc routing for vertical yet). 2. Only draws straight lines for cross edges. It would be nice if the cross edges would swoop around intervening nodes, but I haven't read enough of the CLIM spec to figure out how to do this yet. 3. If you have a depth-bounded tree, probably something very ugly will happen! I'll try to assemble some screendumps and post them, but for now it's weekend... Best, R

1 0

[mcclim-devel] Problems in reading with :timeout
by Tomi K Neste 06 May '05

06 May '05

Oops.. accidently sent this to rpgoldman only :-| Just tried on SBCL with recent McCLIM and :timeout 0 works fine >0 values still seem to be blocking forever. Looks like clim-internals:stream-input-wait keeps continuously calling clim-internals:event-queue-listen-or-wait with wrong TIMEOUT. Or maybe not, it's all (still) bit over my head The :timeout 0 => NIL still seems to a problem on CMUCL, but that's on a few months old version of McCLIM, so maybe it's fixed and irrelevant by now anyway. I really should update my CMUCL stuff on that laptop... I'm trying to figure out how to do some simple animation, like a clock or process browser that should keep on updating every few seconds. So I thought the way to go would be specializing the READ-COMMAND or READ-FRAME-COMMAND and use the :timeout where approriate. I also thought about using different thread for the pane updating, but I'm not sure if that would be a smart thing to do. So I'm wondering if there's a canonical way to accomplish something like that, some sources perhaps? BTW, big thanks to all McCLIM developers, fascinating stuff :-)

2 2

Re: [mcclim-devel] resizeable panes
by Andy Hefner 04 May '05

04 May '05

Off the top of my head, something like this within your layout should world: (vertically () top-pane (make-pane 'clim-extensions:box-adjuster-gadget) bottom-pane) The idea is that you insert it a layout between the panes you want it to resize. This should work fine for a horizontal layout also, the box-adjuster-gadget takes its orientation from its parent. On 5/1/05, rpgoldman(a)real-time.com <rpgoldman(a)real-time.com> wrote: > Is there an example of the use of the box-adjuster-gadget anywhere? > Sorry to be lame. I couldn't find one anywhere in the stuff that > comes with McCLIM (or I did something wrong with find...). > > Thanks, > R >

1 0

[mcclim-devel] Problems in reading with :timeout
by Tomi K Neste 04 May '05

04 May '05

I'm having some newb confusion about the timeout value in stream input functions, (read-gesture ...) etc. (read-gesture :timeout 0) always just returns NIL, while timeout values >0 don't seem to have any effect at all. For example, in the Listener (read-gesture :timeout 1) keeps blocking until some gesture is given. Another source of confusion is the :input-wait-handler. From reading the spec I got the idea that it should be called "continously" when there isn't any input in the given stream, but it looks like the function is never executed. Are these real problems or am I just missing something obvious?

4 3

← Newer
1
...
65
66
67
68
69
70
71
...
82
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

mcclim-devel