[mcclim-devel] (setf bounding-rectangle-min-x)
In draw.lisp in scigraph, there are calls to (setf bounding-rectangle-min-x) and friends. These don't seem to exist in mcclim, but there is (setf rectangle-edges*) which seems to be doing essentially the same thing. Here is a little patch that implements that. Not sure it's really right, though. Ray Index: draw.lisp =================================================================== RCS file: /project/mcclim/cvsroot/mcclim/Apps/Scigraph/scigraph/draw.lisp,v retrieving revision 1.3 diff -u -r1.3 draw.lisp --- draw.lisp 17 Mar 2006 07:12:52 -0000 1.3 +++ draw.lisp 16 Dec 2006 14:58:36 -0000 @@ -134,13 +134,19 @@ (slot-value .x. 'clim-utils::max-y) be) (with-drawing-options (,stream :clipping-region .x.) ,@body))) - (:clim-2 + ((and :clim-2 (not :mcclim)) (let ((.x. *clim-clip-rectangle*)) (setf (bounding-rectangle-min-x .x.) le (bounding-rectangle-min-y .x.) te (bounding-rectangle-max-x .x.) re (bounding-rectangle-max-y .x.) be) (with-drawing-options (,stream :clipping-region .x.) + ,@body))) + ((and :clim-2 :mcclim) + (let ((.x. *clim-clip-rectangle*)) + (setf (rectangle-edges* .x.) + (values le te re be)) + (with-drawing-options (,stream :clipping-region .x.) ,@body)))))) (eval-when (compile load eval)
Raymond Toy <toy.raymond@gmail.com> writes:
In draw.lisp in scigraph, there are calls to (setf bounding-rectangle-min-x) and friends. These don't seem to exist in mcclim, but there is (setf rectangle-edges*) which seems to be doing essentially the same thing.
These functions should exist according to the CLIM 2.2 spec (page 52). Since you already figured out an equivalent fix for Scigraph, couldn't you write some definitions for `bounding-rectangle-{min|max}-{x|y}'? That would probably be better in the long run. -- \ Troels "Athas" /\ Henriksen
Troels Henriksen wrote:
Raymond Toy <toy.raymond@gmail.com> writes:
In draw.lisp in scigraph, there are calls to (setf bounding-rectangle-min-x) and friends. These don't seem to exist in mcclim, but there is (setf rectangle-edges*) which seems to be doing essentially the same thing.
These functions should exist according to the CLIM 2.2 spec (page 52). Since you already figured out an equivalent fix for Scigraph, couldn't you write some definitions for `bounding-rectangle-{min|max}-{x|y}'? That would probably be better in the long run.
Oh. I must have been looking at the clim 2.0 spec which didn't seem to have the setf versions of these. I'll try and implement them. Ray
Raymond Toy <toy.raymond@gmail.com> writes:
Oh. I must have been looking at the clim 2.0 spec which didn't seem to have the setf versions of these. I'll try and implement them.
Oh, I just see that the CLIM 2.2 spec doesn't explicitly state the existence of the `setf' functions, but the actual implementation seems to have them. Su ein Ding muss ich auch haben! Also, it would be swell if the synonyms `bounding-rectangle-top', `bounding-rectangle-bottom', `bounding-rectangle-left' and `bounding-rectangle-right' (and their `setf' variants) were also implemented. -- \ Troels "Athas" /\ Henriksen
participants (2)
-
Raymond Toy -
Troels Henriksen