Hello,
I found a bug into "mc->alpha" method, doing an infinite loop : this method has to call not itself, but "mc->alpha1" function.
And the method "midicents-to-name" is ok when replacing "MORPH2" by "MORPH" at the very end of the expression (last line).
These two minor corrections have to be updated in next release of the source code (kilian?)
Also, I'm not sure the symbols we use for naming the notes are all clearly understable or rational (CN, CS-, CS--, ...) : should we find a better representation with other more common/understandable symbols ? I'm going to simplify the mess of numtochar functions : I have found ie ten different functions or methods to do quite the same job... it should be unified.
fred
Hi,
sorry I am late ....
I found a bug into "mc->alpha" method, doing an infinite loop : this method has to call not itself, but "mc->alpha1" function.
And the method "midicents-to-name" is ok when replacing "MORPH2" by "MORPH" at the very end of the expression (last line).
I fixed exactly those two things, its in revision 24.
Also, I'm not sure the symbols we use for naming the notes are all clearly understable or rational (CN, CS-, CS--, ...) : should we find a better representation with other more common/understandable symbols ? I'm going to simplify the mess of numtochar functions : I have found ie ten different functions or methods to do quite the same job... it should be unified.
At a first glance, I like the symbols. :) But I will look at them more closey. Just by playing around, I think I have found a small problem:
(morph:mc->alpha 6300 2) gives me "ES4"
(I liked the idea of using the german system !!)
But then trying (morph:mc->alpha 7000 2) I got "BF4" - and I think that's good.
So probably the above is a bug... I will have a look now and write again, if I find and change anything....
Best, Kilian
Hi again,
(morph:mc->alpha 6300 2) gives me "ES4"
there was a small typo - I changed ES to DS:
--- src/morphologie.lisp (revision 24) +++ src/morphologie.lisp (working copy) @@ -601,7 +601,7 @@ "~D~D" (nth note-number '("C" "CN+" "CS--" "CS-" "CS" "CS+" "CS++" "DN-" "D" - "DN+" "DS--" "DS-" "ES" "DS+" "DS++" "EN-" "E" "EN+" + "DN+" "DS--" "DS-" "DS" "DS+" "DS++" "EN-" "E" "EN+" "ES--" "ES-" "F" "FN+" "FS--" "FS-" "FS" "FS+" "FS++" "GN-" "G" "GN+" "GS--" "GS-" "GS" "GS+" "GS++" "AN-" "A" "AN+" "AS--" "AS-" "BF" "AS+" "AS++" "BN-" "B"
Cheers, Kilian
morphologie-devel@common-lisp.net