- net-nittin-irc-cvs@lists.common-lisp.net

[net-nittin-irc-cvs] CVS update: public_html/index.html
by Erik Enge 01 Dec '03

01 Dec '03

Update of /project/net-nittin-irc/cvsroot/public_html In directory common-lisp.net:/tmp/cvs-serv10419 Modified Files: index.html Log Message: s/setf/defvar Date: Mon Dec 1 09:49:34 2003 Author: eenge Index: public_html/index.html diff -u public_html/index.html:1.8 public_html/index.html:1.9 --- public_html/index.html:1.8 Wed Nov 26 07:38:23 2003 +++ public_html/index.html Mon Dec 1 09:49:34 2003 @@ -75,8 +75,8 @@ * (in-package :irc) - * (setf connection (connect :nickname "mynick" - :server "irc.somewhere.org")) + * (defvar connection (connect :nickname "mynick" + :server "irc.somewhere.org")) * (read-message-loop connection)

1 0

[net-nittin-irc-cvs] CVS update: public_html/index.html
by Erik Enge 26 Nov '03

26 Nov '03

Update of /project/net-nittin-irc/cvsroot/public_html In directory common-lisp.net:/tmp/cvs-serv24655 Modified Files: index.html Log Message: releasing version 0.4.0 Date: Wed Nov 26 07:38:29 2003 Author: eenge Index: public_html/index.html diff -u public_html/index.html:1.7 public_html/index.html:1.8 --- public_html/index.html:1.7 Wed Nov 12 14:31:59 2003 +++ public_html/index.html Wed Nov 26 07:38:23 2003 @@ -5,7 +5,7 @@ <body> <div class="header"> - <h1>net-nittin-irc 0.3.0</h1> + <h1>net-nittin-irc 0.4.0</h1> </div> <div class="body"> @@ -24,6 +24,11 @@ groundwork for this library with his <a href="http://www.sf.net/projects/weird-irc">Weird-IRC</a> IRC client and that therefore some of the code is copyright him.</p> + + <h2>News</h2> + <div class="level"> + <li>Version 0.4.0 released (some documentation, beginnings of a test suite, better performance)</li> + </div> <h2>Features</h2> <div class="level">

1 0

[net-nittin-irc-cvs] CVS update: net-nittin-irc/TODO
by Erik Enge 26 Nov '03

26 Nov '03

Update of /project/net-nittin-irc/cvsroot/net-nittin-irc In directory common-lisp.net:/tmp/cvs-serv3539 Modified Files: TODO Log Message: adding note about WHOISCHANNEL Date: Tue Nov 25 19:51:37 2003 Author: eenge Index: net-nittin-irc/TODO diff -u net-nittin-irc/TODO:1.11 net-nittin-irc/TODO:1.12 --- net-nittin-irc/TODO:1.11 Mon Nov 24 17:12:20 2003 +++ net-nittin-irc/TODO Tue Nov 25 19:51:37 2003 @@ -16,3 +16,6 @@ - Document inconsistencies between IRC servers (ref. undernet servers send out channel name in arguments rather than trailing-messages on a part/quit message) + + - When doing a whois on a user the library ought to snap up the + channels in WHOISCHANNELS as channels the user is currently on.

1 0

[net-nittin-irc-cvs] CVS update: net-nittin-irc/test/test-protocol.lisp net-nittin-irc/test/net-nittin-irc-test.asd
by Erik Enge 25 Nov '03

25 Nov '03

Update of /project/net-nittin-irc/cvsroot/net-nittin-irc/test In directory common-lisp.net:/tmp/cvs-serv29837/test Modified Files: net-nittin-irc-test.asd Added Files: test-protocol.lisp Log Message: fixing bug in change-nickname and adding tests to catch any future problems with that function Date: Tue Nov 25 08:15:41 2003 Author: eenge Index: net-nittin-irc/test/net-nittin-irc-test.asd diff -u net-nittin-irc/test/net-nittin-irc-test.asd:1.1 net-nittin-irc/test/net-nittin-irc-test.asd:1.2 --- net-nittin-irc/test/net-nittin-irc-test.asd:1.1 Sun Nov 23 17:40:23 2003 +++ net-nittin-irc/test/net-nittin-irc-test.asd Tue Nov 25 08:15:41 2003 @@ -1,4 +1,4 @@ -;;;; $Id: net-nittin-irc-test.asd,v 1.1 2003/11/23 22:40:23 eenge Exp $ +;;;; $Id: net-nittin-irc-test.asd,v 1.2 2003/11/25 13:15:41 eenge Exp $ ;;;; $Source: /project/net-nittin-irc/cvsroot/net-nittin-irc/test/net-nittin-irc-test.asd,v $ ;;;; See the LICENSE file for licensing information. @@ -21,4 +21,6 @@ #-sbcl (:split-sequence :rt :net-nittin-irc) :components ((:file "package") (:file "test-parse-message" - :depends-on ("package")))) + :depends-on ("package")) + (:file "test-protocol" + :depends-on ("test-parse-message"))))

1 0

[net-nittin-irc-cvs] CVS update: net-nittin-irc/protocol.lisp
by Erik Enge 25 Nov '03

25 Nov '03

Update of /project/net-nittin-irc/cvsroot/net-nittin-irc In directory common-lisp.net:/tmp/cvs-serv29656 Modified Files: protocol.lisp Log Message: really, really, silly bug in normalize-nickname (returning wrong value) Date: Tue Nov 25 08:14:34 2003 Author: eenge Index: net-nittin-irc/protocol.lisp diff -u net-nittin-irc/protocol.lisp:1.22 net-nittin-irc/protocol.lisp:1.23 --- net-nittin-irc/protocol.lisp:1.22 Tue Nov 25 08:04:33 2003 +++ net-nittin-irc/protocol.lisp Tue Nov 25 08:14:34 2003 @@ -1,4 +1,4 @@ -;;;; $Id: protocol.lisp,v 1.22 2003/11/25 13:04:33 eenge Exp $ +;;;; $Id: protocol.lisp,v 1.23 2003/11/25 13:14:34 eenge Exp $ ;;;; $Source: /project/net-nittin-irc/cvsroot/net-nittin-irc/protocol.lisp,v $ ;;;; See LICENSE for licensing information. @@ -386,7 +386,7 @@ (new-string (substitute #\] #\} new-string)) (new-string (substitute #\\ #\| new-string)) (new-string (substitute #\~ #\^ new-string))) - (string-downcase string))) + (string-downcase new-string))) (defmethod find-user ((connection connection) (nickname string)) "Return user as designated by `nickname' or nil if no such user is

1 0

[net-nittin-irc-cvs] CVS update: net-nittin-irc/event.lisp net-nittin-irc/protocol.lisp
by Erik Enge 25 Nov '03

25 Nov '03

Update of /project/net-nittin-irc/cvsroot/net-nittin-irc In directory common-lisp.net:/tmp/cvs-serv24735 Modified Files: event.lisp protocol.lisp Log Message: I let net-nittin-irc listen to a couple of channels on freenode over the night and it blew up after four hours. change-nickname didn't work the way I thought it would, apparently, but I'm not sure it's still fixed. Date: Tue Nov 25 08:04:33 2003 Author: eenge Index: net-nittin-irc/event.lisp diff -u net-nittin-irc/event.lisp:1.13 net-nittin-irc/event.lisp:1.14 --- net-nittin-irc/event.lisp:1.13 Mon Nov 24 22:56:06 2003 +++ net-nittin-irc/event.lisp Tue Nov 25 08:04:33 2003 @@ -1,4 +1,4 @@ -;;;; $Id: event.lisp,v 1.13 2003/11/25 03:56:06 eenge Exp $ +;;;; $Id: event.lisp,v 1.14 2003/11/25 13:04:33 eenge Exp $ ;;;; $Source: /project/net-nittin-irc/cvsroot/net-nittin-irc/event.lisp,v $ ;;;; See LICENSE for licensing information. @@ -48,7 +48,8 @@ :username (user message) :hostname (host message)))) (unless (equal user (user connection)) - (add-user connection channel user)))))) + (add-user connection user) + (add-user channel user)))))) (defmethod default-hook ((message irc-ping-message)) (pong (connection message) (trailing-argument message))) @@ -64,7 +65,9 @@ (make-channel :name (trailing-argument message))))) (if (self-message-p message) (add-channel connection channel) - (add-user connection channel user)))) + (progn + (add-user connection user) + (add-user channel user))))) (defmethod default-hook ((message irc-topic-message)) (setf (topic (find-channel (connection message) Index: net-nittin-irc/protocol.lisp diff -u net-nittin-irc/protocol.lisp:1.21 net-nittin-irc/protocol.lisp:1.22 --- net-nittin-irc/protocol.lisp:1.21 Mon Nov 24 22:56:06 2003 +++ net-nittin-irc/protocol.lisp Tue Nov 25 08:04:33 2003 @@ -1,4 +1,4 @@ -;;;; $Id: protocol.lisp,v 1.21 2003/11/25 03:56:06 eenge Exp $ +;;;; $Id: protocol.lisp,v 1.22 2003/11/25 13:04:33 eenge Exp $ ;;;; $Source: /project/net-nittin-irc/cvsroot/net-nittin-irc/protocol.lisp,v $ ;;;; See LICENSE for licensing information. @@ -397,12 +397,14 @@ (user connection))))) ; what if the user is not on any channels? -(defmethod add-user ((connection connection) (channel channel) (user user)) - "Add `user' to `channel' and `channel' to `user'." - (setf (gethash (normalized-nickname user) (users channel)) user) - (pushnew channel (channels user)) +(defmethod add-user ((connection connection) (user user)) + "Add `user' to `connection'." (setf (gethash (normalized-nickname user) (users connection)) user)) +(defmethod add-user ((channel channel) (user user)) + (setf (gethash (normalized-nickname user) (users channel)) user) + (pushnew channel (channels user))) + (defmethod remove-all-users ((connection connection)) "Remove all users known to `connection'." (clrhash (users connection))) @@ -443,7 +445,9 @@ (setf (normalized-nickname new-user) (normalize-nickname new-nickname)) (dolist (channel channels) (remove-user channel user) - (add-user connection channel new-user)))) + (add-user channel new-user)) + (add-user connection user) + new-user)) ;; IRC Message ;;

1 0

[net-nittin-irc-cvs] CVS update: net-nittin-irc/event.lisp net-nittin-irc/protocol.lisp
by Erik Enge 25 Nov '03

25 Nov '03

Update of /project/net-nittin-irc/cvsroot/net-nittin-irc In directory common-lisp.net:/tmp/cvs-serv32047 Modified Files: event.lisp protocol.lisp Log Message: change-user didn't properly change nicknames; fixed. Date: Mon Nov 24 22:56:06 2003 Author: eenge Index: net-nittin-irc/event.lisp diff -u net-nittin-irc/event.lisp:1.12 net-nittin-irc/event.lisp:1.13 --- net-nittin-irc/event.lisp:1.12 Mon Nov 24 22:35:55 2003 +++ net-nittin-irc/event.lisp Mon Nov 24 22:56:06 2003 @@ -1,4 +1,4 @@ -;;;; $Id: event.lisp,v 1.12 2003/11/25 03:35:55 eenge Exp $ +;;;; $Id: event.lisp,v 1.13 2003/11/25 03:56:06 eenge Exp $ ;;;; $Source: /project/net-nittin-irc/cvsroot/net-nittin-irc/event.lisp,v $ ;;;; See LICENSE for licensing information. @@ -84,15 +84,9 @@ (remove-user-everywhere connection (find-user connection (source message))))) (defmethod default-hook ((message irc-nick-message)) - (if (self-message-p message) - (change-nickname (connection message) (user (connection message)) - (trailing-argument message)) - (let ((user (find-user (connection message) (source message)))) - (if user - (change-nickname (connection message) user (trailing-argument message)) - (client-raw-log (connection message) - (format nil "Could not find user with nick ~A~%" - (source message))))))) + (let ((con (connection message))) + (change-nickname con (find-user con (source message)) + (trailing-argument message)))) (defmethod default-hook ((message irc-kick-message)) (let* ((connection (connection message)) Index: net-nittin-irc/protocol.lisp diff -u net-nittin-irc/protocol.lisp:1.20 net-nittin-irc/protocol.lisp:1.21 --- net-nittin-irc/protocol.lisp:1.20 Mon Nov 24 22:35:55 2003 +++ net-nittin-irc/protocol.lisp Mon Nov 24 22:56:06 2003 @@ -1,4 +1,4 @@ -;;;; $Id: protocol.lisp,v 1.20 2003/11/25 03:35:55 eenge Exp $ +;;;; $Id: protocol.lisp,v 1.21 2003/11/25 03:56:06 eenge Exp $ ;;;; $Source: /project/net-nittin-irc/cvsroot/net-nittin-irc/protocol.lisp,v $ ;;;; See LICENSE for licensing information. @@ -416,11 +416,16 @@ "Remove `channel' from `user'." (setf (channels user) (remove channel (channels user)))) +(defmethod remove-user ((connection connection) (user user)) + "Remove `user' from `connection' but leave user in any channels he +may be already be on." + (remhash (normalized-nickname user) (users connection))) + (defmethod remove-user-everywhere ((connection connection) (user user)) "Remove `user' anywhere present in the `connection'." (dolist (channel (channels user)) (remove-user channel user)) - (remhash (normalized-nickname user) (users connection))) + (remove-user connection user)) (defmethod find-or-make-user ((connection connection) nickname &key (username "") (hostname "") (realname "")) @@ -431,7 +436,14 @@ :realname realname))) (defmethod change-nickname ((connection connection) (user user) new-nickname) - (setf (nickname user) new-nickname)) + (let ((new-user user) + (channels (channels user))) + (remove-user connection user) + (setf (nickname new-user) new-nickname) + (setf (normalized-nickname new-user) (normalize-nickname new-nickname)) + (dolist (channel channels) + (remove-user channel user) + (add-user connection channel new-user)))) ;; IRC Message ;;

1 0

[net-nittin-irc-cvs] CVS update: net-nittin-irc/event.lisp net-nittin-irc/package.lisp net-nittin-irc/protocol.lisp
by Erik Enge 25 Nov '03

25 Nov '03

Update of /project/net-nittin-irc/cvsroot/net-nittin-irc In directory common-lisp.net:/tmp/cvs-serv23681 Modified Files: event.lisp package.lisp protocol.lisp Log Message: (channels connection) is now a hash-table and the LIST- command is fairly efficient. now normalizing channel-names and cleaned up some other minor things (all-users and all-channels no longer used). Date: Mon Nov 24 22:35:55 2003 Author: eenge Index: net-nittin-irc/event.lisp diff -u net-nittin-irc/event.lisp:1.11 net-nittin-irc/event.lisp:1.12 --- net-nittin-irc/event.lisp:1.11 Mon Nov 24 16:30:11 2003 +++ net-nittin-irc/event.lisp Mon Nov 24 22:35:55 2003 @@ -1,4 +1,4 @@ -;;;; $Id: event.lisp,v 1.11 2003/11/24 21:30:11 eenge Exp $ +;;;; $Id: event.lisp,v 1.12 2003/11/25 03:35:55 eenge Exp $ ;;;; $Source: /project/net-nittin-irc/cvsroot/net-nittin-irc/event.lisp,v $ ;;;; See LICENSE for licensing information. @@ -29,11 +29,10 @@ (channel (second (arguments message))) (user-count (parse-integer (or (third (arguments message)) "0"))) (topic (trailing-argument message))) - (pushnew (or (find-channel connection channel) - (make-channel :name channel - :topic topic - :user-count user-count)) - (channels connection)))) + (add-channel connection (or (find-channel connection channel) + (make-channel :name channel + :topic topic + :user-count user-count))))) (defmethod default-hook ((message irc-rpl_topic-message)) (setf (topic (find-channel (connection message) Index: net-nittin-irc/package.lisp diff -u net-nittin-irc/package.lisp:1.10 net-nittin-irc/package.lisp:1.11 --- net-nittin-irc/package.lisp:1.10 Sun Nov 23 18:06:13 2003 +++ net-nittin-irc/package.lisp Mon Nov 24 22:35:55 2003 @@ -1,10 +1,11 @@ -;;;; $Id: package.lisp,v 1.10 2003/11/23 23:06:13 eenge Exp $ +;;;; $Id: package.lisp,v 1.11 2003/11/25 03:35:55 eenge Exp $ ;;;; $Source: /project/net-nittin-irc/cvsroot/net-nittin-irc/package.lisp,v $ ;;;; See the LICENSE file for licensing information. (in-package :cl-user) +;; the exports list needs some cleanup/clarification/categorization (eval-when (:execute :load-toplevel :compile-toplevel) (defpackage :net-nittin-irc (:use :cl) @@ -16,12 +17,12 @@ :server-name :no-such-reply :parse-raw-message + :normalize-nickname + :normalize-channel-name :server-stream :client-stream :channels :configuration - :all-users - :all-channels :dangling-users :channel-list :add-hook Index: net-nittin-irc/protocol.lisp diff -u net-nittin-irc/protocol.lisp:1.19 net-nittin-irc/protocol.lisp:1.20 --- net-nittin-irc/protocol.lisp:1.19 Mon Nov 24 16:56:49 2003 +++ net-nittin-irc/protocol.lisp Mon Nov 24 22:35:55 2003 @@ -1,4 +1,4 @@ -;;;; $Id: protocol.lisp,v 1.19 2003/11/24 21:56:49 eenge Exp $ +;;;; $Id: protocol.lisp,v 1.20 2003/11/25 03:35:55 eenge Exp $ ;;;; $Source: /project/net-nittin-irc/cvsroot/net-nittin-irc/protocol.lisp,v $ ;;;; See LICENSE for licensing information. @@ -46,7 +46,7 @@ (channels :initarg :channels :accessor channels - :initform nil) + :initform (make-hash-table :test #'equal)) (hooks :initarg :hooks :accessor hooks @@ -252,6 +252,9 @@ ((name :initarg :name :accessor name) + (normalized-name + :initarg :normalized-name + :accessor normalized-name) (topic :initarg :topic :accessor topic) @@ -278,6 +281,11 @@ (print-unreadable-object (object stream :type t :identity t) (princ (name object) stream))) +(defun normalize-channel-name (string) + "Normalize `string' so that it represents an all-downcased channel +name." + (string-downcase string)) + (defun make-channel (&key (name "") (topic "") (modes nil) @@ -286,6 +294,7 @@ (let ((channel (make-instance 'channel :name name + :normalized-name (normalize-channel-name name) :topic topic :modes modes :user-count user-count))) @@ -296,19 +305,20 @@ (defmethod find-channel ((connection connection) (channel string)) "Return channel as designated by `channel'. If no such channel can be found, return nil." - (find channel (channels connection) :key #'name :test #'string-equal)) + (let ((channel-name (normalize-channel-name channel))) + (gethash channel-name (channels connection)))) (defmethod remove-all-channels ((connection connection)) "Remove all channels known to `connection'." - (setf (channels connection) nil)) + (clrhash (channels connection))) (defmethod add-channel ((connection connection) (channel channel)) "Add `channel' to `connection'." - (pushnew channel (channels connection))) + (setf (gethash (normalized-name channel) (channels connection)) channel)) (defmethod remove-channel ((connection connection) (channel channel)) "Remove `channel' from `connection'." - (setf (channels connection) (remove channel (channels connection)))) + (remhash (normalized-name channel) (channels connection))) (defmethod remove-users ((channel channel)) "Remove all users on `channel'." @@ -369,15 +379,15 @@ (subseq nickname 1) nickname)) -;; oh, what a terrible operator name (defun normalize-nickname (string) + "Normalize `string' so that represents an all-downcased IRC +nickname." (let* ((new-string (substitute #\[ #\{ string)) (new-string (substitute #\] #\} new-string)) (new-string (substitute #\\ #\| new-string)) (new-string (substitute #\~ #\^ new-string))) (string-downcase string))) -;; this is broken. we should use #'irc-nick-equal somehow. (defmethod find-user ((connection connection) (nickname string)) "Return user as designated by `nickname' or nil if no such user is known." @@ -395,8 +405,7 @@ (defmethod remove-all-users ((connection connection)) "Remove all users known to `connection'." - (setf (users connection) nil) - (mapc #'remove-users (channels connection))) + (clrhash (users connection))) (defmethod remove-user ((channel channel) (user user)) "Remove `user' from `channel' and `channel' from `user'."

1 0

[net-nittin-irc-cvs] CVS update: net-nittin-irc/parse-message.lisp
by Erik Enge 25 Nov '03

25 Nov '03

Update of /project/net-nittin-irc/cvsroot/net-nittin-irc In directory common-lisp.net:/tmp/cvs-serv13779 Modified Files: parse-message.lisp Log Message: return-arguments now parses arguments-lists of MODE messages properly Date: Mon Nov 24 22:12:01 2003 Author: eenge Index: net-nittin-irc/parse-message.lisp diff -u net-nittin-irc/parse-message.lisp:1.6 net-nittin-irc/parse-message.lisp:1.7 --- net-nittin-irc/parse-message.lisp:1.6 Sun Nov 23 17:39:16 2003 +++ net-nittin-irc/parse-message.lisp Mon Nov 24 22:12:00 2003 @@ -1,4 +1,4 @@ -;;;; $Id: parse-message.lisp,v 1.6 2003/11/23 22:39:16 eenge Exp $ +;;;; $Id: parse-message.lisp,v 1.7 2003/11/25 03:12:00 eenge Exp $ ;;;; $Source: /project/net-nittin-irc/cvsroot/net-nittin-irc/parse-message.lisp,v $ ;;;; See the LICENSE file for licensing information. @@ -50,7 +50,7 @@ arguments part of the message as a list. Returns nil if the arguments part is not present." (multiple-value-bind (end-position return-argument) - (cut-between string nil '(#\:) :start start) + (cut-between string nil '(#\: #\Return) :start start) (values end-position (tokenize-string return-argument :delimiters '(#\Space)))))

1 0

[net-nittin-irc-cvs] CVS update: net-nittin-irc/test/irc-messages.txt
by Erik Enge 25 Nov '03

25 Nov '03

Update of /project/net-nittin-irc/cvsroot/net-nittin-irc/test In directory common-lisp.net:/tmp/cvs-serv13660 Modified Files: irc-messages.txt Log Message: adding more test messages Date: Mon Nov 24 22:11:33 2003 Author: eenge Index: net-nittin-irc/test/irc-messages.txt diff -u net-nittin-irc/test/irc-messages.txt:1.1 net-nittin-irc/test/irc-messages.txt:1.2 --- net-nittin-irc/test/irc-messages.txt:1.1 Fri Nov 7 08:43:53 2003 +++ net-nittin-irc/test/irc-messages.txt Mon Nov 24 22:11:27 2003 @@ -1 +1 @@ -NOTICE AUTH :*** Your forward and reverse DNS don't match :tolkien.freenode.net 376 cl-irc :End of /MOTD command. :tolkien.freenode.net 372 cl-irc :- :leguin.freenode.net 353 cl-irc = #lisppaste :cl-irc kire :cl-irc!~cl-irc@216.248.178.227 JOIN :#lisppaste :kire!~eenge@216.248.178.227 PRIVMSG cl-irc :heyhey! \ No newline at end of file +NOTICE AUTH :*** Your forward and reverse DNS don't match :tolkien.freenode.net 376 cl-irc :End of /MOTD command. :tolkien.freenode.net 372 cl-irc :- :leguin.freenode.net 353 cl-irc = #lisppaste :cl-irc kire :cl-irc!~cl-irc@216.248.178.227 JOIN :#lisppaste :kire!~eenge@216.248.178.227 PRIVMSG cl-irc :heyhey! :kire_!~eenge@adsl-156-35-240.asm.bellsouth.net MODE #lisppaste +b *!*(a)somewhere.com :kire_!~eenge@adsl-156-35-240.asm.bellsouth.net MODE #lisppaste +bbb *!*(a)somewhere.com *!*(a)somewhereles.com *!*(a)youdontwannaknow.org :kire_!~eenge@adsl-156-35-240.asm.bellsouth.net MODE #lisppaste -m :kire_!~eenge@adsl-156-35-240.asm.bellsouth.net MODE #lisppaste +k key \ No newline at end of file

1 0