Re: bug in mmap() and mremap() return value - and a fix

On 01/09/14 02:08, Luís Oliveira wrote:

On Thu, Jan 9, 2014 at 12:15 AM, Massimiliano Ghilardi massimiliano.ghilardi@gmail.com wrote:

...

2. Thinking that (or actually defining) MAP_FAILED = -1 is misleading. MAP_FAILED is (void *)-1.

Your patch looks good. Perhaps we could teach cffi-grovel how to grovel pointers, then we'd be able to ditch the *map-failed-pointer* bits. I've attached an untested patch that does that. Does using (constant ... :type pointer) for the MAP_* constants solve the problem you found?

Cheers,

Hello Luís,

as highlighted by you and Stelian Ionescu, there is room to improve CFFI with regards to pointers and automatic type discovery.

With regard to Osicat: do I need to do something more for the mmap()/mremap() patch (attached) to be accepted and integrated?

Best wishes,

Massimiliano Ghilardi