parenscript-devel May 2010

parenscript-devel@common-lisp.net

3 participants
8 discussions

[parenscript-devel] Patch: added JS label/break to PS
by Daniel Gackle 07 Dec '10

07 Dec '10

I just pushed a patch (authored by Scott) to implement JS's LABEL and BREAK in PS. (Note that this patch deprecates LABELED-FOR since you can get the same effect by combining LABEL and FOR. Was anybody using LABELED-FOR?) Here's an example: (label scope (foo) (when (bar) (break scope)) (blee)) => scope: { foo(); if (bar()) { break scope; }; blee(); }; I was astonished to discover recently that JS has supported this ability all along in the form of labeled statements and labeled breaks. I'd always assumed that to get explicit returns from an arbitrary scope, you'd have to resort to the ugly hack of muscling TRY/CATCH to do it, thinking that this was the closest JS counterpart. (See http://news.ycombinator.com/item?id=793092 for a thread in which several people believe this.) But it appears we were all wrong. What's not clear yet is how far this can be taken. Can you use it inside a nested local function to return immediately from the top-level function? That is one thing I've wanted for a long time. In the ideal case, LABEL/BREAK could be used as a base for implementing a proper BLOCK and RETURN-FROM in PS, something which we'd long believed to be impossible. One challenge is that in CL, RETURN-FROM can take a value, which becomes the value of BLOCK. In other words, BLOCK in CL is an expression while LABEL in JS is not. It seems, though, that most of this challenge has already been conquered with the development of implicit return in PS. The only thing you'd need to add is detecting when BLOCK is being used as an expression, declaring a gensymed variable and assigning whatever is happening inside BLOCK to that variable (much like implicit return already does with e.g. CASE), then put the variable in the expression position that BLOCK was in. It seems like this ought to work. It would also make things like this possible in PS: (1+ (case foo (:eleven 11) (:twelve 12))) Vladimir (and everybody), is the above clear? What do you think of it? Daniel

4 11

[parenscript-devel] PS Tests - another run
by Daniel Gackle 13 Jul '10

13 Jul '10

Yes, somehow some errant ps macros made it into the test run I sent a couple days ago. Here's another. (This is from CCL.) Daniel Running reference tests: ...............f......................................................................... Did 89 checks. Pass: 88 (98%) Skip: 0 ( 0%) Fail: 1 ( 1%) Failure Details: -------------------------------- ASSIGNMENT-11 []: (NORMALIZE-JS-CODE "var _js2 = someDiv; var _js1 = 123 + 'px'; _js2.style.left = _js1;") evaluated to "var _js2 = someDiv; var _js1 = 123 + 'px'; _js2.style.left = _js1;", which is not STRING= to "left(someDiv) = 123 + 'px';".. -------------------------------- Running other tests: ....................................................................................................................................................................................................................................... Did 231 checks. Pass: 231 (100%) Skip: 0 ( 0%) Fail: 0 ( 0%) Running Package System tests: f.f..f.. Did 8 checks. Pass: 5 (62%) Skip: 0 ( 0%) Fail: 3 (37%) Failure Details: -------------------------------- NAMESPACE-AND-SPECIAL-FORMS []: (PARENSCRIPT-TEST::NORMALIZE-JS-CODE "var prefix_foo = { prefix_bar : 1, prefix_notAKeyword : prefix_something }; return !prefix_foo && prefix_foo.prefix_bar + prefix_someOtherVar;") evaluated to "var prefix_foo = { prefix_bar : 1, prefix_notAKeyword : prefix_something }; return !prefix_foo && prefix_foo.prefix_bar + prefix_someOtherVar;", which is not COMMON-LISP:STRING= to "var foo = { bar : 1, notAKeyword : something }; return !foo && foo.bar + someOtherVar;".. -------------------------------- -------------------------------- OBFUSCATION1 []: (NORMALIZE-JS-CODE "function g1(a, b, g2) { return a + my_library_libraryFunction(b, g2); };") evaluated to "function g1(a, b, g2) { return a + my_library_libraryFunction(b, g2); };", which is not STRING= to "function g1(a, b, g1) { return a + my_library_libraryFunction(b, g1); };".. -------------------------------- -------------------------------- EXPORTED-INTERFACE []: (PARENSCRIPT-TEST::NORMALIZE-JS-CODE "function interfaceFunction(prefix_baz) { return prefix_baz + g2; };") evaluated to "function interfaceFunction(prefix_baz) { return prefix_baz + g2; };", which is not COMMON-LISP:STRING= to "function interfaceFunction(baz) { return baz + g1; };".. --------------------------------

2 1

[parenscript-devel] Miscompiled arithmetic expression
by Daniel Gackle 15 Jun '10

15 Jun '10

Just spent two hours tracking down a bug that turned out to be: (ps (- x (+ y z))) => "x - y + z;"

2 1

[parenscript-devel] random, mapcar, and loop
by szergling 26 May '10

26 May '10

I have three patches to suggest for parenscript. Two seem relatively minor to me, but a third modifies random to be more like CL:RANDOM. It gives us the following: CL-USER> (ps:ps (random 2.3)) "2.3 * Math.random();" CL-USER> (ps:ps (random 2)) "Math.floor(2 * Math.random());" ;; as in ps's original random But I expect the following to be perhaps a bit more contentious... CL-USER> (ps:ps (random (+ 2 2))) "var max1 = 2 + 2; var val2 = max1 * Math.random(); if (Math.floor(max1) === max1) { Math.floor(val2); } else { val2; };" Hope I haven't tried too hard to be like CL here? I hope my patches are useful and would like them to be considered for inclusion. Thanks, Yong.

3 3

[parenscript-devel] The PS test suite
by Daniel Gackle 25 May '10

25 May '10

I'm happy to add tests for bug fixes etc. that I push, so I tried compiling and running the PS test suite. It requires the Arnesi and FiveAM libraries, so I downloaded and asdf-loaded those, then called (RUN-TESTS). The output I got seems to include many failures. How many of these are actual failures in the official tests, and how many are glitches local to me? Since we have many custom PS macros, I was careful to run these in a Lisp that only loaded the PARENSCRIPT-TEST package. Daniel Running reference tests: ...............f....................................................................f.... Did 89 checks. Pass: 87 (97%) Skip: 0 ( 0%) Fail: 2 ( 2%) Failure Details: -------------------------------- THE-HTML-GENERATOR-3 []: (NORMALIZE-JS-CODE "document.write('<A HREF=\"#\" ONCLICK=\"' + 'javascript:' + 'transport()' + '\">link</A>');") evaluated to "document.write('<A HREF=\"#\" ONCLICK=\"' + 'javascript:' + 'transport()' + '\">link</A>');", which is not STRING= to "document.write('<A HREF=\"#\" ONCLICK=\"' + ['javascript:', 'transport()'].join('') + '\">link</A>');".. -------------------------------- -------------------------------- ASSIGNMENT-11 []: (NORMALIZE-JS-CODE "var _js2 = someDiv; var _js1 = 123 + 'px'; _js2.style.left = _js1;") evaluated to "var _js2 = someDiv; var _js1 = 123 + 'px'; _js2.style.left = _js1;", which is not STRING= to "left(someDiv) = 123 + 'px';".. -------------------------------- Running other tests: .................................................................................................f............ff.....f...............f.......................................................................f.f.... ;Compiler warnings : ; In an anonymous lambda form: Undeclared free variable X..f.......f........ Did 231 checks. Pass: 222 (96%) Skip: 0 ( 0%) Fail: 9 ( 3%) Failure Details: -------------------------------- VALUES2 []: (NORMALIZE-JS-CODE "var val1_1 = x; var valrest2 = [y]; if (undefined !== arguments['callee']['caller']['mv']) { arguments['callee']['caller']['mv'] = valrest2; }; val1_1;") evaluated to "var val1_1 = x; var valrest2 = [y]; if (undefined !== arguments['callee']['caller']['mv']) { arguments['callee']['caller']['mv'] = valrest2; }; val1_1;", which is not STRING= to "var val1_1 = x; var valrest2 = [y]; if (undefined !== arguments.callee.caller.mv) { arguments.callee.caller.mv = valrest2; }; val1_1;".. -------------------------------- -------------------------------- VALUES3 []: (NORMALIZE-JS-CODE "var val1_1 = x; var valrest2 = [y, z]; if (undefined !== arguments['callee']['caller']['mv']) { arguments['callee']['caller']['mv'] = valrest2; }; val1_1;") evaluated to "var val1_1 = x; var valrest2 = [y, z]; if (undefined !== arguments['callee']['caller']['mv']) { arguments['callee']['caller']['mv'] = valrest2; }; val1_1;", which is not STRING= to "var val1_1 = x; var valrest2 = [y, z]; if (undefined !== arguments.callee.caller.mv) { arguments.callee.caller.mv = valrest2; }; val1_1;".. -------------------------------- -------------------------------- VALUES-RETURN []: (NORMALIZE-JS-CODE "var val1_1 = x; var valrest2 = [y]; if (undefined !== arguments['callee']['caller']['mv']) { arguments['callee']['caller']['mv'] = valrest2; }; return val1_1;") evaluated to "var val1_1 = x; var valrest2 = [y]; if (undefined !== arguments['callee']['caller']['mv']) { arguments['callee']['caller']['mv'] = valrest2; }; return val1_1;", which is not STRING= to "var val1_1 = x; var valrest2 = [y]; if (undefined !== arguments.callee.caller.mv) { arguments.callee.caller.mv = valrest2; }; return val1_1;".. -------------------------------- -------------------------------- EVAL-WHEN-MACROLET-EXPANSION []: *LISP-OUTPUT* evaluated to ORIGINAL-VALUE, which is not EQL to :CL-USER.. -------------------------------- -------------------------------- EVAL-WHEN-MACRO-EXPANSION []: *LISP-OUTPUT* evaluated to ORIGINAL-VALUE, which is not EQL to :CL-USER.. -------------------------------- -------------------------------- MV-BIND1 []: (NORMALIZE-JS-CODE "returnsMv(); var prevmv2 = arguments['callee']['mv']; try { arguments['callee']['mv'] = true; var a = doesnt(); var mv1 = typeof arguments['callee']['mv'] === 'object' ? arguments['callee']['mv'] : new Array(1); var b = mv1[0]; alert(a); alert(b); } finally { if (undefined === prevmv2) { delete arguments['callee']['mv']; } else { arguments['callee']['mv'] = prevmv2; }; };") evaluated to "returnsMv(); var prevmv2 = arguments['callee']['mv']; try { arguments['callee']['mv'] = true; var a = doesnt(); var mv1 = typeof arguments['callee']['mv'] === 'object' ? arguments['callee']['mv'] : new Array(1); var b = mv1[0]; alert(a); alert(b); } finally { if (undefined === prevmv2) { delete arguments['callee']['mv']; } else { arguments['callee']['mv'] = prevmv2; }; };", which is not STRING= to "returnsMv(); var prevmv2 = arguments.callee.mv; try { arguments.callee.mv = true; var a = doesnt(); var mv1 = typeof arguments.callee.mv === 'object' ? arguments.callee.mv : new Array(1); var b = mv1[0]; alert(a); alert(b); } finally { if (undefined === prevmv2) { delete arguments.callee.mv; } else { arguments.callee.mv = prevmv2; }; };".. -------------------------------- -------------------------------- EVAL-WHEN-LISP-SIDE []: *LISP-OUTPUT* evaluated to ORIGINAL-VALUE, which is not EQL to IT-WORKS.. -------------------------------- -------------------------------- EVAL-WHEN-LISP-SIDE []: JS-OUTPUT evaluated to "LISPOUTPUT = 'itWorks';", which is not STRING= to "".. -------------------------------- -------------------------------- FUNCALL-IF-EXPRESSION []: (NORMALIZE-JS-CODE "document.write(LINKORNOT === 1 ? '<A HREF=\"#\" ONCLICK=\"' + 'javascript:' + 'transport()' + '\">' + img + '</A>' : img);") evaluated to "document.write(LINKORNOT === 1 ? '<A HREF=\"#\" ONCLICK=\"' + 'javascript:' + 'transport()' + '\">' + img + '</A>' : img);", which is not STRING= to "document.write(LINKORNOT === 1 ? '<A HREF=\"#\" ONCLICK=\"' + ['javascript:', 'transport()'].join('') + '\">' + img + '</A>' : img);".. -------------------------------- Running Package System tests: f.f..f.. Did 8 checks. Pass: 5 (62%) Skip: 0 ( 0%) Fail: 3 (37%) Failure Details: -------------------------------- NAMESPACE-AND-SPECIAL-FORMS []: (PARENSCRIPT-TEST::NORMALIZE-JS-CODE "var prefix_foo = { prefix_bar : 1, prefix_notAKeyword : prefix_something }; return !prefix_foo && prefix_foo.prefix_bar + prefix_someOtherVar;") evaluated to "var prefix_foo = { prefix_bar : 1, prefix_notAKeyword : prefix_something }; return !prefix_foo && prefix_foo.prefix_bar + prefix_someOtherVar;", which is not COMMON-LISP:STRING= to "var foo = { bar : 1, notAKeyword : something }; return !foo && foo.bar + someOtherVar;".. -------------------------------- -------------------------------- OBFUSCATION1 []: (NORMALIZE-JS-CODE "function g1(a, b, g2) { return a + my_library_libraryFunction(b, g2); };") evaluated to "function g1(a, b, g2) { return a + my_library_libraryFunction(b, g2); };", which is not STRING= to "function g1(a, b, g1) { return a + my_library_libraryFunction(b, g1); };".. -------------------------------- -------------------------------- EXPORTED-INTERFACE []: (PARENSCRIPT-TEST::NORMALIZE-JS-CODE "function interfaceFunction(prefix_baz) { return prefix_baz + g2; };") evaluated to "function interfaceFunction(prefix_baz) { return prefix_baz + g2; };", which is not COMMON-LISP:STRING= to "function interfaceFunction(baz) { return baz + g1; };".. -------------------------------- NIL PS-TEST>

2 2

[parenscript-devel] Some minor updates
by Daniel Gackle 24 May '10

24 May '10

We finally got all our code working with the latest PS. That is, all the bugs I reported appear fixed and I didn't encounter any new ones. Yay! I pushed some patches that fix minor issues: 1. ODDP macro was using deprecated % operator 2. DESTRUCTURING-BIND was binding empty tails to null, not [] 3. LOOP was choking on variable names like "count" that looked like keywords. Daniel

1 0

[parenscript-devel] Syntax error when binding to a binding
by Daniel Gackle 19 May '10

19 May '10

Another syntax error in the new PS. This form: (let ((blah (let ((x (foo))) (if (null x) y z))))) ... compiles to... var blah = x = foo(), x == null ? y : z; ... which is incorrect. Previously, PS produced this, which is correct: var blah = (x = foo(), x == null ? y : z); Daniel

3 3

[parenscript-devel] Syntax error in treating functions as expressions
by Daniel Gackle 19 May '10

19 May '10

I've finally got back to working through the output of the new PS, and have hit another couple of errors. The following form: (lambda (x) (apply (lambda (y) (bar (1+ y))) x)) ...compiles to... function (x) { return function (y) { return bar(y + 1); }.apply(this, x); }; ... which is a syntax error. Earlier PS put parentheses around the inner function, which is correct: function (x) { return (function (y) { return bar(y + 1); }).apply(this, x); };

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

parenscript-devel May 2010