I pushed your changes and fixed the character encoding problem for CLisp (by changing #\Form to (code-char 12)).
There are, however, still many tests that fail. The bulk of these failures are because of semantically meaningless differences in parenscript-compiled javascript and the expected javascript. for example:
Failure Details:
--------------------------------
METHOD-CALL-LAMBDA-CALL []: (NORMALIZE-JS-CODE JS-CODE) evaluated to "(function (x) {return x;
})(10).toString()", which is not STRING= to "(function (x) {
return x;
})
(10).toString()"..
It is worth considering using a Javascript parser compare expected vs. compiled Javascript instead of using the slight hack in the current testing code.
Anyhow, now that 5am is compiling we might want to get tests working again.
Thanks,
Red
Hello!
On Fri, 22 Jun 2007 20:33:15 +0200, Vladimir Sedach wrote:
> Ok, then I'll just wait for your fix.
The FiveAM problem was fixed with the latest patches, but now there's
a new problem with parenscript.test, in part similar to [1]:
--8<---------------cut here---------------start------------->8---
; /var/cache/common-lisp-controller/1000/sbcl/local/home/luca/Hacking/debdarcs/parenscript-upstream/t/test- package.fasl written
; compilation finished in 0:00:00
; compiling file "/home/luca/Hacking/debdarcs/parenscript-upstream/t/test.lisp" (written 17 JUN 2007 09:22:25 PM):
; compiling (IN-PACKAGE :JS-TEST)
; compiling (DEFUN TRIM-WHITESPACE ...)
; compiling (DEFUN SAME-SPACE-BETWEEN-STATEMENTS ...)
; compiling (DEFUN NO-INDENTATION ...)
; compiling (DEFUN NO-TRAILING-SPACES ...)
; compiling (DEFUN NORMALIZE-JS-CODE ...)
; compiling (DEFMACRO TEST-PS-JS ...)
; compiling (DEFUN RUN-TESTS ...)
; compiling (DEF-SUITE PS-TESTS)
; compiling (IN-SUITE PS-TESTS)
debugger invoked on a SIMPLE-ERROR in thread #<THREAD "initial thread" {10025DEB61}>:
Unkown suite PS-TESTS.
Type HELP for debugger help, or (SB-EXT:QUIT) to exit from SBCL.
restarts (invokable by number or by possibly-abbreviated name):
0: [CONTINUE] Create a new suite named PS-TESTS.
1: [RETRY ] Retry performing #<ASDF:COMPILE-OP NIL {10044E5901}> on
#<ASDF:CL-SOURCE-FILE "test" {1003214501}>.
2: [ACCEPT ] Continue, treating #<ASDF:COMPILE-OP NIL {10044E5901}> on
#<ASDF:CL-SOURCE-FILE "test" {1003214501}> as having been
successful.
3: [ABORT ] Exit debugger, returning to top level.
(NIL)
0]
--8<---------------cut here---------------end--------------->8---
This can be solved with the same patch as at [1] (darcs patch
attached), but then the compilation stops again:
--8<---------------cut here---------------start------------->8---
; compiling (TEST-PS-JS DOT-NOTATION-BUG ...)
; compiling (TEST-PS-JS METHOD-CALL-OP-FORM ...)
; compiling (TEST-PS-JS METHOD-CALL-NUMBER ...)
; compiling (TEST-PS-JS METHOD-CALL-STRING ...); compilation aborted because of fatal error:
; READ failure in COMPILE-FILE:
; READER-ERROR at 2528 (line 82, column 44) on #<SB-SYS:FD-STREAM for "file /home/luca/Hacking/debdarcs/parenscript-upstream/t/test.lisp" {10032C80C1}>:
; /var/cache/common-lisp-controller/1000/sbcl/local/home/luca/Hacking/debdarcs/parenscript-upstream/t/test.fasl written
; compilation finished in 0:00:01
; illegal terminating character after a colon: #\
WARNING:
COMPILE-FILE warned while performing #<COMPILE-OP NIL {1003A661E1}> on
#<CL-SOURCE-FILE "test" {10039BFF91}>.
debugger invoked on a ASDF:COMPILE-FAILED in thread #<THREAD "initial thread" {10025DEB61}>:
erred while invoking #<COMPILE-OP NIL {1003A661E1}> on
#<CL-SOURCE-FILE "test" {10039BFF91}>
Type HELP for debugger help, or (SB-EXT:QUIT) to exit from SBCL.
restarts (invokable by number or by possibly-abbreviated name):
0: [RETRY ] Retry performing #<ASDF:COMPILE-OP NIL {1003A661E1}> on
#<ASDF:CL-SOURCE-FILE "test" {10039BFF91}>.
1: [ACCEPT] Continue, treating #<ASDF:COMPILE-OP NIL {1003A661E1}> on
#<ASDF:CL-SOURCE-FILE "test" {10039BFF91}> as having been
successful.
2: [ABORT ] Exit debugger, returning to top level.
((SB-PCL::FAST-METHOD ASDF:PERFORM (ASDF:COMPILE-OP ASDF:CL-SOURCE-FILE))
#<unavailable argument>
#<unavailable argument>
#<ASDF:COMPILE-OP NIL {1003A661E1}>
#<ASDF:CL-SOURCE-FILE "test" {10039BFF91}>)
0]
--8<---------------cut here---------------end--------------->8---
This one is probably a typo, in fact removing the colon solves it
(darcs patch attached).
However, the compilation is successful only on SBCL-1.0.6.0, because
on CLisp-2.41 (both on a Debian sid) I get:
--8<---------------cut here---------------start------------->8---
;; Compiling file /home/luca/var/lib/debdarcs/parenscript-upstream/t/test-package.lisp ...
;; Wrote file /var/cache/common-lisp-controller/1000/clisp/local/home/luca/var/lib/debdarcs/parenscript-upstream/t/test-package.fas
;; Loading file /var/cache/common-lisp-controller/1000/clisp/local/home/luca/var/lib/debdarcs/parenscript-upstream/t/test-package.fas ...
;; Loaded file /var/cache/common-lisp-controller/1000/clisp/local/home/luca/var/lib/debdarcs/parenscript-upstream/t/test- package.fas
;; Compiling file /home/luca/var/lib/debdarcs/parenscript-upstream/t/test.lisp ...
*** - READ from #<INPUT BUFFERED FILE-STREAM CHARACTER #P"/home/luca/var/lib/debdarcs/parenscript-upstream/t/test.lisp" @212>: there is no character with name "FORM"
The following restarts are available:
RETRY :R1 Retry performing #<ASDF:COMPILE-OP NIL #x000333D42988> on #<ASDF:CL-SOURCE-FILE "test" #x000333CFAC80>.
ACCEPT :R2 Continue, treating #<ASDF:COMPILE-OP NIL #x000333D42988> on #<ASDF:CL-SOURCE-FILE "test" #x000333CFAC80> as having been successful.
ABORT :R3 ABORT
Break 1 JS-TEST[3]>
--8<---------------cut here---------------end--------------->8---
Commenting out line 212 in test.lisp solves the problem. Is my CLisp
too old or is something other?
Thx, bye,
Gismo / Luca
Footnotes:
[1] http://common-lisp.net/pipermail/bese-devel/2007-July/003044.html
_______________________________________________
parenscript-devel mailing list
parenscript-devel@common-lisp.net
http://common-lisp.net/cgi-bin/mailman/listinfo/parenscript-devel