[parenscript-devel] Minor patch: inconsistent function name
Unless I'm missing something, the same function was still being referred to with names COMPLEX-JS-EXPR? and COMPLEX-JS-EXPR-P. Below is a patch to use the first name consistently. Daniel
From 6e7190ace745f5bb2448249b368104a9a8917679 Mon Sep 17 00:00:00 2001 From: Daniel Gackle <danielgackle@gmail.com> Date: Mon, 20 Apr 2009 16:14:20 -0700 Subject: [PATCH] Use the name of function COMPLEX-JS-EXPR? consistently.
--- src/lib/ps-loop.lisp | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/ps-loop.lisp b/src/lib/ps-loop.lisp index 7eeae46..e806e41 100644 --- a/src/lib/ps-loop.lisp +++ b/src/lib/ps-loop.lisp @@ -1,6 +1,6 @@ (in-package :parenscript) -(defun complex-js-expr-p (expr) +(defun complex-js-expr? (expr) (if (symbolp expr) (find #\. (symbol-name expr)) (consp expr))) @@ -26,7 +26,7 @@ destructurings body) (macrolet ((with-local-var ((name expr) &body body) (once-only (expr) - `(let ((,name (aif (and (complex-js-expr-p ,expr) (ps-gensym)) + `(let ((,name (aif (and (complex-js-expr? ,expr) (ps-gensym)) (progn (push (list 'var it ,expr) prologue) it) ,expr))) -- 1.6.1
Actually, that should be changed in the repository already. Vladimir On Mon, Apr 20, 2009 at 5:19 PM, Daniel Gackle <danielgackle@gmail.com> wrote:
Unless I'm missing something, the same function was still being referred to with names COMPLEX-JS-EXPR? and COMPLEX-JS-EXPR-P. Below is a patch to use the first name consistently.
Daniel
From 6e7190ace745f5bb2448249b368104a9a8917679 Mon Sep 17 00:00:00 2001 From: Daniel Gackle <danielgackle@gmail.com> Date: Mon, 20 Apr 2009 16:14:20 -0700 Subject: [PATCH] Use the name of function COMPLEX-JS-EXPR? consistently.
--- src/lib/ps-loop.lisp | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/ps-loop.lisp b/src/lib/ps-loop.lisp index 7eeae46..e806e41 100644 --- a/src/lib/ps-loop.lisp +++ b/src/lib/ps-loop.lisp @@ -1,6 +1,6 @@ (in-package :parenscript)
-(defun complex-js-expr-p (expr) +(defun complex-js-expr? (expr) (if (symbolp expr) (find #\. (symbol-name expr)) (consp expr))) @@ -26,7 +26,7 @@ destructurings body) (macrolet ((with-local-var ((name expr) &body body) (once-only (expr) - `(let ((,name (aif (and (complex-js-expr-p ,expr) (ps-gensym)) + `(let ((,name (aif (and (complex-js-expr? ,expr) (ps-gensym)) (progn (push (list 'var it ,expr) prologue) it) ,expr))) -- 1.6.1
Actually, that should be changed in the repository already. Vladimir On Mon, Apr 20, 2009 at 5:19 PM, Daniel Gackle <danielgackle@gmail.com> wrote:
Unless I'm missing something, the same function was still being referred to with names COMPLEX-JS-EXPR? and COMPLEX-JS-EXPR-P. Below is a patch to use the first name consistently.
Daniel
From 6e7190ace745f5bb2448249b368104a9a8917679 Mon Sep 17 00:00:00 2001 From: Daniel Gackle <danielgackle@gmail.com> Date: Mon, 20 Apr 2009 16:14:20 -0700 Subject: [PATCH] Use the name of function COMPLEX-JS-EXPR? consistently.
--- src/lib/ps-loop.lisp | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/ps-loop.lisp b/src/lib/ps-loop.lisp index 7eeae46..e806e41 100644 --- a/src/lib/ps-loop.lisp +++ b/src/lib/ps-loop.lisp @@ -1,6 +1,6 @@ (in-package :parenscript)
-(defun complex-js-expr-p (expr) +(defun complex-js-expr? (expr) (if (symbolp expr) (find #\. (symbol-name expr)) (consp expr))) @@ -26,7 +26,7 @@ destructurings body) (macrolet ((with-local-var ((name expr) &body body) (once-only (expr) - `(let ((,name (aif (and (complex-js-expr-p ,expr) (ps-gensym)) + `(let ((,name (aif (and (complex-js-expr? ,expr) (ps-gensym)) (progn (push (list 'var it ,expr) prologue) it) ,expr))) -- 1.6.1
participants (2)
-
Daniel Gackle -
Vladimir Sedach