March 2010 - phemlock-devel@common-lisp.net

Re: [phemlock-devel] hemlock clone on gitorious
by Nikodemus Siivola 14 Mar '10

14 Mar '10

On 1 January 2010 16:45, David Lichteblau <david(a)lichteblau.com> wrote > - from the tty-2 branch, I have merged the first commit: > > 4c000ea6 make arrow keys and pageup/down work in the tty backend > > I would like to merge the following commit, but I couldn't find the osicat > changes required: > 346d8fa4 don't allow C-y to generate a SIGTSTP That's commit 451bf6fa993ae74eb56aff80d40050111d7f19f4 Author: Nikodemus Siivola <nikodemus(a)random-state.net> Date: Tue Dec 22 18:49:19 2009 +0200 add VDSUSP to termios constants which is in the Osicat main repo -- so I've pushed the SIGSTP fix to Hemlock. > However, I have not yet merged the other two: 57c160ff (distinct Backspace > and C-h in terminal) and 08f68169 (get rid of the arraw-key kludge). > > The reason is that I'd like to work on the Backspace/Delete some > more. (I'd like to keep keybindings so that C-h is equivalent to > backspace -- by default anyway. But I agree that distinct physical > keys shouldn't be conflated on the lowest level of key event > processing already.) Attached a cleaned-up patch that combines the essential parts of those commits. With this patch TTY matches more closely with the other backends: even without this in CLX Hemlock C-h and Backspace are distinct -- but our keybindings are (mostly, at least) set up to treat them as identical. Cheers, -- Nikodemus

1 0

Re: [phemlock-devel] hemlock clone on gitorious
by Nikodemus Siivola 14 Mar '10

14 Mar '10

On 1 January 2010 16:45, David Lichteblau <david(a)lichteblau.com> wrote: > - Although I have merged bbea34ea including the "Pull out and export > HEMLOCK:GOTO-BUFFER-START" change, I'm inclined to propose a > different plan: > > Hemlock commands are already callable as ordinary Lisp functions, > i.e. the function beginning-of-buffer-command already exists, and > I think GNU Emacs got it right when it made the distinction between > commands and functions as small as possible: Commands _should_ be > called in other Lisp code whenever it makes sense -- or to describe > it in the opposite way: It's okay to take Lisp API functions and > turn them into commands. > > So the steps are: > 1. change defcommand so that it doesn't append -COMMAND to the > function name. > 2. As a convention, write &optional prefix for such functions, so > callers don't have to supply a prefix where none is needed. > (And keep your change to declare it ignorable automatically.) > 3. (optionally) change the name of commands as stated in the code > from strings to symbols. DEFCOMMAND would still define the > space-separated command name in the command table, so this > change would not be end-user-visible. But C-c C-w C-c would > work no the command name, etc. > > As a result, the function would be called beginning-of-buffer > (rather than goto-buffer-start), just like the command is already > called. GNU Emacs has the same name, which is a plus. I made some steps in this direction. http://gitorious.org/~nikodemus/hemlock/nikodemus-hemlock/commits/defcomman… Basically: 1. Existing DEFCOMMAND forms work just like they used to, and append -COMMAND to names to avoid need for wholesale renaming. 2. (defcommand ("My Foo" my-foo) ...) uses MY-FOO as the function name. 3. DEFCOMMAND also accepts empty lambda-lists, taking them to mean (&OPTIONAL #:PREFIX). IMO this leads to easier to read command when they don't use prefix arguments. I also went over some exiting commands and made them use the new-style naming: FORWARD-CHARACTER, BEGINNING-OF-BUFFER, etc. Let me know how this looks, -- Nikodemus

2 1

[phemlock-devel] Hemlock @ Launchpad
by Nikodemus Siivola 14 Mar '10

14 Mar '10

https://bugs.launchpad.net/hemlock Cheers, -- Nikodemus

1 0

[phemlock-devel] phemlock is dead, long live hemlock
by Nikodemus Siivola 14 Mar '10

14 Mar '10

So, David suggested we co-opt this list for the purposes of: http://gitorious.org/hemlock/hemlock (link for the benefit of those on the list not aware of the it) Cheers, -- Nikodemus

1 0