[postmodern-devel] cl-postgress build warning due to multiple loading
Hi I am beginning to use cl-postgress part of postmodern It is working well, Thank you. I have an issue that would be nice to fix. When I do (asdf:oos 'asdf:load-op :cl-postgres) I see couple of warnings like ;Compiler warnings for "/media/sf_git/thirdparty/postmodern/simple-date/cl-postgres-glue.lisp" : ; In an anonymous lambda form at position 857: Duplicate definitions of (:METHOD CL-POSTGRES:TO-SQL-STRING (DATE)), in this file and in "/media/sf_git/thirdparty/postmodern/simple-date/cl-postgres-glue.lisp" I think they are due to in file cl-postgress.asd at the end you have (asdf:oos 'asdf:load-op :simple-date-postgres-glue) and again in simple-date.asd you have the same line (asdf:oos 'asdf:load-op :simple-date-postgres-glue) Can this be fixed. I am using CCL Clozure Common Lisp Version 1.7-dev-r14812M-trunk (LinuxX8664)! My ASDF is a bit old (2.011.9), asdf is one hting I don't like upgrading, causes me a lot of pain. -Antony
I've pushed a patch. Apparently ASDF2's operation-done-p claims that a package has been loaded, even when it hasn't. This was causing the glue to be loaded after both systems, rather than after the one that got loaded last. I've committed a patch that makes the check a bit more crude, checking directly for packages and symbols, rather than for ASDF operations, but this seems to work.
Marijn Haverbeke <marijnh@gmail.com> writes:
I've pushed a patch. Apparently ASDF2's operation-done-p claims that a package has been loaded, even when it hasn't. This was causing the glue to be loaded after both systems, rather than after the one that got loaded last. I've committed a patch that makes the check a bit more crude, checking directly for packages and symbols, rather than for ASDF operations, but this seems to work.
I don't understand how is simple-date supposed to be loaded now. Just loading postmodern doesn't seem to be sufficient anymore. Should it be loaded explicitly? -- With best regards, Stas.
Marijn Haverbeke <marijnh@gmail.com> writes:
I don't understand how is simple-date supposed to be loaded now. Just loading postmodern doesn't seem to be sufficient anymore. Should it be loaded explicitly?
Yes. (And it has been like this for a long time.) It was intended like this? Because before dfb9da112410ccc60d92d7bc8ce0c1efb41b6e9e loading postmodern loaded simple-date too. Anyway, I'm happy with either way, as long as it's deterministic.
-- With best regards, Stas.
On 8/12/2011 7:40 AM, Marijn Haverbeke wrote:
I've pushed a patch. Apparently ASDF2's operation-done-p claims that a package has been loaded, even when it hasn't. This was causing the glue to be loaded after both systems, rather than after the one that got loaded last. I've committed a patch that makes the check a bit more crude, checking directly for packages and symbols, rather than for ASDF operations, but this seems to work.
Works for me (I am using only cl-postgres). Warnings are gone. Thank you -Antony
participants (3)
-
Antony -
Marijn Haverbeke -
Stas Boukarev