[postmodern-devel] s-sql patch for postmodern 1.13: separate condition
We learned that it is useful to a) have separate condition to distinguish s-sql parsing errors from others b) have :delete-from syntax extended: sometimes it is necessary to return keys of deleted rows. Both patches (generated by git) are in attach. It would be very nice to see them in upstream.
Hello Timur, Thanks for the patches! The :delete-from one is perfect. The sql-error one is a good idea, but your patch is completely broken (you can't do (error 'sql-error "~a" val)). I've committed something similar to the repository. (Also, submitting patches created by 'darcs send -o patchfilename' makes it easier for me to merge them.) Cheers, Marijn
Marjin, thanks for a sql-error nice patch, our one really contained the find&replace-typo. 2008/12/17 Marijn Haverbeke <marijnh@gmail.com>:
Hello Timur,
Thanks for the patches! The :delete-from one is perfect. The sql-error one is a good idea, but your patch is completely broken (you can't do (error 'sql-error "~a" val)). I've committed something similar to the repository. (Also, submitting patches created by 'darcs send -o patchfilename' makes it easier for me to merge them.)
Cheers, Marijn
_______________________________________________ postmodern-devel mailing list postmodern-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/postmodern-devel
participants (2)
-
Marijn Haverbeke -
Timur Sufiev