April 2015 - py-configparser-devel@common-lisp.net

[py-configparser-devel] get-option: handling the case
by Станислав Кондратьев 08 Apr '15

08 Apr '15

Hello, I've stumbled upon an unexpected behaviour of get-option and related functions. By default the options are converted to lower case. However, if a config file is read by read-files, the case is not converted and the options become inaccessible. The bug must be due to the code of %get-option, where %validate-option-name receives option-name rather than norm-option. Best regards, S. Kondratyev.

1 0

[py-configparser-devel] get-option: inheritance from `default' broken.
by Станислав Кондратьев 08 Apr '15

08 Apr '15

Hello, In Python's configparser the default section is supposed to supply missing options for the rest sections. In py-configparser this doesn't work. I suggest fixing %get-option as follows: (defun %get-option (config section-name option-name if-does-not-exist) (let* ((section (%get-section config section-name)) (norm-option (norm-option-name config option-name)) (option (or (assoc norm-option (section-options section) :test #'string=) (assoc norm-option (section-options (config-defaults config)) :test #'string=)))) (if (null option) (if (eq if-does-not-exist :error) (error 'no-option-error) ;; no such option error (values (car (push (list (%validate-option-name norm-option)) (section-options section))) section)) (values option section)))) Best regards, Stanislav Kondratyev.

1 1

[py-configparser-devel] Minor bugs
by Станислав Кондратьев 08 Apr '15

08 Apr '15

parser.lisp (defun is-whitespace (c) (or (eq c #\Space) (eq c #\Tab) (eq c #\Return))) (defun is-comment-char (c) (or (eq c #\;) (eq c #\#))) eq should be changed into char=, since "Common Lisp makes no guarantee that eq is true even when both its arguments are ``the same thing'' if that thing is a character or number." Best regards, S. Kondratyev.

1 0