May 2004 - slime-devel - mailman3.common-lisp.net

[slime-devel] Daily ChangeLog diff
by Luke Gorrie 22 May '04

22 May '04

Index: slime/ChangeLog diff -u slime/ChangeLog:1.377 slime/ChangeLog:1.379 --- slime/ChangeLog:1.377 Sun May 16 20:26:44 2004 +++ slime/ChangeLog Fri May 21 17:30:25 2004 @@ -1,3 +1,24 @@ +2004-05-21 Bill Clementson <Bill_Clementson(a)peoplesoft.com> + + * slime.el (slime-switch-to-output-buffer): Use "P" as interactive + spec. + +2004-05-21 Helmut Eller <e9626484(a)stud3.tuwien.ac.at> + + * slime.el (slime-switch-to-output-buffer): Override the + prefix-arg if we are called non-interactively. + (slime-repl-current-input): Don't add newlines. + (slime-repl-return): Send input if we are in read-mode also if it + isn't a complete expression. + (repl-read-lines): New test case. + (slime-enable-startup-animation-p): New configurable. + (slime-repl-update-banner): Use it. + (slime-hide-inferior-lisp-buffer): New function. Reuse the + *inferior-lisp* buffer window for the SLIME REPL. + + * swank-allegro.lisp (find-fspec-location): Better handling of + methods. From Bill Clementson. + 2004-05-17 Luke Gorrie <luke(a)bluetail.com> * xref.lisp, swank-clisp.lisp: Renamed XREF package to PXREF (P

1 0

[slime-devel] Re: Using M-. for specialized methods
by Bill_Clementson＠peoplesoft.com 21 May '04

21 May '04

There appears to be a problem with methods that are specialized like this: (defmethod foo (node (name (eql 'a))) but not methods that are specialized like this: (defmethod foo (node (name (eql :a))) -- Bill Clementson

1 0

[slime-devel] Re: Using M-. for specialized methods
by Bill_Clementson＠peoplesoft.com 21 May '04

21 May '04

Helmut Eller <e9626484(a)stud3.tuwien.ac.at> writes: > Bill_Clementson(a)peoplesoft.com writes: > > > ACL 6.2 returns: > > > > ((BAR #((:FILE "c:\\tmp\\foo.lisp") (:POSITION 23))) > > ((METHOD FOO ((EQL :A))) > > #((:FILE "c:\\tmp\\foo.lisp") (:POSITION 40))) > > ((METHOD FOO ((EQL :B))) > > #((:FILE "c:\\tmp\\foo.lisp") (:POSITION 74))) > > (FOO #((:FILE "c:\\tmp\\foo.lisp") (:FUNCTION-NAME "FOO")))) > > This looks fine. I don't see why Emacs can't locate the methods in > your code. Could you post an example? When I run your code snippet over my methods, with the following command: (find-definitions 'xml-xform::node-xform)) I get the following output (note that :function-name is "NIL" and their are no :POSITION values for any of the methods with the exception of the last (default) method). The generic function is stored in a library file "xml-xform.lisp" while the specialized methods are stored in an example file "resume.lisp". Only the non-specialized (default) method in "resume.lisp" is showing up with a :POSITION value. Don't know if that provides any clues. I'll try to come up with a cut-down, reproducible example that I can send you. It was working fine for me with the patch that I had sent you previously. Is "excl:source-file" not a supported function in ACL 5.0? (((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::RESUME))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::PERSON))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::BACKGR))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::WORK))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::COMPANY))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::ROLE))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::COMMENT))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'LIST))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::ITEM))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::MISC))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::SKILLS))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::SKILLS-GRP))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::EDUCATION))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::AFFILIATIONS))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::INSTITUTION))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::POS))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::CURRENT))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::MAIL))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::WWW))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T (EQL 'RESUME-HTML::A))) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:FUNCTION-NAME "NIL"))) ((METHOD XML-XFORM:NODE-XFORM (T T)) #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\examples\\resume-html.lisp") (:POSITION 5941))) (XML-XFORM:NODE-XFORM #((:FILE "c:\\usr\\home\\lisp\\xml-xform\\xml-xform.lisp") (:FUNCTION-NAME "NODE-XFORM"))))

2 1

[slime-devel] C-c C-z doesn't work after latest changes
by Bill_Clementson＠peoplesoft.com 21 May '04

21 May '04

Helmut, The latest changes to slime.el have broken C-c C-z (slime-switch-to-output-buffer). The first line of that function should be: (interactive "P") instead of (interactive "p") - Bill

2 1

[slime-devel] Re: Using M-. for specialized methods
by Bill_Clementson＠peoplesoft.com 21 May '04

21 May '04

Helmut Eller <e9626484(a)stud3.tuwien.ac.at> writes: > Bill_Clementson(a)peoplesoft.com writes: > > > Unfortunately, it does not work in 6.x - it just positions to the top of > > the file that the method is in. > > May I ask what the attached snippet returns for you? I tried it with > Franz' telnet prompt at prompt.franz.com (a 6.2) and it seems ok. ACL5 > returns: > > ((BAR #((:FILE "/tmp/foo.lisp") (:POSITION 22))) ((METHOD FOO > ((EQL :A))) #((:FILE "/tmp/foo.lisp") (:POSITION 38))) ((METHOD FOO > ((EQL :B))) #((:FILE "/tmp/foo.lisp") (:POSITION 71))) (FOO #((:FILE > "/tmp/foo.lisp") (:FUNCTION-NAME "FOO")))) ACL 6.2 returns: ((BAR #((:FILE "c:\\tmp\\foo.lisp") (:POSITION 23))) ((METHOD FOO ((EQL :A))) #((:FILE "c:\\tmp\\foo.lisp") (:POSITION 40))) ((METHOD FOO ((EQL :B))) #((:FILE "c:\\tmp\\foo.lisp") (:POSITION 74))) (FOO #((:FILE "c:\\tmp\\foo.lisp") (:FUNCTION-NAME "FOO")))) -- Bill Clementson

2 1

Re: [slime-devel] Re: Using M-. for specialized methods
by Bill_Clementson＠peoplesoft.com 21 May '04

21 May '04

Helmut Eller <e9626484(a)stud3.tuwien.ac.at> writes: > Bill_Clementson(a)peoplesoft.com writes: > > > Attached is a patch for ACL to fix this problem. > > Thanks for the patch. I modified it a bit to work in Allegro 5.0. I > hope it works in 6.x too. Unfortunately, it does not work in 6.x - it just positions to the top of the file that the method is in. - Bill

2 1

[slime-devel] CMUCL: code-locations, source-locations, xref-contexts
by Luke Gorrie 21 May '04

21 May '04

Ahoy, Personally I'm finding the source-file cache really helpful when doing M-. with modified buffers, but it only works for some types of location. The `code-location' we get from function objects contains the mtime of the source file at the time of compilation, which we can check against the file and the cache. But `source-locations' that we get for classes from PCL and `xref-contexts' don't have this timestamp. What to do? I'm tempted to try hacking CMUCL to include mtime in the other locations too, but I'm not 100% certain that the caching approach is right. Any opinions? -Luke

2 2

[slime-devel] Re: Using M-. for specialized methods
by Bill_Clementson＠peoplesoft.com 21 May '04

21 May '04

Bill_Clementson(a)peoplesoft.com writes: > When I use M-. on a defun or macro, I am taken to the source location. > However, when I use M-. on a method that has multiple implementations, I am > not getting taken to the source location correctly in every instance. > Instead, I get the following results (all tests are on Win2000): > > Allegro (never works): The "*XREF[definition: node-xform]*" buffer is > opened with a list of the different specialized methods. When I positon the > cursor on the correct method and press enter, I get the following error > message: "Unkown source location for (METHOD NODE-XFORM (T (EQL 'WORK)))" > despite the fact that there is such a method available. Attached is a patch for ACL to fix this problem. -- Bill Clementson -------------Cut here---------------------------- *** c:/DOCUME~1/BC1886~1/LOCALS~1/Temp/swank-allegro.lisp Thu May 20 12:46:28 2004 --- c:/DOCUME~1/BC1886~1/LOCALS~1/Temp/swank-allegro.lisp1996D0P Thu May 20 12:46:28 2004 *************** *** 214,220 **** ;;;; Definition Finding (defun find-fspec-location (fspec type) ! (let ((file (excl:source-file fspec type))) (etypecase file (pathname (let ((start (scm:find-definition-in-file fspec type file))) --- 214,220 ---- ;;;; Definition Finding (defun find-fspec-location (fspec type) ! (let ((file (excl::fspec-pathname fspec type))) (etypecase file (pathname (let ((start (scm:find-definition-in-file fspec type file)))

2 1

[slime-devel] *query-io*
by Gabor Melis 21 May '04

21 May '04

Reading a line from *query-io* two makes the next read-line return an empty string. Tested under cmucl/sbcl-mt with sigio/spawn. (defun foo () (list (read-line *query-io*) (read-line *query-io*) (read-line *query-io*))) CL-USER> (foo) 1 2 ("1" "" "2") Gabor

3 3

[slime-devel] Using M-. for specialized methods
by Bill_Clementson＠peoplesoft.com 18 May '04

18 May '04

When I use M-. on a defun or macro, I am taken to the source location. However, when I use M-. on a method that has multiple implementations, I am not getting taken to the source location correctly in every instance. Instead, I get the following results (all tests are on Win2000): LispWorks (works but not consistently): The "*XREF[definition: node-xform] *" buffer is opened with a list of the different specialized methods. When I positon the cursor on the correct method and press enter, I am taken to the correct method definition. The "*XREF[definition: node-xform]*" buffer remains open. If I then select another method implementation in the " *XREF[definition: node-xform]*" buffer and press enter, nothing happens. Either the "*XREF[definition: node-xform]*" buffer should be closed after the first method is selected or the selection functionality should be still active. Allegro (never works): The "*XREF[definition: node-xform]*" buffer is opened with a list of the different specialized methods. When I positon the cursor on the correct method and press enter, I get the following error message: "Unkown source location for (METHOD NODE-XFORM (T (EQL 'WORK)))" despite the fact that there is such a method available. CLISP (never works): I just get the following error message: "No source information available for: XML-XFORM:NODE-XFORM". -- Bill Clementson

1 0